From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04363C4167B for ; Mon, 27 Nov 2023 04:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4436E6B030B; Sun, 26 Nov 2023 23:21:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F3626B0314; Sun, 26 Nov 2023 23:21:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1E76B0315; Sun, 26 Nov 2023 23:21:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1CAEE6B030B for ; Sun, 26 Nov 2023 23:21:49 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D98BBA01D9 for ; Mon, 27 Nov 2023 04:21:48 +0000 (UTC) X-FDA: 81502435896.26.D8E4DBE Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 180A6C0015 for ; Mon, 27 Nov 2023 04:21:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MHo9WREW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701058907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsv7V/+CFL/XESr1bE2Qe/WX9Bo+trNfwMKc9YwhQsc=; b=eGR9ADS8gIx1i2nXOCfSYWr78zH5vf4mdISJcTlZz40oyL7HWWh2wAS8NV08LlI2K3YEYz mu/+UUWCGw7MI/M5CUf9UaQEfY3wUZ8v3I/VLYZ/SPHJQ7ArDgcnSSJQD0ENy3RLYPIA6z 981rStww8PyRKtrjRG2IRqAxtlbGkDk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=MHo9WREW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701058907; a=rsa-sha256; cv=none; b=KdxUH28qzguHyJtCCpJnHanv24repBbGub/UqgM230EKVHtkHTaSZF3RiRbSEcFM5P0xNT EhlL/99Jlkj3GaSeQxKEIcK1kvduNBm7Ot11UigMghV7pmNr6fh34abiuh1JltFnk5QgGN 2wjm99qqKfBqIbE8vv7Uo/jYVzZxywk= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a00f67f120aso506725766b.2 for ; Sun, 26 Nov 2023 20:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701058905; x=1701663705; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vsv7V/+CFL/XESr1bE2Qe/WX9Bo+trNfwMKc9YwhQsc=; b=MHo9WREWoQFaO0K0itfryxKEfnF5FNVTTc7Z6zTJZYz6Ra8J1gJqbjwcSKIFTGzqMA iM5ylYCPVOdTvD4aZRfirmLoA3mU++AkYLgRmBL66dybysO9rxp9bsUBUwnN8DyEetgO V7vgR0+Nje+h2ju7VqxrI0WnQDvrzh+ACsLDfl8US02A/dcjuoFWf2c+mmkoA+Wq2Zgi xkm3W5H3U+473sdB9TVHiGQeUpx/G3QyaJ6dM/bJUbPOXD0NH31OTRwP2fIgVzNKtn5L hGEraL5iJcW5ILmROG5ZPh86H+a30ZBLdEEU/8CwJ0UyPOAGsgCLcWv2MhjjGenSNfFM aN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701058905; x=1701663705; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vsv7V/+CFL/XESr1bE2Qe/WX9Bo+trNfwMKc9YwhQsc=; b=jke6s8bh16H9SiwMeV12QvqYpelRAW5LxF6+nRekvptw1gPe/AdQzZZJzM5LwxswRD rZdsIm4UY55KtaOoX6cWWNFcpvLmbUzqSYUp2JWpD5ZbaDo/0+l4u3S35+8Q0hA6DZ66 E7RCM7V1OloePYb135VsRxwJCRfa+ymgjkfFmU72/dA+6YvZnroKTpzhCdc7WAgnQV8I ybE3jwWknk+Ux5BcOotE6QKWPh3ZGyAeybVhN329QYpfyRkV/kE1OiCiJLDtOfFimcQp rjpx4gB6XGTkvcD1g4ak9WnfCZ2edU5WzKeqhAIg5lcC/kGB4IWAjx9zQrDzmx40OaGJ KkOg== X-Gm-Message-State: AOJu0YzbUgSm9eMsPy+eS76rT1wwPoIB4wx311TPqvggtWJOYBvuMxfS Ny9lHVn34AiutgPZmM/yvy17EKYDhHMi6Tpzq/w= X-Google-Smtp-Source: AGHT+IG/szwsRgL8UUwXgmTwWcL7KFdHiJr+LufYok/M2MBcFRmqPQIg8QF1WLoo9gtXWATdG4HQTwbVwpWsTPvZGVs= X-Received: by 2002:a17:906:590e:b0:a04:837e:a955 with SMTP id h14-20020a170906590e00b00a04837ea955mr6958384ejq.32.1701058905255; Sun, 26 Nov 2023 20:21:45 -0800 (PST) MIME-Version: 1.0 References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-2-liangchen.linux@gmail.com> In-Reply-To: From: Liang Chen Date: Mon, 27 Nov 2023 12:21:32 +0800 Message-ID: Subject: Re: [PATCH net-next v3 1/3] page_pool: Rename pp_frag_count to pp_ref_count To: Yunsheng Lin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 180A6C0015 X-Stat-Signature: bwprzukr18j495x3sikhp47ks8u6c7b7 X-Rspam-User: X-HE-Tag: 1701058906-711430 X-HE-Meta: U2FsdGVkX1+t/halZJvKtGT+brK7GFeX6vgUO3Efq/XVlJ1OCuYFAb+hDIVAmqqwwHvKUssZCAjA8U7P8fQCONJnBLaX5qxQg1tfwWQZ4Lpgyxhgh0VBL7aYmVa/UkDouJhkHDmDfJQRv57K29eWXvKyZ55eoPGuexglRA2zm1E0R4qy8G8uBFdWLZsMkbdj8o8ltaEim3VwdUrTNTpOzUsAzUJmqXlkQ/CNARhcUcqBPlFsbWORFvcn1HRQjtfCmWqWHRZubZ6u59TEdRkYERXAu4n1qmEUSIO+5qQi3hDJj8Iti8D+9+9hATHNk28DHvftvUnSzVDhebwa/3CDTVrwvvs5NHlQzoZLGMALSqRiUwZUrPeWqsiiyTIRoPYZd+sl4TsaahoZ3Xp3SpadHBihcahJvk5HLhmxzlkwiugnZA7gGHnEbPd+oB6TPrrIxzz9YNPqua3S+xpckcESqLHu1bmR1ql1izmNVfwzMgfMN7rY6IsuqnNC7ghoZXdyr1TXEJ1fNN3c2UvuupG9s+U8bU82ZvFHNJQ1vhd5ZGkrDPC1nWEtGJqJ4bRp7mPKu56uFh1loyYckRRViRTjPWo8eSTtQBVS0LWFFYLvEBHMoO/mqIvTfzIiKWXl8m2f5PBt72B+7I0KTqETEOFvoGhoez4ArsyZ+XIsdytRdXw1fF++J9UeXKhPc5H+5hAZREANWkE2gAw7zdK6DbAtsTL2WHjr0VfKEcdDHlmF0j9cU5AhZ595auDllmdpw400fvIjYY/FBojePyqDAzhOn2LZltk/8Rhoa1SlDxMAxGyd59YWP5Y0lt/DdWCSCuhqFAiXddNf1dZS112tgCp/BFfWieogPomCWwTgpvYDrTHnyezdg8BeQWeCedKzvmAMeNS9lXlsVkOA6Al/eVmOcZONxOWpgqrYW5Uhh8xWH2q7uEeHj2kzFU8UvCxw/3kCBMkD1Dz/GS7WU64viMU 3j4/KPMz f9ndrU8Mjkmd3o7PNgPtkgwbDBtCP2vELximFMrP+oieQFlY0bVLk7mTxApnakJYSoBtVQSyakFVON3hwt6wsXvsxUMoeHMc0Z/pbhGtainuHPRhgXib372I2sF5hcm845Un6hCtO7YsPFKAEaeSysKgcgI0YUyzHgSPdjvcd/Dds4XQNb6rVHACMFPtzyRDz+EQb8cWs+YIiGJ4l9q0dOFEr0jbO4w86vqJJDruJY0wkeBDFT71CM9Xs4l/I0JKfD5V+B4frn8TONZAaPPL6LrhLBT0oPgOQUHMwkeSOk6495l2bB2ZawtVOzNZrnhJkqIEmHxSItOsJgWRrzJfLkwUW9UvhVI6pvi/YU4RNF+BQget0jPyMIAbGbbDHAqUM0Qv+4XkPFawN1fT8ihHUWXOw61xBlqiftYLB1UV5qp0XS10DKDDGN3/53gGo+On9M2tGtqV36qgauEZHt2YiHBe1o+X222H5BkFP X-Bogosity: Ham, tests=bogofilter, spamicity=0.002626, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 25, 2023 at 7:53=E2=80=AFPM Yunsheng Lin wrote: > > On 2023/11/24 15:34, Liang Chen wrote: > > > static inline void page_pool_fragment_page(struct page *page, long nr) > > It seems page_pool_fragment_page() might not be a appropriate name too? > > Perhaps it might be better to grep defrag/frag to see if there is other > function name might need changing. > Our understanding is that the concept of fragmenting exists before the page is drained, and all related functions should retain their current names. However, once the page is drained, its management shifts to being governed by pp_ref_count, and there's no longer a need to consider fragmentation. Therefore, all functions associated with that lifecycle stage of a pp page will be renamed. With that in mind, the following functions have been renamed. page_pool_defrag_page -> page_pool_deref_page page_pool_is_last_frag -> page_pool_is_last_ref page_pool_put_defragged_page -> page_pool_put_derefed_page > > { > > - atomic_long_set(&page->pp_frag_count, nr); > > + atomic_long_set(&page->pp_ref_count, nr); > > } > > > > -static inline long page_pool_defrag_page(struct page *page, long nr) > > +static inline long page_pool_deref_page(struct page *page, long nr) > > page_pool_defrag_page() related function is called by mlx5 driver directl= y, > we need to change it to use the new function too. > Yeah, that change is right at the start of the patch. > I assume that deref is short for dereference? According to: > > https://stackoverflow.com/questions/4955198/what-does-dereferencing-a-poi= nter-mean-in-c-c > > 'dereferencing means accessing the value from a certain memory location > against which that pointer is pointing'. > > So I am not sure if 'deref' is the right word here as I am not a native > english speaker, But it seems 'unref' is more appropriate here if we mirr= or > the napi_frag_unref() function name? That sounds better to me as well. Thanks!