From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F4FC4167B for ; Mon, 27 Nov 2023 04:24:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 927106B0317; Sun, 26 Nov 2023 23:24:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D7366B0318; Sun, 26 Nov 2023 23:24:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79E906B0319; Sun, 26 Nov 2023 23:24:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6A1766B0317 for ; Sun, 26 Nov 2023 23:24:11 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 444141601F1 for ; Mon, 27 Nov 2023 04:24:11 +0000 (UTC) X-FDA: 81502441902.12.C5AB0A2 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf15.hostedemail.com (Postfix) with ESMTP id 7DD61A000C for ; Mon, 27 Nov 2023 04:24:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qm92cXqP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701059049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NEXMJLszQDhGfzr5kIVFv32is+ER6kmRxjkrydSVUsU=; b=TYmpI9wyIY6bMOYOG6cf2WyeOG0TDPd5Tl+MYrBLb5l77MIEHPSWNcH1uYf1Ab91vbOoVD LxdAyqa81WlW9K6y9DjMbIoX9xlBsUdCFGsTTB3MYPyHcic/Fng94wxhmG19gartXI3Eb5 jGKkqplOMHBdKTXszTdRVRzfgZTFnRw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qm92cXqP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701059049; a=rsa-sha256; cv=none; b=GJ6syZazvEkTmh0wxwg0f86o0PItU4ZNvj69vfX0ICAMQCIYOPZZwowwW7TRP5MGxkZqfU ahuWdWaxh/Q5cGhJj/NKuoCx9b1iyquf3ygM3WcY7ddOLdNTYuLQ3wWXEofiQ++5dFzxXN Jt2rxexgZKG2b8o11Ylh9vzUPL+avfM= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-549070a04baso5093816a12.3 for ; Sun, 26 Nov 2023 20:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701059048; x=1701663848; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NEXMJLszQDhGfzr5kIVFv32is+ER6kmRxjkrydSVUsU=; b=Qm92cXqPDezATAl6GxcCnZZEv1gG1Eq9QNYV1N0Y8qJLljx4r0FoSEbMqyu669qGgY LE80lCdp+2L4+N8ZlR7xIEMZ2T1y7KaXA/J8CcrWuKyx1GC8JovnWaUbI/INLMb6cVLe a8+wayD9yVSsOcParVGiNbccIJPc0A2EWs+veb87tHhMmhoKdwbswwJL5WlkREfJvRPw PubrgQRLjgQeHCHTPSHU4KrCe344Rx8VqtQlyrZG0S069K2d0mqO/F0HvynO6ltU3T9/ Ezyl15uGgQnKi8Nj0cU6t7PjPjRh5h1d8EYBSLPb09zTMsBu/NDZh6K7Kz1BZljV6mi+ QzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701059048; x=1701663848; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEXMJLszQDhGfzr5kIVFv32is+ER6kmRxjkrydSVUsU=; b=UL7XDB9vcLNcyu/3ssSCOa6hn6T6MlNbZC7vbzogXx9whWIybkE/jmtJxeVLovf1sS hZE42zZXYeys6yAg1ZLunHCCnWg3QcLlrRhkf2UgQKF+5g9bo6EOmAkuoJxEjkepxeII auS+/D7FNmVxUgPtzVqqjOGsZ41E0ax1FkUglDIv5OtRS8amn48k35dvcIb4UKgowohG 5LrGOahKoI3CuQuY25AYu4yultbSi0AcPXy1FRS9cERineMMNYv/Dewsoh4CKaGOAYZr TEk0BQL36cGsytA3U7EGBemPvN+tvRZu47SJUy9qOBNRTPoFwrfRtQHZFF7AZgK0zIVY JCvQ== X-Gm-Message-State: AOJu0Ywj3Qqdbi7kVNm9u5NHROOhCCQUkn4uq7ywipp65OnvgeeK1+QN 4eJclhZ7eevQkI9ZJfVbF3XHY42dOL3EAG8MUyA= X-Google-Smtp-Source: AGHT+IG/zt2iYN62fPrr7sJIYjIfIwWYOBb+ZJ9f7sa30hes5ZUQtO+6rMiz/gP/aDOHh0BWfZHEgafTpBi9gVuqFSQ= X-Received: by 2002:a17:906:2da:b0:a01:9e72:9579 with SMTP id 26-20020a17090602da00b00a019e729579mr7688634ejk.60.1701059047934; Sun, 26 Nov 2023 20:24:07 -0800 (PST) MIME-Version: 1.0 References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-4-liangchen.linux@gmail.com> In-Reply-To: From: Liang Chen Date: Mon, 27 Nov 2023 12:23:55 +0800 Message-ID: Subject: Re: [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool To: Yunsheng Lin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7DD61A000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nc1q8aqmrs5ky1k7ermo6pcftc451zwc X-HE-Tag: 1701059049-224999 X-HE-Meta: U2FsdGVkX18PaFaWChiB6BnRqxxMILzOn5eRYFoVIMQMBA4iYJe4pwSlZo1Z1iKXelcK1mJzPm2gel0W3gdxCghfBKlEh0wI1owlPPR+ITwZNKqatAZ00Qfz6hIXnLyiCnaC+RUOB1e650lcb80JS0fpIHT2QkW0YRaWl6r9gBK2cGrAc2AYhm4i3RKBmBwkaQUkkf7rTlOf2EN8eEXu6VNYuw46NzaSbd7cOamkzCCiC1z8RzDrkDIV8vwdzoNXIheLoAB4j1A1CyTiWbOKv+WFUAwJ0E7Abc6tJjTkllGvNgItFkd0ISgHFgZIHufe8/Yek9kHoJCtAIIs2lo6ZjHKeFqIycuo22h0jHPs3bBQGjWAhdgvOV0ihLOq83VjylIp/5iidkcpgUnTu5gm37WnJT/E8I6UU5ZxqFpehtBIQ3S3gfG9kz76eoV6D91PrsH3Mesp8bZS9oNm0dsQftpmu/TQTgBKKmnX9sjo5YapdsZtCNW6Z0IwIcvk7IESE4Qy7aVTuMXgnZGW9yw0rcbrtAd45QttYmbTbFqR/tz4gGsuHjFu+Joa0s4lT2grfaTOBK9XBM1FGCXJahjgeFTu6SAhlStZMyBrqwM5iGoNDByb5VrZIhWz7Qx/F3Di4BIOtviQdcPz5yEd+m7+7nNF1qXfpbxvIHYDwj8zL8ITnHfQtAYW+uMooSOOEIXTS8SwPH5oIsM6YmhRkb81yCHBCTJJAnW70pyO4bEJu9jzAU0xpQ0+AHwhbzpsoLLx4rPHLjBZukq1iY7eNc8iQiHwjWiwr2FqVA2XS2XNCvGbuBWCRbjruK5eU6b8WvDJq+ybEpo76upceGfAIrbON58erWtW9TnnNotVLVQaPNJKIFn3DZctkPemuOLGqbjxBepyi2Nyv7cr0xZnLbQgxzTU2jNp9R+jMyAXQD9SK5JZizhWwrv0svBuMIAiAQWxnLnbXK5bqmmXYFyABvv DjXBnEPV IMUT8QutNqY4gStpyDGkJprEdFq7jQzFvuqRsgTF7NTFzxmGc4rhZJoe1A7wmzSoPYheo3lk8qdxXITkmFXbZgsEBZiaaoetXfR5qjj+BpnW9YeYp5T6DdpcrSJCzhL8Hp39fjbAbreqt4/swZsPuYPMDtY9/h169MajDDT9cq2C4CgTMtRPnEcoyAmBhF0DVoLLVsGFZ1lgibAQukYl2BZhlGxzHUqaz5wCJAJK/xVZ5ot0gPfnSH+ImNjDQ2JhisMXSOV+uxazwQ5Vlg7mbW0MQA95enS0MlDg8FgnR4p1HXyrNHAVdefdnJg7I47CVDITJfZmODCoQ69R8/6EM1/3RSk6Hg9WoUKcH9hzlBc6Lx6a8AzI3+opKBy62xMqBRrZE6bks2k7FcUzul1x3aHk9+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.068822, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 25, 2023 at 8:16=E2=80=AFPM Yunsheng Lin wrote: > > On 2023/11/24 15:34, Liang Chen wrote: > > ... > > > --- a/include/net/page_pool/helpers.h > > +++ b/include/net/page_pool/helpers.h > > @@ -402,4 +402,26 @@ static inline void page_pool_nid_changed(struct pa= ge_pool *pool, int new_nid) > > page_pool_update_nid(pool, new_nid); > > } > > > > +static inline bool page_pool_is_pp_page(struct page *page) > > +{ > > We have a page->pp_magic checking in napi_pp_put_page() in skbuff.c alrea= dy, > it seems better to move it to skbuff.c or skbuff.h and use it for > napi_pp_put_page() too, as we seem to have chosen to demux the page_pool > owned page and non-page_pool owned page handling in the skbuff core. > > If we move it to skbuff.c or skbuff.h, we might need a better prefix than > page_pool_* too. > How about keeping the 'page_pool_is_pp_page' function in 'helper.h' and letting 'skbbuff.c' use it? It seems like the function's logic is better suited to be internal to the page pool, and it might be needed outside of 'skbuff.c' in the future.