From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F248C07E98 for ; Tue, 28 Nov 2023 10:42:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D68306B0280; Tue, 28 Nov 2023 05:42:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17EA6B0282; Tue, 28 Nov 2023 05:42:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE11F6B0288; Tue, 28 Nov 2023 05:42:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA05C6B0280 for ; Tue, 28 Nov 2023 05:42:10 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8499FA0185 for ; Tue, 28 Nov 2023 10:42:10 +0000 (UTC) X-FDA: 81507023220.20.DE4C6E7 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf22.hostedemail.com (Postfix) with ESMTP id B467BC000A for ; Tue, 28 Nov 2023 10:42:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J+30B4j0; spf=pass (imf22.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701168128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DozXjJqnuFuq9pSAH2N19zU2gp9mW0B1YAvriLiF6cc=; b=1jiSTSUkqKVUq1igebbqZG4dTYoxuw3VQIH+mOsif1kiOOonI0DI6je76M01rTB43pkkpl sGZ/g085aFKCcRtCVqBXiawPhg5/m7lZdXPU6iLFUCkA1ONAkyvbykDDfLIfY0ukvjtxKf 0cLQjMR/hqDOFQi1rAN15ohXGROeqNI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=J+30B4j0; spf=pass (imf22.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701168128; a=rsa-sha256; cv=none; b=rjylVqy4ghpMpgbFV6zohktvx9F2HaP0+pl2dVHnjhovur2/d4x3t9aXa7dnk0uRyOw918 vPO6eagKqGvuLFPHzFxHkzrVMGmeKSzfMlS0SZCH9GVgsvQQzkMRqLPqaqBnmm4fQ+t+os OT5uT61zNR7v5k74Sbu4sE412wu0Ocg= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-543456dbd7bso11842794a12.1 for ; Tue, 28 Nov 2023 02:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701168127; x=1701772927; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DozXjJqnuFuq9pSAH2N19zU2gp9mW0B1YAvriLiF6cc=; b=J+30B4j01c7QuTjO+mRj/9urXYHec8HWYuhqVrQ6lYG9MOwxakaBFCtYW/jvrVvSL5 P7Or9RdeIxuTE1Dj+Azg37e4iqKtcmrOzBdCHxdcwdxS7LrMD84HvLteg2GBr0Je6roW sOPuxPFpeNGuEN70LI0btRWuPcLkl0BXy9m9nRVPS0axAzF0/TKKLF1JQRBR8ZM3Sk19 CtcoanEDe2afUtgdgsB3OU+6sjI/dDTYoOJcxOr6QSyTo6wqH+8wdctUDvlYqdxkR0Tw NlUHCTbsNva0eRfUOLq7kKdS4j1508KFnvN/HnVDdoOnqRCcCxGy5TD8sPJt6Xu8C3eG JA/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701168127; x=1701772927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DozXjJqnuFuq9pSAH2N19zU2gp9mW0B1YAvriLiF6cc=; b=h1HZAu4OkCDee710tjXZLKU4YOOuJpHQz3Q/tIXLD2saowsUJNAUFf2eWnkCBLkCya i0Z/wRSjSheXo7aS+DpP6WxGsTXbevoWLFebsED5COYmDJ3YhHN2f80RNTAZH9FxW5lM M6OdE+Hn1PiC8kTpYMeZmb+/XUbN9VV1R19hOYM+5PnH4TA8/V8Vjdj6U1zs0mGlbbAs LPBANVsFfOjgtVtninUcctuHh+Yt2FYyTFJ1/pp6HvuhsVf7xTwDupOEYCfimoxydH1n YG/ypJiHx7fHEwxKyfdKmHWIRT7whTJ9+Im6I9CfaS9EwkaSpbHimAXhhQfKz3iq/B6d hpKA== X-Gm-Message-State: AOJu0Yz8EeD3smhH1IbTZKulEZl4rNFa2PVdQ4MtzWVW2Kyv5OEcjJCw ZY3+EkmjEr0Y/oqREx9gUfdPtRgaBCS3OuBJlrE= X-Google-Smtp-Source: AGHT+IGTZIrZa1Lt+/Q5jBFS7D8yaTtRM40DmOkXoDVWsRHMms0pfIOn0To7U9cqouW4Zr2K3C7ygQY9DmN0WRNbSSU= X-Received: by 2002:a17:906:c791:b0:9ad:8a96:ad55 with SMTP id cw17-20020a170906c79100b009ad8a96ad55mr16600400ejb.14.1701168126895; Tue, 28 Nov 2023 02:42:06 -0800 (PST) MIME-Version: 1.0 References: <20231124073439.52626-1-liangchen.linux@gmail.com> <20231124073439.52626-4-liangchen.linux@gmail.com> <288af908-eed4-7ba0-17d5-2c7fb2c87233@huawei.com> In-Reply-To: <288af908-eed4-7ba0-17d5-2c7fb2c87233@huawei.com> From: Liang Chen Date: Tue, 28 Nov 2023 18:41:54 +0800 Message-ID: Subject: Re: [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool To: Yunsheng Lin Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B467BC000A X-Rspam-User: X-Stat-Signature: ffnn8ft36ktm3e45r3f9es3s6r8ktm7g X-Rspamd-Server: rspam01 X-HE-Tag: 1701168128-776354 X-HE-Meta: U2FsdGVkX18tE7aA91wEiHvXsPklsW9rPLsAyYFsMRc2XWDeWvB9f1+Oa5u1RRukNg68yZvKJbnruCTa/67rcYnxZRcGTOdpksZOqYh96DRuEaS82srHrwVm3Dt72CL43E85BOQ1K32/4Z8GKl1Q/gyQp7+OZACn+P4I0Ih7nzA3ZCJb6iUPqWFww8awoliMGLQbf/AZWnWWkEY9n2NHqOdZCGzh7NWqPy3yMK9GCyrwCEKSSdS4WrVS2kyPY+2tslKfJnASaGnbIUbDMFv7RNvXFgENleUORZ1drSZnvUihrcnrHDWvBXnMjQjCPsmqDUts15EqU6HLE5XhrSVbdCBAEp63Lx6peB+5ul9CjRUaNl0Rmo8wPHBiJ2hWCbPa1bfGrU0JxYRbAWaleAQfWUPb6+kWDIuapzdtJJ/cgMzR+apW28NuDgcDwYMA7m8TpagtpiH25RNox3DaZwFz3fwq9CYK8qAB+bHG1gL2i2DAl5J1wt+Dbyz7ZT8XJJg9upauSdiiYn/F4L2klwP9QwIiqZ10wKwSbAG+Vn1GXSt+zqtKzWxF4+v/CbA4gFOwzUEtHliigUk+NgVigG2h3CI/+SBmqyH7MxJUXH6s/qG3JKJRUJtNVN6vH4dJSTIsoLpzxEJUrNLLnnBxbTB7O8+sSOsE+UwPSUUv35tn3HqXolIl7bnLdnCxTkWaA2/U5NFShHv7pUbWFLba6IS71FQg1s58Mi/vJV74FMxRgcM5KQBr2LAB2C95oDxoDVzu0v6FW0wlbzc3bDUaHIAwC3Cflpt7pFjEOyvj9U96PN6kEvOtOGY590fJ1gNo6Kd9uib4rILVDobE5CRVVYYFSZWSHudMlDZ7mPRt45JW6QVmZK01+8lbq949k7Hr7nDqiefWzP7e9t/OTlZ8MEZz9Xiuefy37O1z1NxaTmy98God2StzDZLTiGP/AINyRzbc2NWLyPu6nidRkq3FDhJ 2AwiqSgL NiXBKmF/vJSgg0Ev//J7b/I3lqy3Qykoga1+u8+OsMKoU5D8TRs4QQy08v0WO8zSbK6vhw9Xf14ovLaDKkA3+75TsjhwF/v3GJFKTZbHKCXFW2W/ctRMoD2/vQ0hHMdiUv/LCUuDFQB1h/P+gJcSBWhOuS/lYE/NCNwbbAGemu/RFjym3vL7slPMA8UzqrPLSURMhmY/oT1uu+djyKLf7tsvlqudYQOE/WLaPW5tCJDCkPFPNVyyTIOIH492v82kZpryRjQiDQNjsJQV3t424+jmFZsLm6clsB+Ta2EcyeoC5WP4OEtfpHD/E4vatd29tiwd55MshMe1Re24jEc7DDQ7PHa+Igyh3LU517F66SwqiRjGpFi0fAA+1GJbPho+aHibAwiQZPuXmkrsGUQQlTbAtRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.203785, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 27, 2023 at 6:48=E2=80=AFPM Yunsheng Lin wrote: > > On 2023/11/27 12:23, Liang Chen wrote: > > On Sat, Nov 25, 2023 at 8:16=E2=80=AFPM Yunsheng Lin wrote: > >> > >> On 2023/11/24 15:34, Liang Chen wrote: > >> > >> ... > >> > >>> --- a/include/net/page_pool/helpers.h > >>> +++ b/include/net/page_pool/helpers.h > >>> @@ -402,4 +402,26 @@ static inline void page_pool_nid_changed(struct = page_pool *pool, int new_nid) > >>> page_pool_update_nid(pool, new_nid); > >>> } > >>> > >>> +static inline bool page_pool_is_pp_page(struct page *page) > >>> +{ > >> > >> We have a page->pp_magic checking in napi_pp_put_page() in skbuff.c al= ready, > >> it seems better to move it to skbuff.c or skbuff.h and use it for > >> napi_pp_put_page() too, as we seem to have chosen to demux the page_po= ol > >> owned page and non-page_pool owned page handling in the skbuff core. > >> > >> If we move it to skbuff.c or skbuff.h, we might need a better prefix t= han > >> page_pool_* too. > >> > > > > How about keeping the 'page_pool_is_pp_page' function in 'helper.h' > > and letting 'skbbuff.c' use it? It seems like the function's logic is > > better suited to be internal to the page pool, and it might be needed > > outside of 'skbuff.c' in the future. > > Yes, we can always extend it outside of 'skbuff' if there is a need in > the future. > > For now, maybe it makes more sense to export as litte as possible in the > .h file mirroring the napi_pp_put_page(). > Sure. will be done in v4. Thanks! > > . > >