From: Liang Chen <liangchen.linux@gmail.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool
Date: Tue, 28 Nov 2023 18:41:54 +0800 [thread overview]
Message-ID: <CAKhg4tKr5FZyeMq0+dyKQydgeE4WrEimhpxv_nVoqqY96YWK3g@mail.gmail.com> (raw)
In-Reply-To: <288af908-eed4-7ba0-17d5-2c7fb2c87233@huawei.com>
On Mon, Nov 27, 2023 at 6:48 PM Yunsheng Lin <linyunsheng@huawei.com> wrote:
>
> On 2023/11/27 12:23, Liang Chen wrote:
> > On Sat, Nov 25, 2023 at 8:16 PM Yunsheng Lin <linyunsheng@huawei.com> wrote:
> >>
> >> On 2023/11/24 15:34, Liang Chen wrote:
> >>
> >> ...
> >>
> >>> --- a/include/net/page_pool/helpers.h
> >>> +++ b/include/net/page_pool/helpers.h
> >>> @@ -402,4 +402,26 @@ static inline void page_pool_nid_changed(struct page_pool *pool, int new_nid)
> >>> page_pool_update_nid(pool, new_nid);
> >>> }
> >>>
> >>> +static inline bool page_pool_is_pp_page(struct page *page)
> >>> +{
> >>
> >> We have a page->pp_magic checking in napi_pp_put_page() in skbuff.c already,
> >> it seems better to move it to skbuff.c or skbuff.h and use it for
> >> napi_pp_put_page() too, as we seem to have chosen to demux the page_pool
> >> owned page and non-page_pool owned page handling in the skbuff core.
> >>
> >> If we move it to skbuff.c or skbuff.h, we might need a better prefix than
> >> page_pool_* too.
> >>
> >
> > How about keeping the 'page_pool_is_pp_page' function in 'helper.h'
> > and letting 'skbbuff.c' use it? It seems like the function's logic is
> > better suited to be internal to the page pool, and it might be needed
> > outside of 'skbuff.c' in the future.
>
> Yes, we can always extend it outside of 'skbuff' if there is a need in
> the future.
>
> For now, maybe it makes more sense to export as litte as possible in the
> .h file mirroring the napi_pp_put_page().
>
Sure. will be done in v4. Thanks!
> > .
> >
prev parent reply other threads:[~2023-11-28 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 7:34 [PATCH net-next v3 0/3] skbuff: Optimize " Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 1/3] page_pool: Rename pp_frag_count to pp_ref_count Liang Chen
2023-11-25 11:53 ` Yunsheng Lin
2023-11-27 4:21 ` Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 2/3] page_pool: halve BIAS_MAX for fragment multiple user references Liang Chen
2023-11-25 12:01 ` Yunsheng Lin
2023-11-27 4:22 ` Liang Chen
2023-11-24 7:34 ` [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool Liang Chen
2023-11-25 12:16 ` Yunsheng Lin
2023-11-27 4:23 ` Liang Chen
2023-11-27 10:48 ` Yunsheng Lin
2023-11-28 10:41 ` Liang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKhg4tKr5FZyeMq0+dyKQydgeE4WrEimhpxv_nVoqqY96YWK3g@mail.gmail.com \
--to=liangchen.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox