From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D51C4167B for ; Mon, 4 Dec 2023 02:40:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71CF56B0286; Sun, 3 Dec 2023 21:40:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD4B6B0287; Sun, 3 Dec 2023 21:40:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 594586B0289; Sun, 3 Dec 2023 21:40:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47D676B0286 for ; Sun, 3 Dec 2023 21:40:21 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 16A8A140242 for ; Mon, 4 Dec 2023 02:40:21 +0000 (UTC) X-FDA: 81527581842.09.77C55FF Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf20.hostedemail.com (Postfix) with ESMTP id 4D05F1C0015 for ; Mon, 4 Dec 2023 02:40:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JedKEfxj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701657619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n6ad35jf8C8Ph7dsQvygt2QEuwxMTGgW33q/fgDf/SM=; b=gNZnb26UJHfco9NaRyJzRFgwIgwrpP78YhZMj7iVUYqfdzLyVJGLpn8q6Vk+hVvxuBk3Ti eGW38NQGYrCQi/uXUkaZ+hrm/u/cP6XofR/tDXcUux3bnvd8QMgxTlP4HWza6Rs7oBfE37 DlKd8qLxkXoZscg6Rl0gxtPboordzYE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JedKEfxj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of liangchen.linux@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=liangchen.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701657619; a=rsa-sha256; cv=none; b=Rfchm4ka0wuaumrSITLRLi1qUWbbe+4Nqc9BeONiqhcUTf/PyB9s2QRZl5O2+ge5hng8fi 4LgZDxWbYOymwdhnEjy/NBzER2pSklva/9DtbkO59AVBS87O/mjsv5xhMDvCGajeyxfpqG 9uDcO9uNcfNZ113gJE+dtIOnYrFGEQw= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3333b46f26aso1382864f8f.1 for ; Sun, 03 Dec 2023 18:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701657618; x=1702262418; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n6ad35jf8C8Ph7dsQvygt2QEuwxMTGgW33q/fgDf/SM=; b=JedKEfxj1CZMJsfoBdKGL9q6s9J3Ovua07Q4bblKFd3QqqMdW4ACNcuumf9LGuV+OO P2VCxVht6XvkUo/o+gDJitZj7C1e+4TJLWUSLGyOQDAygItTzIJM1wvdqL9e8uM3KSKd 23peL6pRxGEYmElHkYIqhTYVn+IlWpPYRMTc793IvfiSSk5TMxxC3mHMPtxZhtaOn9Hp Uuo8wrTeYX8vOmfmL6jy9iQLcFpq9RoCBlz5kBmCxGRRA6caKUrqV7ufmEllRX5oBM8H 6J6TDVC+UzFY/CUQD92GMeog9NYSouvqAZOsKDRokW4dTC6tJeyWfI6MNcYwbjc+BPQK U5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701657618; x=1702262418; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n6ad35jf8C8Ph7dsQvygt2QEuwxMTGgW33q/fgDf/SM=; b=tPWHe7vH44cYmY8K6SCcRYqnodW626aMtS19OhOIV9e++wk+UZxRCYF5CBxB5d8QAO P/W2nR1eL1MZA/KnKPowp7JEq8uQECGFIfBYgZckmAP419xTpyyLCz/dghfUOISy8/O2 7ARmpnpL4P2N3UbhJqhcsZMYqDb216drlmn9YggUvZkDVZTLboS/iSciogt/3VQXbfOZ +BuOTtUcOR9xokm7DFT93n4oikVZusOJLyw7yipX4djEmm7UelFy5jw8YhnZ2jUdGZ5H XX6SYlHYavouUu1hz5OF0pH0r/TTg3Al859uiBWr9bbwgoTIZgNevfGIinsaRGZLbZzN Ef3Q== X-Gm-Message-State: AOJu0YyeXZm0fJ+0boGvxfOTqsUDj1rJt2Omfs+rPEKiK4fyJjV+7oAS EmodnzEthDqVS3DE9zfrx+QwZJsuCPFunOcqBC0= X-Google-Smtp-Source: AGHT+IHvpQzHOa6JyrsYbT48kgHxpqhNoY1BCpvOXKIE0ASxxvQvE22pbm9FbiDKAy0qr7L+P/CArsAr28TXXdX+yI8= X-Received: by 2002:a05:600c:a06:b0:40b:5e1e:b3b6 with SMTP id z6-20020a05600c0a0600b0040b5e1eb3b6mr2085201wmp.52.1701657617452; Sun, 03 Dec 2023 18:40:17 -0800 (PST) MIME-Version: 1.0 References: <20231130115611.6632-1-liangchen.linux@gmail.com> <20231130115611.6632-4-liangchen.linux@gmail.com> In-Reply-To: From: Liang Chen Date: Mon, 4 Dec 2023 10:40:04 +0800 Message-ID: Subject: Re: [PATCH net-next v6 3/4] skbuff: Add a function to check if a page belongs to page_pool To: Ilias Apalodimas Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, hawk@kernel.org, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-mm@kvack.org, jasowang@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 3okssm3r19ez5eoqxuuenhdyn8fd8eyh X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D05F1C0015 X-HE-Tag: 1701657619-653760 X-HE-Meta: U2FsdGVkX19aVVPzg2YvBNOZbUTP1Dnm6aK1WV3Az3ZP5SEQKmttCU4NkoQhKj56mmS4fKq35FV3OgWYe2FSTJ77zNTZXOpsYDlSjNrOLVXzpaBqDhcuhOVutEmzcwUyOy+rrqKFyKczCPWid9Z3jv/QaXgLHKVa4bJH1QDvHf4iIL5Sw9yHHIclx1aMlvbgsco/dVAxaLsZEcm7qRYx7CBC0vx0u/vFyO9kWb6n6FPbgNN2aVp3P9MZcArhu1qdgc/vOCAEQTbwBWJwkuoSODgDRWp4U2nxk30aadya05RbDs9B7CWrBXEmLl3Myd1wbDpl8rO5WlRR1PT2y1xA3lRer61xnw3p8DT7soqKbdHcr3jtC7CS2Akz4cZDuSkZUeJQfAq4mbkToi0XILwZ/Z+EiJIAWdVSeSoTjNQ27Gijcz9ocKpPpK2wEekArXOYy8ThLAurHt4jjwu+bTVvXc+u4EBwUMK21UD+bZjNIDw/KzQaVj7JilopZTI5ST8fdRzimm3exJbdhi+8U8gp2xOdKm4UMx9kjuC0gPb33KTJali673RltvKLz2uE/dJYB+qT5/f8oJyFlR8MXvdpRYuQFQNYZYWp9JsRS3HPE7l7psmeFOM38SFq7/1PYldoP1Fu+FgfS5HgRcIHw3fnTcC4yD83YIbIYro99pUc8vXhehXCHil4kfuQ/4muQ9gcKDuMn0gGFY50ZSfJw0mzwfDDcd4srgkfwdrVPQKIXEMhWKpjoBJpRUbgjI1hxGJDaMKTQdDiznBU9Kmdd4Adto/8QSKRoFAwPrUpgf7zuJkpGjgJ3w139sPSIxhZ/loWpAmT2FGKnG0vZLQO4JrlIZNnVOQ8zlXagGhFwuRWi6ntbcUSaaROLZM81wNzetOJcaGnhuH26UOkBQOy0OVdtCNk5o7R12QcYJx6oeQlUG6gS8rhZQKMzurXHgYN3v/3+CxaGMs2W9OlxYXbpi1 NlFpT0vO hA0TIpjlCU+gtbriQQgrHYMmqzFewNbi7Bnk6BZZ3UU4p19/2aZ+0blW638VEV57usgLrvkjHEKyj6IP4ebJEOabmiItppRcHnAk3152YJPlCN/UCGU9QHUdfkfHE01lFNyuljA64djr1JYofpuLVJPstCir+GWZ+v1q3UatgUtpTErQ3/FUyCA/uWFP3fs/Z0Hh6EF6+eAUi4nkjNKFmtFd9pau/TTdcYkvegM3fyzz1/5SS5JS3i/WoHOPBsICmNaO+I+twSuxVNJ47/FyJejfjufEkbiO99vNwv8VjqfulFJglfIZbJ5ShldXIBw6frLy1CMH1qc0FxZ2k3qzOyJWgah2PchDU10a0gNUooQOVHOs9D8e9ctAHM/XrKGWnlenxjPkJEk4zNDfosxfkTDNe4vW226yuKShFP2QNSNgx4F1kdVcxOMflUi9+EM0Q3yxd3xHMqSlvQiCEAsB9lfQpP6gtzJO7/Xlv8Ev8O9dzmdZbkrdF0J4UGMKscMCIunimPbli58LRYV9BfFPsvmT6rHfjhSpDypW4IJ7diT+MpZfx+783uY8C2KjLS5KYlTUW1BnikZIbKHckUeVgpthIcHLQ1mQXuVRF X-Bogosity: Ham, tests=bogofilter, spamicity=0.003237, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 1, 2023 at 6:23=E2=80=AFPM Ilias Apalodimas wrote: > > The second time is the charm, apologize for the noise.. resending it > as plain-text > > On Thu, 30 Nov 2023 at 13:59, Liang Chen wrot= e: > > > > Wrap code for checking if a page is a page_pool page into a > > function for better readability and ease of reuse. > > > > Signed-off-by: Liang Chen > > Reviewed-by: Yunsheng Lin > > --- > > net/core/skbuff.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > index b157efea5dea..31e57c29c556 100644 > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -890,6 +890,11 @@ static void skb_clone_fraglist(struct sk_buff *skb= ) > > skb_get(list); > > } > > > > +static bool skb_frag_is_pp_page(struct page *page) > > +{ > > + return (page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE; > > +} > > + > > That's fine, but why _frag? The same logic applies to non-fragmented page= s no? > So rename it to skb_from_pp()? > Yeah, the same logic applies to non-fragmented pages. How about changing it to 'is_pp_page'? It takes a page as an argument instead of the entire skb. > [...] > > Thanks > /Ilias