From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A0AAC61CE8 for ; Sat, 7 Jun 2025 16:21:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC6D26B0088; Sat, 7 Jun 2025 12:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B77676B0089; Sat, 7 Jun 2025 12:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A65D66B008A; Sat, 7 Jun 2025 12:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 88BBA6B0088 for ; Sat, 7 Jun 2025 12:21:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F40FD1D77FD for ; Sat, 7 Jun 2025 16:21:32 +0000 (UTC) X-FDA: 83529120066.01.2EF56B7 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) by imf21.hostedemail.com (Postfix) with ESMTP id 797221C000C for ; Sat, 7 Jun 2025 16:21:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=A2Vz5jqH; spf=pass (imf21.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749313290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b1/dkGTH1xeAme9R9t2fbDHSI0S91hJULtQEJ50D1VY=; b=04/6LFx/jEkt98xRk67wg59i7Q7VDfyQ+waYSJBLa9FAIbO5A0WRNUohwaUh7fij6HuT9B oiM3lgFYrpz3GF8zagIBxK1uhqJT30UrTSntZKM9V86KSJkF3it8YOgRLfku+dSo4Kapm8 bFo0j5apsjlWVZ4wMwrS5N9qW6H3U9Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=A2Vz5jqH; spf=pass (imf21.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749313290; a=rsa-sha256; cv=none; b=3RK2MwgGDsDd1rrIn6U7j/Uz+Foj3Wr2eQAUfuJ55qOiIZV0TJrMY7uLRyzHkN/Ugh/jGA FbSftae45+d+4DeChvtjzgA4LkIDGxmoru1IdJc2RJGfQyncEPL2+S0AKE+ourQgl5kxTR wtU0p2tLJzti1GwffI2HLRtL+3dRzKQ= Received: from pps.filterd (m0167068.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 557E5pCm024167 for ; Sat, 7 Jun 2025 12:21:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pps01; bh=b1/dkGTH1xeAme9R9t2fbDHSI0S91hJULtQEJ50D1VY=; b=A2Vz5jqHTguP+2vmawdts1FsF06GwGS9TdrxjyypO205RZXDQfAmp+0nYOzIBlYLNAQR IrqwYnKwhhV1CCeKsCEqG8nbfjFoWO3k2R2Xly5B2Jkghr1Zo7kWMg3kUF8vcEQ8leA6 jwkdiVHBtbkHc9fWcPXkRTr0xSx55ehsmDX5w145E+QQjKGR4f4Iz+K2UZt1uzQH0LOt gOdDok1/r/3nAPAmHU9NOPtoIV7SXLjUhyB40qMXofuYbWTeE2LpUujYelWXe3cP+wPT ROTU/pXeJmKSrhOCCnwnpdR66k05cZpy4+ETNdtTVXXi5090LAGF2lXd8pl8jHUXjxCR dw== Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 474fq12562-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 07 Jun 2025 12:21:27 -0400 Received: by mail-yb1-f198.google.com with SMTP id 3f1490d57ef6-e819c3f8861so3461097276.3 for ; Sat, 07 Jun 2025 09:21:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749313286; x=1749918086; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b1/dkGTH1xeAme9R9t2fbDHSI0S91hJULtQEJ50D1VY=; b=GQIm1YT2TAycCJ68UUQtBXcf+RfJwrGJuZC099eLSg5TEo9fTDp0YuqnqzXQGB68p1 5AZsUSx6Ydocj9rqunPe9L8eIsseiL9UkQ3wzE2PvPpibDWe8gJkPPX1evhObXDsJkqM D4K6mGROjA2u+uY7u/g/jU48ECUew76/o3a0ZKSHkUYzwez2+bvd8c+sKKY+JzG181W2 bMcUiN4QfCGIDGPv8bej4rc+GreJSgtyKMdy1yZMbRXU0xXoowIs/mvlCF/jOslgFeTU KQARrkXNepZrnU8kY6hqfrwsaC4VDNT3VGhHXffz89lP2QgByLyuNadclyJgCinOg6Lv wpqg== X-Forwarded-Encrypted: i=1; AJvYcCUx3BHyTR7hNsVqw/MUaHcPboL+/GMcbAlqARDiOJwfHqKi6OIGxiPk1iC/g6P0cmE7yjzxvxDFDg==@kvack.org X-Gm-Message-State: AOJu0YxMqghgC5SuOjwIENLLH5+H02Fuq/eJ6/3RR7Tnpo9U4Gw7WBG2 NwrPGbf/wRZqeO7KGW5eCM9gUjvvtL/2ZZE/VQcmf7m8V+naCiRk2AB00AMLVos7vdU0CLHPepJ 56jQ4hZONE6uZUmtElc9U75M8ABNJVX62EOOAAmAu1li4jVMqXYhWvPrhz/BO/CuN2T7q9c4Q43 NrYQclI2XF0CVTjffVXEn+kVw= X-Gm-Gg: ASbGnctVQYs7BDJ/3m2ag1QcQG9x+yw84OONI4m514m6lKkC4PuGbMYt4l9LCW+ITfm t1mbPeaUy5eWrJJlU6TGAT/eDAy8VaFXbXyUo+MB4LJO/KIIrI/EsaUnRrXeswlVDlni+uWWZI3 uvkqw= X-Received: by 2002:a05:6902:1ac8:b0:e81:7940:a3d with SMTP id 3f1490d57ef6-e81a20d3aedmr10750106276.10.1749313285868; Sat, 07 Jun 2025 09:21:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWyeICt1A7veaAAv59SpFycsXTLfXEYDrG4MaoFSg9L2FwOS/7iU2JS9hVwi/qkCGPwcD0n/I3JBjeaeUGYPg= X-Received: by 2002:a05:6902:1ac8:b0:e81:7940:a3d with SMTP id 3f1490d57ef6-e81a20d3aedmr10750078276.10.1749313285509; Sat, 07 Jun 2025 09:21:25 -0700 (PDT) MIME-Version: 1.0 References: <20250607-virtual_bug_on_invalid-v1-1-b792ac2b0920@columbia.edu> <2a768123-4423-4f52-a0ef-96fa69872949@redhat.com> In-Reply-To: <2a768123-4423-4f52-a0ef-96fa69872949@redhat.com> From: Tal Zussman Date: Sat, 7 Jun 2025 12:21:14 -0400 X-Gm-Features: AX0GCFv6SH9nZ6VnHaOWZJU6oFxtwlJcRVa7KKHc4OLpc_7Y_UCQYQH3crh4lw8 Message-ID: Subject: Re: [PATCH] mm/debug: Use BUILD_BUG_ON_INVALID() for VIRTUAL_BUG_ON() To: David Hildenbrand Cc: Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: b1H4mlSZauEMQzZXJsLX4K1VIRgPBQ78 X-Proofpoint-GUID: b1H4mlSZauEMQzZXJsLX4K1VIRgPBQ78 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA3MDExNyBTYWx0ZWRfX7BvNllp4EoDs xQW7/vRhNKMb+PT7SYAYllf142Q88gpIuByhphi0QdjnQvFL7aFviAOy9OfkAxcnwR31rQsrlyh JBj80UNC4MkIw8HmcvZB1kfwknIp6x6H35Ye1PPGaz8tDo8PO8sOZ644BNwsUc4maSoQXJ8zG+/ xfK4aEJpLrv3qNuGfwzF+9Vmq87qrfjTSDPssAX+LVueVR/0/cCEVRhGLmn9ShUkt5wxXI4pNYK qa3Y5e1i9njEVTCEKLGSIb+tLQ4lrqm6xICT9ugdISfr2DzHsmDde/kMrNefRouVvuspXqQQOmI BXPeA/UsvlCCR5eq7/fxv3+tolexzZINlSBQUMc9DMNZcAQWkerkfI0YDOY+DAdDeqYMLjrV8zV 3Ow4vW+9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-07_07,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=10 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 mlxlogscore=581 impostorscore=0 clxscore=1015 lowpriorityscore=10 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506070117 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 797221C000C X-Stat-Signature: 9g4r16ckuoxu8sa5gs1j6r8xyz5be17b X-Rspam-User: X-HE-Tag: 1749313290-146811 X-HE-Meta: U2FsdGVkX18CgYQCfGGmVSJj9Gp6whA5bCeVIs5REfU5WX6Y/emISRXaku7Gx+Q6fwRdArxAx/kSEc7iASNTOlRNxzb1mcp5GUKE3KdHoRL+PgIGzTALIgiN3eOf1CLvOwM1+ONYnLAsahxFr2TlkWMDyc8nuJICnMAn6M9ss2S2ysjs7CL1Q0pJ4TUNcv2QItCXCgpzAW6M7uO2ei+PR4ZgJ1U66YOBBIP3H3wBbJQS1IwMZOiP+IX4nJx5aUtsqg0vq8xYYaaDTHNs6yOcXY5l8KLVEAJvkmpS+O/Q7lNspQc5Bc2nFL59n0Ua81uTuGFcKu6YSoomyB+qBBefuYEzxaZoHPthFg79LFdlvmR1eaNVxhJmjVaB1c5tfZm3p0ALPLsYkhgPfVws8zGnBp09nGYNk4JNsVb2cwwWR7/JSOne+B3PhBw8sjjj+/oDZfhJzuc4Bqd+6C3hGz5M1nEgvbXm8XSZSjqWrgccZY6lZGErInohYR6/o3dAtIYlkIdH1bPe/x71EwYyitWaTqor3V9CqB/f0CX6963G6FjdGH4FnhMaU2UsJGIU6qUsqY9ve2jy1HCRHWwtP2ROELxn8RCBw15EMXXG4qOfu8gN2SzNGVdK9/oYmgc37b3nbVE7+t+esvoBDSVWjTTwruS6FirjCjTQ4B/Jc2G6qc9YqMybCb2eDnmvgGxOvADJSWhbWgCS2CQyHiSau5sNsU/K6rmSt3BcmFmliSe6cEvN0Qw12G3bADUqcCtQKgUCP+2Gui9/X8g+o7duZQNZiYa3ocDjRlqak2+RtZD5N7xZ5r9vpZAVt7lBN9WG8bkTgrgxsjkz03SCnWMiTE1JE83q603J/kA8ypgUp/vET+CHUdFS1D4428GyGwu+fDrIph8s83TItbyQcV8R8WoXcJKWDXLMMXFzy9+JphwwuhPI9SpOV65qOGwjB3S3ADbps/hVFexMfJziIXJvzHh b840XZx1 jo2saMjxL6A5+opjC/DQR4BtUl+KiEwBvTvP3fAp2Ms8NAPXPMBEo4i9Fi+qO8HoF5H224TxbkcEX0iXsccLIXQkLeAQOhkQMtmNgth8MJXI+M2PyrD8HocbmJ9elpO134M61CxVQZt9p2r6ZdNgF4ZK0QFtymzaTh9SudeyiB0I9FYZbVSc0cjNeSf7VYjed0KDPfHdZ0+1lo50wexiw8zbqwMhIRxIM0cuTs/puxsLQ7Fti2GC/6aIGSqL75hspuxj6hdZa5jV8joC4FdZSlnWHDnq/pbDdTuVMsocoa2owbhKyLvTYLaQLyWAHyenysMCA2YiiesgY03S9I1NYRIDElKPUtim+JtBvp5YRHQrKm2PQQ78eJO9ZrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 7, 2025 at 3:59=E2=80=AFAM David Hildenbrand = wrote: > On 07.06.25 09:09, Tal Zussman wrote: > > This allows the compiler to validate the condition even with > > CONFIG_DEBUG_VIRTUAL disabled, and aligns VIRTUAL_BUG_ON() with the > > other macros in mmdebug.h. > > > > In the light of recent discussions, I think we should get rid of > VIRTUAL_BUG_ON completely. > > There are only a hand full of callers, and I am preety sure for most of > them VM_WARN_ON is a suitable replacement. Makes sense. However, all of the callers (except for vmalloc) are already gated by CONFIG_DEBUG_VIRTUAL, which doesn't depend on CONFIG_DEBUG_VM, so using VM_WARN_ON_ONCE() would break DEBUG_VIRTUAL on its own. Perhaps it makes sense to convert the non-vmalloc callers to WARN_ON_ONCE() instead so DEBUG_VIRTUAL still works. The vmalloc caller would then become if (IS_ENABLED(CONFIG_DEBUG_VIRTUAL)) WARN_ON_ONCE(...); as opposed to VM_WARN_ON_ONCE(), in order to maintain the existing DEBUG_VIRTUAL behavior. Alternatively, DEBUG_VIRTUAL could be folded into DEBUG_VM, but that seems like a slightly more invasive change... Thanks, Tal