From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86511C021B2 for ; Tue, 25 Feb 2025 16:04:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9AA280009; Tue, 25 Feb 2025 11:04:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AC7280001; Tue, 25 Feb 2025 11:04:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02B50280009; Tue, 25 Feb 2025 11:04:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D2B91280001 for ; Tue, 25 Feb 2025 11:04:26 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6D426B0BE2 for ; Tue, 25 Feb 2025 16:04:26 +0000 (UTC) X-FDA: 83158939332.17.B8DC972 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 068604002F for ; Tue, 25 Feb 2025 16:04:23 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b=ew2aVisr; dmarc=pass (policy=reject) header.from=scylladb.com; spf=pass (imf07.hostedemail.com: domain of raphaelsc@scylladb.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=raphaelsc@scylladb.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740499464; a=rsa-sha256; cv=none; b=56ozPlTmIXTPlSjn6j4Nxjsddln7Jhab1HVf0/JdDYUJUXUCEht/tUiNqy35/Xk1g5xr8W bc+eUZ/3GGA6wRL4+5rslfibQyb5JWaW4vD9lFSt/5u0u5Yy0CQ53C9Bz/mjy8ft4/1fgp A/3/VUf5pyPAzoxTzCMop6kQdgxkxCs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b=ew2aVisr; dmarc=pass (policy=reject) header.from=scylladb.com; spf=pass (imf07.hostedemail.com: domain of raphaelsc@scylladb.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=raphaelsc@scylladb.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740499464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hRKvkOnD9TtTQxj3HCyksPuAKJutP4jLh4PJeGhnrRw=; b=nIlMDfD/8pfnokcuqbDzjdDr6yTPyJR6ieNumsNjglLvC4I9FrCyKRtg4PtGjU2+cPFvNq mFewLEBuA2EQScjdo+twq2s1n+FASPtEfvBIyFfUG7R/79VyJ1WHBo9ykmf9OfsoFq4pZH loEcXogXVGUF2evQy/vRQMxbz+B/dVY= Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2fbffe0254fso11696405a91.3 for ; Tue, 25 Feb 2025 08:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb.com; s=google; t=1740499463; x=1741104263; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hRKvkOnD9TtTQxj3HCyksPuAKJutP4jLh4PJeGhnrRw=; b=ew2aVisruY2KxHPVPDJPZ6tALiYWDD8ovlUlH3YAbk9sMGvbzyDsYbTzk6eFJNwRkq S+IvNZDtNZTWWL/vKvoKlBtpJwM+Y7S+Z5Z7GCG8fk0y4CWadv5F7J/svr8/uKpS8AG5 T8X/pA+rtKZ/apFW6Vt1V7krrjlveXDkt379VhNPcmVM+3bu6/uN4et2uzfahEeHJHsG MIZ9rJZfXB3R+J79+O6DJIet3oNpnJGlctrEJXBT5zUOFo+VLc/tW+zJi7iETwxoBv6w 48aCbhZZ6QcH2S+ZFy7I/zSOfvIfTt8ZiuI96po1Ge0UYzt9QD+7Dx6qdwkLu5B6tJrB 3iBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740499463; x=1741104263; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hRKvkOnD9TtTQxj3HCyksPuAKJutP4jLh4PJeGhnrRw=; b=pD8Q6ke1hLTC8gBHaUrvDWOe691TP8vZo8BLK5AMzPhcbeXpnNmZ5MYStfrnM3QDVF UhuJQJAznS6h+losS4eLW4yK1TRn9zedckM8Mj/Mn+eE4WasN6FRoEoEZV42IO+TdjyT wLadhROTL9zNQ3sOWrps/8BEyMsS6Hey4Q/ri5l24rM8UrXX9Dh42VmYtf2OSNqKyrrK tdDoRrbTTK2CDj6jkYl+1+dDAamhVUAwdQHPmtsd6MPeZdUzShdNX0rhkl6ZFfWoeKqB 12l2UdZ7dysBIOAaT3qwAZJaxDWablq0VYl6v+XMUnD1JWcoP3mg0fgx45vtszxB+MCd ybCw== X-Forwarded-Encrypted: i=1; AJvYcCU8L9HEiYTWq4gKlvIOoHZ0VzysdBQE95L/k2OEnP8bdE6m23Vfy2qI0jD//VdtfKCbTkdTpzef3A==@kvack.org X-Gm-Message-State: AOJu0YyBi4fUte7urnyRGKOMuFxFIuGhUlImWhUyBv9TrJY7K3R6IiPk tTRRYSo/vBfZ8s58V6rhw9FPR8llq7WmQCsM7aCmyLDIHsEQaUScCcAhQfjtylCnCGdtOsP0awK XjoyZ/UkT0pVwH9j1WBFpPRswP5ncS0eEWtq16g03zPT5Ff1sIYxckQHm5Juicya0N2IJR52YvH s1Ia8hVSyWTx2IItVPEkGP6Nmbu3IcvWrgMVQiG3JdbcyFA/1sExU7NFKn62qQohlnJrmulfLXS RrBRPJDawNLW+VyiFkgyLrJuIGpkIV/yBiI1MRoYBiCA3i4rSm1w8+A6CoB6JZ7RuN2tAl6VCxn lWJ/qTAixHknHGrxe4TlQO8p/OdxaYtkWCGHbChF74uV3G1//Re2DxW2 X-Gm-Gg: ASbGncvrjkjti5ykDUVs/Of9K+bgvK/OhKcJrgUNZEZ4HkTxIuJasVonXsnhRPMkAj7 q8M9FdjRbxalvB9Pj72ZaKeaeVm3Z4mYihPksXs1cU48/S/DldbzkTDaGIoZ1/1DR6EXmQNtfiW VK/7+Ema4QYpjfCS1Eq40ndYys X-Google-Smtp-Source: AGHT+IGyh1jWG7kvXPe8EQRd9GcQQNFYExzpyCfQNpHjeoLN1FUP/xzECarfl4fqw7bw9I5wDY/K15SD3y8rUQxdngU= X-Received: by 2002:a17:90a:ec8d:b0:2f6:f32e:90ac with SMTP id 98e67ed59e1d1-2fce78a9aeamr31654991a91.11.1740499461044; Tue, 25 Feb 2025 08:04:21 -0800 (PST) MIME-Version: 1.0 References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> <20250224160209.GA4701@lst.de> In-Reply-To: From: "Raphael S. Carvalho" Date: Tue, 25 Feb 2025 13:04:04 -0300 X-Gm-Features: AWEUYZnSwsts3AlnyMyPnDoZIO5Ek4gNZJVOo4qq2rXtoP6hhryN1CYaV-mMojI Message-ID: Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT To: Christoph Hellwig Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylladb,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylla,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 068604002F X-Stat-Signature: w3cgb54pnk6mp6db8c175ae1dge73pzo X-Rspam-User: X-HE-Tag: 1740499463-212505 X-HE-Meta: U2FsdGVkX1/X3MqxW9JfGxQ7aaDrZfXnLINzWwFODId5hm8J96elFU52YxmZ5iK7aJx7JT6b8sL3KwU5BP1lpLFXeWa9YQ7n4LeVP3U5SEBYQF61o18fLM8h83c9wGE40wYyDIbpYQF8dDJaGMVUobpZv1q/tl1oLxnxjK8GzxGbOyg2vXiP5Szi0gIfml+gbTNzmFnWzEsj2Emwq5P0/kt7H1GO8Qef8RkDrRfHwcPnSx6N2mMFOerE8ZkKyqpQ2+iydqlqfudW/d2yzjUAHlhLFX4WACGjEO0IrMFeYdFhXXrki/1iow3gk703cIGX1jkZGpB4emQYlrpJ4rfknVIv3xF4xyWGvIRBnuHiyheLqlUC7/YobjRT7W9HP9wO4aZ7ShIsd2pP1e/zJJ6twyCbIFZ2Z8QDApDufYn3nq7B3pQhQ6P4614ocSXhnKKHV/RTLNQ4NbITA99vpsy/uYrWGN1Dj8bVEOx1+C7tQLUdGA18NalZIu/llu9YnJ19G+Tc69Ygtlgdg8hUOs1slHitSW7XXvFredNXT6LR0sPJ+x/Nj4uvrveUc3mCC8vdgfJc4PHSL8iho8LpeUF01xWsHGBKicyDQUBOCsjt0XCoratR2buZ9hFdgaFqDpKqF9mHH5bVkznDgqdU8URZWlTMN/zMVNyjL5W5oL6/NnQ05Y+4iIhei2LnhDzGwaqrnPPmA5A/+S995Hw1u5AjC8vjRm5FTMxNDfRWluFkgcqxnqcHIQo77xr6rZgwFb2rZWWSXs3FB31YjID67pdd6Ui85qwnjYcev2YxEPwo05F/cUnf04GiZpXgrbpW4SVEoLSQl2enkdkj5PAMgwBW5YSfxeC7KSkGM11mMIzl7WeNnXRYk7/cEkzgradwbBR2cz/oLQGjajzepKXk4sL9gZHUOShN60HYClDprlvZkmFymatC0jCIYtkfVFUrmUup7MlPP35XKsXhkfb0PyR gvKNivyQ QjC8L547uXPuKhFpN5h+3PhLrm4QMvAmJAKL2UJ31FDvSiwZo8v1rR8HodyoJeBa3sJnoS2xHDoQ+XHBdj9CbYJLjRZ1VP6nWPUq8TGKPeZiYQFSr2RFngRNyTRQqQe6NSWooZDw+kVd7JrILWCqzcQFHqQXsbWFyDxGWjyLao0cQz0jG3eG7H6q8rle57R2WjvEkapH06NDxEziHV6qO4JDX6EiJ7CFa55+pM1qVen4BIwFgTRokE//4rMdmsRl0dEqaRmKFca1h4wVViOnDNUMx65AHxuBlgSKLaQxAQJ2/X0wyqGHxn0q6Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.076977, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 1:15=E2=80=AFPM Raphael S. Carvalho wrote: > > On Mon, Feb 24, 2025 at 1:02=E2=80=AFPM Christoph Hellwig wr= ote: > > > > On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote: > > > I don't think it needs a comment at all, but the memory allocation > > > might be for something other than folios, so your suggested comment > > > is misleading. > > > > Then s/folio/memory/ > > The context of the comment is error handling. ENOMEM can come from > either folio allocation / addition (there's an allocation for xarray > node). So is it really wrong to say folios given the context of the > comment? It's not supposed to be a generic comment, but rather one > that applies to its context. > > Maybe this change: > - * When NOWAIT I/O fails to allocate folios this= could > + * When NOWAIT I/O fails to allocate memory for = folio > > Or perhaps just what hch suggested. Matthew, please let me know what you think, so we can move forward with this. Thanks.