From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02C9C021A4 for ; Mon, 24 Feb 2025 16:16:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A6F76B0083; Mon, 24 Feb 2025 11:16:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 656EC6B0088; Mon, 24 Feb 2025 11:16:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51F2A6B0089; Mon, 24 Feb 2025 11:16:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 30DE46B0083 for ; Mon, 24 Feb 2025 11:16:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BCCD4B54A5 for ; Mon, 24 Feb 2025 16:16:14 +0000 (UTC) X-FDA: 83155340268.02.417664E Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf22.hostedemail.com (Postfix) with ESMTP id BB3A7C000C for ; Mon, 24 Feb 2025 16:16:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b="uc3lz/4F"; spf=pass (imf22.hostedemail.com: domain of raphaelsc@scylladb.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=raphaelsc@scylladb.com; dmarc=pass (policy=reject) header.from=scylladb.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740413766; a=rsa-sha256; cv=none; b=nJ/M+5jL/mOY2b2SgvjYEkxTk6lGhtz4KQEMjAfo+FlMWhOQn51mKJ2LDpslj5kTXJmPSK 27r+aCh5eD1FVaxT9JmEBJn+gyiz5PjoiuZ5/rstGLL/UBQWbmV6jRr4GL49O8SZjPLQBB Ib4eFSKrOK9QbRJqZZVE28dY/xv9WrA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=scylladb.com header.s=google header.b="uc3lz/4F"; spf=pass (imf22.hostedemail.com: domain of raphaelsc@scylladb.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=raphaelsc@scylladb.com; dmarc=pass (policy=reject) header.from=scylladb.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740413766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VbFIiyVBu03rSNrD6SoQF/QaduESan/tbVEXpCDAIFo=; b=u6d63T59VlbL/dhwqlETWsSNha+UgQMz6SjjFkel1uVkY8QQgb5/ZI6vlaHjvFV/s5Ycfj /zO5f70PrCz+Boyx+d79ugI5TZjVTxQdyuRwx25vAOWPRhL+BCzOa4KiKrKtuDdQj4IJDH 7mvJCjKIxmB98HMW2/EmpXMa7kI0YvI= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-220f048c038so87099305ad.2 for ; Mon, 24 Feb 2025 08:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb.com; s=google; t=1740413764; x=1741018564; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VbFIiyVBu03rSNrD6SoQF/QaduESan/tbVEXpCDAIFo=; b=uc3lz/4FV9ukHppoYSNhULtCszpHeRiHQgSU0SkxWtkwkIguOP8EYv591+ikfvqn8O 7Y4f2h+wk3JN268dzZi0ocUtRlTsUMhyM9/Rye6ASyRQOAEu/MTHxqUZrNhf2SsPCyhK tBvlb46nUcj6YbOhRatZ0eP7EYzICDpb0H2fhHnmtaVkHdMRWLamWEVKyL5CsEqmJM6z oJZdpwW8hukXUGDzHFUp5E7XgFgVIk8TsRoypBjehaa2oiQdYMBXMX/ItSvtx4HqS/bs AxwiYuQAiqXtwUzKK6dHbpL2Pn32YOB/QFk4CAX9tA3Pv7hhNAZJgqq7tCM9H/VcERnY 5MvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740413764; x=1741018564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VbFIiyVBu03rSNrD6SoQF/QaduESan/tbVEXpCDAIFo=; b=PNOaoXp4w9x6ZAButrzjoflR0vnFmi7UFEe0T34Y3X364GOV+NloAfflBrdSccEZPY Qcuhf0Omip6S/+gRNGhS7ZfJgn49mmAXClOfrpkNuk8bZjSxbYnXFSb+uFWxTio9rL2a 36Huxmlf0GfD65dAAbKQZEp/eWesHXT6pCFp+wUfS+5oKgH4E+CY454V/fOkeJ6KXJqf EBuLg6voQH/CwLXnmqo4vq8OdKYWtQ2W+juvOz868tV4xQlMVx+QROqaSmUz0+f5/gvI 8GfdGpZg79yWcy1Lu5GR+pFBaAes/O+Z89JZfLBPf7HHLgDs1jPPtEOsJknxmL/mazgR sb7Q== X-Forwarded-Encrypted: i=1; AJvYcCUWfTlsB+EvCeOL90xJ/RYO+o3vTOBvZ+zjaQa0OwbxzN/ZWwRVCVv24WU6qUm3XLii05Omr4nJIQ==@kvack.org X-Gm-Message-State: AOJu0YzvXUhfsq7PIziav28/V1vTBeIoXbpoVFFuDEorrwTG+oZqc728 Y5/gWAZ24XNt7diCTQxosfa12CqvTNs0Kmo1632+FqZwEn17zIeMPBVpp1bku6gOXHt+UhWFnLQ B4FBmU7tJiSMbTFAqErItob6Rh7ms5W+LovSnI7b7QNC61WU2ETlsgc56VHqzht7P9L8tKWhrLM wOUvlvoGtdFAH2BtzaXh1SZBPj5/0DoGJEFO5pDQtYVchHdGes+eQ3Y5nmlypvxB3K32MoU5KBe 9q+OXnJp236G7pkijq1aO6YU2ilsKj0wbp22r2BizUtolrqyZKLTEg8qTYRxYmbzA0zJsCcjzzy Mw4KzqB/O67uhXqaN/z4t6/n3MdT4AigLWetGeais96TQXanTZaw4R15XmVCkiAmtssqwEfN X-Gm-Gg: ASbGncvuMINtkTskU/JhG0fWriCfWvMLAP9gVlrGOjWHZgz0lDKnyy62xheSizCVDKp SvK6bUuGhGkwbbJLjXZpFTPhgU/cCuB3HwkKd8b31Abe3I0wUxEoFFJuKrx7KCUIlr+IzNHhfhq RyIdpOw7XLs4WyX5AqmGoAXQ== X-Google-Smtp-Source: AGHT+IEQcUqXWyzW7txhoFxLDejkrVizVTPPzSveJ2vrUrEWjOUz5Sv5py/r8tfjXiTPcGqGgkDF7WJoXP7Am8Q34zY= X-Received: by 2002:a17:902:e74b:b0:220:efc8:60b1 with SMTP id d9443c01a7336-2219ffb68c7mr179690365ad.39.1740413763937; Mon, 24 Feb 2025 08:16:03 -0800 (PST) MIME-Version: 1.0 References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> <20250224160209.GA4701@lst.de> In-Reply-To: <20250224160209.GA4701@lst.de> From: "Raphael S. Carvalho" Date: Mon, 24 Feb 2025 13:15:46 -0300 X-Gm-Features: AWEUYZlaokoekDAILx5r9gFW_X8gGLcj_ZVwIHgsDoW_nk-h_xzSP63aCt62qg4 Message-ID: Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT To: Christoph Hellwig Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylladb,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: scylla,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 X-Rspamd-Queue-Id: BB3A7C000C X-Stat-Signature: 6upyec5ywcssawu89i1cczyfs3cw78hs X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740413765-425856 X-HE-Meta: U2FsdGVkX18dk8sC8a6RgjreRbmlrnLE8PfNwxpwqJkrJCC6/YwweOW/pDjdfx8rQ0+jQCH6gASg9zPl0Az92n1xns88JsPTxsfdP8fZI3vf7HMBDzThuH1ct8w7eBBYuSW23qd7/TfsyhHbGnc4IzNJilCzEjloL6Onjsy2cw22PpbjyAcsHndsBBPL+4gReuB3bcxksdVtHaf7FMaD8TUKHO7YDqHcr2tn8LoedlY7SW3sYixpFftbtcqgmwhnas1xZGX05r5EDr4Ayh4zol9E80YIaF7GvNRFyYaoKETnod8ji5j6AC2/uH25HtLhvOkwfJmSkzaVcNmFBRNnOMI7TCT9oJMkaWaCwuQsY3mim8/zJEZrDdDCkhz8aYSgcoK+ljrOYL3yq10orwLsDDhkJWo/n4Qy0IUM12lqiaEbq8CwW5O98MWbOd5izE4uWQzAkL8g/pdSFPAX/ld0icLHHKfucFvmCE9n1dxRP0TD7q5Fa1tZidzBsFNdW41lM1tLgdQ4JbXeKSofHPsw1oJ2/4GKJdFX8XxKNFIn8vnqCwvGyTjvaxVdjQLAsLq6TFT9F0lCD/dTJXZ2BtPrGuu0W233tfXCMgEpHm8t6v1YEOVGzcPWLpenzKRbGQqdh0+iYuaU8HRzrsvDybyasJdOf39yLihyhcOMkFCQNgXAkyKUtVVNu0VLuHVHq3KskUJyp4ALOezKWrcrJKY2HKrZXmXmDkVYaodHa+of6r3WyFuTuRg9Hw8jPruYHuOyto8t14YEdoPuabv6mdTtR08UGWv6FpcFqhR7iFbQWzlXWPA9q5Hj71t+lF1rlqzofhrxOv17NXwWqMTl6xhNjIY7wJSekcu5SjYU+k52gSaHeNoJ7PVD1csg19yxyAMdTDwRyckDqjDuQmw0RQeySOXmh8HVCQ6mOpweEOTYqDYUbNzAcMhv5Cv3s//16m8WYqoSbref+LAeP9+nE09 UQV6t9kv Ou+1JCj0klhtwseKDpdv5pq8aGVaHlFOPQMExbw8r93c/9DuRxYQUWasMxAacV2ARxW2XfMGDXwwX1QWtwYJWFvX6OuTVBXykPlP9ZH2fTRUxraOlOou4O/L+gem42ROcuG3XI3jq/4kbYUb4C6WCP61PltzWfNuYuEdlOsfhgCwjfiMn37ubluFSAFL5L2szumea7lJdFWy0bO7J9dg3HZqU61NljhF6kj1OPyvBS61xt7v/jfmS5pgY/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000777, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 1:02=E2=80=AFPM Christoph Hellwig wrot= e: > > On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote: > > I don't think it needs a comment at all, but the memory allocation > > might be for something other than folios, so your suggested comment > > is misleading. > > Then s/folio/memory/ The context of the comment is error handling. ENOMEM can come from either folio allocation / addition (there's an allocation for xarray node). So is it really wrong to say folios given the context of the comment? It's not supposed to be a generic comment, but rather one that applies to its context. Maybe this change: - * When NOWAIT I/O fails to allocate folios this c= ould + * When NOWAIT I/O fails to allocate memory for fo= lio Or perhaps just what hch suggested.