From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2F2C433FE for ; Tue, 11 Oct 2022 13:28:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F426B0071; Tue, 11 Oct 2022 09:28:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34EAC6B0073; Tue, 11 Oct 2022 09:28:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EFC46B0074; Tue, 11 Oct 2022 09:28:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 095CF6B0071 for ; Tue, 11 Oct 2022 09:28:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D189FA02FB for ; Tue, 11 Oct 2022 13:28:46 +0000 (UTC) X-FDA: 80008748652.15.36DBC05 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf22.hostedemail.com (Postfix) with ESMTP id 8827EC002E for ; Tue, 11 Oct 2022 13:28:45 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id a2so8584924vsc.13 for ; Tue, 11 Oct 2022 06:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=raH7WVDSsvCPKQIhYgmZFVAAGSUF5nc09Zedq+rsMAU=; b=RIe4dBR0aMf5OdrqYm/Utd+N0OJj8M7yVRnxQt0SWrAE+Icqli8dm198FiWu1zyE4K ThFkWDgg/9Td5d2IRDtyLEfSPwokGQrcFSl+ZlD2K4af69I3g3EB9B1emQIrMWvScJHw r+I3aZYKyOKoXo9+c2guSFePs38N6mNAHs3VoFJnnpA5I08Jok+DXwlLOgxNK3KgfAUZ XdH4LxlWpNY4uzGhO4Af+xDw0bOM1Vadya5Rtbe4apuRaNOzWyL2aYvjt49BUK4JI6Dw lHsf8fQMu1jQgOb7cxH8q3pAtHNmlqi/rQWzUKfzGN0Ycw4ppIGnoOMf/vkNLy9aLTOC /peA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=raH7WVDSsvCPKQIhYgmZFVAAGSUF5nc09Zedq+rsMAU=; b=0E9S/iUY3Lvf4FDW0VBxa7AKsfWJP6X594PIDRiAm/2vt6aRwGiTd8+YTjDzKowYQv 3fqlogrEwFZj0WSzPonmYXdYp0m5QoDrk/0MjDGb1MUu9YDWgm11ZDIKc4YO0zBkqvhG pymc1KLBFsXtGBswIMRvStifJ8EeSmDH94ILzx8lc92GhpSCVnCcHXQkcek60iHVu/qY Jk71rVrmAEipNRZnbaKb0UQtEyVoAzuHAXqwh1EOuzysgOMa1gEc0P4g2P50kPJIG6ke zAT4fzThSz0LccK/AvZfGAAwilbHwAqsJYrG7YtJketluhh5i+MX/IFRMfdoFgZeFV2V TlEg== X-Gm-Message-State: ACrzQf3FAKW/g3wtl1TSg0Z6w8dEnlbEF11rd2YydfuAyW+W2flvPCUV 4XIj+5kO+GbNipyI+WC95ya+q+kJinV7qVrs2qThbw== X-Google-Smtp-Source: AMsMyM4RCzDu9DE1SgMdp+TCHAnmXWjm2D/kY89a9RpcBY1OK3SAh2E+19si06YAqT4aoi2eeQCzNy8ngm5l9Ym0oU4= X-Received: by 2002:a05:6102:301a:b0:3a7:8755:2b7e with SMTP id s26-20020a056102301a00b003a787552b7emr4741009vsa.32.1665494924704; Tue, 11 Oct 2022 06:28:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:136f:0:b0:3d2:4916:f286 with HTTP; Tue, 11 Oct 2022 06:28:44 -0700 (PDT) In-Reply-To: <20221007155323.ue4cdthkilfy4lbd@box.shutemov.name> References: <20220704135833.1496303-1-martin.fernandez@eclypsium.com> <20220704135833.1496303-3-martin.fernandez@eclypsium.com> <20221007155323.ue4cdthkilfy4lbd@box.shutemov.name> From: Martin Fernandez Date: Tue, 11 Oct 2022 10:28:44 -0300 Message-ID: Subject: Re: [PATCH v9 2/9] mm/mmzone: Tag pg_data_t with crypto capabilities To: "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665494925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=raH7WVDSsvCPKQIhYgmZFVAAGSUF5nc09Zedq+rsMAU=; b=sxaP33+7Uf4Td2LgxTdsasPCy6Yn7LQH++KTecRco5SClV/UZprJVsEescVFr/12OPdBKY KYzDd3j2c/AUivTcUXN8ttrbnQiA6rbSM89cB2TLO2l7DfeyYOQP5jZuGTZIMgVY4C35Qj FEZiBWoRhXgkdusey8yP4xjkugQEKyk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=RIe4dBR0; dmarc=pass (policy=quarantine) header.from=eclypsium.com; spf=pass (imf22.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665494925; a=rsa-sha256; cv=none; b=x4cTME/RRFI6z5JBEFCAwpCmPfMCp9JlZhogHQh4IZEIePG8/wAPoCQF2Wt569iz+YUocv TJDmjw9KwIXJHWtMFMgz4v66jERF55mrX4/txMNytO70vu50AoW0P2s7rqxGzVklkiwXOS HLlxk9BI0tt7V0xW169CiYjDZErgJU8= Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=RIe4dBR0; dmarc=pass (policy=quarantine) header.from=eclypsium.com; spf=pass (imf22.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com X-Stat-Signature: okqa9mykjpwqe3ytjucdqywxebx3hgq5 X-Rspamd-Queue-Id: 8827EC002E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1665494925-857633 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/7/22, Kirill A. Shutemov wrote: > On Mon, Jul 04, 2022 at 10:58:26AM -0300, Martin Fernandez wrote: >> Add a new member in the pg_data_t struct to tell whether the node >> corresponding to that pg_data_t is able to do hardware memory >> encryption. >> >> This will be read from sysfs. >> >> Signed-off-by: Martin Fernandez >> --- >> include/linux/mmzone.h | 3 +++ >> mm/page_alloc.c | 1 + >> 2 files changed, 4 insertions(+) >> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index aab70355d64f..6fd4785f1d05 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -883,6 +883,9 @@ typedef struct pglist_data { >> struct task_struct *kcompactd; >> bool proactive_compact_trigger; >> #endif >> + >> + bool crypto_capable; >> + > > There's already pgdat->flags. Any reason we cannot encode it there? Not really a reason, I'll considerate when I send then next version. I tried to quickly find for references of what kind of flags does it have, I didn't find any. Do you suggest it should work? >> /* >> * This is a per-node reserve of pages that are not available >> * to userspace allocations. >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index e008a3df0485..147437329ac7 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -7729,6 +7729,7 @@ static void __init free_area_init_node(int nid) >> pgdat->node_id = nid; >> pgdat->node_start_pfn = start_pfn; >> pgdat->per_cpu_nodestats = NULL; >> + pgdat->crypto_capable = memblock_node_is_crypto_capable(nid); >> >> if (start_pfn != end_pfn) { >> pr_info("Initmem setup node %d [mem %#018Lx-%#018Lx]\n", nid, >> -- >> 2.30.2 >> > > -- > Kiryl Shutsemau / Kirill A. Shutemov >