From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C44C433F5 for ; Tue, 8 Feb 2022 14:39:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFEB06B0071; Tue, 8 Feb 2022 09:39:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C877D6B0073; Tue, 8 Feb 2022 09:39:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3856B0074; Tue, 8 Feb 2022 09:39:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 952516B0071 for ; Tue, 8 Feb 2022 09:39:52 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4460A8249980 for ; Tue, 8 Feb 2022 14:39:52 +0000 (UTC) X-FDA: 79119871824.17.1947064 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf15.hostedemail.com (Postfix) with ESMTP id B32B6A000A for ; Tue, 8 Feb 2022 14:39:51 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id j2so50643522ybu.0 for ; Tue, 08 Feb 2022 06:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y10yijKVCYf8QEAAaedBpWn2jA9AeIsehHwTb+17Y0k=; b=EkwsBw2shjc0kor8kv6zvognuh72Q+rCGOQ35cWZNXvnfHoVuJK9Ky92xWXKHNXZJ+ uRntSQCS0CApb8ncu2TtNVZVUxNVCPOT2jY/IQJEuV0X+se8H0vfaC111dv3xzndndPo o4fGTXkxhiDWHKrpePleHQmvK+JCvSH9t2Xl16P4zMklrjP0k5zgmhbNlFD5IgLxooAT hCe4kcsJcdn/Up1JkyIxglzTNai42QRYxcaYYRO3KwqUUpyFXvWrtRPRJtRBzG55bEkt m97bHgp0kpXIDN1XnlFyGzRkGNdW/yNt3GM2cpAWxy/eo9VAOZcXOxnNG6YfVVVNitHU U6GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y10yijKVCYf8QEAAaedBpWn2jA9AeIsehHwTb+17Y0k=; b=NYGIe5HM9SwapF+QgOOnzabgF6E5yHJJDHrmSVq21B2IbEz5YDP1cl5hFSKyt2WGWw SZdhFMF2TJC50ItQCRN57fht6z+zbu9j2DN1TozstsZi88ezN7cayireE8KfZuFaivCQ 9tb48q+a9jiKNv0JSywcNoJAEbalJe2KYDv5crDYAk4/8EXnHNsaxq1wgsPpPaxkJZlJ B8kt8zj/nzTV9b30v1wk1s1q+kWG4mzmd9/6Mf43SOTpranvPf4URObG17+wQhDn/PQ5 QGXLfvFBuGNV97dQhkfP2NoVWZSvorFJsAvERP/BHA7a2xMRopzPOdaTG0ixcfswHiCM 87cg== X-Gm-Message-State: AOAM530Tr57/KhryQFFLZTiXr8iGUjZwTXXbAInnHavnR1i0L5NLFFB/ JZrEEPfOdRsNbbL9TKJfoS8ysOS53Q941muNbq24sQ== X-Google-Smtp-Source: ABdhPJz5AFxmIsOU2xTwKLGiiL2caloO6fvTxq5q71UI2JljgKT0YDbdSxVzkocMB8lAxijQAwAYICfaue8xYFuRwKE= X-Received: by 2002:a81:8b48:: with SMTP id e8mr5046849ywk.9.1644331190998; Tue, 08 Feb 2022 06:39:50 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a81:174d:0:0:0:0:0 with HTTP; Tue, 8 Feb 2022 06:39:50 -0800 (PST) In-Reply-To: <202202061945.DACC7BD04@keescook> References: <20220203164328.203629-1-martin.fernandez@eclypsium.com> <20220203164328.203629-2-martin.fernandez@eclypsium.com> <202202061945.DACC7BD04@keescook> From: Martin Fernandez Date: Tue, 8 Feb 2022 11:39:50 -0300 Message-ID: Subject: Re: [PATCH v6 1/6] mm/memblock: Tag memblocks with crypto capabilities To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B32B6A000A X-Stat-Signature: uie5wueofnsuffmkizc94wi7jndsur5r X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=EkwsBw2s; spf=pass (imf15.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com; dmarc=pass (policy=quarantine) header.from=eclypsium.com X-Rspamd-Server: rspam05 X-HE-Tag: 1644331191-406004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/7/22, Kees Cook wrote: > On Thu, Feb 03, 2022 at 01:43:23PM -0300, Martin Fernandez wrote: >> +/** >> + * memblock_node_is_crypto_capable - get if whole node is capable >> + * of encryption >> + * @nid: number of node >> + * >> + * Iterate over all memory memblock_type and find if all regions under >> + * node @nid are capable of hardware encryption. >> + * >> + * Return: >> + * true if every region in memory memblock_type is capable of >> + * encryption, false otherwise. >> + */ >> +bool __init_memblock memblock_node_is_crypto_capable(int nid) >> +{ >> + struct memblock_region *region; >> + bool crypto_capable = false; >> + bool not_crypto_capable = false; >> + >> + for_each_mem_region(region) { >> + if (memblock_get_region_node(region) == nid) { >> + crypto_capable = >> + crypto_capable || >> + (region->flags & MEMBLOCK_CRYPTO_CAPABLE); > > This was already mentioned, but I just thought I'd add: this made me > double-take, given the "||" (instead of "|") in an assignment. It looked > like a typo, but yes it's correct. I was expecting something like: > > crypto_capable |= > !!(region->flags & MEMBLOCK_CRYPTO_CAPABLE); > >> + not_crypto_capable = >> + not_crypto_capable || >> + !(region->flags & MEMBLOCK_CRYPTO_CAPABLE); > > not_crypto_capable |= > !(region->flags & MEMBLOCK_CRYPTO_CAPABLE); > Yes, this also works. Thanks.