From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ACCAC433F5 for ; Mon, 17 Jan 2022 12:42:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A85496B0071; Mon, 17 Jan 2022 07:42:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A35B56B0073; Mon, 17 Jan 2022 07:42:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD636B0074; Mon, 17 Jan 2022 07:42:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 822BC6B0071 for ; Mon, 17 Jan 2022 07:42:02 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D7A5E824C429 for ; Mon, 17 Jan 2022 12:42:01 +0000 (UTC) X-FDA: 79039741242.25.610AAA5 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 833EA180012 for ; Mon, 17 Jan 2022 12:42:01 +0000 (UTC) Received: by mail-yb1-f173.google.com with SMTP id z22so44912286ybi.11 for ; Mon, 17 Jan 2022 04:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eclypsium.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vAmFUqrC0PksSSA2pMtmtsSscMtr7L+ruC6Pf2vhQnE=; b=e2bMOzD6lFvxfjU1JWi/EP+qcCLvVyTMOV06myYdjWq34wqNWJzOikTOYQ47Fiuw/X pSkOTE+pLL7w8DbMB9AEWd4xKCTPZfAP5WR6vW1ebgqvqXcx+bTDNMEHFSllfIeb8VFz 9h4iD8hED19+5Kp2Qw8HPKyDauoLc1HyQxURhgIgLLiMueg85slmtbft0dfJVAamzSUo V+aeGqgnX8FU4h6LWcS9AeA5pxShh3CkY80HKJ4X+AgpAmB9tLNzVQZ/9tmLq4tbk/xS MQnLnHfy7eD4X8ws9cLWfX3s4s7H4keEnjxEESQuLldmZtHkmSLWptYn+j2p86vKI8p3 jaPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vAmFUqrC0PksSSA2pMtmtsSscMtr7L+ruC6Pf2vhQnE=; b=oVQc1SDsE4lhe24ZLmBWJa23FBxVpdVXsDOmdS2Uo/rN/WPf20AI+Z5R1oADhJEGGy gk5okwdyqj19tILvudKqeLUBTH6CslT1MVs6jOY1eZyIQzUv0ZRxY73CQxB2bFUV9wGL 5NP1GlL8haDfwz+NJp2gUnsE9P+IP6BEIWFwudC8r1W1wg1KT81vR5SK3WhdG6GlHnna LBgl3rj+uP0bCVEYDBGmZEATLGu7DFVOthVRWOEB7fRbrDJcW72quSHm/THnnWUobtQ6 3YYk1DUp5Z66Wy/ESIJCbEulhT6MLa5W29NwupA8R5mcHMKGuPJwkvuh0c3P0Y/wFdTn Hy+g== X-Gm-Message-State: AOAM530l3YCmYksBWZfg7wS2ytsqJQP+IXpt6lHsUwB483uQ0gy6LbEM IC0WmDBNkKqm59Yv9CdDEeuPEdWnWdyxHaKXBvg43Q== X-Google-Smtp-Source: ABdhPJwFcWegAP/aLBiQS2RDOI0Vfg/3kYpQ7IAjve/Fx5jG6zBvjvW74xJsvC4FSVsUwOS9wCM3NvGN1aPUjQAvZa8= X-Received: by 2002:a05:6902:1141:: with SMTP id p1mr3065197ybu.393.1642423320797; Mon, 17 Jan 2022 04:42:00 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a81:3cd:0:0:0:0:0 with HTTP; Mon, 17 Jan 2022 04:42:00 -0800 (PST) In-Reply-To: References: <20220113213027.457282-1-martin.fernandez@eclypsium.com> <20220113213027.457282-4-martin.fernandez@eclypsium.com> From: Martin Fernandez Date: Mon, 17 Jan 2022 09:42:00 -0300 Message-ID: Subject: Re: [PATCH v5 3/5] x86/e820: Tag e820_entry with crypto capabilities To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 833EA180012 X-Stat-Signature: 8noan6cc7u7bjemns5r3ky94jkn889ms Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=eclypsium.com header.s=google header.b=e2bMOzD6; dmarc=pass (policy=quarantine) header.from=eclypsium.com; spf=pass (imf06.hostedemail.com: domain of martin.fernandez@eclypsium.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=martin.fernandez@eclypsium.com X-HE-Tag: 1642423321-987875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/14/22, Dave Hansen wrote: > On 1/13/22 1:30 PM, Martin Fernandez wrote: >> +/* >> + * Update crypto capabilities in a range >> + */ >> +static u64 __init __e820__range_update_crypto(struct e820_table *table, >> + u64 start, u64 size, >> + enum e820_crypto_capabilities crypto_capable) > > This looks like an almost pure copy-and-paste of a 70-line function. > That's not the end of the world, but it does seem like a place where > refactoring is in order. > > The rest of this series looks pretty straightforward, but this part in > particular is the most worrying. > Yep, I'm not super happy with this either. I'll check it out to see what we can do. Btw e820__range_remove is quite similiar too.