From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04A7C433ED for ; Fri, 2 Apr 2021 18:17:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6369A61163 for ; Fri, 2 Apr 2021 18:17:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6369A61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C37A66B0078; Fri, 2 Apr 2021 14:17:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE8A76B007D; Fri, 2 Apr 2021 14:17:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A62616B007E; Fri, 2 Apr 2021 14:17:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 8B3F86B0078 for ; Fri, 2 Apr 2021 14:17:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4222B10FBF for ; Fri, 2 Apr 2021 18:17:48 +0000 (UTC) X-FDA: 77988235416.25.0D3CD82 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 3C8A12000255 for ; Fri, 2 Apr 2021 18:17:47 +0000 (UTC) Received: by mail-io1-f52.google.com with SMTP id x17so6135440iog.2 for ; Fri, 02 Apr 2021 11:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ccSWi23ioLarklHBwKpDmvtB7DFqOqi/sX0Oeizonp0=; b=XmdhjhrukGOaqMeDQ7vefBMkZG0SpnAqECA1nEiU4stSwWdD3bGqPgGonZZP9di1bC DXLSoc6O9uU06VC7LO4KcT/KynhsbnH7qwdyL7tGieL3GJArfG0jpRoblw1iXm+3r9NP KI5suCFU6ihF23FYR2HhpUQSIdaaeRdLy+oI+AgA3UqPDQHOTmq2/9y23T2jW5fsmZld JTYph/lNqyUAClmaTC5EQeExcOq79G+5Anasr+7lmNNM+Xl+hwWqQYSjs1oL1FTBtwf4 sR8nEY0XW/mMC/xIBZ18rZd+3fOAyIXhRY5cvRghZsHE278TGRffpZVRq0gHVwtNWvLU UaXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ccSWi23ioLarklHBwKpDmvtB7DFqOqi/sX0Oeizonp0=; b=jmvIG3kCMYzApzt6+1m1lHfrSupYqP/IrUUcIxj2LttvdJQAkadsE0msX4EDnMZETF uXJbOnDww3QS1pe3TRZnf1qKR9BbfUaQvDCUanbs19r0pshFlM6rh+vjE6o8N0elCABx Bl4+qtN1ATQpD4EWhQPzdXvZ3qlpk9SS8fUXkGESV4aVQ9rMeY6fH4ws4lTGdim2bpBb 9Isrpw4EPKXuI5Cl0TIV8tNlZGy42XLC6+54hCq3uHQ9uB4GtxzddZ7fmGkV0eiEETzt zd0G3z8H2820YR8iu9dEJClqcHHkzmoi0TjNZhSBYWuliobOMJ3jKGKywG5w//dqhj+c uhdQ== X-Gm-Message-State: AOAM532LtKL9JUa/GfiYfEZjTR34BW6akDoXIVfTY4IuSrkmqbrD245X yzDNw8y4Xm4r9H1YHutg1PLMxWiR1Go7DZPx5BQ= X-Google-Smtp-Source: ABdhPJxAH8vNy4Vood2FbsrbqH29MujqOf22SqtN2QCg+MTbrklHoTMZTnm1Z5oCkNE0tAeNEhc3Xv5GEHwZSe1WM7c= X-Received: by 2002:a05:6638:2591:: with SMTP id s17mr13637097jat.87.1617387467177; Fri, 02 Apr 2021 11:17:47 -0700 (PDT) MIME-Version: 1.0 References: <1616751898-58393-1-git-send-email-xlpang@linux.alibaba.com> In-Reply-To: From: Alexander Duyck Date: Fri, 2 Apr 2021 11:17:36 -0700 Message-ID: Subject: Re: [PATCH 0/4] mm/page_reporting: Some knobs and fixes To: xlpang@linux.alibaba.com Cc: Andrew Morton , Mel Gorman , David Hildenbrand , Alexander Duyck , LKML , linux-mm Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3C8A12000255 X-Stat-Signature: fexwwgajgpwenhc86ei8rsumq786pkzc X-Rspamd-Server: rspam02 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-io1-f52.google.com; client-ip=209.85.166.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617387467-597084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 1, 2021 at 9:09 PM Xunlei Pang wrote: > > On 3/26/21 5:44 PM, Xunlei Pang wrote: > > Add the following knobs in PATCH 1~3: > > /sys/kernel/mm/page_reporting/reported_kbytes > > /sys/kernel/mm/page_reporting/refault_kbytes > > /sys/kernel/mm/page_reporting/reporting_factor > > > > Fix unexpected user OOM in PATCH 4. > > > > Xunlei Pang (4): > > mm/page_reporting: Introduce free page reported counters > > mm/page_reporting: Introduce free page reporting factor > > mm/page_reporting: Introduce "page_reporting_factor=" boot parameter > > mm/page_reporting: Fix possible user allocation failure > > > > Documentation/admin-guide/kernel-parameters.txt | 3 + > > include/linux/mmzone.h | 3 + > > mm/page_alloc.c | 6 +- > > mm/page_reporting.c | 268 ++++++++++++++++++++++-- > > 4 files changed, 260 insertions(+), 20 deletions(-) > > > > Hi guys, > > Looks "Alexander Duyck " was not > available, so Cced more, any comment? > > Thanks! Yes, my Intel account has been offline since October. If you need to reach me, my gmail is the best way to go. As far as the patch series itself I am not exactly thrilled with it. There seems to be a number of spots where things are being changed such that the CPU overhead will be much more significant. The cover page should actually say what the patch set is attempting to accomplish. In the patch descriptions you have told us what you are doing, but the why isn't completely clear. For example I am not sure if the issue addressed in patch 4 was present before patches 1-3 were introduced.