From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40796CD4853 for ; Wed, 4 Sep 2024 15:13:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A239F6B00AD; Wed, 4 Sep 2024 11:12:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D3B46B00C7; Wed, 4 Sep 2024 11:12:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8760A6B00D8; Wed, 4 Sep 2024 11:12:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 68ADC6B00AD for ; Wed, 4 Sep 2024 11:12:59 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1BEBEC12A3 for ; Wed, 4 Sep 2024 15:12:59 +0000 (UTC) X-FDA: 82527398478.01.8ACA8DD Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 0F676140021 for ; Wed, 4 Sep 2024 15:12:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="dij8id/j"; spf=pass (imf26.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725462680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=txNXksKNnr5CcQmhvZpAfXPbym/UdfLQWjik9aFGQpg=; b=X0qCsq4WaEK9Ui3bZD5hCdPLeRsHxDyCw6mqz+98wfuwgTvQxbKWRxjLL9fR7lfZP6+N5Z 0l4f6him12v9xM0P/0IrUF22OhdKKfRjMYYwtiZu/kBMci8zNB6DdkyqxIPFMZhCS8ozY0 lha6qICC8lJ3vDF5U0GI1dRCOZf35yg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725462680; a=rsa-sha256; cv=none; b=1/jBV/wx4flyvlrSFTBNfWC9K3zbxINqIRlPPu0fbqtKp1OLawrFYPAfLeSFHPjlYdbRro sR+OG40a3vLKC6EfIORaS5rsgQ4iQYm4eIGX35E40tUJDk+noUahyFBCdYZ+4znFbRRnS2 4LbuN7GmefKU9c17QSa6FaxmJY+dcm8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="dij8id/j"; spf=pass (imf26.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42bbbff40bbso46819955e9.2 for ; Wed, 04 Sep 2024 08:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725462775; x=1726067575; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=txNXksKNnr5CcQmhvZpAfXPbym/UdfLQWjik9aFGQpg=; b=dij8id/jHPCBbsgd12tHrLCxRKxBrX6YgGfJ5QFEm5iluaxKQZc4ODSy8SGq7+7mSU +ipi/8K3x/vKlzwguTlCpMCwXO+1jISHQDTFuLFix/pI/oXp5PwA7lTD+2Zey6N9HFw4 m6ztkovesu+W+7UimckVuGgO8YbR+Yml5IS4B3TAddn1bWAexrsu+du/wxcN7/DnM6J9 giyHPOu/e0hS/QwoiVqqlt1/Qi/SvspW/hu6owF7a1z7FzSx/ZA4wbqEjPOWWXCTXKbd KVjExMvAHHHqccDwgx2D0R8AjrdUiSS6KbGrNb5Bibu+Buden3XD90tdGRWPkq5t4XVW P1NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725462775; x=1726067575; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=txNXksKNnr5CcQmhvZpAfXPbym/UdfLQWjik9aFGQpg=; b=jg7Shzx5TxqsU5nmkQUF2I7uJs3W+S2bGHprJ04aly1+8TESERWhSljoQpHaHgOn3h QtXRZLQp/AizbcfS63L0PIbjdZs7puJiEMAomEKkzZI87rQZzZuhn25ABJOZTa2DPLip mWO6UefxlewROfpxpNXovxY1pX0MufdpGrhgMZ9urU8jiJx/JInuqWnBkGLAsaJIDvxg fY2fcUTsWJr3zgZD4Em6u/ZL2hGTbeKM2b0HmMIoOqZKox2nAOWyuty6pMLv5aWF6rts 0AQ+hyxyk18/DWPgI4hzVtxuWWsLgggbYFMF/a8jprJTCA6fcGzefN6gq4EkHLQgI2fM gfwA== X-Forwarded-Encrypted: i=1; AJvYcCUm0jNHTFqcO36Q1wqA3r9usY3my1vdsNUjcoX17MKIgKQXciLbi8dcaS/aa2UaHXTtC1YlD4/7cA==@kvack.org X-Gm-Message-State: AOJu0YzEKxOPED0pk+MmpbvGAKUxvqAADnSPNsuOfsVkbEgjDvumQFvz slWWBCJSkthsXAqJfAmOyB/bBhAN1TNhBYsM+obMxM+DSOE/YEb38opVSXumbVXtXVOGF4Nsjkv ZlD5bu5Jqo7qP38fDLfKdCijCQxE= X-Google-Smtp-Source: AGHT+IFgy1TZEAQFZHztxlV15qG5NfTjA0UR0zIDatCD8i3rg2377HVbpyopn1HUD2u1Kv2zYWf5Z5LZrhRvSK8H1GU= X-Received: by 2002:a5d:5ccc:0:b0:374:cd3e:7d98 with SMTP id ffacd0b85a97d-374cd3e8008mr5730376f8f.19.1725462775162; Wed, 04 Sep 2024 08:12:55 -0700 (PDT) MIME-Version: 1.0 References: <20240902120314.508180-1-linyunsheng@huawei.com> <20240902120314.508180-2-linyunsheng@huawei.com> In-Reply-To: <20240902120314.508180-2-linyunsheng@huawei.com> From: Alexander Duyck Date: Wed, 4 Sep 2024 08:12:17 -0700 Message-ID: Subject: Re: [PATCH net-next v17 01/14] mm: page_frag: add a test module for page_frag To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: nt3sip34kbud6usp3u8dfet96c5tf5pj X-Rspamd-Queue-Id: 0F676140021 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725462776-973362 X-HE-Meta: U2FsdGVkX196qvT9s5fjSASD3V4+03U+x4L3DhgOPyT3Bd64F4DqFjcteinOTaw4hhSKCz9a2XLtsU5VUhe4TiMI48KMtcawmTlPwigT6+KvZcEeQFAXa0Wf+jkUU3pww6OinAf6SQoFaY/vvm4mWuF5asxYavfVfuj64ClKtZ4x7SgZFQ51FfiNsGLpLFMtI2Hkbb4/0Gu02eCiBwL2C1vHeNk587nzId1U1CJakB20VrAKIwGNFGBC5ZeAXM4G7eheMDDN+T9BGx6pQUIUtF63jRGHab9QIr6u8vkYeHYYf4NmszdiuPzPmXQRs6xJ3yA8kTirwj9AGSnkfgAptmTi+52rGtrGSCMaOxCzKWh1GAPTnARwxobaJVxLuA9Cni6AFGSKDM9TIV2u9oQjRLoRK3+a46mMCgo3IofbYn4PIJBRGqAPBQeKVQ/9wW1JFg8twASDv45taqpuHuUrocC5n3UMoctMxAplQb+DNTnDTDaYUjdosSGrU59UFB7Q/a4cqaA/ILUgh7FBpx1N7qpytIBuqZlGlALs/ieLWw0A8ur3NPbCDtFb0HdZdTJI07As/dMUu2JtNmoAflYOMuPPiSReLBSVImUJttIYg8FfeOttZy4IxsYlrpX4UAWwHp8e3PPGvC1CrS+mEYOW6geKlSwVkVIbsMT+qBV3mwvxVwnQQlEw/7YYkbF6sY+dGNsyDPsC3mQrfx5SzBsOfTA5pdTkwSEujuQYJyunmd9TYSYKn7NrnLY+I59nO0xflwYSHDMph6OQ9bem+q++nXsjlRw/fsBL3SnxfHdz/gr0YLQQFLJiIXz2gTtHq9EdJ9rt00TAiAPrAwMYXlM66mzi41yZWiSopg1MLdm0S2OFVLGqSSirBSCMGzLhQSP/H4kPNdRzVyNfVN3DFVxY9whRBP9OBjJBiHM2b8i4ZY6Z/TmBNJKdFLVwXx3dBcBNuAe+uucQrOSFloTJuOu 8iMnPFnK JRnV1juUankiRToLzUcRxFqAGUPj0K7TLKl+XZUi9ifVwdwhkqbeV7wnAAs7/L2+KqmrNI2GvtyX0++ShsUwUzDsXxM/bXxdOvui4XJoCeagl81K1EkD7fm7kRR2FNR4y7pxIGGHz/HUoR2l8NdUyQmvznK5pJLBRpD9S103zU9bRxco1tPdQXIdQv2jpUvk4nl9gHK6JICGa2KTgy1Xyc6GQZkpq67ilPa7tLbi9CbLVLZ8GMzmEa9BeL6gN1pUNQaFSLX94ihQ3K+wijdnAkKJrz/Pt83iIC6aOdx4Wbinm5t6GlzfURQrM47xaILn2m0gLjafydjzxl84D8+KmA8rIolZicLBHYqNEUFMGGDg4YHdnBwajpFimimlrjS3/WSXMqVCouAKCmmZ09QXNQ7bYG1hk7QLyapcjg8V3tmrQaBFgx75jAxel31WGVnCR4LGrsl3V8Z+ZMu4hwB+dENTGvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 5:09=E2=80=AFAM Yunsheng Lin wrote: > > The testing is done by ensuring that the fragment allocated > from a frag_frag_cache instance is pushed into a ptr_ring > instance in a kthread binded to a specified cpu, and a kthread > binded to a specified cpu will pop the fragment from the > ptr_ring and free the fragment. > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > tools/testing/selftests/mm/Makefile | 3 + > tools/testing/selftests/mm/page_frag/Makefile | 18 ++ > .../selftests/mm/page_frag/page_frag_test.c | 170 +++++++++++++++++ > tools/testing/selftests/mm/run_vmtests.sh | 8 + > tools/testing/selftests/mm/test_page_frag.sh | 171 ++++++++++++++++++ > 5 files changed, 370 insertions(+) > create mode 100644 tools/testing/selftests/mm/page_frag/Makefile > create mode 100644 tools/testing/selftests/mm/page_frag/page_frag_test.c > create mode 100755 tools/testing/selftests/mm/test_page_frag.sh > ... > diff --git a/tools/testing/selftests/mm/test_page_frag.sh b/tools/testing= /selftests/mm/test_page_frag.sh > new file mode 100755 > index 000000000000..d2b0734a90b5 > --- /dev/null > +++ b/tools/testing/selftests/mm/test_page_frag.sh > @@ -0,0 +1,171 @@ ... > +check_test_requirements() > +{ > + uid=3D$(id -u) > + if [ $uid -ne 0 ]; then > + echo "$0: Must be run as root" > + exit $ksft_skip > + fi > + > + if ! which insmod > /dev/null 2>&1; then > + echo "$0: You need insmod installed" > + exit $ksft_skip > + fi > + > + if [ ! -f $DRIVER ]; then > + echo "$0: You need to compile page_frag_test module" > + exit $ksft_skip > + fi > +} > + > +run_nonaligned_check() > +{ > + echo "Run performance tests to evaluate how fast nonaligned alloc= API is." > + > + insmod $DRIVER $NONALIGNED_PARAM > /dev/null 2>&1 > + echo "Done." > + echo "Ccheck the kernel ring buffer to see the summary." Typo, should be "Check". > +} > + > +run_aligned_check() > +{ > + echo "Run performance tests to evaluate how fast aligned alloc AP= I is." > + > + insmod $DRIVER $ALIGNED_PARAM > /dev/null 2>&1 > + echo "Done." > + echo "Check the kernel ring buffer to see the summary." > +} > + Other than the one typo it looks fine to me. Reviewed-by: Alexander Duyck