From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0493DCD4853 for ; Wed, 4 Sep 2024 15:47:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845336B00F7; Wed, 4 Sep 2024 11:47:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F5906B012B; Wed, 4 Sep 2024 11:47:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F8CA6B012C; Wed, 4 Sep 2024 11:47:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 410F56B00F7 for ; Wed, 4 Sep 2024 11:47:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E410A417AB for ; Wed, 4 Sep 2024 15:47:45 +0000 (UTC) X-FDA: 82527486090.25.94667B9 Received: from relay.hostedemail.com (unirelay03 [10.200.18.66]) by imf14.hostedemail.com (Postfix) with ESMTP id 8CF44100022 for ; Wed, 4 Sep 2024 15:47:43 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725464756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UI3ncFFHcdlnELuJGp3NCftA6/xROBK9Lrqnz+qYtJw=; b=BXnAz4AIIKe9OBXfx1MCgKQTU1zq4cNYYutAxMhQ8+InEssv68KQys2s4mri02yKI5ZKHK ACMIRLJkkO7jLxFMR646X+yQjqBTAzfUUXqXnIkgjxzlinRqHkQbg/Xh1oZWNRxvYV45F/ przCGE+6/3neO5flZ+FT7V5kzazpHuI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725464756; a=rsa-sha256; cv=pass; b=AHQUi6I+0AsNLhM6tn/iVU+UG7IBxzKF1L/LlRKGMT8JhIWnNQLUlxL5JzJFBNiwHfQb8/ pVLK/v5oQRO+QjI7MEEQx3o6qGgbO4wd7UZMewa3CAVX83//0q1UTSaaZGuED+pTkhQ6tN 0vAKwPK65S2njG2q2/AigXhSd2old+w= ARC-Authentication-Results: i=2; imf14.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 13C52A0800 for ; Wed, 4 Sep 2024 15:47:43 +0000 (UTC) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E85B81A16A2 for ; Wed, 4 Sep 2024 15:47:42 +0000 (UTC) X-FDA: 82527485964.13.02C2F6E Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 1C4F240021 for ; Wed, 4 Sep 2024 15:47:40 +0000 (UTC) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725464837; a=rsa-sha256; cv=none; b=EO2QXhvz4ERHWyNGHUz59kBXGeVDp4HA/oHfVifGfg9PjoDDx0baC1udfx0JzajoXjYN4u lTXyFftAdDSXWLJbgwb4YfZceePBCl25tLCko23bPK1ZjFCXXc5soW1MLedSVBZy1cdJLy W6qaLx72DUiQNr3o4rUVIh++47fJwpM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z3BaVbz5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725464837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UI3ncFFHcdlnELuJGp3NCftA6/xROBK9Lrqnz+qYtJw=; b=nTl7lLYhAMNee7ouEc2r6cCGxI3jTsHe/gdzej/DAQGebdJspjWvRowjGimdXv5q7I73GZ 2ygHf3U/H2nqCWfLqza84v/Tx8XLWFsqzWaWJQiqpxA7qzLJI6qWRQjnT1yMlJyo6WUVz6 TrCPezzmPD4zS5Moha309ejP1jPP/TI= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42c7856ed66so37728275e9.3 for ; Wed, 04 Sep 2024 08:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725464860; x=1726069660; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UI3ncFFHcdlnELuJGp3NCftA6/xROBK9Lrqnz+qYtJw=; b=Z3BaVbz5lPf0ckC0hwipEkrDszdSRG99REuXbfbvCyV8dWhkkPXtvAULiiqGO54ePj ElFvIasRmyBUsKIVoVrre0bCvvzcyoYFIDsy8/HWTO+fn0AiYGEqGDSGTE44dgNXEQFV p1pnWx+UWZBbEvY70lCTAT5carCZNCNq+jZ5NYtUadZaYgXDJeBc3VGfnJYk76JQYVFg zyNZXlKqEKJrbUN8vuZkmoW3A5wgjd0asQR/3bIidZLF2+HfPjB3cGCWuWSs9j1DDj5+ nDHNRxU9SCXxXL4EvhAVtr0oWI7U+dQU4REryQmQg+NErsmvgYLkmbcEz5hyfteO3nLd 9z9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725464860; x=1726069660; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UI3ncFFHcdlnELuJGp3NCftA6/xROBK9Lrqnz+qYtJw=; b=B67ncbwJHGwM39xIpfQk+8poW2IMbfrNKG2ZLQeUKFpelAGauXZH23pILr1eFW8zoM G8FWRSsMgKGfcX7mNeyjXhHm8OYCKYEOyXCRby2cwp+v0+d7gjzOcJUU9203qO++/fer emc0qcLhBeOo6Ld/7gb/kS3a6EX8dblEw9TuuU8vCc67I0FWzQlF042S5TfEZ9W8ScIh D5ZY7A/aT/sQkmYr9wdmp7Tefan1ISXS8e0bk56CAdmKbFXHIGWwXgM7vOwPLVdW04Fp iph0/gZjTeGcedwlcrUfBbSCIZLJ+zEvVtfQTZ+KiAlgBF735lpF8e+cTN2Sfc6zGnYd 8qaQ== X-Forwarded-Encrypted: i=1; AJvYcCURznxBJ4UQCGyMyB0KdTuA8fzLg4g7dSPiNDOx2hEvcJiqbxeslr1vZ5zCeduNo9bdOs0btwA8Ow==@kvack.org X-Gm-Message-State: AOJu0YwSu0+N52HiSzw6yGF4iZS274eo2k1ATOMIyYWt9H4F4nzH2//H bWtaojlXRrYi2DC6HccrDHCdbQBlDMImKQ3tX+eO1zsNm9xm1nCnR2kN43O7imVhEJHtRsymL1+ 60fkcCA7yJFALGMAZYFb5bKOrnGQ= X-Google-Smtp-Source: AGHT+IGmP7hsWCrfK/n6gsjKnTU2NzzTQotXfiQVbbRNqQTQ2XYB5CMxF/h3wMW8waQyayCh7zivtQmWdmrOcZTGzSE= X-Received: by 2002:adf:b512:0:b0:368:4910:8f49 with SMTP id ffacd0b85a97d-3749b531311mr13794461f8f.12.1725464859273; Wed, 04 Sep 2024 08:47:39 -0700 (PDT) MIME-Version: 1.0 References: <20240902120314.508180-1-linyunsheng@huawei.com> <20240902120314.508180-4-linyunsheng@huawei.com> In-Reply-To: <20240902120314.508180-4-linyunsheng@huawei.com> From: Alexander Duyck Date: Wed, 4 Sep 2024 08:47:03 -0700 Message-ID: Subject: Re: [PATCH net-next v17 03/14] mm: page_frag: use initial zero offset for page_frag_alloc_align() To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-HE-Meta: U2FsdGVkX18fcglEy7CePftRJ/xvV0Xx7Xkw32Ff2/GxND19tyGfAT96chTK7eTFAv4mdMHG/3+cQYVDMprnGBsK6lPNcpl84JDEU1oQmxck76k8a06cZdI8N4e5Z3QTyDDZwFWjEYKC3pk2Gj32rsDIKaHznYk7gF1vFj9Q42AbzBuXWSsB7cGZQwxubN+KJNSaR+qlXj6o1xlMbhKA3DFFz0xV92Z5W8oDhzI+jSXp5j4h5D6cWNNVlj7IcxzbNwEa3uHnJcGMFNnOJnBjUq3Zg7H6tbyYZtkgDVXOqexpHLInpHwlCieqg+gU3LCqzXoiMacYzgAQ482VXNWmrWeqslBizATVife5LsQq+OAdtRiWxN6dJgyJ5SpuUzLGB5O8xuiZt0lRElpSAdNj9zz7A0ErYfciRny9kL6KQjHu9k6owKFMMZCB6d/PJcHLfqBJoR4Jp0dU+wM0zS8iFeaP/MstMYXKOQrRo5z/vtBZMusysMYVqxsY2j0ZSxHfj3odgmiGmW0WEDMuan/opvjIG5sQKoLuWpWknt/trtbtJCGUvbRYlK0gh3jF1EecZ3phdjlD9dnLFE/KkhOM6JHFxOfuuoiBJ9DMEmqVPJzSKTsvCidYhGvshekAkFc14+BhlN+z22Ff5yt9VWANXf75wEyRgTuU1YvIazhkk6KdWgEmegCfAWJv/75FgHMtXnrsdROkPPlWTcdjCTKydVsKswLk+AU15a1LZsxWAG7sEBtgzHfVkyImGvdNkW1d4/69ZTIi0A2JNvz6PYS2oXZg8FV0AUyl8/txWa/+VsthPEMMusnEoOdEeuC1KJS7hWLxwrane0kRTz0VwF1TQAnLK+/1mPhYtK0xKcNxIyfMjdJV7hQYBDOY/sbK21z2o5IxbEar7cWMNEzCvBHcwZa17EF81fUYZ9/To2zo7Gk5FRqFOin6/TgkXrO6rd6G9c1gfgsA5y+vgM+UqVZ rMEH1kiC P67jhxjQCDnLJhZKX2dm64x6hW8Z/z84io06uctMUd6gJhlO4QUHdZz0CJs6gGpjjoXXcz0OyGEA7UPb81FhlaFfWuOJFm0Jk7nYq4iO9+XVtTNKhPy2E7pQvB/kwGBih9G5syPElRU53YfHF5Zuh21GQQjU133uRDKjsBl0xqIg/hzKHjr2FBVsy7z3/uCnUwAUWSBHmk0HPkETEaUvCR6JDduj2DPdlp6C2aFBxRu9i71AgDUetxjWl11UHJTruxLUEANxfL4QQX7lJQunNbnpMDYYb2ic+Wa7wH+LUV0sMHp/2mkIUrTcl67XJ8QnRKpN3dDng3AiN56m7yrB9uqhAnxNzkM1w2YTndePJBlNEWIUm0PdXWBpKNsTpNuCalk8rv5eIASXuW/Yf/UQy6Z8fvH2L7Agff/Q1QX2mIxrCDqt8xk3Y/rwRg/kNYmxQLyxo82WH7SIt8uVKgfltpOjLeI1W1qloAcYjLEgQY6tkMTk= X-HE-Tag-Orig: 1725464860-547568 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8CF44100022 X-Stat-Signature: k9xjan1xqr9i89bhz7635g7zku7i9sfh X-Rspam-User: X-HE-Tag: 1725464863-152329 X-HE-Meta: U2FsdGVkX191T8CqkyAjCb9I5npAptipG6W9Us478Zco0x5philXBsnb61hEPAVpB/IBZia+JwKwlXfK9p2briZ1X6tPsqHBUdEopz70aPMGPp3C0+Qwg1s3h13bdySz1H2LMtFNSY9qKvZWDp5d86/X0pXXhrJOZV8ExuBHiyAe14xkwmCHlYaeyjNrx+QUCEv2TZ89uCVyyOTv6Tuy6ztywRrg/yGKdclQbh16qANTZe/gjMG1W3xPpshbr9pn2bsCwv4c0dTQEVq5u3XxbfaJn5bU2kdPVUvK0ZSgBQWIOyStzy7V0Td4L0i/zTVHODD7xJjMyOmsbMA8/vZdawnGZ1mi58HgsXG62IySyox75PqvAZPT0iDASptYBn9Ima7TV8KaDarrIz541INy8gIXcRJzCJ781tMseB2QwZGpNZCn192xJLk1xKJEsV1loKlx4HpRlEpui8eKX1JWGNtGEnxpGE/qDygwkvwMK2ronYz3nwNLF27jvXnWOYLy1DWfnRg0unbaIO80HqidsVIAa7spIXZDkr2J0VrjEdPSgh2rLlqSOH6kOxuLws+g4KN/NxaHYqvRDGU1pXuO1iQN9wtjK3f0vxfSBT/sNCWaQUYoAX99dYZA4tpaQSNGiwBTHlqr9gXblmuhHAWDfc/SIHmiVYE2nawXOVSsWf5Ghx+Q9HgA+xb7g39FUKFW28aF/FxKsDVGo8MNO2uC3R5bwdnfy/3mMS7gz8BR14+gEUuS0f88mUpquaP+IYNLAOO/3k/GWo1/JhD3HVz901nveLtucyUelpY68fxD3YjvVAaI3A3wPj36vgrSZfzaTTRoQkL7BZHAAWWCHdPECUDnXvHNDZr2P3hm+6X/kTjWcOCerXPfBqGLwPCHAiwslgeONhQvUt6LRqyC8/CEILfL2dJbprp7WVNecUjlv51iJ1EpFQs9gb3n5AGeSlfqLWu0QU5mnwI3CVOBRhf aiw8qP3f Tnxa7bGRzZO3F0ISObmjUsfZOKsDJfI9+Ps3SKFQ3JuwY3D7LkVYjQwkomKY56KAhHNej01buERtoMRdGx7bH+W2+20LRsM5qbC0Pee9vdY4mP3RA05r8Q55ls6XV66157dGXrHf08ee6WEkOeWJ8ybjBekgu5uQk5yp4/VoofPssZywkRDPrQ3qy3A07WIod7/IBxradmvloVsK+gEJQT7dBPaIZAdTGhiWl1JWspD+TM9SvCX+nKEeKe1/M/0c79XTuWEXxfcRprvMZWdQ5Z9ffIPBIH4DMLmezndvrJXPW2K95xoZ9p2mY46jrz3MICunBv5TpIRtn9tRFmIQ7/ImD07IoH1+ejzm8WQF1+aW5H2sUahBqVskT2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 5:09=E2=80=AFAM Yunsheng Lin wrote: > > We are about to use page_frag_alloc_*() API to not just > allocate memory for skb->data, but also use them to do > the memory allocation for skb frag too. Currently the > implementation of page_frag in mm subsystem is running > the offset as a countdown rather than count-up value, > there may have several advantages to that as mentioned > in [1], but it may have some disadvantages, for example, > it may disable skb frag coalescing and more correct cache > prefetching > > We have a trade-off to make in order to have a unified > implementation and API for page_frag, so use a initial zero > offset in this patch, and the following patch will try to > make some optimization to avoid the disadvantages as much > as possible. > > 1. https://lore.kernel.org/all/f4abe71b3439b39d17a6fb2d410180f367cadf5c.c= amel@gmail.com/ > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > mm/page_frag_cache.c | 46 ++++++++++++++++++++++---------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > Reviewed-by: Alexander Duyck