From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBB3C433DF for ; Tue, 18 Aug 2020 14:55:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62F2D207D3 for ; Tue, 18 Aug 2020 14:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vh12em2j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F2D207D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBA568D0010; Tue, 18 Aug 2020 10:55:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6AFD8D0003; Tue, 18 Aug 2020 10:55:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA8C78D0010; Tue, 18 Aug 2020 10:55:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id B5B798D0003 for ; Tue, 18 Aug 2020 10:55:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 77D1F181AEF09 for ; Tue, 18 Aug 2020 14:55:46 +0000 (UTC) X-FDA: 77163988692.20.balls07_090dd5927020 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id B8461180C0614 for ; Tue, 18 Aug 2020 14:55:40 +0000 (UTC) X-HE-Tag: balls07_090dd5927020 X-Filterd-Recvd-Size: 3969 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 14:55:39 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id p18so14024569ilm.7 for ; Tue, 18 Aug 2020 07:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hTTAJhh4NfjRHYn5UI6mlznlBlZYFizrT8lslR+Z18E=; b=vh12em2jvehxMcRPxHt0I2lWNAsDN3sZSBXx4kJbYF0NfJXsSIE1NVVqTy/+6tKJMF 7RB2EYuxpr1PxGbqVNEez8GM8mwOByVxPSd//nQ8WoZoNLKX0s5deJPv5469v9sIjtgq G0W0pU17InFXwODo47EKbwVzWeJy2mXrQ/8xTyTe+JvYDKk8PXR2c5IAQ+oylPbs7q/n aUrX1f/Djm6IdJRF89V2qMW0DmEw/cvdPN5ZMpGWLCunkU8Ioc7AEfKYsqPZaqI/AliI IltgHRorX6o2IcZX+N/J20iW5PEzuToOZ+bIIE//rL/pr+FsDUj65rt8QANZIIsJDrpM X69Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hTTAJhh4NfjRHYn5UI6mlznlBlZYFizrT8lslR+Z18E=; b=aYyJ3a0ju2OeDT/1Hu7gOgVu+RjuIf2pmbouYCJpVJ4ML2KeB7QzSWgXHibPYgQbLH PfYWwozfETH2+3DRC5YNt7nZfxlCfjMA1TetnVIIunMrQpSXLRJnFpL9j/0bFsv03iZ6 Vc0VupOt+7HbCbkO4zJc8BDRLPP5Gnhl8ruEXkg7eB8IE6uMzlh1KKCUxUqNZ4CPbAnW xiily9erhh7fZyNcU7eSHBq59g55rhH9RacKjCpboYfaFrz1/JhPTLGem/wCnW7gwZhn Z95T/IaYjop7W+eMwTTWopboQOu2yksoVBhP0l9YNbbimwoGvCd1iaTueSuNQEmdwr26 cNXw== X-Gm-Message-State: AOAM533uTrSeF5hd510iajY4IRREUnUkWKzpNGTyMeb8BEAFSyb3N5bg CuEegAE2fMe7FFF/ku557l9A1ouw+zS+myo3IXM= X-Google-Smtp-Source: ABdhPJyugOzq1mpedIjjSmTESPhs9cSE7mixc1n80W/RK28kNpOwE78cHLlZbvm3vZliI5m8Ws6AWgiGDZyM2eNZf40= X-Received: by 2002:a92:d646:: with SMTP id x6mr18734591ilp.237.1597762539068; Tue, 18 Aug 2020 07:55:39 -0700 (PDT) MIME-Version: 1.0 References: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com> In-Reply-To: <20200818084448.33969-1-richard.weiyang@linux.alibaba.com> From: Alexander Duyck Date: Tue, 18 Aug 2020 07:55:28 -0700 Message-ID: Subject: Re: [Patch v2] mm/page_reporting: drop stale list head check in page_reporting_cycle To: Wei Yang Cc: Alexander Duyck , Andrew Morton , linux-mm , LKML , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B8461180C0614 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 18, 2020 at 1:45 AM Wei Yang wrote: > > list_for_each_entry_safe() guarantees that we will never stumble over > the list head; "&page->lru != list" will always evaluate to true. Let's > simplify. > > Signed-off-by: Wei Yang > Reviewed-by: David Hildenbrand > --- > mm/page_reporting.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index 3bbd471cfc81..aaaa3605123d 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, > * the new head of the free list before we release the > * zone lock. > */ > - if (&page->lru != list && !list_is_first(&page->lru, list)) > + if (!list_is_first(&page->lru, list)) > list_rotate_to_front(&page->lru, list); > > /* release lock before waiting on report processing */ Reviewed-by: Alexander Duyck