From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AFDD339A9 for ; Mon, 28 Oct 2024 17:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE366B0089; Mon, 28 Oct 2024 13:49:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D763A6B0092; Mon, 28 Oct 2024 13:49:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF0946B0095; Mon, 28 Oct 2024 13:49:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9C16B6B0089 for ; Mon, 28 Oct 2024 13:49:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 147C2140C70 for ; Mon, 28 Oct 2024 17:49:54 +0000 (UTC) X-FDA: 82723748520.15.0764670 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf23.hostedemail.com (Postfix) with ESMTP id 38D67140012 for ; Mon, 28 Oct 2024 17:49:36 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ra7JMFL/"; spf=pass (imf23.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730137737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dS+CDaRqLDX9OzIJihQbnIilfInW0I2/bW/aL1LjTwM=; b=T4zEQcblB3V6InCcvCsbkVo2m9kwmn/1BUUG7jWL3B0wRg+z9S1l9c5DDJaJoKbEnySzaO o1v8z20X+KsBk+hsDPGwekFHmqr2WbpPNSF7NhgQQ8nJtyEk0KPcmmDbwtQVrUfQI4eXhh N9SmBLbl5BS/ozsdTH9c5r0gK+Bo5qo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ra7JMFL/"; spf=pass (imf23.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730137737; a=rsa-sha256; cv=none; b=scEk6OlSme/tK8v10n0qgOsBTw3A8l6IA9/Iy4ZbMPA4/PDlzvj8x0G3M8r7qr+6S38tkn j6p+iFd3B7No1CT5p2+m/daT8NGiDfmdrrrCUyqUroPgnUEs/OWeNJRawQUGPxm2BXuVFt K/x49N0gO84Xk1RLxXrzdha8nviwUEk= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4316e9f4a40so47297585e9.2 for ; Mon, 28 Oct 2024 10:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730137790; x=1730742590; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dS+CDaRqLDX9OzIJihQbnIilfInW0I2/bW/aL1LjTwM=; b=Ra7JMFL/vIRMJABroqOS/JZuV1K5xXG6g/nLLZ2HPTU9L/5yg1Snpmf0azhtkPuy0g XQXudV2u5c+tWMkRK/U8buHHQTVBBa8fbfVH4UuSBnkYNtKoU+x9w1uvVVQq7C0tkyxR ffdJPNtPvpCdzT0XX/6LP3M9YnK336WRNvSIldXDBdWc6WM6/UbjxBRD+cXHMQfduIyl V0OxhiomruiumsOscIXZPqOhbkzXeh1DehIRAnhocQZYjFtdvPJeGgGMFtqkWUb7AJ1A WczLgC7sNHunDviqKVOPDA4o9bO6CeXl2j0FrJusPVIdDvm6R1ZwxRWbxt6gBt47WM0c d/Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730137790; x=1730742590; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dS+CDaRqLDX9OzIJihQbnIilfInW0I2/bW/aL1LjTwM=; b=e+osfqBWVzAIwW/dqiFX3sIcEgDMINhkzGr2g4wVSG40VnljN7iKdiyQCDdPZTo+kt NJXOk3cc5vSlZfBjJwsiiTnVrB0ZGzaJISUvDcHVgwqkTyG9X6IcYXQr/xK8OLLNC4P0 GqO7xjdewQs0VQ1F7QZE/NVjZVbk9K47Y+lgEizks10mQc7wrz37T3cC7eKsFdtGazhi pgo07uhwJWEvPhEmgs71dub8npTMfPOBdpKe4iv1wdN3nUr7thIyAiI3u09/ONk7NIqB VaoA11Zg946gRZFS4MPRZbaH/MGOCZE1zgBFanswWy3IcJtrKKmtP+5bAQPyg71gWnLX Iscg== X-Forwarded-Encrypted: i=1; AJvYcCUxQKe0eXi0eiQ54k6Duht8ysFX986jCECB9z6xEgPoOaTCvOdC9WhsDwzeF3SBOsCEaVDv59uqJA==@kvack.org X-Gm-Message-State: AOJu0YwPc2uJTH8ieLr5wVNJV071f5m4UwnN8J7q6EMKMTIuEG6Uszrb kGeL3kdFOTWg8EQ1wG/7tRsoHPVLIOXJoQu2lbwZFyCPgFt7NWApFm/OIWzNoFuBpcg7S7zHoIP J2maI4oXuJIUs2K2Plh12XChK5hM= X-Google-Smtp-Source: AGHT+IEZiLVIqCI0cfYUlRzU/AbFdJ9mVCLjbS6yx75u6/19fy5sdAACVuuh5PZYe5RJd1iUMLtWWGteS29/GiRwVks= X-Received: by 2002:a05:600c:3593:b0:430:54a4:5ad7 with SMTP id 5b1f17b1804b1-4319ac76449mr84448105e9.1.1730137789737; Mon, 28 Oct 2024 10:49:49 -0700 (PDT) MIME-Version: 1.0 References: <20241028115850.3409893-1-linyunsheng@huawei.com> <20241028115850.3409893-3-linyunsheng@huawei.com> In-Reply-To: <20241028115850.3409893-3-linyunsheng@huawei.com> From: Alexander Duyck Date: Mon, 28 Oct 2024 10:49:13 -0700 Message-ID: Subject: Re: [PATCH RFC 02/10] net: rename skb_copy_to_page_nocache() helper To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Linux-MM , Eric Dumazet , Simon Horman , David Ahern Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: eusydn1n5spho7si4gr5c7stmpcoqz6j X-Rspamd-Queue-Id: 38D67140012 X-Rspamd-Server: rspam11 X-HE-Tag: 1730137775-946263 X-HE-Meta: U2FsdGVkX1/O2SD0kzhumEBsM7sjcrSU9vIjTJ2BIUvx+D5sCxjJ50Pair4ypLkJ3XtpzX2P9dVex0CGm7tpwey/mv0jDBmknL+bpPhApfem2BQmABOmUSIMO/1vdRblfBAj8qFbdsOzzx3tRVvsBEi3DKN+6/NUHfr4eddmNWVlCVf9woIfWkOy7hj6sxm65Z/+yWnAOG6ZtwT9F0vo1dGNvMgZrvDMLaLGztcHqUxmtBJPV8Y6NgC8yHa6k6NgGVloJ3x8CG95Y+fObgXF3DrR0lx9+1s9YBGCSiMROvRwxShUbubCeRGynbw+h39xkabkS6r1P75tBNKjXIznv9lNap6kXXm6+39XvVnAxZLggT3+xPgk2Njeqp0osoQWBfVZ/BYIbHSgkWy+Us7KSAX69YngJsG9w9CEfPB3Ci21aODUM7obebMi0V0ohgFDykNWg8w6NSWdefIRyhKiR1SJwbGP4BMo+07NFZzUeCVoRusnscyiE+rf0qMVYc6o+S9TE971+gB3orCAlg7pcw7nD/v5Axowt5zNqJCf6+gyXCVRM8dn4Knkjjk2e0G0kiYa4c5fmCvIV1gqbD0UhGYR+3+4biszw8qd0rz6dBia8Cc/6uY4KEsrKN6blbcYnaW7zsFReNPj3ui+kdhs4XB2Mb9aDb6hEfZJi56gMmpw+NBmBtfipAWMKyahu4ygmwSyfehB2+4eCtdfBnV82UzHwb/R8Y6fe5IdbDIpXqilixSMJRyanUEys7SnSUOMlNnaMMYGZQ+jiMkusPxU2ZrQTeCcA4s7lRZ0kV96R6GpJxNZ2SJcA+1bDk8MzCTxpK7QTaSEW8+FJtEGH0LXQxKbWx6fogCyPwgJZRXRo/MuznUICgxBl1I6uRgLG2uFF3JqAS0qfOg6V/xmTWr5Yw5LbBilbhaMhH6DrLVRxWWD9vUiyoN4icbrxkdz6363pUhgdEyvaiPYSrfYq64 Z6uPumh5 j1SVtt7surZhzLJk/mlk0n1DimcQz40DnXVoREAoNypYNTUS0AQ2+WxV/k11p7pHL2Y5b/wG+bWVlIvSqZYXz+zFyXTIE4ANxIuRJPBVQw62SlAJu1SN/k7Ig6ZNIHenhl2sfDd3S8Sp+Gh75lYlnQx/4BTvafs/nZGBxDoMkIyorittUxF3y+gBxxip4WCIO0XlwXDLsJneVUcv3k5VMM61nhXZY6wru5KjrkTz9Jke/6ITLjogE8BWg81TmTkqFyeY/N9V1/ODd/c2NP0xYNk4sMOGAXB8Y7av2C5vnIBC1/wFVT3MASp3Zrvk2AsrqqGYFoWX1ivys6EjWasEgZGqTbaht/67AxtOOT3rnv5FwCr4uDpRaQcf6ZFh9rUDym7pcz/W/0cflDxN3e4h7OBK7pE5A60CdmBiIMCnHqcR4ISiQ6zp64m4XCAHjBBzVMhEj4Z/mpdaAzyopyDTMxCFyEkCnrPfBLXS8rmEc86xzjKS0nT6Tt+HxHP8aejd2P90w2YAsayolC4m+5s62jYW6HrR8mX0slGC8xtpJOsEiK6skVCi2ZvlPUXF/uo9yqzEwdarqmLjrdYz07Mc31vH5vOWWWbj7LkD8/ot0+sBEB5s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 5:05=E2=80=AFAM Yunsheng Lin wrote: > > Rename skb_copy_to_page_nocache() to skb_copy_to_frag_nocache() > to avoid calling virt_to_page() as we are about to pass virtual > address directly. > > CC: Alexander Duyck > CC: Andrew Morton > CC: Linux-MM > Signed-off-by: Yunsheng Lin > --- > include/net/sock.h | 9 ++++----- > net/ipv4/tcp.c | 7 +++---- > net/kcm/kcmsock.c | 7 +++---- > 3 files changed, 10 insertions(+), 13 deletions(-) Looks good to me. Reviewed-by: Alexander Duyck