From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBB0C77B7E for ; Sat, 27 May 2023 15:55:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C0F6B0072; Sat, 27 May 2023 11:55:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECCCD280001; Sat, 27 May 2023 11:55:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9459900003; Sat, 27 May 2023 11:55:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CA7A56B0072 for ; Sat, 27 May 2023 11:55:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DE021C6D75 for ; Sat, 27 May 2023 15:55:29 +0000 (UTC) X-FDA: 80836484778.02.B232F11 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf02.hostedemail.com (Postfix) with ESMTP id C310B80010 for ; Sat, 27 May 2023 15:55:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rWmpr8Dk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685202927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qZ/1f+H9JrSTH8ywSfAAbH2Cj7OIgM+7OnWkNZ9G6/M=; b=aIdSxvsNzl6qITpmQdOK5AoeTdCPFhCHrAjY0PzP7C2l9jgufQuZKlwWDDVOr0KHLBElBE RYyI08DuHv0O2VDgx21w+f5IcRBJdnsSsH0xF0L/m1VWktTZGHf+Dsj+/hMQJ/wt4haAYE o2K0y/mjXEijrkEF+ECxKBfNOVRvh80= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=rWmpr8Dk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685202927; a=rsa-sha256; cv=none; b=FfMq2fifL5saDJgZnGfkvLCktW+6z4qV10ZbGTPQdNZtA/9+30wWByNzVa3yLqgQ15NrG/ vMn9xr+G7/4GTv+5SLRly4D4Dcq3Ssrc270GHobxfCT8x8hlTMoMFyFU7AWqcpf1VmcchS BN40XY++d71zmnKsqMrhFSkzhn5d5r0= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-64f47448aeaso1448614b3a.0 for ; Sat, 27 May 2023 08:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685202926; x=1687794926; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qZ/1f+H9JrSTH8ywSfAAbH2Cj7OIgM+7OnWkNZ9G6/M=; b=rWmpr8DkC1PTeJ+ruz6WeYjVl72SKKE6L1OzdPejDPoSAW7zXmZBUw05Qrt26S9C9K U8JnJZ5vNM2ey8vstjtpFowukp0q7XfWY2JXtuYDLVNZoKAmgGFXv3AH3K5cpcaz6yzA tx91B1UH6oX8Yj1XcUfOG7FXKm07iJHD7w0wWjDwLfpPsf1Ztx3fCMZZCZ1yRYuid12c hZjLS5sLbyBGPteYx+LmLRsBwT2IK3Km1i7IeAe/4St8n9Um0UQ5B5cMIWj/X1fsPudq wfXqVoiC2glYv8qzoHIMH8l1e1p/1kUSfdOSTb1NwubYxiVsbSN+YVuhQB/kWWU02/Dt K3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685202927; x=1687794927; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qZ/1f+H9JrSTH8ywSfAAbH2Cj7OIgM+7OnWkNZ9G6/M=; b=NufsKWwvLjYbfls7LhFrpbiD3aMbOh4gk4y4QhLdSC+uwie12whfGPQ5BeIPgVKH2u gX2QExf2RAxEwKqJqrilJj1yl6hXySEB0bNrzCJu4THiJPCNqsFe1Tz3VgZs2f2xhHUs 3eWyS4nE7WW61MwWbroy8XeBpRuysvum4NerqPSGapDhbl3Kh/bUOfV7AoLYyiChFGVc Ki2iTTbZtFN6PGn7Ch0iCkNbqgprxV86t6BYHiaNsgWdcFGr6pjeOSqNBcKt+tXalZes 4btudtQO0DJZuTQYegOiC61n/wfNsT/93X8wMbek0H/8X65vHvcXBjugM2VxxuuvgIBO Veug== X-Gm-Message-State: AC+VfDzRfGGyjOAGBCzg4grl6W0kcotxXxRR8GjAFu8UFJ6SoU/ZW532 DXvfHw5DeDqBnRLlseCg0kNtUee66giPtIFsyWo= X-Google-Smtp-Source: ACHHUZ64JnVWGNRmG/FMmCXkRK9umouxfNu5WSYpfqhZWb1yayLJ0QzFvBLSS7/j3llpZaEueVjiGE/MaMAjTCqEuek= X-Received: by 2002:a05:6a20:4428:b0:ff:a820:e060 with SMTP id ce40-20020a056a20442800b000ffa820e060mr4237395pzb.20.1685202926525; Sat, 27 May 2023 08:55:26 -0700 (PDT) MIME-Version: 1.0 References: <20230524153311.3625329-1-dhowells@redhat.com> <20230524153311.3625329-6-dhowells@redhat.com> <20230526175736.7e75dcf9@kernel.org> In-Reply-To: <20230526175736.7e75dcf9@kernel.org> From: Alexander Duyck Date: Sat, 27 May 2023 08:54:50 -0700 Message-ID: Subject: Re: [PATCH net-next 05/12] mm: Make the page_frag_cache allocator handle __GFP_ZERO itself To: Jakub Kicinski Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: b9bka4kf5a5te45c6comrp5jnka4ir1b X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C310B80010 X-HE-Tag: 1685202927-447997 X-HE-Meta: U2FsdGVkX1+kPtBkAZoXkrHhkxf1Zk5n3ajAwQ6L/worTmcajtjjd8KlpEh1+PgYgnfuULLN8ohg1Lec3/s/hpUfYsabVje7Rc6Zxlsuzcko5IuPRBgnc4Cb9oqrfPNOhRjXy9qSwP7AK8GBfpGvTVHmN2R8U5ql1LOZ5MAUwYx2WAWF2fUhdiIh6/cwWp3Xzv24iY8L9EleVMV5vrVSFcrHVfgrEJaElrwKDHhThtb/ijrk9I1Pk3zG+U5wGsz2i6bmczl1UlOnPS9E+/eHGRa8Hi/l5hATaN1ajd1L9GOA1AXW43rHJhhiQdKiO6k65C7twUyjV3I3I7sH7lv1vkNsXwlqr6VWeAjuZkCeWnzyJqCitO8RT20QXB6rX7LlG6/vaelpQpVeCXvKa0DimXxbwmaYDCtmxSnYxiZyW26kGacGMq/ma5T2RBNrgSNSwqe5XD2kIIRzDbGKLOYLgC7Lr83oF+j5pP7Rj2FXbtd7WdKTnriFeMdCV9XYu6UO4DlVRYkNs6i6Km/KIrxaEejVOfV4Ytf/VgAUsS8XEEWXZeZcpgXJzj0DFmBQz8uEAr7fTAaBOSeSqolD2ovfrJ4S7Lkx65TTnZfIfXlxz3UuzceB1cT9obs4XHios1sQXqeL5E842xjUJDE69iHwMSDUYpu2gk1/MocVyydNSod5dCRF4iLdOrliR5abiKMB79m541rjaBnzdmJj0SxZuEKOZJz/1vT3s7qdubagbd7NrdezeqP1U+3VkPSCqD+yKH7Gwwd0qG7cK3MhMQBPk/Cr0pUf6VG9Tye+HfjcqjIJrIIxWjcjS/qo1gRIzlTIVqh9OHTP/MLCBFQi2KHqWcw7zfarDplHHTz5NA+yAcF52cyStJIWZXJ37+w2xHeWe/LEJhkChVO/M8CJnAqOUygm/hC2tVQ2XgT2X8VOjVVe4Q65WWZBbcdPDo20GMa1lyg0aUHyOPR6FVOkDhJ pjuuKejE oCbAVfzF3VEk8ZuzBYf5N5NneeRVjxnPBbaiBVJF8sQzk7KBOijcVwPXIlZZrCaikwvTLYziAdB7a4yaHs6ZjncjHWeDXymWA/8kXBKVkvU1+tYRuD7ZgjBzBcPB0+nIxljDFsghW/FuKqAl8DBQj88vV2+pl0krZPM7LgBSUD/eG/af14lN0I4Glt8GglzVfwy7gb+AR8sN1ZOwMZ4XGhNTcSR3uWKwK+hQtnipb85dCSH1/Fog3uvf+6Uk6uakE90dv+DiXAlrGquYGeczIPJuchRxEtZ/+pd8DNpNOz2ZYTioiJ5pxXSJPMznarKI2h1j/Zzk4OwShpti4CehZDC091TDzEJcEQNE5wmE86fG2xY+2/mnV05NCY1SIIMKEQzB0A9t5gI/CN2l6GN4XwV26NvkFvxULUbxM/HcBH3UwY0NwGePdWk0MwzxVdq9jDvh9sw698t5oVLk/LTtVYtnvktuLCJn8nogh2z/d/EDpCPD//JIB5bJMu+qk6v4hqdpkhoLl5WaQEyAfSCuGQpTf7ysLLNuz/IEfflbfxJHhidYGwAhFA5xrqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 26, 2023 at 5:57=E2=80=AFPM Jakub Kicinski wr= ote: > > On Wed, 24 May 2023 16:33:04 +0100 David Howells wrote: > > Make the page_frag_cache allocator handle __GFP_ZERO itself rather than > > passing it off to the page allocator. There may be a mix of callers, s= ome > > specifying __GFP_ZERO and some not - and even if all specify __GFP_ZERO= , we > > might refurbish the page, in which case the returned memory doesn't get > > cleared. > > I think it's pretty clear that page frag allocator was never supposed > to support GFP_ZERO, as we don't need it in networking.. So maybe > you're better off adding the memset() in nvme? > > CCing Alex, who I think would say something along those lines :) > IDK how much we still care given that most networking drivers are > migrating to page_poll these days. Yeah, the page frag allocator wasn't meant to handle things like this. Generally the cache was meant to be used within one context so that the GFP flags used were consistent between calls. Currently the only thing passed appears to be GFP_ATOMIC. Also I am not a big fan of pulling this out of page_alloc.c The fact is that is where the allocation functions live so it makes sense to just leave it there. It isn't as if there is enough code added in my point of view to create yet another file and make it harder to track git history as a result.