From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC8DC5472D for ; Mon, 26 Aug 2024 16:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBC396B007B; Mon, 26 Aug 2024 12:31:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6C546B0083; Mon, 26 Aug 2024 12:31:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A33D46B0088; Mon, 26 Aug 2024 12:31:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 84BF66B007B for ; Mon, 26 Aug 2024 12:31:22 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0D803A12B4 for ; Mon, 26 Aug 2024 16:31:22 +0000 (UTC) X-FDA: 82494936804.09.8D02785 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf09.hostedemail.com (Postfix) with ESMTP id 22A36140012 for ; Mon, 26 Aug 2024 16:31:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E9yZaeVR; spf=pass (imf09.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724689861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OgP1RaXOzzzTBKazcsHO9qES41aL077t+VcUN6dnDbs=; b=d2ZeNvOf42/Wu3Wvs1Z7KOniqe/+pWIYsKisOBdKTIhVap3uEZcerFkVPhmuO++WmsXa+7 EbTrbmvpAzRC6yyGjtn6454RfMBXWv9EyQvJ2d0him1rAkA6t8HjnBrrB48+oN/pOanM/F +udALCdHhqX8TWOpCt8SZltRnGhD/DA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=E9yZaeVR; spf=pass (imf09.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724689861; a=rsa-sha256; cv=none; b=ZB6crxlkgK69lfEgZYCHzBM66BO/eHJtQnByvvVo+nr8I3EcSG3R0d/GO2LAQsY1AJPjYG BLI7afaazhk7Gq43YPFpRvy+F+tRATyLRqHM4XkeLFbZ6bp02uFN/zPukFh9OK12G8qctv Kfva7Z+KI3K/bGlH3B9Z0UoEsmdW+8A= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-371bb8322b2so2422392f8f.0 for ; Mon, 26 Aug 2024 09:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724689878; x=1725294678; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OgP1RaXOzzzTBKazcsHO9qES41aL077t+VcUN6dnDbs=; b=E9yZaeVRONTsydiHgOpJ13qDIO7Sr3E2wN0jdoo7NZoqXY92pZVfmUGREwkHNmWruQ fmCG1PfnEy/1HNKffxeeJCzPrOWhxvF5CW84+twXxzLDqwcc8GG1FKx8n6FVIyjOEvMb y1Et7JT29X3DHJciyR8VcLpK7CKLQzUwuLw+iRIeQKTba+3gravPhHFzfscxfR6U9E9Z fe+UIMb3qz99l0qUBkfhWdQwHtzK7c6GFENEodCoLcVkUhspnIkq6NvzLgYfZCjjmvq3 oCFRIuEa/a5Aml5kwjzq+hggMdam1lf9zoNGTtQ2iK8l1fSm62ghbS/EmBYOxCx75/ld AARg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724689878; x=1725294678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OgP1RaXOzzzTBKazcsHO9qES41aL077t+VcUN6dnDbs=; b=Jv4+Zmd375IxnxOViqs/AE61ay0BmxHjlpkH19zROHwAFTN/yMkNm6Lx+VYEO9FMqn ayH+us3bT2yIihcziVD9WO3HbQDF3RYdlDmhsQKle/4hcHbeTcp2wKJCHMwEd8oziDfH 8lni6c9JLu41ObGvXmPdIIjNbwn1j+autiS5Mi/7vRt/DltZ4OVdXbO1jhnfz6gavKxS xPKJSGCBZi0vhSp3laSvsyeC99BN8sjJwXea+CUAEksStZA3q2xw2S+hhZ1bBkIvTUPh ZgRTXTGZl5HDHw3OJ8oQbbpKFpoOAHtrpcY8xW8spVqvdzgHZd312POQr0Okt1BVsY4x 9Nfw== X-Forwarded-Encrypted: i=1; AJvYcCVyZ9w9xYioh3UgC50bGVpkTSTo9cLArG60MDSUmZJjk+FnIggulDvQM7f+8myVsSUCfO67VIsN1w==@kvack.org X-Gm-Message-State: AOJu0Yx5/mSZf2Gf8qiBxEkA5MS+jBXrDpwt2gc/Eh9qL9HEhWZC2QM3 P1Bkr55pHz3B6+WEFc16SC8CWdg/j9iNPCKFG5UrfAykuLbZaETr1UDNJPOViG9jZHu9sg7MEpg yrX/2t90LOgDmxL+y57XTfI7FHsHofQ== X-Google-Smtp-Source: AGHT+IGvlKM5jEkyZL5SDFHJ5vCf7ieoBS46eVPP0FWNvkfN0Ygt6SwSa79aV/SxBKbtgib3VrcY3K+UOy576RuKy1k= X-Received: by 2002:adf:fc0d:0:b0:365:aec0:e191 with SMTP id ffacd0b85a97d-3748c88a349mr113978f8f.21.1724689877939; Mon, 26 Aug 2024 09:31:17 -0700 (PDT) MIME-Version: 1.0 References: <20240826124021.2635705-1-linyunsheng@huawei.com> <20240826124021.2635705-2-linyunsheng@huawei.com> In-Reply-To: <20240826124021.2635705-2-linyunsheng@huawei.com> From: Alexander Duyck Date: Mon, 26 Aug 2024 09:30:41 -0700 Message-ID: Subject: Re: [PATCH net-next v15 01/13] mm: page_frag: add a test module for page_frag To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: f7xr8yatgrs998yfdeap659bidpiagn9 X-Rspamd-Queue-Id: 22A36140012 X-Rspamd-Server: rspam11 X-HE-Tag: 1724689879-655376 X-HE-Meta: U2FsdGVkX19diOM0g1OjGDus2Sc5LN+8zSaClAt9TrUUMEFdjWqvAIyJFa0TNCMWt6cNPpG4b9q5isYedWB/jIPss75dle/J+ATHp05NZNdCZXG295eMuqEPdlf6ERbsmBjiSc4XAK4OZ1DzMKSZjNa8vmdgQVtTpEdDTXA6yU31N2irZWlRqwcBAWUXz89SBPA1YJnO+6AWG4xYEHCXvJrChalfRWIiHFPiZ/jTw0Ga7QDSeLdouFxBrEd0gXRVt0Qwe3BA7+jRF493Cd3zGOLPmgKdEhXw4PLGl8LhfpcY0OEOypVgBsE4+fFsVKlW7rikVY17lCNwOSQ2iCADu67xoLYUZCLTn9pDK/HXKsxjcLkDF1YeH2DoWpWofXCBa5J0046nLobBNRrfjdjCamSGIwmjrLMgMd5RRuZlOKIH6VKYcGBs6YZOQq9g57jvhpJBdB7qydbrzZIo8g8Mjkv2RjOtb4grhDiPjJd2XQDdKQUkYrIKujIvomxZea5A/T0DYHObd/EAF+gfcvMUcxbw+YecAFG5xhJeJbtUmqaYx8qS/YRK1qgsr2YY4t/5CjKkGO/5xlZn4CuBmrbPYJnjKHho1B7dWRWjmFQ5bdd8dzKfzbxVAK8PZuXBs4F7p3gnc/Khpw+r+YHkfFx6lbWBmqpHL7lCq8++uiU55ZGEPaHToeOR3W3IL4YGHk2QgWHESz2VGIVgv77EjXVI9fWT3+8I42IsdCbhTnLtp//uqU6eJAfb0TrRdOdBiSmkdD9GB+KcbBEmZtc3OysKNMOg9cMkpe71HO5jfOKyPREMIlfVGuMpmIfCV50GUQRNk92kJnwj0HB6s6KFVfaP4U2VXmGfkFWr6poGD8tVZenzq1Ds9CsdLaPQzUxo723nwky9eaaRj49ynkFFlJE4UPhxEZa90FmAh4m4lZYaOAcaphZqGhx7Z1UnJvCGOarRAAuCAIQzP+2ReNbty4V WB1FJoIN NWuiBdgY2boZAoV3/sTreGuM0lIfGAaOQupplBoLQVN/IbDlG9Ng97RMNeZ3IbJXZ+eff9cDuWqB4WTsn3czcVkYIn/02StY2oQx0EV8V7F3hA04z6LFcHhFYoDcP0L4cKYxvbk6IRUhzKuLbeekaSL3p3zIJ+SeA5GY658Tpc0MCsLJRfn5h1p7SoIOzYKI5PrApqJuLrvZy0OxjxSBxqFxt4ubfP0w7Azcwyw/VJSLPsEevFCNLo33yu4XLGOKh7RVKO+CMXLcSGSf9K2q6UdwZ5zEufxIFlS6Fb6OQLjbD1maOr6yx5KWT2ZlbQpPNFerJqjvrKGjfwUoXqxZu6mpAJq4STAyS6ZgNKqzXzI8RzKpieaO+5RV/oR3IpW+XSgb1GQFl7xL5bo/ZBsjPTaPxjyJSnBxFV7jF2lWop+pFeVk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 5:46=E2=80=AFAM Yunsheng Lin wrote: > > The testing is done by ensuring that the fragment allocated > from a frag_frag_cache instance is pushed into a ptr_ring > instance in a kthread binded to a specified cpu, and a kthread > binded to a specified cpu will pop the fragment from the > ptr_ring and free the fragment. > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > tools/testing/selftests/mm/Makefile | 2 + > tools/testing/selftests/mm/page_frag/Makefile | 18 ++ > .../selftests/mm/page_frag/page_frag_test.c | 170 ++++++++++++++++++ > tools/testing/selftests/mm/run_vmtests.sh | 9 +- > 4 files changed, 198 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/mm/page_frag/Makefile > create mode 100644 tools/testing/selftests/mm/page_frag/page_frag_test.c > ... I am good with everything up to this point. > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/se= lftests/mm/run_vmtests.sh > index 36045edb10de..9a788d5f3f28 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -75,6 +75,8 @@ separated by spaces: > read-only VMAs > - mdwe > test prctl(PR_SET_MDWE, ...) > +- page_frag > + test handling of page fragment allocation and freeing > > example: ./run_vmtests.sh -t "hmm mmap ksm" > EOF > @@ -231,7 +233,8 @@ run_test() { > ("$@" 2>&1) | tap_prefix > local ret=3D${PIPESTATUS[0]} > count_total=3D$(( count_total + 1 )) > - if [ $ret -eq 0 ]; then > + # page_frag_test.ko returns 11(EAGAIN) when insmod'ing to= avoid rmmod > + if [ $ret -eq 0 ] | [ $ret -eq 11 -a ${CATEGORY} =3D=3D "= page_frag" ]; then > count_pass=3D$(( count_pass + 1 )) > echo "[PASS]" | tap_prefix > echo "ok ${count_total} ${test}" | tap_output > @@ -456,6 +459,10 @@ CATEGORY=3D"mkdirty" run_test ./mkdirty > > CATEGORY=3D"mdwe" run_test ./mdwe_test > > +CATEGORY=3D"page_frag" run_test insmod ./page_frag/page_frag_test.ko > + > +CATEGORY=3D"page_frag" run_test insmod ./page_frag/page_frag_test.ko tes= t_alloc_len=3D12 test_align=3D1 > + > echo "SUMMARY: PASS=3D${count_pass} SKIP=3D${count_skip} FAIL=3D${count_= fail}" | tap_prefix > echo "1..${count_total}" | tap_output > I don't know if this piece is needed. My thought would be rather than mess with the run_vmtest.sh directly which is more of a pass/fail test it might be better to handle this more like test_vmalloc.sh and just put together your own performance test that you can run to collect the data, and then if you want to be a part of this test you could call that script from here.