From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C9DCD4853 for ; Wed, 4 Sep 2024 15:44:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEB716B00C7; Wed, 4 Sep 2024 11:44:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9B536B00CC; Wed, 4 Sep 2024 11:44:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3C886B00D0; Wed, 4 Sep 2024 11:44:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 833806B00C7 for ; Wed, 4 Sep 2024 11:44:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D669A16048D for ; Wed, 4 Sep 2024 15:44:43 +0000 (UTC) X-FDA: 82527478446.25.6D8BB83 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf07.hostedemail.com (Postfix) with ESMTP id 0E26640029 for ; Wed, 4 Sep 2024 15:44:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CW2wxiZ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725464604; a=rsa-sha256; cv=none; b=EkQUEtNEcb46RudAd4p0RP13mNbOqSduxBybvmzdHF/jCA7bzSm9EJtg2QPf+I8y4FUff3 EbbaV1tEp5szvTzx35gCZ30zgS4OOTXmV4p3l/eHqq2C7zKItB+zuF/Qzc0CxdJ+3vsw2p tV+3TMoqcFnVy3MNNL1J73Cj1cGvwV0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CW2wxiZ+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725464604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=umDL6mMF2LGIC/gv7mZ3udOWUJnQiCok84gUZNiT1Zg=; b=NfkEyqUxXMhCmKyaUM0NBWURV4tT+JHGiy2unBmdS+pv4QBdBmcNGVws3AYtIsahKjK+Br OxzZGUBz0+FDhp2NUlXHMrU8a6ENTdX4AnUK8MS6r/QQyl8saS2o9zwlFoIbuktuZJAS4P vZlLMbFLFiloRIaHjLjjvda7w3yqHb4= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42c7856ed66so37704405e9.3 for ; Wed, 04 Sep 2024 08:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725464680; x=1726069480; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=umDL6mMF2LGIC/gv7mZ3udOWUJnQiCok84gUZNiT1Zg=; b=CW2wxiZ+k7eDQkFhCg42TGCWP4xyJLkkNxX1EpBuswUtVXWhU/jgk7i1528Bt0CUNA sOJL4MjVKNQd9WE7pLg//Rj5rGUbdPSBnLf9kdtKRQzyfRdwsRAAsGIUff/0tLugefnt C8CljKRHo1wljUHzVsaRkVNET3X4GOzQDqdb2lJImVP7OreVPm81zq6tqWPQXWWLyDHr 5Wlz3tTuoJ4ucccu1BRm49JAf52inWzpWyL681FxGol+32tDXF4awq7UKmTjatZzmO1z 9NfghHmRmCVOOI5+7iUsN0IZOtu1uOGdUnIhovpnG/qTDtAkonISejisEOQNhSsh76gg BfoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725464680; x=1726069480; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umDL6mMF2LGIC/gv7mZ3udOWUJnQiCok84gUZNiT1Zg=; b=u6lJXHwoXcSP4LKC0DLVOZwElUvHFxbhC/QM1F8RxjQfHHlhqESvHLrn8Snlns5e18 TG3BEGNHSi2YKrbGaQ1iZ1QutSfL+hzQxmJSKC8Lnzpk8OjaI+7nCamirENECBX0CwXs jKt+5u5rxObgNC9mehCjyIV8cKjYPEF4ox5XbqPZPlpo1yIcQSHX92ERWpk7lpTAOUmf 6ZSfAzAHnxlCSR6e7l9Sm8hOCVNfS7lblQAKmEwYsRavR3xTBWmgbzuGBbIfZ8HK+0Qe aE25UUO8NvVlEydja4KJdBc06j1/RCOA8FjWzsnfuTYdxrBRf9Co8aRZPF4uiuqvFvnn jGiQ== X-Forwarded-Encrypted: i=1; AJvYcCW6gpXszPxS+gnw035BEjlPoW2FegnpTGgsRJrx87F50etSTK3nMWcnkUgwVB1TgRC11Tc5cG/3vA==@kvack.org X-Gm-Message-State: AOJu0YxAORvqeMVSjNmISJIIn9zzXh/G6NEndRWH3IZzzLZHotyUmi6K cUHFkZN7femnuZ/aVrtE8KxaFoM4jdMNAbZfk14uTACgzr+2yEDGVYNkZuMXo+TlPueTYCu/WUO W5hnacLz21eHSSOrHjDZN05FTnKY= X-Google-Smtp-Source: AGHT+IG/BmSVshTuSzwHzg4qPrMOTOCDcwQIxT7cdW1azDwNVPeYpby/rAXvfjK9JwzNmGKJtZBXoDCTRKBu22h8oBE= X-Received: by 2002:a05:600c:1914:b0:426:5e91:3920 with SMTP id 5b1f17b1804b1-42bb27a9eedmr160835315e9.29.1725464680483; Wed, 04 Sep 2024 08:44:40 -0700 (PDT) MIME-Version: 1.0 References: <20240902120314.508180-1-linyunsheng@huawei.com> <20240902120314.508180-3-linyunsheng@huawei.com> In-Reply-To: <20240902120314.508180-3-linyunsheng@huawei.com> From: Alexander Duyck Date: Wed, 4 Sep 2024 08:44:03 -0700 Message-ID: Subject: Re: [PATCH net-next v17 02/14] mm: move the page fragment allocator from page_alloc into its own file To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells , Andrew Morton , Eric Dumazet , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0E26640029 X-Stat-Signature: akiihgmuczmsrgukbqy6g5zih6414mth X-Rspam-User: X-HE-Tag: 1725464681-571601 X-HE-Meta: U2FsdGVkX18uGBW2eAt/cxWJKxVHfIRUakMzjRVm1GUt8oVzm70jjC2qFJxxa7Zt+iMAD4dcxRHowIN82l/yLNC9Ra3kaR/5Jzu1Cflxunhjasg6Zrs8ibrztk2ZVRTXwtOdTKUeJ9nSEtev/pSjZRVpdriE7VSdSW2yvXgWUV/9cp5IqQYFgtv29DhqZZ+DiqkHDTOOBp3DaOHU1aYuomcAHCSUOS7b1dnNKwHNzdoBXCnPIVx9PP/iFoPK84gX3+m0AK3P+nVPvs+mn5IzgTm63z/XxvyZcxau8RZcqPoN42ay5BmJ39LO6rQY4QMNzxtU73EzHN2yixRfJtQc45xs4ZGOfC6IDEyedQOckSfT1CYZ2F+ec+laid3lGKE1z/rXKEwpabRf/Uua/EEE44XnB686KH/g36abqCW3LUzEy+72o9Y+vDMkiEj8s7fDOz3tfAKH/wWy4Fr5u7ezj5vuJFuksKILNsWuFJrWHtheLwepO2917PA9uXWPYhk2BDarIy+SnhwVWLazIqCNYioc+act/KdVXBOQkCYdw6LcV8oz7sMQCPNelqnpTvTlJS+IhNtXrpStZVFepGj9t9NarAdCWPuGDR1nGBvkXQbq7UPt2GH8y3e5LKMC8tPjpYHwwPGBVpCUHUlMn4IKOvIXjR+XsPUxS5kBPiHatqsmTJ/vf+pLWkl7SP5kDDQpuAuFj2j5xwylI+Oa3LaDTmPIpsxIwOX9saTxDbZVt5pm4UIhD3pAUOekl5bml25x1OZ36Lyc41oYgtUPEQo23NunGzDX9nw/O9xuzfnz0S57k1TZHjJPVLxOF2KYPDD+GN5Czmrmiw/YVGhG6IQ76LveeUwyxlvEiNbfrZNtT4LIyJ3N2UBVm8980YRYO3M0X8Ap3j0Kw+feFW3WmXPEiA+1QWV6hoAcWfgORZZ3qwRZpCo1FPBMOgvUAL+fQMgRgzxqDVwV/jWrTaV2S2b y1Va7ezM TEEAiMRYkraKSrrqx0rWmPKeEURQFoOxvP8S63uj+qwtVBTR8uQ95CmqvoTNLwF4eGhdPaRR0/kNQfcLtgMfcqwhHJe8mhRDFCEaNYyl8qN+eZRLimk1cuYsvOyUvmORpXi8I5B7kMZqFjHpPZZfaBgE/zFJ8Vtjx4sLpeizsVsELWMbgEjxpGD3mp8JL3QrTPAbYS7carYiaiy0KESbSgPDSzMyTmwy8CCH/ZTNmbCDt7fZ6tcnwV3F1MRh0dIlyg/XjTs+/UbZEohgTfj5bc7rAc68sxTyiGgU9Rb2BWkRNbG2zGtg4Pp1Aa+yqBj390s4YrZ+nn4veQ70L2xFjTVLDkW8aBcgTItFE1W6TpWKj+TXvxb+prkki4EgeB/RI8+0XrWC/ILEzjmVeXOXn/pARZIt3XU9MYMOZyJoCbXNHKnz+pDJH59eyHGQLUb0m4tTGZ4w4773ala9y2/mbB7oY//rLKYcwKBSW5RFJIRO6qKnMh+0Ptn3h9d/P68omm7Bz0PECfvNi5AofpRZ9XAiVyl5kjMkgpVd8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 2, 2024 at 5:09=E2=80=AFAM Yunsheng Lin wrote: > > Inspired by [1], move the page fragment allocator from page_alloc > into its own c file and header file, as we are about to make more > change for it to replace another page_frag implementation in > sock.c > > As this patchset is going to replace 'struct page_frag' with > 'struct page_frag_cache' in sched.h, including page_frag_cache.h > in sched.h has a compiler error caused by interdependence between > mm_types.h and mm.h for asm-offsets.c, see [2]. So avoid the compiler > error by moving 'struct page_frag_cache' to mm_types_task.h as > suggested by Alexander, see [3]. > > 1. https://lore.kernel.org/all/20230411160902.4134381-3-dhowells@redhat.c= om/ > 2. https://lore.kernel.org/all/15623dac-9358-4597-b3ee-3694a5956920@gmail= .com/ > 3. https://lore.kernel.org/all/CAKgT0UdH1yD=3DLSCXFJ=3DYM_aiA4OomD-2wXykO= 42bizaWMt_HOA@mail.gmail.com/ > CC: David Howells > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > Acked-by: Andrew Morton > --- > include/linux/gfp.h | 22 --- > include/linux/mm_types.h | 18 --- > include/linux/mm_types_task.h | 18 +++ > include/linux/page_frag_cache.h | 31 ++++ > include/linux/skbuff.h | 1 + > mm/Makefile | 1 + > mm/page_alloc.c | 136 ---------------- > mm/page_frag_cache.c | 145 ++++++++++++++++++ > .../selftests/mm/page_frag/page_frag_test.c | 2 +- > 9 files changed, 197 insertions(+), 177 deletions(-) > create mode 100644 include/linux/page_frag_cache.h > create mode 100644 mm/page_frag_cache.c > Looks good to me. Reviewed-by: Alexander Duyck