From: Alexander Duyck <alexander.duyck@gmail.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
Shuah Khan <shuah@kernel.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v17 02/14] mm: move the page fragment allocator from page_alloc into its own file
Date: Wed, 4 Sep 2024 08:44:03 -0700 [thread overview]
Message-ID: <CAKgT0UeHFm9Oy_TwHgtsWpr6EMRAxsKn+H-p8dUTgAtBJwbzpQ@mail.gmail.com> (raw)
In-Reply-To: <20240902120314.508180-3-linyunsheng@huawei.com>
On Mon, Sep 2, 2024 at 5:09 AM Yunsheng Lin <linyunsheng@huawei.com> wrote:
>
> Inspired by [1], move the page fragment allocator from page_alloc
> into its own c file and header file, as we are about to make more
> change for it to replace another page_frag implementation in
> sock.c
>
> As this patchset is going to replace 'struct page_frag' with
> 'struct page_frag_cache' in sched.h, including page_frag_cache.h
> in sched.h has a compiler error caused by interdependence between
> mm_types.h and mm.h for asm-offsets.c, see [2]. So avoid the compiler
> error by moving 'struct page_frag_cache' to mm_types_task.h as
> suggested by Alexander, see [3].
>
> 1. https://lore.kernel.org/all/20230411160902.4134381-3-dhowells@redhat.com/
> 2. https://lore.kernel.org/all/15623dac-9358-4597-b3ee-3694a5956920@gmail.com/
> 3. https://lore.kernel.org/all/CAKgT0UdH1yD=LSCXFJ=YM_aiA4OomD-2wXykO42bizaWMt_HOA@mail.gmail.com/
> CC: David Howells <dhowells@redhat.com>
> CC: Alexander Duyck <alexander.duyck@gmail.com>
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> include/linux/gfp.h | 22 ---
> include/linux/mm_types.h | 18 ---
> include/linux/mm_types_task.h | 18 +++
> include/linux/page_frag_cache.h | 31 ++++
> include/linux/skbuff.h | 1 +
> mm/Makefile | 1 +
> mm/page_alloc.c | 136 ----------------
> mm/page_frag_cache.c | 145 ++++++++++++++++++
> .../selftests/mm/page_frag/page_frag_test.c | 2 +-
> 9 files changed, 197 insertions(+), 177 deletions(-)
> create mode 100644 include/linux/page_frag_cache.h
> create mode 100644 mm/page_frag_cache.c
>
Looks good to me.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
next prev parent reply other threads:[~2024-09-04 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240902120314.508180-1-linyunsheng@huawei.com>
2024-09-02 12:03 ` [PATCH net-next v17 01/14] mm: page_frag: add a test module for page_frag Yunsheng Lin
2024-09-04 15:12 ` Alexander Duyck
2024-09-02 12:03 ` [PATCH net-next v17 02/14] mm: move the page fragment allocator from page_alloc into its own file Yunsheng Lin
2024-09-04 15:44 ` Alexander Duyck [this message]
2024-09-02 12:03 ` [PATCH net-next v17 03/14] mm: page_frag: use initial zero offset for page_frag_alloc_align() Yunsheng Lin
2024-09-04 15:47 ` Alexander Duyck
2024-09-02 12:03 ` [PATCH net-next v17 04/14] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Yunsheng Lin
2024-09-02 12:03 ` [PATCH net-next v17 06/14] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' Yunsheng Lin
2024-09-04 16:14 ` Alexander Duyck
2024-09-05 12:13 ` Yunsheng Lin
2024-09-05 16:55 ` Alexander Duyck
2024-09-02 12:03 ` [PATCH net-next v17 07/14] mm: page_frag: some minor refactoring before adding new API Yunsheng Lin
2024-09-02 12:03 ` [PATCH net-next v17 08/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() Yunsheng Lin
2024-09-02 12:03 ` [PATCH net-next v17 10/14] mm: page_frag: introduce prepare/probe/commit API Yunsheng Lin
2024-09-02 12:03 ` [PATCH net-next v17 11/14] mm: page_frag: add testing for the newly added prepare API Yunsheng Lin
2024-09-02 12:03 ` [PATCH net-next v17 13/14] mm: page_frag: update documentation for page_frag Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKgT0UeHFm9Oy_TwHgtsWpr6EMRAxsKn+H-p8dUTgAtBJwbzpQ@mail.gmail.com \
--to=alexander.duyck@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox