From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A41C2D0EA for ; Wed, 8 Apr 2020 14:54:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C68FF20678 for ; Wed, 8 Apr 2020 14:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B1vlQtrj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C68FF20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3484B8E0012; Wed, 8 Apr 2020 10:54:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D1CA8E000D; Wed, 8 Apr 2020 10:54:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1989B8E0012; Wed, 8 Apr 2020 10:54:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id F2EF98E000D for ; Wed, 8 Apr 2020 10:54:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B043F181AEF3C for ; Wed, 8 Apr 2020 14:54:12 +0000 (UTC) X-FDA: 76684983144.29.page01_5ef1bc9518809 X-HE-Tag: page01_5ef1bc9518809 X-Filterd-Recvd-Size: 3728 Received: from mail-il1-f195.google.com (mail-il1-f195.google.com [209.85.166.195]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Apr 2020 14:54:12 +0000 (UTC) Received: by mail-il1-f195.google.com with SMTP id t11so6968830ils.1 for ; Wed, 08 Apr 2020 07:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xrn2+iEZGKbu9eVh6NG6/Wn52EOvhn13a9saeycxHlg=; b=B1vlQtrjWNR+73PU7ReQU7+KMWGYr4vDc4/Jj5ZpsIQxH9Hs3/BHIACMk2yXMnjcBj BYi/R4IpHudZi1tT/8BOX6xH3ymU6rSQE56hmUR0QnBMNelHdMJpbf/9L/7yq+eI5ki2 qZCQlbbH4eoOKBbuLNyiJTJM+uIrRytxbcq8eBS+TyUd/L6BwlCJPymtfxR1HqysNiCb uf/mAiEBlB5ICZlyhknNcjbgYw553OTweJV1xKWdeenOAGfi5gK/uIRPloC2+RaHhPDT MsnRWoHfap4vKakp2E/y0QetJeW/LbFJTddSBrSe6HY6FoSF5p0rsOBx/1tMHA/VBGxu ei7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xrn2+iEZGKbu9eVh6NG6/Wn52EOvhn13a9saeycxHlg=; b=AKyaMLzF2pfKw1nRjJtkU6K5ZtZaUkheg0ozOAT4EXGyouPgRlMynZNcJ7NRrFOJPH 0WGA04m8S89aH35jSP3/yz0FnByusf6wqPXZ23UVNfxS5Nl02dCkZGbu23u7MUuEoKo9 4qA3XJkXgKfDjAOWYPDO4My/Jii+w6I7Z7lD4Sie/GNdH0rVt+g9alI2nw5F/ho5xCOY nUYLgUJDtFBxBR+TlE3Sh7PAko6lKMXbA9rfQshE8EWBillRAM17DtSf2oPRzzuOyVt7 uxzfkVIk2lM+6bUnPXAstM+pe4bohLyzN0uNHvCX/bEDVYJMF5zanPd3ws14I3mwznm0 MAAg== X-Gm-Message-State: AGi0PuZ+oxbeTeeB/quWI/TT/S+z3VkgXW+/LhvVnoNUsrBbgN921LGi HOITNyeqlGeA1ZjKZap269JQqUYSxp47HCbFzhI= X-Google-Smtp-Source: APiQypKeUdcbm7tHk/y33oq9oGLVJlXo99XJVgq7G0Y7uFMjUhWWime2C8bCVddAjvwbSZYSXqhrljXsF+upBNZngEY= X-Received: by 2002:a05:6e02:c25:: with SMTP id q5mr7378028ilg.97.1586357651643; Wed, 08 Apr 2020 07:54:11 -0700 (PDT) MIME-Version: 1.0 References: <02998bd4-0b82-2f15-2570-f86130304d1e@infradead.org> In-Reply-To: <02998bd4-0b82-2f15-2570-f86130304d1e@infradead.org> From: Alexander Duyck Date: Wed, 8 Apr 2020 07:54:00 -0700 Message-ID: Subject: Re: [PATCH -next] mm: page_alloc: fix kernel-doc warning To: Randy Dunlap Cc: LKML , Linux MM , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 7, 2020 at 9:30 PM Randy Dunlap wrote: > > From: Randy Dunlap > > Add description of function parameter 'mt' to fix kernel-doc warning: > > ../mm/page_alloc.c:3246: warning: Function parameter or member 'mt' not described in '__putback_isolated_page' > > Signed-off-by: Randy Dunlap Thanks for catching this. The fix looks good to me. Acked-by: Alexander Duyck > --- > mm/page_alloc.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200407.orig/mm/page_alloc.c > +++ linux-next-20200407/mm/page_alloc.c > @@ -3238,6 +3238,7 @@ int __isolate_free_page(struct page *pag > * __putback_isolated_page - Return a now-isolated page back where we got it > * @page: Page that was isolated > * @order: Order of the isolated page > + * @mt: The page's pageblock's migratetype > * > * This function is meant to return a page pulled from the free lists via > * __isolate_free_page back to the free lists they were pulled from. > >