From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36BAC433E0 for ; Fri, 12 Mar 2021 22:16:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 435BF64F51 for ; Fri, 12 Mar 2021 22:16:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 435BF64F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE12D6B006C; Fri, 12 Mar 2021 17:16:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C91C56B006E; Fri, 12 Mar 2021 17:16:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B32046B0070; Fri, 12 Mar 2021 17:16:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 97EDD6B006C for ; Fri, 12 Mar 2021 17:16:52 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4D5D28E5A for ; Fri, 12 Mar 2021 22:16:52 +0000 (UTC) X-FDA: 77912633064.07.F88CCF5 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf23.hostedemail.com (Postfix) with ESMTP id A0BC1A2E06BA for ; Fri, 12 Mar 2021 22:16:48 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id u20so27363439iot.9 for ; Fri, 12 Mar 2021 14:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ow2p0xO1hotn6RJOItrtDiyN/JeHanAbeq4vQ3SfL3Q=; b=ca8qSuxHMylJkf9hpLyRjp/Lol2CkO36rE6egf5H5JN5eI3b6iTEL/fbQnmfD7v8RO yZWhE84LScpT7GbGaqCoAaP0WaoREHhGnBmlZN5HTtwRcQL5uQ4U1b86yAr7SHM7AKtl ZtRUX0KButFkQukRno//Ub+D781me/+qZ7nlmeqE+By32gH/DPuRaX5hBoNJOYYGOTPf AlM+aytVEXO0CdK/7+6/r4TmJj+k85QG/VGkdEdCPfxaI6y9ZkBLiO8MV3FnzitzfrZA tMg6yZWfvr8ee8xR6PYOYlKUJtiPIxMMUaFdoJ4wlgDr/U+OtXRtd2Bomtnt+BwF6t0S bYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ow2p0xO1hotn6RJOItrtDiyN/JeHanAbeq4vQ3SfL3Q=; b=bkEpGS7ZSfGj3dtAZA9IHhmAu9t0bnNWqiEh2zErpbB8yGTywnQabSS/MBr4aQy0+U pwseSoWTZeAQtEMr5ANhQMzZGsVQ580Ie6/WbBzuUrjIw9tzAQV5DadBcSRbwTeUr/mk WAZO8eCiOtT4yQXdTPATu0OrbNQ6921g3whizFgCZEWh+B6kW7JkV99eu68KqOvsccei W2C0XsAerDObh0pRUthRnT1L+P53EX6jkUPCwIJDDJBmVPTZrU9aMwYFi60WZRNA8S20 XJjvb6bU4wFpCW0k4IfQnA3n4EWPIaQpz/EGfWkl5UT04NkhX+OUqS8Y1QQXpvTJM2f2 hNnQ== X-Gm-Message-State: AOAM530uTjsF5wHr8/ciy+mPv/3/EJUqsjfWfpwVmduhUHncqZoPTiG9 fKZyRcRpo61/GqwUo60o3vfgrN1nEm35VkGSnpk= X-Google-Smtp-Source: ABdhPJw4pENv2yhmlx0fcfNkJOaKYdFrSOwU7MnjJ4DmsXBoc7adHRZNZlntn33952ydymnXbYqzCKVZOzwv+b1gXE8= X-Received: by 2002:a02:53:: with SMTP id 80mr1335477jaa.96.1615587408621; Fri, 12 Mar 2021 14:16:48 -0800 (PST) MIME-Version: 1.0 References: <161558613209.1366.1492710238067504151.stgit@klimt.1015granger.net> In-Reply-To: <161558613209.1366.1492710238067504151.stgit@klimt.1015granger.net> From: Alexander Duyck Date: Fri, 12 Mar 2021 14:16:37 -0800 Message-ID: Subject: Re: [PATCH] SUNRPC: Refresh rq_pages using a bulk page allocator To: Chuck Lever Cc: Mel Gorman , Andrew Morton , Jesper Dangaard Brouer , Christoph Hellwig , Matthew Wilcox , LKML , Netdev , linux-mm , Linux-NFS Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 65rho6c1i6wna9jr1ezma88izpjkojux X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A0BC1A2E06BA Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-io1-f43.google.com; client-ip=209.85.166.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615587408-432047 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 12, 2021 at 1:57 PM Chuck Lever wrote: > > Reduce the rate at which nfsd threads hammer on the page allocator. > This improves throughput scalability by enabling the threads to run > more independently of each other. > > Signed-off-by: Chuck Lever > --- > Hi Mel- > > This patch replaces patch 5/7 in v4 of your alloc_pages_bulk() > series. It implements code clean-ups suggested by Alexander Duyck. > It builds and has seen some light testing. > > > net/sunrpc/svc_xprt.c | 39 +++++++++++++++++++++++++++------------ > 1 file changed, 27 insertions(+), 12 deletions(-) The updated patch looks good to me. I am good with having my Reviewed-by added for patches 1-6. I think the only one that still needs work is patch 7. Reviewed-by: Alexander Duyck