From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853A9C3DA41 for ; Tue, 9 Jul 2024 14:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272C96B00A5; Tue, 9 Jul 2024 10:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 205A56B00BE; Tue, 9 Jul 2024 10:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3CA6B00BF; Tue, 9 Jul 2024 10:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E18396B00A5 for ; Tue, 9 Jul 2024 10:57:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6AB68417DB for ; Tue, 9 Jul 2024 14:57:07 +0000 (UTC) X-FDA: 82320516894.01.7BBAA69 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf24.hostedemail.com (Postfix) with ESMTP id 83D95180016 for ; Tue, 9 Jul 2024 14:57:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GULzBG5O; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720536991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TGP78oa4Q8trWeJFoXv/gZ8zqFMpduK6EZ81uys4LZQ=; b=XJOXcoBvZUhCBxqR+Umh4FE5RPlX11iJMQE81/2JquQvCVj97uIJ7y9Fa9X2wXTysfQ49+ K/Upc5IrU4Ec2KUISMGF6dTBUCon5ryGoOLpenRgIRgfxFZIGH8NgQtLghmg1PqMUMRBgP Qe4vcU0ltpP6rG2MC7Sz7w/TylWAb1U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720536991; a=rsa-sha256; cv=none; b=JEcO7NkIY05+AQSWa8T9fYYU24+2zVBigswDss+33e9/3XU3bimpq4TrblO+++8uuSKx3z fVMIf5/68TRgW76WhaOtEdpDbD57+kE3UOYYGBM48vmwsPCl3n3LQK1rymXBmyobgrdQs/ 2Lla7UKCqk1P/aidDwmOi7arLUrNxXE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GULzBG5O; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-36798779d75so4625278f8f.3 for ; Tue, 09 Jul 2024 07:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720537024; x=1721141824; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TGP78oa4Q8trWeJFoXv/gZ8zqFMpduK6EZ81uys4LZQ=; b=GULzBG5OQThYPHLY4KxbesQS3xDKkJT2g8lIsa4KvxxuiMyH0x3p2lXOg6ta9iJhC2 BvTXHA/+KMJACvQzc2pSHNWybj3ykRm2/7cXqbcp/c6hEo7ML7a2bhkeJupxtkJm6UnE Im88VEn9M/3JEJz8Y4rfOAuAwHWjvA0uiipcKo2F57ac63+l/5v901lN1FZ8eAq29cja AtZQD6Eug2ZnUto8sW1BYDKRFmFZ1e3+N6GBBCMRReoA0UKMeyPNG4moJ1gFaqG55zeW YrwB9A0BuwQHlHwr1zXSgCNuY5TpDZdUYFZ6A40JfbC9wWlSzkzQmOoeNX8Erd/x2nok 82lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720537024; x=1721141824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TGP78oa4Q8trWeJFoXv/gZ8zqFMpduK6EZ81uys4LZQ=; b=ZwThS2ydYp5BwzGNrr7d9IVe7nl76lv6wQYJBT1ySQQhort6etnc6HPe1oj4aetuIO EkOs4JZ0nGfVEzKgVrxiBFNxusakx3755objh9S3TxyEIRmVE08KpxIL6zCAfhFyYwyv PR1K4sBZG45c/8h48i1+T7zeGj6dA/8aetIkzbX5ZgMga/SJBNuog83pnpP+4R7RSpO/ BE3tOc76SdG9WneKCWGtqJ20ydZNT7Zd/TqticYkPKTz4n/EMd8WMCqVqqIYhhIWrCDS ZiayOQKP98eJ1p6t4AvqF/+8H5uVVg7NMs+lLdhul4S2J0/LOFrLdjVGIhTOizgPVwOR 2eQw== X-Forwarded-Encrypted: i=1; AJvYcCUPVrHsk+8yarZRuk9f/AuofbV8RAkTpfgOZdTTyaYktMEtqdcdkzfG1cCFv4MY+DcQ4QWlq9iaT1sLdo/klSNFdjM= X-Gm-Message-State: AOJu0Yxlwnb5FNgIUnUi4hh623oQNsCFzIO/kdOprzB2fgXfo5wbflZp OMvn9UbclqCjW/ndhPydpNVt64/1E0UHoXuD1I3VIN3kIjBs3iE3R26xFw5J/GFVp2FoxDHMxrZ 3VvMDYktVFUj7RcDzySsm2TWAUpU= X-Google-Smtp-Source: AGHT+IFftnKHZMj16Ic6EO/cWEKP2Brpaqf++vaF4SjaXWM9Nok4ZOTK803ow3PbVjGrqZPfXi5GiRSoYvnusza54Rs= X-Received: by 2002:adf:a38b:0:b0:367:89e6:e28c with SMTP id ffacd0b85a97d-367cea67d63mr2613384f8f.17.1720537023803; Tue, 09 Jul 2024 07:57:03 -0700 (PDT) MIME-Version: 1.0 References: <20240709132741.47751-1-linyunsheng@huawei.com> <20240709132741.47751-13-linyunsheng@huawei.com> In-Reply-To: <20240709132741.47751-13-linyunsheng@huawei.com> From: Alexander Duyck Date: Tue, 9 Jul 2024 07:56:27 -0700 Message-ID: Subject: Re: [PATCH net-next v10 12/15] mm: page_frag: move 'struct page_frag_cache' to sched.h To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 83D95180016 X-Stat-Signature: 3139tkpt87sf8n6ei177o9azi4xwijtd X-Rspam-User: X-HE-Tag: 1720537025-42217 X-HE-Meta: U2FsdGVkX19Y3poJ0GJl9DP89/fUV/pSNQ7KdjEI9lXgElVyE9qNKbUYqlYPFugq6X1gtD4JYjfHMNoszcO0IfufkTf6T0BQjc2kVK9inzkjiCf6rBW7zYqGkBd2yO4/Osl99maddAoWA2GSUgEFWUt8qYjD9Lfs1NUqPutxLJkbqUy99bjEKcrfMQr7VZ0/SFxYpaA8LDKjg90z9iLn2eIs6BBM8RR/7VJyqoz3tpL5anOzenZ95HElh5Pru9/RgHJHDMwFl+OXbomYwxwosMy+wWyCTDbs7SUISQwzD2CQd5WUmJQScbM1A1VTGSzWEVS/aG2mcoolU2PR5EZKN8OG1LuqLs9Mr3EXAQZpZMGi42gvRmB0DMeEXBYPjt3ihflCeLh8QdnTsISB3tTrT9GypHJpmGwg0w/zuGkWTVP/vBrsLaYmtlRA8wgJ50MM8gaL+yK2yXe27xEJSCZk9vFB8rEjKdhw8A3n2kpQ1Nuk7xzTpFTtTSlZiSMvcUuU1GpkBdCY536g8LZld5VJuAPG2+pmPdkn5Lq43aent4eYsnBxpbRvdGJsXRuHN9fHzXSQ8bcb4mtuIlkFRnmAnafoq4fD3vkMR0mDevqT2JJttSQaSs9fhqGGtAnLaz4P6wwlNScvT8dx+0t9Q7mtNI/JT+9wAlkPnxZyo7Pn0hS3jVG8zAZxpSeG+KLmEspzNkLRIbklcvxRV28GiMRjqOYTop5Ibbbkp+DBcEJBLo/sHNYcKHWgkxbjo3JcHv8ZltCfy8OLtTmXGjwNcmNCQaN0BHWKc3F9QyWHYtZ9JZLmYSCaYagnroIn5FDpudbH0EKNpoDSyiT5Gh//bG+FRLHEUz0h9CSsaB7jljmmMphScV54OFnP8yk6f8nJRV1yISU1NPTqU47/xM+8S+8cUBHMQ+tSVx2QU90AgSMAPUdssWTKHblYYsqvwa8gYgfuDStGdUM47VDazxwsUjB rvaHluIb ejxcH/rsBuyXGaxAHSbVtun5MEfxHE9ngfsAAYFKDB1C4CaB5DOFPv0xTsFTOtd3Z+j9bw7TN6Pwh3xokhFVvJ5wvxOjsHBrkAvBRuLy6XFEZ7pKUn98yyVWnjhdKmC5i5/xtr4Zw6P7eOdKyVGq9bxtPkjNqLNLXBooEwQuA2To1FpBuJUZTTbg4cUG79mi2bpGBchSVx5aeyDE8zxoW1Ta/Jq9Z8w97SakIqdSMxS4fbj1I1J7o0opoYoSQguBfhePwtSO1Tnp1DfcLvbsyebBvtYokBTw5yqM8kUlds1FysCwIDZturZ6u8QuUimX/4gt9E30t41NoX5GN7ynGIPpIM2TVXizHYb/2VMGchQURPEq2WTgIXDzKHP2jBtSztQJRbonuYDYz4V4yvJz+uU0MHYPInxPNHAy7rnaU38ei7Rg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000561, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 9, 2024 at 6:31=E2=80=AFAM Yunsheng Lin wrote: > > As the 'struct page_frag_cache' is going to replace the > 'struct page_frag' in sched.h, including page_frag_cache.h > in sched.h has a compiler error caused by interdependence > between mm_types.h and mm.h for asm-offsets.c, see [1]. > > Avoid the above compiler error by moving the 'struct > page_frag_cache' to sched.h as suggested by Alexander, see > [2]. Both the title and this description are misleading. You are moving it to mm_types_task.h not sched.h. Also I am pretty sure you could just fold this into your second patch where you moved the code originally with just a tweak to the description explaining the build dependency issue. No point in moving the same structure twice within the same patch set.