From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D642C2B9F4 for ; Fri, 25 Jun 2021 14:18:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 298FC6109D for ; Fri, 25 Jun 2021 14:18:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 298FC6109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C9636B0036; Fri, 25 Jun 2021 10:18:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379356B006C; Fri, 25 Jun 2021 10:18:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24E9E6B0036; Fri, 25 Jun 2021 10:18:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id E657F6B0036 for ; Fri, 25 Jun 2021 10:18:19 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0ED16160CE for ; Fri, 25 Jun 2021 14:18:20 +0000 (UTC) X-FDA: 78292451160.32.58EE045 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf14.hostedemail.com (Postfix) with ESMTP id BBA08C01C091 for ; Fri, 25 Jun 2021 14:18:19 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id n2so4242661eju.11 for ; Fri, 25 Jun 2021 07:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e7odR4aMn5lHoU/Eflc4EvN4jyzHUqkEXilkSBCcXS0=; b=tNNV+jdgQMXQTyxqq4B42g/wE2Zvlyw8LJRd8d8glsVfoOHx1vNtoUWaZgR01f7FU0 XVbQ1JdTiK0YF93GtIND56AxTsmLdzwXp2hlSTnW4dlPl94/Oo3LJgv83hs7xA/SFlaG rwC0KxO84uz14hsi5lMmoiOgI0BKKAQu+o/u+yCaa/cFYeWiBE+7RlVLhkhzZMfgCn0M +QrF07NpMqJbwdcHvjBc7VtEoxBt+tS+vfRrRZGF2F/TPlOUWl9l7IwYw3hcDL+eUqvb dIyMp7DOD5F/LcEtPLppzc88ejmr4bRyiqYccDwFn7ko+XzGWd7fMKGzVX7un4khSDeR jEkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e7odR4aMn5lHoU/Eflc4EvN4jyzHUqkEXilkSBCcXS0=; b=NeJ+1YhTwQnjiJg9F3L+sZFgSmE3/85z4hpmBejzOE/3UXA6dAt32349H7uk49BJ/a yvjBuAQUvZ7zhPKnJ29rcvStI2MHbp69S0Xbw3K3plq6jin24j7GP9x9FyDTZXWI6ut9 Zlp/Co59OG5JCihuLzHuTNSe/Z0LWVx2MlMvn1ne1R0/F4H5rZCNMvg52mt5yO9kKnAF leODmls6gWKeXkyELudWFRMgRkGSCzoPKyDDE2WFYiGGPaK/7sZcucztw6imZ/e1P6W+ dzFfFLQVa8N3ATF1hlmB9Xf0XT0y6Blt6Aja35Z1WrzdBObEqr5w4zUUjAX/T6fNQoJr zdqA== X-Gm-Message-State: AOAM531UGDJbNZWEO5DW9Q6D5B6PCNBw8xVmD5A0sVaLxgVdrEkttBVE dyk4+DdfcdI5hK/NJUyhuVB1Mfu5bUdaGThh2uA= X-Google-Smtp-Source: ABdhPJxYzkQQM5eSqsayekfeaI3QKu0VxAN0Yv/9gIIBoVNwKStbQCtKVVWGpGQIcIejqm+weh+e8pAJg9dE1VRMXJs= X-Received: by 2002:a17:906:1299:: with SMTP id k25mr10939369ejb.139.1624630698528; Fri, 25 Jun 2021 07:18:18 -0700 (PDT) MIME-Version: 1.0 References: <20210625042150.46964-1-gshan@redhat.com> In-Reply-To: <20210625042150.46964-1-gshan@redhat.com> From: Alexander Duyck Date: Fri, 25 Jun 2021 07:18:07 -0700 Message-ID: Subject: Re: [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size To: Gavin Shan Cc: linux-mm , LKML , David Hildenbrand , "Michael S. Tsirkin" , Andrew Morton , Anshuman Khandual , Catalin Marinas , Will Deacon , shan.gavin@gmail.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BBA08C01C091 X-Stat-Signature: wnykozcqyhdzedoyo6otohqrd87yqsf3 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tNNV+jdg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of alexanderduyck@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=alexanderduyck@gmail.com X-HE-Tag: 1624630699-183126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 24, 2021 at 7:20 PM Gavin Shan wrote: > > The page reporting threshold is currently equal to @pageblock_order, which > is 13 and 512MB on arm64 with 64KB base page size selected. The page > reporting won't be triggered if the freeing page can't come up with a free > area like that huge. The condition is hard to be met, especially when the > system memory becomes fragmented. > > This series intends to solve the issue by having page reporting threshold > as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as: > > PATCH[1/4] Fix some coding style in __page_reporting_request(). > PATCH[2/4] Represents page reporting order with variable so that it can > be exported as module parameter. > PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify > the page reporting order when the device info is registered. > PATCH[4/4] Specifies the page reporting order to 5, corresponding to > 2MB in size on ARM64 when 64KB base page size is used. > > Changelog > ========= > v5: > * Restore @page_reporting_order to @pageblock_order when > device is registered in PATCH[2/4] to keep "git bisect" > friendly at least. (Alex) These latest changes address the concerns I had. Thanks. - Alex