linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-mm <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	 David Hildenbrand <david@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	shan.gavin@gmail.com
Subject: Re: [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size
Date: Fri, 25 Jun 2021 07:18:07 -0700	[thread overview]
Message-ID: <CAKgT0UdVjW_kfeARo3Vsf6fZGPv4r_DEN7+NVp8PN4figkrJmA@mail.gmail.com> (raw)
In-Reply-To: <20210625042150.46964-1-gshan@redhat.com>

On Thu, Jun 24, 2021 at 7:20 PM Gavin Shan <gshan@redhat.com> wrote:
>
> The page reporting threshold is currently equal to @pageblock_order, which
> is 13 and 512MB on arm64 with 64KB base page size selected. The page
> reporting won't be triggered if the freeing page can't come up with a free
> area like that huge. The condition is hard to be met, especially when the
> system memory becomes fragmented.
>
> This series intends to solve the issue by having page reporting threshold
> as 5 (2MB) on arm64 with 64KB base page size. The patches are organized as:
>
>    PATCH[1/4] Fix some coding style in __page_reporting_request().
>    PATCH[2/4] Represents page reporting order with variable so that it can
>               be exported as module parameter.
>    PATCH[3/4] Allows the device driver (e.g. virtio_balloon) to specify
>               the page reporting order when the device info is registered.
>    PATCH[4/4] Specifies the page reporting order to 5, corresponding to
>               2MB in size on ARM64 when 64KB base page size is used.
>
> Changelog
> =========
> v5:
>    * Restore @page_reporting_order to @pageblock_order when
>      device is registered in PATCH[2/4] to keep "git bisect"
>      friendly at least.                                           (Alex)

These latest changes address the concerns I had.

Thanks.

- Alex


  parent reply	other threads:[~2021-06-25 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  4:21 Gavin Shan
2021-06-25  4:21 ` [PATCH v5 1/4] mm/page_reporting: Fix code style in __page_reporting_request() Gavin Shan
2021-06-25  4:21 ` [PATCH v5 2/4] mm/page_reporting: Export reporting order as module parameter Gavin Shan
2021-06-25  4:21 ` [PATCH v5 3/4] mm/page_reporting: Allow driver to specify reporting Gavin Shan
2021-06-25  4:21 ` [PATCH v5 4/4] virtio_balloon: Specify page reporting order if needed Gavin Shan
2021-06-25  5:58 ` [PATCH v5 0/4] mm/page_reporting: Make page reporting work on arm64 with 64KB page size Michael S. Tsirkin
2021-06-25  6:17   ` Gavin Shan
2021-06-25 14:18 ` Alexander Duyck [this message]
2021-06-28  9:45   ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKgT0UdVjW_kfeARo3Vsf6fZGPv4r_DEN7+NVp8PN4figkrJmA@mail.gmail.com \
    --to=alexander.duyck@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=gshan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mst@redhat.com \
    --cc=shan.gavin@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox