From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC657C3DA47 for ; Mon, 8 Jul 2024 14:31:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C6A96B0083; Mon, 8 Jul 2024 10:31:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5767A6B008A; Mon, 8 Jul 2024 10:31:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 465476B008C; Mon, 8 Jul 2024 10:31:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 29DCF6B0083 for ; Mon, 8 Jul 2024 10:31:11 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 958AF161371 for ; Mon, 8 Jul 2024 14:31:10 +0000 (UTC) X-FDA: 82316822700.26.88800E6 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf20.hostedemail.com (Postfix) with ESMTP id C699D1C0007 for ; Mon, 8 Jul 2024 14:31:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KXI6N+wZ; spf=pass (imf20.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720449039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=praCejWfnL4tvn8vRf99MQxNtfzrDObizyuJfLk1AHM=; b=r4yRxge8+0gUS7+A827b/y/4TGE68moCXPziuh0GKaMrore3DoFCNAZWpeEmA3egWFYTYZ dX5ULBk6MK0kzbwYzYCMSZ+9C4ZPNbbPNO/tYkiZfchSuWNDZntGb0X1NrP8LA+CxSBZ5u DkGvjluaiPYtxCMCOm8lxCFopgpxr1o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720449039; a=rsa-sha256; cv=none; b=U3VQnHiS0ah5PHRupNsmzTjzB4iCHZKS9ULhri12nUtG451TchFxKlLZOSTkBA+q3ts92p 3FxJ/XRy42BCsraEvoqoCpS9FCxIxIcYcPP/z6Y0IPFgYLfZ+mVCFTB8GKxVCI46FDu/cy AG4p0gj8WKJdgvGswb0B2ot+142vJdo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KXI6N+wZ; spf=pass (imf20.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3679f806223so2326594f8f.0 for ; Mon, 08 Jul 2024 07:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720449067; x=1721053867; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=praCejWfnL4tvn8vRf99MQxNtfzrDObizyuJfLk1AHM=; b=KXI6N+wZHVs9yNLvfQ9D0w/pFMwfRNY32K7a4u5v1YXa9oxhZSkteRH36wrSw1S+Za zMhz5pOg9JUVzuHoD0sQjRLWbU3BXvGEjwfwripTt/CUDgpWIcBfgGpA2YEZkU2Xem10 aj1gxVoYUH2J7fPq7iH6B9L3reVvyXpb+ruL6J1G6gHz+m9JrDHQ9lW0qxCJUWPFHJUn 4GvVWs1zEvgOrdR85AxgQ/gOXfITaKsLI5ohZoE5uAH1eV6zMHjX9FWgeWWaLH5sAfXn YdE3ule9AM7i8jbQdx/LLmkXcn18q7gety4aMx0BESdMMv6i3Nq1hPwMzip8/BVbsY+W 7bww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720449067; x=1721053867; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=praCejWfnL4tvn8vRf99MQxNtfzrDObizyuJfLk1AHM=; b=vohDr/ICc44IOXQvnLqBzcuccZ2MP6YLAvYcLNyCvZw0I5i4tLd0lW+3urkUPBwTzB wasVTWl67iORt3Ur/AWQnjsKISUrArz/rK1nCewvLodqJ7Ohghp5LPP/Gs85b47XIIbz S7iaSVZ8Snu6ItZ+C8wTLq61vsR9/gkVy/+sO3k4eI+wdEf06tCCdK0y5ihm+WAOrh/V iHwu/rugnPaO1Cm8f8a9MmV75SJuWLBEa+NQWIpF5DQKY0HSqH+RLrtdKT5i+6ZX7rZ7 /jL58W67bhlYoIJD7YsdhHmkLBOMtcMxMECapdngdLpFecWcFvpXyqGHxG9yGz3p2x2k 1jsw== X-Forwarded-Encrypted: i=1; AJvYcCUyNRcO3hxZuDZdCD05fXIrWZHqaPBKYKO/72broA261FnY8I1T0CEyHYHISpy7KRuTMYeMWIkWsi2Gmta/GHrlqCc= X-Gm-Message-State: AOJu0Yx4qIEO+OIcNWpjco4IfvJhqswGykzQUqi6KhebvXB98OSEr6oH Ku/Z02a8kBaxA1u/qIdEh84jSn92tfmHwvl8OYbirNxauDd3q9DRzLt8w4o1HZPx73WBG/PN0uM ZA3EiCSYy7g682yq8bdTrDMUfyean/Q== X-Google-Smtp-Source: AGHT+IFoh68HLd0TMS0+kGGf5MwuNOwxGvMq4ZWjbXeoBxd9S6ujGKoBgyoOGLXMik21GVdPzCHmonPJZKz88mSGP0Q= X-Received: by 2002:adf:e790:0:b0:360:9500:9bbb with SMTP id ffacd0b85a97d-3679f6eff1dmr12024136f8f.12.1720449067049; Mon, 08 Jul 2024 07:31:07 -0700 (PDT) MIME-Version: 1.0 References: <20240625135216.47007-1-linyunsheng@huawei.com> <20240625135216.47007-11-linyunsheng@huawei.com> <33c3c7fc00d2385e741dc6c9be0eade26c30bd12.camel@gmail.com> <38da183b-92ba-ce9d-5472-def199854563@huawei.com> <0a80e362-1eb7-40b0-b1b9-07ec5a6506ea@gmail.com> <15623dac-9358-4597-b3ee-3694a5956920@gmail.com> <200ee8ff-557f-e17b-e71f-645267a49831@huawei.com> <83cf5a36-055a-f590-9d41-59c45f93e7c5@huawei.com> In-Reply-To: <83cf5a36-055a-f590-9d41-59c45f93e7c5@huawei.com> From: Alexander Duyck Date: Mon, 8 Jul 2024 07:30:30 -0700 Message-ID: Subject: Re: [PATCH net-next v9 10/13] mm: page_frag: introduce prepare/probe/commit API To: Yunsheng Lin Cc: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ttagzudemrzpeyauikudwg89noyo9anu X-Rspamd-Queue-Id: C699D1C0007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720449068-246102 X-HE-Meta: U2FsdGVkX18e3gECN4Lv/3nKBHFJrmf25/Bm2rcvWK5WPk31FfqGMMRB9kMiw4D1sc+st6kV22xLC2uRGzqy8E2qSWaNds5kr66LZkKXgmIOFE2xgjqGIFdGIh/NeNfA965BNagoRXla48U6utDCdOL2aQf/WQyhVhHodM0xVY6t+wo+w5ZLgjB1xOjyJhcgo40XWATX0QcFOAckmKkfgrMYycl8oxMlNeKwrsaKfmhS4ltrTKoAbE7+NONmRGrTx8b91CMKaNYtTavSWzL+aC+RWzl1uEGV3I+/xQSwRwCegFegatBU2gXl6oPNEaPwIcqk+MvLliCivOcHtooLuwyt3+h99q+BUZnIofarCy8/J2ysaU1NQVQjQiDZ6ZkvO0TAQFiaQbzQof8K8kqAe6j7DY1gNXpr73Xqesjem9o/gAAgIOWr6y3G/KwD1vjbzvKA7cne9yJJP4ZkldjjCb/x/drp6hq/fmqhw8f+LysFeZi+YyppgZG/QXEE2IYWhNk2qpau5WzsvfWH97/ezCakGUn2ngvwyTyQzp8i1jaMhyP8T9ldT14H+4s52G0IVFzesDzKEs/Viu8qIXDAp2hWZav76v+Z+kjxAwXXL7XiWbTpPfIDUVFNVJnL75FDVA71b1d/OhnMiDZfEjqaovOmWvaURnTwoWiQIZgb4dUqzIQknAAPzIrUIMsyta5GIxgB0sFg3Kt8ig8rQuv+MSbzVQNFxZTh72aMMrx8F6CVGc04Dm96ZhUnFT7ik9py80lpYNJMMk2AUPUSECAuJwfqUhNYq/7MaCIRgo1Hw9QzZdnxgokacyTRSM7obHL1SA8DackA0OYm2ss1n+xSdo27sqHxt/I86K6SKmPtz5zIxs8zakYFVpTMD3/J0PCbQ6lvkmFBBRzVkRApnhS/9F0DCPMubX+q0EiPnroRZgHeOvvgMUloKql2C1+3zar24AoQpJ25fvIfao1JdWl D71aROBJ IEi5WfGsNdpZqhziUBXXFETxqyD4v64qwFixMUM24ecgcDPKi8bCVvaZV8e/UqhpnSXZq6DkyFU6MAMD1243sd/FAO2W98mUt5jpuzxF8cEdIsPNoqjCkdexkAz8+NEbqxSBi4Mrwr9e7FZ5V9tnCgbD+YleoXpFyMZkdsN6BM++wGS4byhoraafzLFCybVdcSZ0ZWtDSBEpo7x0x2vaOvHUXmofZI4fk8lqjMRA86czhBip1jhLJZKm4VW+BrH1sVfJ3OlsJ29cVVz0mMVH78MIjZ6E/Y1GG7taPd8+oYUGcGQoc2ZLynrf7d5Zu1LjBw1myW3rWhv7WC/zGE7cF+v/hcb1aHA0WGhefQbHVLtl8SNCbS4H4ivxOeofhokZ5nog/bqYfZ3UQpiw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 8, 2024 at 3:58=E2=80=AFAM Yunsheng Lin wrote: > > On 2024/7/8 1:12, Alexander Duyck wrote: > > ... > > > The issue is the dependency mess that has been created with patch 11 > > in the set. Again you are conflating patches which makes this really > > hard to debug or discuss as I make suggestions on one patch and you > > claim it breaks things that are really due to issues in another patch. > > So the issue is you included this header into include/linux/sched.h > > which is included in linux/mm_types.h. So what happens then is that > > you have to include page_frag_cache.h *before* you can include the > > bits from mm_types.h > > > > What might make more sense to solve this is to look at just moving the > > page_frag_cache into mm_types_task.h and then having it replace the > > page_frag struct there since mm_types.h will pull that in anyway. That > > way sched.h can avoid having to pull in page_frag_cache.h. > > It seems the above didn't work either, as asm-offsets.c does depend on > mm_types_task.h too. > > In file included from ./include/linux/mm.h:16, > from ./include/linux/page_frag_cache.h:10, > from ./include/linux/mm_types_task.h:11, > from ./include/linux/mm_types.h:5, > from ./include/linux/mmzone.h:22, > from ./include/linux/gfp.h:7, > from ./include/linux/slab.h:16, > from ./include/linux/resource_ext.h:11, > from ./include/linux/acpi.h:13, > from ./include/acpi/apei.h:9, > from ./include/acpi/ghes.h:5, > from ./include/linux/arm_sdei.h:8, > from arch/arm64/kernel/asm-offsets.c:10: > ./include/linux/mmap_lock.h: In function =E2=80=98mmap_assert_locked=E2= =80=99: > ./include/linux/mmap_lock.h:65:23: error: invalid use of undefined type = =E2=80=98const struct mm_struct=E2=80=99 > 65 | rwsem_assert_held(&mm->mmap_lock); Do not include page_frag_cache.h in mm_types_task.h. Just move the struct page_frag_cache there to replace struct page_frag.