From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2043AC3DA4A for ; Thu, 1 Aug 2024 15:22:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC32C6B0093; Thu, 1 Aug 2024 11:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4C016B0095; Thu, 1 Aug 2024 11:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89E7E6B0096; Thu, 1 Aug 2024 11:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 696D96B0093 for ; Thu, 1 Aug 2024 11:22:41 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 371CCA0F1B for ; Thu, 1 Aug 2024 15:22:40 +0000 (UTC) X-FDA: 82404043680.18.48E9F39 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf01.hostedemail.com (Postfix) with ESMTP id 2DB3D40014 for ; Thu, 1 Aug 2024 15:22:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NChe0DYy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722525716; a=rsa-sha256; cv=none; b=CWhR8rXQwhH0NFFYtVyBaNIh8eTSiBTQWxs4xDigmi7VC0FePRCfb6+v8+zxGCUcaIYdFl 6G/AzOrnL1njfHoGxeYgWlqXvRH14OdyvKIMj065KzUnKSGPembTUqbPJgduVnIHC/33U+ IILQF7tEM5Ypq8dJS+3T+rXIuXGB/ag= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NChe0DYy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722525716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Dx2Bv0d2od3Km7MjoXRYzhl1VfhP4WqwsY5gBZHcjc=; b=mPztgzPsos+TTUnq8s2vpO9jHwmVyCFG0IjjYpeH4Yi99vqeimKsewkMP+eCfIcrHwW6pp WkPAzThaMtlxmdt92X1UO1fBktd8ithBtjl/fnpykCORxC8evs2YYkHeQ5Hs7hQuwHee0+ oBfRkDJTLZJafVfsuSOYuOa0JFYj+xg= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-428e0d184b4so6439295e9.2 for ; Thu, 01 Aug 2024 08:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722525756; x=1723130556; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8Dx2Bv0d2od3Km7MjoXRYzhl1VfhP4WqwsY5gBZHcjc=; b=NChe0DYyhV7GmOPedwGNOxuDJxwiswlR5k8OLAHmjbiTiiczw/bKEyAnVw8xtyG3V2 NwgPjIzpQgsrtEcZY30w1x9re6k7b0BAPybXzA/VRpQT1XXUrkrzlqkLY8nMYBalTqGj c1MeSEGWXuXzAzQtmAzV1hCFy1fwJG2OldVJM9hCxelmLCzs7Jyc1lit/jWukWAzp7yh jfXqT7CfA6cYACboQZmTc7OeW/F2/RBfH7jFQh8zIBFT03WznB5AycSQVNI6uHVBvhr2 Eue5HXAjtgyPKGypf71/mCYBTPAxUyYoeeOXuh5yFW70GFXtw5jz4DB3mNXtYFADMIGa uvxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722525756; x=1723130556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Dx2Bv0d2od3Km7MjoXRYzhl1VfhP4WqwsY5gBZHcjc=; b=PyBqeJ4KyeKVjtlMFZtf2j+tAsf27Ufgu5KmzyLUlXL2PJ8kN6o1UWFkyaYcru6lmz put1HEKGBU5OjeuPiC5/tNfdb85qzZI9AP+nLjiA18IkEbKEVfYZe/KcQItmxs2px/PR 9sYaPqI0eM8nd/UIr56NrLG3Qdqm8XqNI712/VEnacHPCATGmaJIMpOLwJAjlk7PuV+F 3WLYiifcVHJI9o+rrTAZjF+OAcuhqo04wALruqtapJHVgzTOkopgHwQZMkLjBUknccsP YgFcrbFkCqhF3FKogQHAsxe1Oz9CN9Kf8aKLkY5vRLkKoRK0uj2y2w3y/kWRfCOUP5GX UE3w== X-Forwarded-Encrypted: i=1; AJvYcCXr+PDc2kyKeAuxJ/AY/3y+byZwR8fHxUTWQfTqJ/w/MlD4Op74ThKS/toQBXhnUHkNOVjUTs+k868Jv2CqZBNF6xw= X-Gm-Message-State: AOJu0YzUGQBOnf8ikF5GkPU7+zwhVVdar3M+SrVk12ne9ugkZGwHb8aF uwitQ0yLSXSfQghkZUu/pAuy90P7yv+D75fWMtoj67Ln9zkHwTEFvpqjNdCXE13bA8i2JtX82RX dwO//jNGbFiVZelQk1Ok+uybm2ew= X-Google-Smtp-Source: AGHT+IHJwpMJUuvVBDGd0+iVwndbV1UbEfs+MYBNb+0c/veShsqCR+fklPSjDi/gK00dEDB9UQYZf/nj06+15imHIwM= X-Received: by 2002:adf:f14d:0:b0:368:4bc0:9211 with SMTP id ffacd0b85a97d-36bbc0f3459mr125871f8f.17.1722525756248; Thu, 01 Aug 2024 08:22:36 -0700 (PDT) MIME-Version: 1.0 References: <20240731124505.2903877-1-linyunsheng@huawei.com> <20240731124505.2903877-5-linyunsheng@huawei.com> <22fda86c-d688-42e7-99e8-e2f8fcf1a5ba@huawei.com> In-Reply-To: <22fda86c-d688-42e7-99e8-e2f8fcf1a5ba@huawei.com> From: Alexander Duyck Date: Thu, 1 Aug 2024 08:21:59 -0700 Message-ID: Subject: Re: [PATCH net-next v12 04/14] mm: page_frag: add '_va' suffix to page_frag API To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Subbaraya Sundeep , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Eric Dumazet , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Geetha sowjanya , hariprasad , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2DB3D40014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gn897uia9j5qqg6y5yc7uqsrkpyjyqor X-HE-Tag: 1722525757-22357 X-HE-Meta: U2FsdGVkX1880NqrFAnW0giVtsSjJsSpOrZXzRhmnWV2/L8ItM4OOT+HGDjUQyElXMDu02xAEM0rR8H7C5lUEfML8aXfkJQdPNDzoT90oIuus4yhOgVIxAV4L1Je7tAheqDFzr0TXE7RWny3WrZZE94QkN6QxRwd/HzUy9d+cPr2nZmGZXcAsHj4xZB1ZTff9dmFZMrO0pXZ6Dpcda5YrtWUwba7VjRGDBjNkwLQEsBZk7fj+yMsX3NpniCS4n32ycxoHdocQiwub9vpr7+J7W20XvgCr7SRjo4SqXIcZWtRX2Yw7RUMcvbT2oK0MJbVuB+GOB3yuB1zIVQHVASkNZq9kYz07EOh3C/ILTl0yF3PORDin3rqqHOZ5teKAbQALtcZ6qKkLZug/DpdRz9f/Nq5osfxVEAIf6hmVzEamqB5k77MfH1Bj7s/K9aCnXqh52FdnImAvyd0CX/XEOkFPtEp4kMlsQBLhVV2hx1VrIOyerQQWXXIBapolRhm5HivSqCR21psLBUhJwx847BOUbDdVd9Km/ML3gsOKgDlNo+PYTbMk0+6qvq0BlHWwz2epYBprSmYH4/qWw3kfHM5lQgu97952PyvxxuX0IbkNRrG+AnjOCOzocGNhnfU3yLw/MwzjxCuCdfQSHg3T2stmysmCUrv2DXM/PwD06p7oJgX9yh1twuCFl9qMVL5Vg1bqXNoMenp9Ugd464GmAL+7Vghuxb+kj/haq2FDZVlCqIZ8XAUhV2y+RxVHeQSzxhRb/VePMHWgGiU/v6eaRZIC/47KrKYE/WOEggV2UBE62TWno3yPvhjdPQj8jf7cG8tfW2hqnINekzNNUCoQzmbKOuazswfg+jybgK/d1udFSA7Uy+TLyYmt0/4JkRpZ4RdWIrcMvxp6dx/kMn0PuOZnJi/BPbzWnaBH4WOyoBbYRRPHhGUXJ5Zji3k0LE2bYYWG5/MG69vZX+1o3D8fja qOvOkgah gIwg1s1lih4Xo9Y3xnUMnlrBYbG8RFt9IdTnkvY0xbJtluJwi9+7gL1YDTNBZaqYeUl0buKEy9wCyb4thLk5YCCWLEejKPuOJQXRAuqIlRH+LJJInME4ZVO8t0sBU5Yk0Xlo2ODOA/VozW6EFS0fq7ntQVwY+Itx9BcOVpyFiuLcQYpSoqiIXR61G5zaV4V/JTYIg3lgfmIycWJGmTQ/tNC0Jt9t7flKG1uR3O8+c/gPRbRl7jHNPbxfL3jh+3I+KCQ9Ghjo2eMjEuOAWqNBfZFCrsVufvUPZ5alKVIjMo6zd/f1WaI1ZsV9wvIWovPVzh7MPpp3ul8cPUjbNmXIkzd+ZugZ6JpKriu+byc+dB2lP+PdVj9EFinZ5OlofMquGvDwoD5oiMpSlZ6kt+Qh8YCJNo8tREcIwItNOWxwPtu1Az3HyNlWFy5gy+yhYd5dj7uWXr93zjXLU6zsfCGgo1P6cGtKNUAqdZgaMx19LMtmjpN9EL5rQBMt+qkdsjGliNgvkT0Prz4SxG2paLF/CPYltf8txZBY2UNmrIJlLQGsIUaaLMeZxuN1+r79AjSPvZZf6jbh6htFtCFaqlU49ffVQWecM1hX2z5G/D9d3dC/JHX8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 1, 2024 at 6:01=E2=80=AFAM Yunsheng Lin wrote: > > On 2024/8/1 2:13, Alexander Duyck wrote: > > On Wed, Jul 31, 2024 at 5:50=E2=80=AFAM Yunsheng Lin wrote: > >> > >> Currently the page_frag API is returning 'virtual address' > >> or 'va' when allocing and expecting 'virtual address' or > >> 'va' as input when freeing. > >> > >> As we are about to support new use cases that the caller > >> need to deal with 'struct page' or need to deal with both > >> 'va' and 'struct page'. In order to differentiate the API > >> handling between 'va' and 'struct page', add '_va' suffix > >> to the corresponding API mirroring the page_pool_alloc_va() > >> API of the page_pool. So that callers expecting to deal with > >> va, page or both va and page may call page_frag_alloc_va*, > >> page_frag_alloc_pg*, or page_frag_alloc* API accordingly. > >> > >> CC: Alexander Duyck > >> Signed-off-by: Yunsheng Lin > >> Reviewed-by: Subbaraya Sundeep > > > > I am naking this patch. It is a pointless rename that is just going to > > obfuscate the git history for these callers. > > I responded to your above similar comment in v2, and then responded more > detailedly in v11, both got not direct responding, it would be good to > have more concrete feedback here instead of abstract argument. > > https://lore.kernel.org/all/74e7259a-c462-e3c1-73ac-8e3f49fb80b8@huawei.c= om/ > https://lore.kernel.org/all/11187fe4-9419-4341-97b5-6dad7583b5b6@huawei.c= om/ I will make this much more understandable. This patch is one of the ones that will permanently block this set in my opinion. As such I will never ack this patch as I see no benefit to it. Arguing with me on this is moot as you aren't going to change my mind, and I don't have all day to argue back and forth with you on every single patch. As far as your API extension and naming maybe you should look like something like bio_vec and borrow the naming from that since that is essentially what you are passing back and forth is essentially that instead of a page frag which is normally a virtual address.