From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 617B8C31E40 for ; Mon, 12 Aug 2019 15:20:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2006120665 for ; Mon, 12 Aug 2019 15:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W1JJqGlN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2006120665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B11AD6B0007; Mon, 12 Aug 2019 11:20:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC2366B000E; Mon, 12 Aug 2019 11:20:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D9786B0010; Mon, 12 Aug 2019 11:20:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 7DF7C6B0007 for ; Mon, 12 Aug 2019 11:20:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 2F56E281A for ; Mon, 12 Aug 2019 15:20:55 +0000 (UTC) X-FDA: 75814138470.14.table68_2514b73193e21 X-HE-Tag: table68_2514b73193e21 X-Filterd-Recvd-Size: 4580 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 12 Aug 2019 15:20:54 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id r20so10317106ota.5 for ; Mon, 12 Aug 2019 08:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y942T0sqUtRFxvyP+0sjKx+0c1PT5SZ2qa8t2fKDAFs=; b=W1JJqGlN7ks0BxXMoB5/KNFf0nROJKOybkqJ3cMs4ab0iL75KVUafriWVN/E2cXEcY O3K1ggu/sQaRj/xiNZ9O7MVWaLBiZMFdO/1MnRO6Vk7ME3/5peR5kdpkxJuB5oyachfk 8A1p9DZAF9gn9rQq4QW/RoiO9zf46h9rMAh9Ngv1G3Mxc8W8iKJU1rZhENWpQoBn1MkR q/rd7cfqkWyzM2uJ71cL67Hm2hPCH/+QkjFnruZEGUER+hIwreqxsfn5TzbhXzuO8BZc qd8my03dztvuYLIviS608mRiHqNoxRJ2sL4KscopZRh1NZJKF6FXfZ2kl0V6Z2nAkT5k 67PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y942T0sqUtRFxvyP+0sjKx+0c1PT5SZ2qa8t2fKDAFs=; b=cYL0HFgHhK1Ee6omlGRtHjWKiIaq/Sm9CkPbD1tl4QgK6s2Vo5MVYchOJZuBRj9O02 uxCcdTugEsreuFziXeVayZytbcd30IyaZ2MCDtIsObjCuHroN0iQ2GeKdiRtTmuM8KVX 38/dg+HM/oHZ1LeoBa04j6sWiXodIH7n8bk1Dsqyqz0hUYyvetjEbgxwvjMVwYLy6UiV q711LEOUKs/pNY9Pge/GkN6SEeiMEQ3sjcVVZ6+Ri75/sWJ+fWqzC63XzaCf8zP6oZQH eO19zi4PgzKkVAF2bVkZpwwe4tgDSQmz8NaxeqaN9SDhejvMFEd5jdTK0R98AurZIDJX SNng== X-Gm-Message-State: APjAAAUepXBE8mssVBFAjWbd1xPk7abW1RoKxp/pGUS9ZCtxCGho9DLf xce8JP+xneomFrPY/LUQG7uLa76tFHSSwXOVV18= X-Google-Smtp-Source: APXvYqy9RJAJ67fbKLDTn0LncfVL9ev90bkQOYTqrem2KxlTH8J/PW8bomoaqWAAmMVPPE6mcs7yIw7PbWL3Dvd97d4= X-Received: by 2002:a5e:8c11:: with SMTP id n17mr33490391ioj.64.1565623253892; Mon, 12 Aug 2019 08:20:53 -0700 (PDT) MIME-Version: 1.0 References: <20190807224037.6891.53512.stgit@localhost.localdomain> <20190807224219.6891.25387.stgit@localhost.localdomain> <20190812055054-mutt-send-email-mst@kernel.org> In-Reply-To: <20190812055054-mutt-send-email-mst@kernel.org> From: Alexander Duyck Date: Mon, 12 Aug 2019 08:20:43 -0700 Message-ID: Subject: Re: [PATCH v4 6/6] virtio-balloon: Add support for providing unused page reports to host To: "Michael S. Tsirkin" Cc: Nitesh Narayan Lal , kvm list , David Hildenbrand , Dave Hansen , LKML , linux-mm , Andrew Morton , Yang Zhang , pagupta@redhat.com, Rik van Riel , Konrad Rzeszutek Wilk , Matthew Wilcox , lcapitulino@redhat.com, wei.w.wang@intel.com, Andrea Arcangeli , Paolo Bonzini , dan.j.williams@intel.com, Alexander Duyck Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 12, 2019 at 2:53 AM Michael S. Tsirkin wrote: > > On Wed, Aug 07, 2019 at 03:42:19PM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > --- a/include/uapi/linux/virtio_balloon.h > > +++ b/include/uapi/linux/virtio_balloon.h > > @@ -36,6 +36,7 @@ > > #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon on OOM */ > > #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */ > > #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisoning */ > > +#define VIRTIO_BALLOON_F_REPORTING 5 /* Page reporting virtqueue */ > > > > /* Size of a PFN in the balloon interface. */ > > #define VIRTIO_BALLOON_PFN_SHIFT 12 > > Just a small comment: same as any feature bit, > or indeed any host/guest interface changes, please > CC virtio-dev on any changes to this UAPI file. > We must maintain these in the central place in the spec, > otherwise we run a risk of conflicts. > Okay, other than that if I resubmit with the virtio-dev list added to you thing this patch set is ready to be acked and pulled into either the virtio or mm tree assuming there is no other significant feedback that comes in? Thanks. - Alex