From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741B8C3DA64 for ; Wed, 31 Jul 2024 18:14:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 845186B0082; Wed, 31 Jul 2024 14:14:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F5786B0083; Wed, 31 Jul 2024 14:14:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66E896B0085; Wed, 31 Jul 2024 14:14:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4A0936B0082 for ; Wed, 31 Jul 2024 14:14:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E8841120210 for ; Wed, 31 Jul 2024 18:14:34 +0000 (UTC) X-FDA: 82400848068.03.8872643 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 01B81180011 for ; Wed, 31 Jul 2024 18:14:32 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Fe/rZpMy"; spf=pass (imf06.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722449668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pp0vWyL7VeDKadleGOEHNTdhDMPNVXeakIX5tgvvsCU=; b=u54+Y4GccLA7FrHlmo6ttRzFtfa60y8t71IYT5CY6fM9/g0x6k+K5Y/hdWcXq44eGZoBfF /W4hrgpPtSl6kNVUNkH+3KmYNBsYGPiQlQ62/wvTR+f5SN+QPqRJfhTQt3h7k2yH49smVz zAVGKZj1snpSuG2Ls+JycHg2F9iDpyY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Fe/rZpMy"; spf=pass (imf06.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722449668; a=rsa-sha256; cv=none; b=AkdphGLIzpYSqzjEe6F8Bb0BSUzsNtNKYOTUPOb9uVQu2IOY8hyem+231Q3v9X3uFK2hTG gWqCSllZJ2yMVJDELUqNM3r5aX0iazC60kJvpd0Xhx8z69BgmzwlNhnI8U1In/2MzPWBuE AuLH/UAh7NawYdSACEiuHeSy6WyGs+4= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-368440b073bso861449f8f.0 for ; Wed, 31 Jul 2024 11:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722449671; x=1723054471; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Pp0vWyL7VeDKadleGOEHNTdhDMPNVXeakIX5tgvvsCU=; b=Fe/rZpMye6o+8vvpKuhfQv2gkcl/S5sCadUELHLMlnJ0mVPp7JW9UmxZTxa8vG5vAd Iw848MHOa5J/FsCxzobfdPrTeMG1X3ba1uGdROnegtPuZYxikwlBa8akTY7CH0cf14UG pNR1CHT2G1AY3CM/M0WEc8bToQyqM5bWck542siIW96fgaQyVgRmbpN1e0BWG10WWKAA fbvdN9uDxGdkXXVy8spYmhE7b3O+WAIITUeajrzOW7phuVLVLaNcGgwcoltpbKqWmzHl WvldRZIscqggqKe9QHZaWH13OuoyoTi+1M10KT1U8G5g+q4bTuiCUoSZ+9AgqQ63HIxz A4nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722449671; x=1723054471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pp0vWyL7VeDKadleGOEHNTdhDMPNVXeakIX5tgvvsCU=; b=GJ+O7S1wg53efmkRgYrywnvPEVflgM3wWKejkG9W2rw5mPFecIbUDrqQTkKBlH6KBI xyyFLxvfd88TMFRcXxsFe2I/ZSsMXigiAmqh9aZYchJhgY3KKnkYAyQUKZ3i6Oz2PSam IeS6J4jdCdxRnZfW+Zg/kKe6hEidFQt591s7qdCF73ary/1J0qmdSUthZIUiQCE/F/f0 gGOScme78zmyacx+gFitYhUzk7LsVewID+Whq0Z1ONxqEyE1kprXPLmDJWaSIJym/Ypv xu51F5lrdwBqZxNi98Y4GOMeDGrYdHPjUEbpeFRMOOjllYzK5mOVUBSCkfsMEYrr+JPJ Rf8g== X-Forwarded-Encrypted: i=1; AJvYcCWInLMqx+juOU61HHLnpOHf9363xRqPW0idWw8kLRXZWgjn7TVoNDvMGnMcpn87Y7xxtR/Bqcdn12vR9dax3q3Qn20= X-Gm-Message-State: AOJu0YxnTACROOZUkJXUeazBpscNY9EJYeMQ3Lzn0HYfZmNi6fkgNwuK 2ZxyfmMAdl29ESbWu7f2EEeiRx+KAdVSVXiw3ey2LSfcy2VDAmwfyQRzNH4QKjsyZrvpZfvI7r8 6tdI5GwjPmS89s3TqrB9Jttb2IEo= X-Google-Smtp-Source: AGHT+IGv2ta3BQ/aeYaFuo6uJnDIs2Oh1PDBCcZrH55JaT3W4vssxSHelAFkF3XSYf9nggWCe12LvyT/WHK2KvkPs3c= X-Received: by 2002:a05:6000:4582:b0:365:aec0:e191 with SMTP id ffacd0b85a97d-36b8c8fdbdbmr4052808f8f.21.1722449671103; Wed, 31 Jul 2024 11:14:31 -0700 (PDT) MIME-Version: 1.0 References: <20240731124505.2903877-1-linyunsheng@huawei.com> <20240731124505.2903877-5-linyunsheng@huawei.com> In-Reply-To: <20240731124505.2903877-5-linyunsheng@huawei.com> From: Alexander Duyck Date: Wed, 31 Jul 2024 11:13:54 -0700 Message-ID: Subject: Re: [PATCH net-next v12 04/14] mm: page_frag: add '_va' suffix to page_frag API To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Subbaraya Sundeep , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Eric Dumazet , Tony Nguyen , Przemek Kitszel , Sunil Goutham , Geetha sowjanya , hariprasad , Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , David Howells , Marc Dionne , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ndstr7i78eh3h9bdgddoitmkoaj8hz7g X-Rspamd-Queue-Id: 01B81180011 X-Rspamd-Server: rspam11 X-HE-Tag: 1722449672-316200 X-HE-Meta: U2FsdGVkX19vldNt+TmPOWFAP1L76/vg4bWHIlYBK39VaMvV0hBGMNq7u5Es07hGvXpDizN0u7BpjO4NmkS/FAjLvRKpu33+SfN2wi4In/Gjv2gLbjjF57+Ak9Gu5ecPgNrpuNxBmtgQziSdbX08M6lJI2pnRGHsgWae9qasdTEMz57iyo08TVrkM+egTVnSxCKH8zj0z4tcyqCWvRlqED56tudgcn2nWBDp1PuD7DpSU6d+u1jSrfP81YPxGta+hYTe6n1DaQMKQ5urFyLZbkW1Qh3LaVjCnKT/1B5DZtaR75fsMU34Ew1hUdvMqLwri8XP9Vc4t9NAoW9WxUQVLSW/h5DcGyKFoJNb24zYhwRssr2mePbFxpUBQNdNhRnwQQSEZ5lMeBaHINHQcMQlRRh0mWTpbTkE3tfW8LHyazn+o9tWEb2WGF4QClm6LuXHT/nlZ8hvzvln5zTUU+rcFizhBxVVvW2WPY6lP4dJKOaKtm2P9GtHMOEEpLac0VZtNARgtlTNAb7ISOJy9KA8/h+rC7kyScL3WcPC+m8oCmwPppquOX/CaXFKCsbQZXnVvL4glVjl2kSzSpKBe9eR1HDI99MS6JpRJ1c7umoB3uNV2lm7lz7VicijgcWB9wyaDZgxhFPT5+x7zrJR+IdLwpk2hdlPG5yFTVTVTRuXwXTho8gNpgLXzbkbI4HL2jSonQJWPUKCjpA6SrTaltnWRpM+d4uAOKsj9sQj0+J14IfN4+qm0oYBh07+Lmu6ViIEglRPVUbFSohfGjaA+vLV9yIt0UT6eoZfJo3+Lx1dD87dTnt9Ho4FbhmsYcTp5cex/H6vS+GKsYykzeLbJasJSNDvJYwaqjnRa32gBgPPkELq5Zsn5PpCsy2nNLzDvhkJWFb0RHN1mo/gMWRV8/vusb0BR5ns4FQIJeCqK4dMTzL4X7gIOYC0QqJ8+VAo2j9Zb72bgaw3QpY+Ke9dQ2M 1plnOyuI NCZ5eqR9KafeCAqsIcM5n+/11IsqeXkILotNrEQq+tR49xQxCgTAMFUKEzix0+wcBAZ/LK04Yum/x0ynTFiwl2TcfDFaaplDsRzyoNFpv2TeSiN+imBOc58lApe/tgq/BfLeNo1RtkubPOi/QuiIylCmM2dTQEnQE3oNlcmyyZtW9O1m908F9dcV49Cs3sG2NGf7FYh/g3VarfM57xQiOt8Pi/0Uhyv3+HbjcmjG296OCAXV9c5mSWOc37M5TIktuzLTixFY25+8/xpz7rxWDTn03uixP36Fnf7wfT4hmN4Qw5CPystRBHy34+VcsExeXKwVKl81qxKpuHnxW8P7MN5ev1HRYiuFQNiveCCrW+U7NOpCdqMJyOGAr2G2LDlysXc5ZuLGmnsawjp4kvE/jwHFKZrRwUEzMOZ1aVHncFpDgJEkRpfCoX6uDPweNFTT3127vb0/H3ceeiG2potzydCRwoobG70AFDN1c8GOM4UKwVZzgb59J4OMGnKLBUZogkwiVD1SHmxSgjW9FzNe5qMApZUD+gUud4kTD8oTer3AEQX4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 5:50=E2=80=AFAM Yunsheng Lin wrote: > > Currently the page_frag API is returning 'virtual address' > or 'va' when allocing and expecting 'virtual address' or > 'va' as input when freeing. > > As we are about to support new use cases that the caller > need to deal with 'struct page' or need to deal with both > 'va' and 'struct page'. In order to differentiate the API > handling between 'va' and 'struct page', add '_va' suffix > to the corresponding API mirroring the page_pool_alloc_va() > API of the page_pool. So that callers expecting to deal with > va, page or both va and page may call page_frag_alloc_va*, > page_frag_alloc_pg*, or page_frag_alloc* API accordingly. > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > Reviewed-by: Subbaraya Sundeep I am naking this patch. It is a pointless rename that is just going to obfuscate the git history for these callers. As I believe I said before I would prefer to see this work more like the handling of __get_free_pages and __free_pages in terms of the use of pages versus pointers and/or longs. Pushing this API aside because you want to reuse the name for something different isn't a valid reason to rename an existing API and will just lead to confusion.