From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9EAC433E1 for ; Mon, 3 Aug 2020 22:46:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47D1722B45 for ; Mon, 3 Aug 2020 22:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iXpmTJ6i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D1722B45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5C858D0117; Mon, 3 Aug 2020 18:46:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0D4B8D0081; Mon, 3 Aug 2020 18:46:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBCE8D0117; Mon, 3 Aug 2020 18:46:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 75EFD8D0081 for ; Mon, 3 Aug 2020 18:46:02 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 36FF53626 for ; Mon, 3 Aug 2020 22:46:02 +0000 (UTC) X-FDA: 77110741764.14.crown41_330819926fa1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 0975418229837 for ; Mon, 3 Aug 2020 22:46:02 +0000 (UTC) X-HE-Tag: crown41_330819926fa1 X-Filterd-Recvd-Size: 4454 Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Aug 2020 22:46:01 +0000 (UTC) Received: by mail-io1-f65.google.com with SMTP id j8so27895891ioe.9 for ; Mon, 03 Aug 2020 15:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gbJLXIAhRA3ILjxJ/kOnaqM4fWJ/LpEX+iUTeUndPqc=; b=iXpmTJ6iTNHX5/0yQVDFwLIAFlMfeqBTpmWkw/+gdIlRTM53IBjEPiTdOr2WqHCjf1 /ngIOpPdDMnmF2xOP6HHwk+9yO6JRwHBhmEVmtCeryvi401SbANXAXdxqxr/kDqXwT7a aVsVubcmq1syeWSWgj5QeG6iBGgl3zE15WTocvZ9qmYIvLIJDw/kaAeSJRCaFFSLh3s6 +tfjoW3jE7RnVGlBtZ1M1r5sGFLFxuDy4hEJq3VAfoN9EqPy+dV135AaJDrqRsY6Vtes OFWRY8PISjNVEERbRNnZQpHElFL71u2bADXCdsR1RpkNR/8z/Lta+ZJiVHfTGqxE0qeE /eRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gbJLXIAhRA3ILjxJ/kOnaqM4fWJ/LpEX+iUTeUndPqc=; b=SdrH1j/7hBo/3zA6i8/Yclthkcvnrs4wfqTx/cpLtZ9lVziRzeW57E/1XwZron6Qgb f+0WFO/I3AoWYqBUQ+IMqApX2rlKdf1FZ5Tkufd6bzQwAmknm2HVoMGX4Ag+2E4DPe4e vs4NQ/YRAaNnSbKDFEqian/yMT5147n6/ebZk0LVcKExHOykvhR5q9sin2G+oB3Ze/yx 5D4QvUQmgRwYus3iNLryUwVblShlkoAKqZVMZ2C/s6MUnIm30V0p8ZrryKIgGJTAfJQ7 yo8mI+CKlhpxII4x0qaHX6M62u/akxw94EVXsRD6C6IiphXSt3EuB7fDUebifIpEyHgf FWxA== X-Gm-Message-State: AOAM531JFV27EOtMBcn6mydXsLqK83Lr+zKJ7mmewoNdFj9en9GFF7T0 YNPb8Rul1I619ErzdAGFbCqbOAT0DN4NA2rmRNM= X-Google-Smtp-Source: ABdhPJwIYpCvFGkCiGSEc1aDXcpoKK7cGb6N+8I2MMc5J1M4owpv0ARR2wasZVYDndA4tWugeNL7PFHnSM1tY1vY8CQ= X-Received: by 2002:a5d:8d04:: with SMTP id p4mr2150494ioj.187.1596494761071; Mon, 03 Aug 2020 15:46:01 -0700 (PDT) MIME-Version: 1.0 References: <1595681998-19193-1-git-send-email-alex.shi@linux.alibaba.com> <1595681998-19193-21-git-send-email-alex.shi@linux.alibaba.com> In-Reply-To: From: Alexander Duyck Date: Mon, 3 Aug 2020 15:45:50 -0700 Message-ID: Subject: Re: [PATCH v17 20/21] mm/pgdat: remove pgdat lru_lock To: Alex Shi Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" , Rong Chen Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0975418229837 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just to correct a typo, I meant patch 17, not 18. in the comment below. On Mon, Aug 3, 2020 at 3:42 PM Alexander Duyck wrote: > > On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > > > Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore. > > > > Signed-off-by: Alex Shi > > Cc: Andrew Morton > > Cc: Konstantin Khlebnikov > > Cc: Hugh Dickins > > Cc: Johannes Weiner > > Cc: linux-mm@kvack.org > > Cc: linux-kernel@vger.kernel.org > > Cc: cgroups@vger.kernel.org > > I really think this would be better just squashed into patch 18 > instead of as a standalone patch since you were moving all of the > locking anyway so it would be more likely to trigger build errors if > somebody didn't move a lock somewhere that was referencing this. > > That said this change is harmless at this point. > > Reviewed-by: Alexander Duyck