From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CC0CF34D6 for ; Thu, 3 Oct 2024 23:53:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA34E6B042D; Thu, 3 Oct 2024 19:53:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E54296B042E; Thu, 3 Oct 2024 19:53:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1B636B042F; Thu, 3 Oct 2024 19:53:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B08336B042D for ; Thu, 3 Oct 2024 19:53:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F18B1C4E86 for ; Thu, 3 Oct 2024 23:53:18 +0000 (UTC) X-FDA: 82633944876.20.B72D4DF Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 99EBAA0002 for ; Thu, 3 Oct 2024 23:53:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=STbEOUz0; spf=pass (imf15.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727999467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/FXW2qfy0Mzte0KQiCiX7jmY+EmRVQswHOXZMTK6z7c=; b=Nd+MwnGVJaXVpkoa+YDUs3QxQ/DVy5R2M1nnOpM/0ihvy8fXjI2UkRkayFdfbuNCycvM0R uVgQ4faaNPUyaRA00M0bcTjgXyBV4Q90y+yDKAu9KVyvKgJw7YwjNWSr2IwPGP0Ntfw+d1 9evG1XNIOffOYqQB9bzJW7sd/WxngeU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727999467; a=rsa-sha256; cv=none; b=hus+TTUloBqq2LstdSaYsxxj9vSiUkWySUTLfPjTn7YTXFZskZIj/PkaMjv51NXfN21mC8 nPZ4T5sCu87Zb4LsIAAgN+9Pxy7TI1GQWCB/dXLxtghIFyuZfhFeumXuDjJsYLLttXRFO0 ZQ+CgElAgxVPaVdZZa8D0t/7XPVofYE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=STbEOUz0; spf=pass (imf15.hostedemail.com: domain of alexander.duyck@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=alexander.duyck@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42cb60aff1eso14474505e9.0 for ; Thu, 03 Oct 2024 16:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727999595; x=1728604395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/FXW2qfy0Mzte0KQiCiX7jmY+EmRVQswHOXZMTK6z7c=; b=STbEOUz0j3Nn8eos22C/+kTBKO4Fki9zwaKdQxdorXY9uADMwFkZb6oKNxW3rwf0pS qFMjG7UwA3WFMSfDbLXkZBw/gFF8mnjL4onKgGL82/OjQTzdVIscQVs1k3l+AqMyi3tQ BiCv/VWjpzID6MTYbCTosUOTqtSSFfu1nhVASf5gTN0vPZWWWanuRSUEYrT/2J5pzgZj ZzL8fey3JHOTHrXtODuR7w/Mjir8NLUlNE+OBQ9w5v+B0UUaAEUKqHUF+TNgmXH9OoG+ dhq5HD2xK2BODzSPs02yI0pc9ZYryQo9pittZzLrlfwH2nXc/gMAiB9OwNavqPRhB1wJ rqFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727999595; x=1728604395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/FXW2qfy0Mzte0KQiCiX7jmY+EmRVQswHOXZMTK6z7c=; b=jEzv0RbjmSKD50qPviyhn9CiLNVCHSTejmOJjl7vs4PxYTgbPtaLBqxcMe6LmKYJ1Z 0f6W6AsgcfztoLguVwHEawgioVeSdGRXzFfSWZpf+p4vyLl/z1e6rrOIGjZiSB+rKW8Q Kv9poioUIjm2iSeO+xZioDMyRsnl/MjdmgiAEr2W0+v/MZhCrufZEPuDsPVkjQbRN56c ZKoFvH18zrPn9lYAm2TAJhgqyOepGc2TKyk+9iq/dGVCel0aMtogfJ09fHHx3glDsfXS kUbQMesWvaE/ZKMNCZAZjt/1q/L84H3a9WimlYfjY1gSmrOy1+OSL3TuyGKAuc3oo8zL Gs0Q== X-Forwarded-Encrypted: i=1; AJvYcCXqlCrtyqtAK5SnIX34Z1vXoVQ2hVq2nlzXmtKSJ0p3pFs82fYlyRxHmX/G/j1aaCjBAUGsPlfdig==@kvack.org X-Gm-Message-State: AOJu0Yx/noTxa8agJpKdT40/YIYP4nnpRsXbFpeq84ub0Im14ibeva2Q 8TxedyjXZyVkSSKJG1jo91oEEFezZmJYTwOMV2zHKKIw4YLtVvkH3WQI9erP21SRSF2IloHTZYZ 2Y+5EmypYCjEI7v8q2gJmKwCCOHI= X-Google-Smtp-Source: AGHT+IGn4fiOS89M9btpbU+jhafEsx5YrKlTjASgePNBq5sUh3zB9NpfPwXjvgun8r3L8mFlf1mrHdGYSR8h8EhWulk= X-Received: by 2002:a05:600c:3b96:b0:42c:bad0:6c1c with SMTP id 5b1f17b1804b1-42f85ab86cemr4605685e9.18.1727999594965; Thu, 03 Oct 2024 16:53:14 -0700 (PDT) MIME-Version: 1.0 References: <20241001075858.48936-1-linyunsheng@huawei.com> <20241001075858.48936-9-linyunsheng@huawei.com> In-Reply-To: <20241001075858.48936-9-linyunsheng@huawei.com> From: Alexander Duyck Date: Thu, 3 Oct 2024 16:52:37 -0700 Message-ID: Subject: Re: [PATCH net-next v19 08/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yunsheng Lin , Andrew Morton , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 99EBAA0002 X-Stat-Signature: 56w7q989huhdo8dbtbdenged8f47obco X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727999596-660613 X-HE-Meta: U2FsdGVkX19ZnE/vE5ycQi6Kp2AZ76fORgYYuVGu3Az85UZWIXYjssQfJZlu/jknamY0RkHTNsm5YffsfUuc35VtGxqi4fwWlsxPCG14yb6s/OUJQSRU8hUuYgzVtzAqsYmM9QQG/fe+xn7psT9zi0uLUqsSWHs3HRSbyVn0KZgTtQEmjhqXOhdtCEx10Da0Er8TQB7e1GI8569D2J7En3Z1Ri3fiyxMbSMLxp9wXauUJqBvKq7anKBa52+p6N+mf58zW4Q1RmSmTNcRlW8tTpUWe9fKY41PEMaCBglSYKlN6f5+TlE+sj/c4YawJbZvty91G7ai9513evBGIGQsrKN8kr0m5CLLuY/vt3Nb+wp102rXi0TACi76LVFub3DWPfESi9YzYDOcGXtdPM+wADHUlxFfk4SwLLt5eiXm8pRsrLtorT2lBTA7+lhjF3exMb0EWxVKXbEojdN07vA6VNjlNRhF2sVPUMKWajctcfvXmnHZ4741Z6O9321DBC8FNqX93PX3U4A8fzeAKy/Kf7+4MCzt6a0DDQ6jUZdbKGuxvYX9hGTLQpLzRmwwBCGMIRR2BPfltgrHbh1woVnJSHwLwmH6ioBFXAa+E1qLIMPfjZlrahawu0UeqSMba27QUnrs+MZlz1hDJlJ1wOGxoQv1JrapJX+3UllvhAA3lR3CAJLfkx/RPcdcDPEa5rImvV+Lb2e/IFKDZa5A5T6nfkxHSA36KSuiXbmQkbqoeslCCbSJ2v7WqYG+HUYlU0J3skGZIilbUmxIWvKMxftC71AGVyCzVRZfdpNt2riat7NbvjjHKDKI4kCaFE1xbTi/XNzPoD+z9t7DCsgcXxPe8wj/WSD6CtKVCrauatreNxl7NJiSBFwT0BY/o+UbRJTWAL4WjW0HpPwmIxM2r4DAOypgwH47o/Vp8lTyC+lZk7QZzgQBKWAp8aTZFKy13+LLEp7jxeYS0ooLq6HPifA u50D6+R3 aEkIi2iHGkqPhNrhxy0UByzBqsfVG5QH8AfOifQUqzPGPeBma7yR4Kiv3/uWGeU/ktsZkjJ4axV4N8Cr1ZhasU1PWR7t8S+uibIB52AFaeQUoJ8AFlD0e7f7p5Hr4yQRvO2OKfE21w8nL/BfNEmc6aEC9vNxR15sZ2ZbJOvQn1OcEpBQdhPFs0jTomfmNkEaHRB442xGD/xo/ItaohH1Azb6kIivwkq7gGalh9LqzCbaWmJB5j2Y30gyp717soYLqk9iLS/xD4ZRkC8+txNAWqoACzR6HvC5i5HCr+k+c6FnWQ66wstd7z2lNX7HhTIfz44ttbMPBDEjBgcFkvPBYeF+Tsh8OzzJsOJrFn4czzTBejhlwXITK+AkCv3YCSgiXpa5bQ2n0tqHaM12XqniEAZqG+mjAZlJyUHhPr5fS+aPiIcdi+GvXrMKjAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 1, 2024 at 12:59=E2=80=AFAM Yunsheng Lin wrote: > > It seems there is about 24Bytes binary size increase for > __page_frag_cache_refill() after refactoring in arm64 system > with 64K PAGE_SIZE. By doing the gdb disassembling, It seems > we can have more than 100Bytes decrease for the binary size > by using __alloc_pages() to replace alloc_pages_node(), as > there seems to be some unnecessary checking for nid being > NUMA_NO_NODE, especially when page_frag is part of the mm > system. > > CC: Alexander Duyck > Signed-off-by: Yunsheng Lin > --- > mm/page_frag_cache.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_frag_cache.c b/mm/page_frag_cache.c > index 6f6e47bbdc8d..a5448b44068a 100644 > --- a/mm/page_frag_cache.c > +++ b/mm/page_frag_cache.c > @@ -61,11 +61,11 @@ static struct page *__page_frag_cache_refill(struct p= age_frag_cache *nc, > #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) > gfp_mask =3D (gfp_mask & ~__GFP_DIRECT_RECLAIM) | __GFP_COMP | > __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC; > - page =3D alloc_pages_node(NUMA_NO_NODE, gfp_mask, > - PAGE_FRAG_CACHE_MAX_ORDER); > + page =3D __alloc_pages(gfp_mask, PAGE_FRAG_CACHE_MAX_ORDER, > + numa_mem_id(), NULL); > #endif > if (unlikely(!page)) { > - page =3D alloc_pages_node(NUMA_NO_NODE, gfp, 0); > + page =3D __alloc_pages(gfp, 0, numa_mem_id(), NULL); > order =3D 0; > } > Still not a huge fan of fixing the bigger issue here, but I guess there is only one or two other spots that encounter this, so I would classify it as "mostly harmless" in terms of not fixing it. Reviewed-by: Alexander Duyck