linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-man <linux-man@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	Jann Horn <jannh@google.com>, Florian Weimer <fweimer@redhat.com>,
	Michal Hocko <mhocko@suse.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [patch v2] mremap.2: Add description of old_size == 0 functionality
Date: Mon, 25 Sep 2017 21:26:42 +0200	[thread overview]
Message-ID: <CAKgNAkhJEyK=LhFj9W-RgSv+ET64d+MaEAQ41y5eximfQmYPDw@mail.gmail.com> (raw)
In-Reply-To: <83b023da-e9f5-2957-981e-5b0e71e9bf1b@oracle.com>

Hi Mike,

On 25 September 2017 at 18:33, Mike Kravetz <mike.kravetz@oracle.com> wrote:
> On 09/20/2017 12:25 AM, Michael Kerrisk (man-pages) wrote:

[...]

>> I've applied this, and added Reviewed-by tags for Florian and Jann.
>> But, I think it's also worth noting the older, now disallowed, behavior,
>> and why the behavior was changed. So I added a note in BUGS:
>>
>>     BUGS
>>        Before Linux 4.14, if old_size was zero and the  mapping  referred
>>        to  by  old_address  was  a private mapping (mmap(2) MAP_PRIVATE),
>>        mremap() created a new private mapping unrelated to  the  original
>>        mapping.   This behavior was unintended and probably unexpected in
>>        user-space applications (since the intention  of  mremap()  is  to
>>        create  a new mapping based on the original mapping).  Since Linux
>>        4.14, mremap() fails with the error EINVAL in this scenario.
>>
>> Does that seem okay?
>
> Sorry for the late reply Michael,  I've been away for a few days.
>
> Yes, the above seems okay.  Thanks for your help with this.

You're welcome. Thanks for checking it over!

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-09-25 19:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170915213745.6821-1-mike.kravetz@oracle.com>
2017-09-15 21:53 ` [patch] " Mike Kravetz
2017-09-18 13:45   ` Florian Weimer
2017-09-18 17:11     ` Mike Kravetz
2017-09-19 12:11       ` Florian Weimer
2017-09-19 21:42         ` [patch v2] " Mike Kravetz
2017-09-20  7:25           ` Michael Kerrisk (man-pages)
2017-09-25 12:36             ` Michal Hocko
2017-09-25 12:40               ` Michael Kerrisk (man-pages)
2017-09-25 16:33             ` Mike Kravetz
2017-09-25 19:26               ` Michael Kerrisk (man-pages) [this message]
2017-09-25 12:35         ` [patch] " Michal Hocko
2017-09-25 12:40           ` Florian Weimer
2017-09-25 12:52             ` Michal Hocko
2017-09-25 13:16               ` Florian Weimer
2017-09-25 14:52                 ` Michal Hocko
2017-09-25 14:54                   ` Florian Weimer
2017-09-18  1:52 ` Jann Horn
2017-09-18 17:19   ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKgNAkhJEyK=LhFj9W-RgSv+ET64d+MaEAQ41y5eximfQmYPDw@mail.gmail.com' \
    --to=mtk.manpages@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=jannh@google.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox