From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id C219B6B025E for ; Mon, 25 Sep 2017 08:41:21 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id g50so8913199wra.4 for ; Mon, 25 Sep 2017 05:41:21 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id d9sor2024863wrd.25.2017.09.25.05.41.20 for (Google Transport Security); Mon, 25 Sep 2017 05:41:20 -0700 (PDT) MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: <20170925123621.35godwzhvw4wbisc@dhcp22.suse.cz> References: <20170919214224.19561-1-mike.kravetz@oracle.com> <6fafdae8-4fea-c967-f5cd-d22c205608fa@gmail.com> <20170925123621.35godwzhvw4wbisc@dhcp22.suse.cz> From: "Michael Kerrisk (man-pages)" Date: Mon, 25 Sep 2017 14:40:59 +0200 Message-ID: Subject: Re: [patch v2] mremap.2: Add description of old_size == 0 functionality Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Mike Kravetz , linux-man , "linux-mm@kvack.org" , lkml , Linux API , Jann Horn , Florian Weimer , Andrea Arcangeli , "Kirill A . Shutemov" , Vlastimil Babka , Anshuman Khandual On 25 September 2017 at 14:36, Michal Hocko wrote: > On Wed 20-09-17 09:25:42, Michael Kerrisk wrote: > [...] >> BUGS >> Before Linux 4.14, if old_size was zero and the mapping referred >> to by old_address was a private mapping (mmap(2) MAP_PRIVATE), >> mremap() created a new private mapping unrelated to the original >> mapping. This behavior was unintended and probably unexpected in >> user-space applications (since the intention of mremap() is to >> create a new mapping based on the original mapping). Since Linux >> 4.14, mremap() fails with the error EINVAL in this scenario. >> >> Does that seem okay? > > sorry to be late but yes this wording makes perfect sense to me. Thanks, Michal. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org