From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF2BC001B0 for ; Thu, 13 Jul 2023 07:57:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577EC6B0071; Thu, 13 Jul 2023 03:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527E96B0072; Thu, 13 Jul 2023 03:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43F0A6B0074; Thu, 13 Jul 2023 03:57:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35F5E6B0071 for ; Thu, 13 Jul 2023 03:57:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F3CFC8015B for ; Thu, 13 Jul 2023 07:57:14 +0000 (UTC) X-FDA: 81005833188.10.014A3B9 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 1808B120020 for ; Thu, 13 Jul 2023 07:57:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="j/nV/8M8"; spf=pass (imf29.hostedemail.com: domain of lilinke99@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=lilinke99@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689235033; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZBeF8DimtieRIbeczjrQAO7Bmt6r/83M9FTzR+dYQus=; b=h1Nabh887Z3F6SwBNFBliyOP49J9hnyLOKpLtlpyaQV2LWeEoQu5RycuTmPhWoFYFffvWJ k8AXK2p/j7eiBT+8kIVP8Z3Dlntx8oSu2COwY+efbW34xG/lEwjXOedoq00zcaEqxpQa1n X28JoxOQe99YwpIOEwG0gUncnWdFTeg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="j/nV/8M8"; spf=pass (imf29.hostedemail.com: domain of lilinke99@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=lilinke99@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689235033; a=rsa-sha256; cv=none; b=tmJDgRN5kXo1z1EHqi/vkXXFVm38cb2cS/KUOtFlO+rYcWrO0WDkvcHD7gn6HWWHoq52n0 H1J+RbU4b+AvL5rTyyoBbvM5ohCkM+tSv4q0gDFns3qtJUgf7XwtRURUsNiu1iEbJRAE0F bIyPLWwBS/WE4vU2uP9mLojh8GREnPU= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51e57874bfdso459853a12.0 for ; Thu, 13 Jul 2023 00:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689235031; x=1689839831; h=cc:to:subject:message-id:date:from:sender:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZBeF8DimtieRIbeczjrQAO7Bmt6r/83M9FTzR+dYQus=; b=j/nV/8M8qJDGiBFI8327yymczZxYK3EfM6/n5B+YZFgBAbsM/NkhigpTrpzmhftlim sU9+IpUQhH+EozlQ8N+xthICiD87MdzfWGGhmOFrlFvVBLBZ9RyIXawww6pS6oMMOD/W 34dGfPC+7nNIb6RO65P3JlWDda6SSyv+raLu1gVioQGyGlxCj3oloUL1ds0vxrQgqfoW ivlzJxRwt4BvvmFntFjoZL/7wSo0p91OqWuP3X+UtA63HEeE9BvbSLAjMh2X08w/PTcR YHluygjJ7slsd5eqGK/SAm+AlFSvlynVotNqmbbccE7lLTZQU+JpYjYHBvO/E0k1Ezgh 0j/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689235031; x=1689839831; h=cc:to:subject:message-id:date:from:sender:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZBeF8DimtieRIbeczjrQAO7Bmt6r/83M9FTzR+dYQus=; b=BC6NnWmvn+eL7/SL4RJ5EgdBm7scE9r9qBTJ7f0iXDxDqrVxquHIkmT33mdkdhI2WC SDEHWDQOFQG/rzqt1xBlREsUz+CYVddLEn1pvvOKLpzOLTnmhKMIWI0EHOtoBBYPJgEW F6RJrwI4Sc7NkAsxu7YVOta607QAHixsVzDKJWitemkgILx8M8/9TM8T3y/gJhyOEcRK n0Nfsu6TiZhy2a61c5eA9Po54dkK28XwBzXQcUsDAIRKceIDELJMF3joLDtb14muMBCl CgOkss0WAoCwmfEGiSfh7WKwE68WeJvzNk/gOOa7m+FeK+3vMU895XlfhOVfE3OENgzO /oSg== X-Gm-Message-State: ABy/qLY9lZgrGRP66wrcTD5v0UaKI5ulkIMf3u9moAwG2Osi60pRbU0q LeboiZniKkv4EVkwHOQ/e/fmFMOcqzhIIKOKf4BM7+oL420= X-Google-Smtp-Source: APBJJlHbM+0P718q61QkhmRg2sZBdOo9EtDJ8+TrS+eXLQDo5tAoYPNE/0mM/eZP5gei9DkV5833SS3E0v0Hx3rZF2E= X-Received: by 2002:aa7:c90f:0:b0:51e:f83:6de6 with SMTP id b15-20020aa7c90f000000b0051e0f836de6mr1240233edt.16.1689235031366; Thu, 13 Jul 2023 00:57:11 -0700 (PDT) MIME-Version: 1.0 References: <65f4c60a-9534-56dc-099f-ee7a96e0ccaf@redhat.com> <20230712235813.GE6354@monkey> In-Reply-To: <20230712235813.GE6354@monkey> X-Google-Sender-Delegation: cl1ntlov3@gmail.com From: linke li Date: Thu, 13 Jul 2023 15:57:00 +0800 X-Google-Sender-Auth: AOlVQvJu9wTequs-Y5TVT_XTP9o Message-ID: Subject: Re: [PATCH] hugetlbfs: Fix integer overflow check in hugetlbfs_file_mmap() To: Mike Kravetz Cc: David Hildenbrand , Linke Li , linux-mm@kvack.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, trix@redhat.com, ndesaulniers@google.com, nathan@kernel.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1808B120020 X-Rspam-User: X-Stat-Signature: 7toxzceo1izan6tftowa4qwq6qfbtrdq X-Rspamd-Server: rspam01 X-HE-Tag: 1689235032-606105 X-HE-Meta: U2FsdGVkX18n+IT91eq26eshNP6Ftdhs3n9OXg32luIpdQScbRmHQ6XIRUgwhdpWIUSqGIMPlUC9thGZLIm4VcRA43GLx/Q3MnQZruhB+PuuAZZsUE9iV1GBKob9cHJZjHPv0Zxwt3cf8/1e3GpMIazCCBxOv+J1e4jXHSjF1kwrxCzde2/GFtkrwbT9p+bZ6c0WK8qkHm205zqlNx4A59cL16FV1WT2vxlQP06hWcm2HBJWYrc5gCWr4iXzNBeB3TePoycVJv4slX1EF6lWW/p+stzFXfld/W51d3yYFHVijBJoUH+RauzxT6dlfBo7KLkn1paYPnonDJJ8KTxyvfLqxylZtbgs2V3bKOd5c3BKFETGgHatSgZ+I6KMDKELwCwpnzkjxYi78JELHcxab/od5Hpp9e6050wzfMGtU9LSd/ldKxSQXZc00EW2qQ1dA4OvNdVc2vqpLuaIzwKiAC6R25s4E6Wi2McpJPrzqTCJX4vRqqk+pihA2Rr+hyX1idBttYoBcrx/gCSGMU25BUU4AN5k3BqLKYAovywja5YBqVqprQxc/AwIdhBVxPdvIYhoGlI5+2Yk5XJXDTGF6O3Ls5qWB5cvWgLR6LZjB7bG+VSsab8hCFoca93gA0TxC8I9fEMfN3zJ8yxbgildLrPgUSE9Sj6HnzIpKYVdmTpYkPbBHekYR41nDEhUZKx9dM1cKWOnQqSCWsGxYfeSbEKXhNPiqIpTrF1za7mkFke3alT+Adt5Kzq6p51wkqWJYRMLg2r7ZruFkDnK3VQSV0MPsQ+BZeW2hls2YoQlHA0ZUIGmsupiv1TLbX33erx72YKza5MC7+Nd6pVRfY7Ni2owTOorWtP3XanPKH8BbO5nz7r0rwqWgaZaSJyS0v13OzMARzGUOV6rr0NX5SRP+ovTNj4se+rGOMb9ydZUSDKwN07Sf4P1wtW6zrlQ8oBkzEG+ihkXJoSd6TU5BZX GLzVBB/T dxY9vSXetCUH8+/I8eyaa66k1Oi/hCNYUGhgNAYiiTUgKUNgOlDR+ra1olX1a6ZMIH3phIBNVp7zx9n/OjvGchv1cMnsLxvnk1pmjGUQUWZeshAPEfreBla589ifLZ975FZv8osL3IDizo70rIu2U2+Me0Sc05NDHoStu7fYPEhgkIVNHWYfHw3MLrLceDnPb8JDmqPXL0V54ckao47YXXCbATZXqBCHbklQIrrmKYMd12KwLGYw8W3p/svmVKhuTpylcXAriNisVz7jf1w7f1c9bjEMhhMICkMbb53iguYoN6YHB2CX9sIn8MgYBm7d6YAVKDY3AIiHPSk/ZCQdY1ngfkWubJe8plu6sFx1akC6bOnlRmNvqUMwvwdqk35ZkANMmltwZlA8So06bMICksfMO3ST3zi1WGKhd X-Bogosity: Ham, tests=bogofilter, spamicity=0.014916, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > However, if this is a real issue it would make more > sense to look for and change all such checks rather than one single occurrence. Hi, Mike. I have checked the example code you provided, and the difference between those codes and the patched code is that those checks are checks for unsigned integer overflow, which is well-defined. Only undefined behavior poses a security risk. So they don't need any modifications. I have only found one occurrence of signed number overflow so far. Thank you for your valuable feedback.