From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61BD1EB64DA for ; Thu, 20 Jul 2023 06:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B75292800B5; Thu, 20 Jul 2023 02:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B250328004C; Thu, 20 Jul 2023 02:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A13AC2800B5; Thu, 20 Jul 2023 02:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 92D7F28004C for ; Thu, 20 Jul 2023 02:25:19 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4285F1C7F55 for ; Thu, 20 Jul 2023 06:25:19 +0000 (UTC) X-FDA: 81031003158.10.CDAEE8C Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 4AFC41C000F for ; Thu, 20 Jul 2023 06:25:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QSIEs6AV; spf=pass (imf18.hostedemail.com: domain of lilinke99@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=lilinke99@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689834317; a=rsa-sha256; cv=none; b=LdFxZAS2xBqLcRvJrbWB5G1M7ipQ1qX33Jh15DmxGvvx/qcRVhdHMy8zlqMC2WEzSN08wP SMqAuOW+FxkNRFnCtj/VygmZtkfZkhbW1aHznimlVCeP24Z9BiHiqd8mQx6en96pIes2l8 vhsJdNoYOgMdPPyX0/TBSa6D4kzAA34= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=QSIEs6AV; spf=pass (imf18.hostedemail.com: domain of lilinke99@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=lilinke99@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689834317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNL4l5GRlHwxV4ntRBz/satLVd2URGo3WiWHTSW6eE4=; b=Xcs//smqAg+4YRiuemIEaLTgzL4kXBIse2S/u/kxf/1Qu/qcGscWLr6Kc6Xy+RDXGEgqS4 6ZJLC3mPz2KayApOKvXe0a+CUDp7scktQ0bPW19bExlesAcWfxC/DAiQtLLjjy/0D3T3iy PhnnTpISRiVpkxeeLOWjcEytiYLbijo= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-51e99584a82so505921a12.1 for ; Wed, 19 Jul 2023 23:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689834316; x=1690439116; h=cc:to:subject:message-id:date:from:sender:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JNL4l5GRlHwxV4ntRBz/satLVd2URGo3WiWHTSW6eE4=; b=QSIEs6AVNYFv9z7/VkvFN6axf4NcXNTrxvEwfbAuZA0WcfDW38zoK9JiXytigKHeC5 DYrGbL81QYKlCI3xxV2RkC77wi61QADL6LviFW9H11F/dPugFW7xEmVX+QjEXU1feoVD r/iGgnqx5NWyBUmW3RjUTvFEQdxnxtgYgIylX3zuVgOSCcn3FbbI6ZrikCDtfGGw0SzM GlA76rMc2dAxDSVfmtfttYx25yhlC3DcZSusFga55N33uy9Dghfn6kFirVqYwJHUS1G5 rHe56vsX6IiWWtJR/I0a6iP9g4YPMWImyJ81ITLfzqgoHcJ60W4jLbJbry35YY68TR/O 6BQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689834316; x=1690439116; h=cc:to:subject:message-id:date:from:sender:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JNL4l5GRlHwxV4ntRBz/satLVd2URGo3WiWHTSW6eE4=; b=QCouOIpbAdA9XiBszQfqxA4xhBzWptp017XCQcKAA+azITBz9Hw0RC/+ALJMj0ObId iGateRK8zN14t/GNo2kJ0rW5fWQ8RgFWASD21e2CfcNrpG5XW4Y1e+tYMqQIG0ZobUhY uoeQkMisnvU59kBO28W3TRGIvnTFuCh0dD1blC4MEUY0SC1gS7W8rNJtaovsz9gS/K6z 4LtDfMjvy2ns7nW256qgrNxNKNdSWhfP+dCHcxGH7qWVhHBfY4B9vxVjq7u190+RYe8G yrWgLpCcz22AeDM5V9BYEt4gCUT3A9CdHc7XYznJk1hNgJ0eMp/7KB5yc0wDiiM1oWzY GqKw== X-Gm-Message-State: ABy/qLaS9cdiucK31DKMuKL+7s5XwigS8iO2ydG+QMMu/tz/UwBhR3No wFSY1KGBdy2EdzjycIgFLTC0I8kjt/DTD8XcYvU= X-Google-Smtp-Source: APBJJlEAekAGm8b9heA5DHCrx/MiGSEyvtwHTkQ52PeIUjOZOspIHL6dE4HhuM/FqIfVA4Wld5gYo5iknBjb+B6hYbg= X-Received: by 2002:aa7:c38a:0:b0:51e:36b8:34fa with SMTP id k10-20020aa7c38a000000b0051e36b834famr3973631edq.4.1689834315425; Wed, 19 Jul 2023 23:25:15 -0700 (PDT) MIME-Version: 1.0 References: <65f4c60a-9534-56dc-099f-ee7a96e0ccaf@redhat.com> <20230712235813.GE6354@monkey> <6c3191e1-23fd-4f9e-9b5e-321c51599897@moroto.mountain> <20230719232248.GC3240@monkey> In-Reply-To: <20230719232248.GC3240@monkey> X-Google-Sender-Delegation: cl1ntlov3@gmail.com From: linke li Date: Thu, 20 Jul 2023 14:25:03 +0800 X-Google-Sender-Auth: vNNFw5NqUWJumSZdCdnOBZIRxbk Message-ID: Subject: Re: [PATCH] hugetlbfs: Fix integer overflow check in hugetlbfs_file_mmap() To: Mike Kravetz Cc: Dan Carpenter , Linke Li , David Hildenbrand , linux-mm@kvack.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, trix@redhat.com, ndesaulniers@google.com, nathan@kernel.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4AFC41C000F X-Stat-Signature: 8ntu71n6h6impi6j4ispt59b35fmo7gz X-Rspam-User: X-HE-Tag: 1689834317-529524 X-HE-Meta: U2FsdGVkX18GD6/bN0Qp9ZEP4Hskjo4uTQ974vyX4jfH4VRh/icd6PJo7WwolOjMmbm9bmuqLppwLegkGwahAO+7KjIUZNswSsI5GwjdGgoWpmuaxCAaFKZp5oMKmETzRHCPg4PaVdJMVyGm33JLEOiYX0JlzkKy/QH/WeL8Q6DjBNfKMvsdup0iSp73dsPwx8cFZnFTZf6c+gsXdFzNe++nX8fDHXqFdLz0TWE2ELN+0KvZuaEapDKpLVTUjhEREEY9RS8HjLROBWcqKZluzuSV8M5mLFddCuzwNAiZ6reZiIvu+RLiNCqm8Wo90ww6kc5DL4LcUfX0nHaV4d2MUmIWZ9bboMjF4d14TBoeGB0OoTAX/t5mel2zVVMx5JM1aVixZkyM3YF2obSMM5zDMKwEsvaHiNXZVHV2mOqIHFqpv15DBpyScbl9QePRBH/zOoh8637p1+PivqHnPo5BEVDvWrKUegxAzIkZGEzVYNsq33hm+Xqi8SiaIufex9H2RIuQRrl9EyhCiCQEEkDI+QkpSXSfyrF7wGU2VMufQaBylGUYMAvGIE4SO97h1Z2LIc/O9Vyb5xzsqwgPa8qSvZ8FKXGaqbYlRyO8e49jS0Pa9h6PWmFDmhPL0IeKCkr5sYxmHBzTJ1IbdGcUy+d33HV1WCqPv2HAA7baBSeKuw0tpog8gJCu/wwgK0AQDC18M9KilsI69oOF6O3fcpVnVlmxLRtNldiCHlG1VwX3JKhlVnJcb2hDRBA67lUVXjCHcaidV8Ex55hAKonU9iOom1fbN92BxCb0n4plmnKHMABKLwSNdlfcsZutIJMDbs7A8Y49OiJOIUnb2TAn4WMQh60pgAAu1J/fF+uUsUh8fFNqkbgScIM0K4rYuqiHOrbtDfpa0rqi1mPapAWmV4EkViYpMpnkQS+fnpe6vCZcpKDAeJly3egqqkqh3pMbC8stjbsLOONhP+uEzlJZ7Mk gI+672uG kH+X8JSm3c1VfPyM2tLWDFk/UdUQzrU5LeWvmwshmhy4Slan95p4HVQCOnaiFVyA0a4WgSFBY49s/IrvgVKNF0VqMPx6OTz+KdezSqNiqVEIfcJbNOqLc4sEazfyHDpiI/YLdto2lXYILFklzdYfHthZZ5+Icma/QdRCWzQRc7bv8VLFfRMnEW8SlMMaPcZRROaJcqENq0fZGDF9tsslCpNkPYhP9Ai6QC9XLbyJeuevWBCedjJfhxSoicbMByOdsSY7kh9Fw+rT4thMmcekop2mSfbtZ1PMgyKVNIefhQDVeX9ifTSYuvZKW3shhlzZSOZQ/Y72tllPhI1GHdzoBkz1dtjK7cK8VzG0cCCLTglr3DVb7LHhAhX0JoyuCQjK56TLqlEq5JasDZEY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.023554, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > What about using the check_add_overflow() macro? > > I like the macro. It seems to have plenty of users. > > Linke Li, what do you think? If you like, please send another path > using the macro as suggested by Dan. Thanks for Dan's advice. I have tested this macro in gcc-9 and clang-14, it can work well in both compilers and regardless of whether "-fno-strict-overflow" is added or not. I will send a new patch. Best Regards