From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DF3CDD0FB for ; Tue, 22 Oct 2024 22:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EE776B00B6; Tue, 22 Oct 2024 18:08:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69D636B00B7; Tue, 22 Oct 2024 18:08:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565456B00B8; Tue, 22 Oct 2024 18:08:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 360726B00B6 for ; Tue, 22 Oct 2024 18:08:32 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DCD4AC05A9 for ; Tue, 22 Oct 2024 22:08:13 +0000 (UTC) X-FDA: 82702627560.24.5394D32 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 96E44C0024 for ; Tue, 22 Oct 2024 22:08:13 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WYKjOa85; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729634859; a=rsa-sha256; cv=none; b=Qs9P987e8VrT9FXfychzcpuQ2tGULz7dju0epb4jKWXooDodmIkCSwuwNZ8NMwzpI6kVQd m1QSqXpmErStnFHQXAdFidPgJ/1izEKc6NnSOrgXG2kOZA/KIwgo0QuCs2zR4dOHejF47X N4ncJI8CckB+KHgvIpW6pkVPKeSiluk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WYKjOa85; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729634859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1EdHuO8J8iAbx9XEg99EM0K+vD/8zpQZPET6Q+8S4M=; b=U+dLfn5UWHkc+mKLTuIieZQA2P7NA4IQLYF6I+xomyBg9eElk/qjMY2Pj6mvrv1s9w3tMj Ea/xqsn7B9QgG1+PuoHiAGT3rQySJ8hb14eru3usltsMAYrEjGzwwqu45czE7X6x53ri7P PsxwcCuzRMNmbz+jJzWDFE0l+DEm2S8= Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-4a46d36c044so155602137.1 for ; Tue, 22 Oct 2024 15:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729634909; x=1730239709; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F1EdHuO8J8iAbx9XEg99EM0K+vD/8zpQZPET6Q+8S4M=; b=WYKjOa85Acbtvfs4F6AzLVxM1KAA5yvZflddTFr/dmPSMZP6gqCbmO/tUrXCH2dwRb mi4i/2QPwAWOz3yTDa03S0vYatKENZ0q7buEb+XknfEyxh/hOJ2Vn5I7klhsXYb9ke5J 5Tlw0njZuXFS4lxWCxN7Q52uW0tZ4jRoZSXh8aWxYkxXqFd+vnmZ+71+H8MiL1VGQxP1 Qmn/79UcJnf2/S/+ML+/FG4jYasFy6UVRjnoZ3PV6XJNhDLMfh3VrZr3wTpg6EqSYEvv Bmc6h7VOYAfgAHK7kyUCGeoeFdWjy6+E/PttDEun40nrnJ99MSyILGrgiB7pr20b7Vlw BK1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729634909; x=1730239709; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F1EdHuO8J8iAbx9XEg99EM0K+vD/8zpQZPET6Q+8S4M=; b=pFBZfpH5zUB138H1/GeDLfmLYtiRRhG54NL4x1rAJjKWPMbTHcvglT5UyJ3znkHDul cn/8fspgQWYKBM+VgjPZhoTmIHz9CsaBCUL32W4iew6rNdUW65zjuMyO186Pk2LZ57el lzLurkRZOk8KDXjZRVXtSf66T/ZviTYlG6mIDV6/oQMT6pD10MkICqiWxpZzyHgnkBKZ gFUqwOBJGETbSh7gbSc3xUTyzhtujYPKRlFiUtzIDjHrZ8ZGiYUi7z6/9um9nEiPbaue M9Gz8IE5Sy3soutEDyuBXHk4HDGzzNl+AKZ2sBZt+6IbNhEcePpRBtmAv5uqdGhQyDE1 rj7A== X-Forwarded-Encrypted: i=1; AJvYcCVVaprFREuCpoVk/zcA3MsRtfEBeakG2d+el+3b9XKAtGc/5cS+T0KwoWLDSj+AtuDDv6Bb0MS1PQ==@kvack.org X-Gm-Message-State: AOJu0YzVBZJe2WY2iAnrdtsLWLyACheKL8bzjHzQz5skPat+zrn9SMNa xvjLr4KCPzLEg9IobtY3s1fx+QlH7L2m48Xr29B2lWrUHzhq7YBaKhkaVifrIE5q4MEWS6bLKSd atHqDIan1n4jx30f116VYatKZy54= X-Google-Smtp-Source: AGHT+IFR4lJPOvtab+BXMERxfYcK0NvC6Q7/68IB4+RkRk13GEKMIotK57tlpFQV51sMJcQHm8gAHnfCqqVTeH9MQa4= X-Received: by 2002:a05:6102:a48:b0:4a4:8a11:a3b9 with SMTP id ada2fe7eead31-4a740d6ae64mr3427941137.1.1729634909118; Tue, 22 Oct 2024 15:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20241018174114.2871880-1-Liam.Howlett@oracle.com> <20241018174114.2871880-2-Liam.Howlett@oracle.com> In-Reply-To: <20241018174114.2871880-2-Liam.Howlett@oracle.com> From: Pedro Falcato Date: Tue, 22 Oct 2024 23:08:17 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] mm/mremap: Clean up vma_to_resize() To: "Liam R. Howlett" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Jann Horn , David Hildenbrand , Qi Zheng , Kefeng Wang , Jeff Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 96E44C0024 X-Rspamd-Server: rspam01 X-Stat-Signature: kcaafud1d3tqjgs5gpghfsbbsayha83r X-HE-Tag: 1729634893-741508 X-HE-Meta: U2FsdGVkX18KI+5/YyrQzHn51h5TwOR6qjbZhj9CJdYfgO4UGE/njD6AHtBFTY9TquYY0rvxzIxE16C/7KbMWdckjRe8a67Elr+//Mz0UTj3dYjod3IF0rufvpT7SHMwdfcU+dGhdvoeVIymiBTMbvLIZyI5VVry/WGjOuyWe7reCDP6hpeKMzky64jiMoXQ6+AySBP10eJP+9a4qXUQXFSlHiZgDWiD3ufyHB5U8kAnXT8hkjz3fxhrnH5l0clUSMJTVOiACCpQdHQgv8DMfKxXLptPBIWEbRInc8nPydddfrETlNJUISkUPbs3oNbDoKe1/XV1nyPEjPA46fugQtTs23cr4TcKJOiFqp2tVv7xsVBiv6GEGndVEI1NMAYAvzpH4s/iO1diU5UVUchuuDvhXn0GXiUTfz4lvtg90aNxwt6+jNx8+jxr1yp4ZPmmL1F7tq+Jc+nR2sCKAjOqGVpsPC7GbzVGtSswM4mFHSvnOYKG5P74RCg/vXQvY8ms3+t00oOeZKRuNJhSlhnnsRJSlWyOSl1Zv5RWdd4qBgQbGwwRmy2FaFKatu7pklboiIM8H3/myfZknBVNtzX9MLWTFohdznZzQnR3d9gDHf8m5xuXkzavLEft0SlPKcpoLhVCn07DEhm5Zyj8EhAisoV2R0uDhDsHtn+JFhcIZuLvp8ObPEFZ/S/4eXzgHKcb0r7ndwXDg5vhLUk+ObReSk6HuRZF7lnBLsH/Imsk4HkQec7LkCKc4dGpIKr//rgLC+tyhCC8F2rn8AdHfm1YT9dYo+KnZorkPZfmKG/itLqD9YbNf/aVY4e5RsEMHa5mB3bKqStBjRgkpmqf7vTu08eM0IE/tf3/tIfZByBbG4qRanULa9cdtWsJ+Q4dgdPDGfSd268Mg2EnXl+dVI0M4U7WAdDYjocbl4TEly0l3X48SjH90kzSepOp00AnnorK4keIdymfhD5qWtgqE/K drU8FcN1 ayBaRBQPlXiUUxjkRUHN3BKwvSMI3xKiPA+08b87RTFG1jL8ce3Yue8dcx4luwh5kMz0mUh9sZVVFSqs5C2ABfSKojCsN3Apto3o1zeQjCqkW7nv6lZlhTNftOrv2zVe7sx/C33NbfNXG9zVicVbNlpDP0/fQbiJOg3al0nHNASbJe3RfIlqPu8t6t6nikd8nGWOk3myy1Jlo5xXRb9Y1Jwv7nylU7PSgpy+pkNGvujKu1tE8+364mr1CaE5EFDw7vk4W4k1RTgN3p56MiK002UG1N1qJilm1hep0kfjZ+6RCuAGBzEsZhxcZD1bdfbS7Ii2Ok4QVrEDf3eCApfHlYFh3lS1rqRsoaGNUwhaLOiHevI0CzoqrIu/gJJBejYeLw5CTN3e15+NJLPDWiXOVaKeZ+NwZuLh8Le1+GJoHydGxNVRkUb0pmnNgf6f81U2ZAGaB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 6:41=E2=80=AFPM Liam R. Howlett wrote: > > From: "Liam R. Howlett" > > vma_to_resize() is used in two locations to find and validate the vma > for the mremap location. One of the two locations already has the vma, > which is then re-found to validate the same vma. > > This code can be simplified by moving the vma_lookup() from > vma_to_resize() to mremap_to() and changing the return type to an int > error. > > Since the function now just validates the vma, the function is renamed > to resize_is_valid() to better reflect what it is doing. Small nit: Could we pick a stable naming scheme? I understand the kernel has historically had plenty of ways to name functions, including do_stuff is_stuff stuff_do stuff_is I thought we were starting to converge into vma_/vmi_/vms_ :( I would personally prefer vma_resize_is_valid/vma_resize_valid (even if it's a static function, so it doesn't matter _too_ much). Anyway, enough bikeshedding... > > This commit also adds documentation about the function. > > Signed-off-by: Liam R. Howlett Reviewed-by: Pedro Falcato This patch made me realize there's a couple of small improvements we can still do (maybe with a vmi) to clean up and speed up mremap (at least!). I'll look into those if I find some time. --=20 Pedro