From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5139C02187 for ; Sun, 19 Jan 2025 20:18:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04AC06B007B; Sun, 19 Jan 2025 15:18:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3CA36B0083; Sun, 19 Jan 2025 15:18:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDCDB6B0085; Sun, 19 Jan 2025 15:18:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BE58A6B007B for ; Sun, 19 Jan 2025 15:18:46 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E554162563 for ; Sun, 19 Jan 2025 20:18:46 +0000 (UTC) X-FDA: 83025314652.23.B793AD9 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf13.hostedemail.com (Postfix) with ESMTP id 63DB32000B for ; Sun, 19 Jan 2025 20:18:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GIIKLVFs; spf=pass (imf13.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737317924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWgnJQq33Ke9O8n9TfrlwCiL4N29jeQ56k1zFQcVy8w=; b=43M5zDfzH4Y3BofkHssZRw6TRJxMx0xozId2IJBoKIfZiExVGIPZRrdb56+hhc/ji3l9Tu bfAScONEjB5JwAwPtPkN0mkJOoE1SiHgU+O6zQD9r1fbba8lNCCe9bTSNuVT5Si5+kQBfj c1ta/BZTS+lVCYyWM75nTC+RrZckw0o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GIIKLVFs; spf=pass (imf13.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737317924; a=rsa-sha256; cv=none; b=cWJgQBFLM65uJ09zrWs9w0t5WUknbf5iKincHShU7v7xNw9GyBx+0HHgtHArFDMi3WH3+h BNzUSsPiZW0IRND00O4/BAVWK4FypKTcv3G0h9VvmFoCaFqMv79AxoStDoVRLeOFG1xcxv qofxGFqq8SCBrBzsazjbhC+vSYqwYjg= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-51873bc7377so1104015e0c.1 for ; Sun, 19 Jan 2025 12:18:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737317923; x=1737922723; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nWgnJQq33Ke9O8n9TfrlwCiL4N29jeQ56k1zFQcVy8w=; b=GIIKLVFsE8Xw9v/UxE2imIsU16vIty4h0WDNevCrOKp6aOAOT4iirE8hk9izMngkXH 4GNGcxNHSYbJbYrUuipES4W82B7W7lG8cBSK0ecRp8agNDHhIakc7UZ1dXSH2ZLMNagt vK0cQSDjZk7VVjlJb2OArtJ36PELbXLnec+UqXUB3OCRxuAIa0Kkud/2ZCI5xWLaX4N5 4P8pvc4gTD1AZgGyejJSdQlkTrnWy75bX9DPu7+ejuaMAGoRSpmOG0k4tkCJQc2cC370 vu4rG46B+SHH025UlS5HIG7T2Oz1jK++J0OWbL0mkHGAxwsRIA7aXdKEQIIuwBJpXqwN zsVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737317923; x=1737922723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nWgnJQq33Ke9O8n9TfrlwCiL4N29jeQ56k1zFQcVy8w=; b=mNrwxVbVrrJLss+eS3AY1UoSpg2tt5+YpUySnRNBGhIu3muxra1tR/+/NJbxj0Auen dDFBhQzpok3vtv+chBwCVblLGgrCL+MvMnMTqfyNpA8K3yh4mWIXBWjtpu8zErAuIIUt WoQVPYn4UOYSKYHg6VkQVWApFIxmhQwookXY9oy8X8DpyZDguMi8+tnTBwXCOSmosMZB ChwWQX5Av1SKlBRwEXhCGAYPwKIA0njG6b+Bn041sDjljOH7p89PUPceiQwcsoPn6gRK XMuq8/hsyqfJjZcsDdpAh0KPM93p2iQvozspw1J6jVqirkYjO5U775h4QaMh8Nur99QC BqqQ== X-Forwarded-Encrypted: i=1; AJvYcCXUFot/SIsJtMqp16+zTbros8NLklaYdx4OOA8fWmVhjT/WO6V8xfVXLSsaTWE+LKG4q3bZnZBBSA==@kvack.org X-Gm-Message-State: AOJu0Yx5GYaxrrVcguwEPX9tQtvzeuelP86pTTA956wD/8jsVy1JqtKh /gH5mka+CEX+P3Al2R36YSSXjxXA6cTmOcyrarZWkL/dhHklUDw70vwEdi7AaRIARyQPjb/76Hn SbJqe21VMozLWZHjnxgh1YuieDJw= X-Gm-Gg: ASbGncv0jZEKcTPLgcb9FQw1C9Ud5K/VDPXq820sfPliJVAOwaZDybSzQfJTEKP0nM8 rTDYtQOaWqJh/6wguDi3G2W3m3vdjgTslSo/hKJr7LE1nHd5ArwUzwKLLifjWHYHcSdMAI9OmEq kIVUPRJcU= X-Google-Smtp-Source: AGHT+IH7MdM3RfD+Md7VWTJAbx8Tnm0+3Pw80v639Zt9f5lk+zV04F8PSjNvU2UT91jk3cpa/kjhMZYZrLIk44XZqy4= X-Received: by 2002:a05:6122:d22:b0:51c:c23e:8cd3 with SMTP id 71dfb90a1353d-51d5b253f42mr8914860e0c.4.1737317923415; Sun, 19 Jan 2025 12:18:43 -0800 (PST) MIME-Version: 1.0 References: <20250119180608.2132296-1-jiaqiyan@google.com> <20250119180608.2132296-2-jiaqiyan@google.com> In-Reply-To: <20250119180608.2132296-2-jiaqiyan@google.com> From: Pedro Falcato Date: Sun, 19 Jan 2025 20:18:32 +0000 X-Gm-Features: AbW1kvY-Fai8ufnaGdNwcD3Bhzh-Y5UY48veKzIzEol1DVQ_MCSkJ3gMiCaSGfw Message-ID: Subject: Re: [RFC PATCH v1 1/2] selftest/mm: test HWPoison hugetlb truncation behavior To: Jiaqi Yan Cc: nao.horiguchi@gmail.com, linmiaohe@huawei.com, sidhartha.kumar@oracle.com, muchun.song@linux.dev, jane.chu@oracle.com, akpm@linux-foundation.org, osalvador@suse.de, rientjes@google.com, jthoughton@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 63DB32000B X-Stat-Signature: nxeaxaddnt1weafomuzwwee7tbpuw3wz X-Rspam-User: X-HE-Tag: 1737317924-38017 X-HE-Meta: U2FsdGVkX1+Nojsg7U6hk/S67fNYmGpGZ3W35kzfiNbawFEn2tUxwBm2/9B0kL6Ecxxr8ckmAkR7pU3LKs3xmBTEVOijgx+4BquW7/fxxQNCBsqO5Vh/6A4lnApFOh5rp3OjvIyMpHeevrmKgzIvRNDH/nL5Gl2xRWhiodm9EO9Gcn2YXMKDRjyznAoQCjOG5pYKcsgEsuH7VZTAdrCWWsObBZkA0sc7WSUz1II+x+6I/jM6j/KNO3rVySDf6P4SwS2+ssWixxTSwTzD5oTAW++G737qQ4+1BhgHZyOrir0bL/ELWH1zI8JPAbrYDY4+g90BEnAwewR5gIxFA3ZzzWpu8IoMe1TKEGERwaloV3Zh0U2JFTXwOKp0p1cgKtYknlbLy/uBk9tvql2d0+Vhfhauk9YUo3GpuccJWWajb6HgPp9PmBqvTHcgfbkZcJDmpXucl9FU1jIt76sz8ilY4d/04UndbuEcXVZ8RRzztkLPFK89ZVf0EXFPRIZ+4Aa0fmOMdjxUIQaB7r8xaM1nAtKqtKoaCwLkjSdKe94NT5y5XgMdIfgJMkPtXsTzTs3hlBg1GvVLL7Ev1hT+hZ5c135Ukr75lgsxGvs1VlpFmFaHlXiJro5vjjLKM0F/bCyow7vjOORNWnrCt0Yttx/OHz9X640i//374lXTzU31L7IzDzUINp1D7LAfCQemt7k6hhUJAX8E5SVvS2wagmrQIhHUWPFLnPQUqORYY7PXG3cGuzgrDFSbdbVmwCe7plArux4swgiEb04dgj3P3ASr7xXNIUMpSLC/ZMx1Rf+PhjTyrddtkB0omrXRligf+PCIBl4bmbLMMskmTs9Q9GDY4n+pwvCGOuRUnq4za4EvPQxUYIowR22FfclvCPm9F1EoghAm4T8+rrmY8xIwmvVzscJ3rSAIjv4UEI48yZHgXXVnSreGW+BWf4JfVNh1p63rvRd04q+gJ9T1lsQ9QEH PoTaAK5a ceM8wSBsc2ObPMBDYWoCQ1H2j5mHCQQ3wl0dc6BsmHRuzHrccWOZDJuVf6IgXnEuzFl8pkvdEfoIZA0mAeezRk9KfkgaHCXM1LQ2wQ5eK2tGnkIDkm/AgRllQbc30L6QTYwffScSPKjUIxlFfWmw6rlXKx0cDAJbWoIHLrKoVAwvAfa//28KSAl8kQpcE1gCreW3cRx+6LI3AYVvzkouHY7O9SPjjGGWKRxGjrlUBt8vJ6P5pvHOKM0vFsQAd1nDJPvbAkI7fa3SPFlADezAaSde/IGl8JSLtIOos3jgOLyappxRgBiaYOLG7wvZw4J/dX7+u9zK3zza2ko8Z87pQbz53pCy2MOgMOt6mksE3jTGoCvuaoeJvD/ClvbhAz83YZ2C2FhFfwQ1hCOCSKQqXW7go4Vg54TUCRzxfKx6LOAPGw6m8EUodhpPi9WzIq4fWBqe8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 19, 2025 at 6:06=E2=80=AFPM Jiaqi Yan wro= te: > > Test based on my understanding of the memory failure recovery behavior > for HugeTLB file system, especially after file is truncated/closed. > > Signed-off-by: Jiaqi Yan > --- > tools/testing/selftests/mm/Makefile | 1 + > tools/testing/selftests/mm/hugetlb-mfr-base.c | 240 ++++++++++++++++++ > 2 files changed, 241 insertions(+) > create mode 100644 tools/testing/selftests/mm/hugetlb-mfr-base.c > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftest= s/mm/Makefile > index 63ce39d024bb5..576626c93ccab 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -62,6 +62,7 @@ TEST_GEN_FILES +=3D hmm-tests > TEST_GEN_FILES +=3D hugetlb-madvise > TEST_GEN_FILES +=3D hugetlb-read-hwpoison > TEST_GEN_FILES +=3D hugetlb-soft-offline > +TEST_GEN_FILES +=3D hugetlb-mfr-base > TEST_GEN_FILES +=3D hugepage-mmap > TEST_GEN_FILES +=3D hugepage-mremap > TEST_GEN_FILES +=3D hugepage-shm > diff --git a/tools/testing/selftests/mm/hugetlb-mfr-base.c b/tools/testin= g/selftests/mm/hugetlb-mfr-base.c > new file mode 100644 > index 0000000000000..b8eee071babe6 > --- /dev/null > +++ b/tools/testing/selftests/mm/hugetlb-mfr-base.c > @@ -0,0 +1,240 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#define _GNU_SOURCE > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "../kselftest.h" > +#include "vm_util.h" > + > +#define EPREFIX " !!! " > +#define BYTE_LENTH_IN_1G 0x40000000 LENGTH, but the macro name itself is also a little weird-sounding > +#define HUGETLB_FILL 0xab > + > +static void *sigbus_addr; > +static int sigbus_addr_lsb; > +static bool expecting_sigbus; > +static bool got_sigbus; > +static bool was_mceerr; > + > +static int create_hugetlbfs_file(struct statfs *file_stat) > +{ > + int fd; > + int flags =3D MFD_HUGETLB | MFD_HUGE_1GB; > + > + fd =3D memfd_create("hugetlb_tmp", flags); > + if (fd < 0) > + ksft_exit_fail_perror("Failed to memfd_create"); > + > + memset(file_stat, 0, sizeof(*file_stat)); > + if (fstatfs(fd, file_stat)) { > + close(fd); > + ksft_exit_fail_perror("Failed to fstatfs"); > + } > + if (file_stat->f_type !=3D HUGETLBFS_MAGIC) { > + close(fd); > + ksft_exit_fail_msg("Not hugetlbfs file"); > + } > + > + ksft_print_msg("Created hugetlb_tmp file\n"); > + ksft_print_msg("hugepagesize=3D%#lx\n", file_stat->f_bsize); > + if (file_stat->f_bsize !=3D BYTE_LENTH_IN_1G) > + ksft_exit_fail_msg("Hugepage size is not 1G"); > + > + return fd; > +} > + > +/* > + * SIGBUS handler for "do_hwpoison" thread that mapped and MADV_HWPOISON > + */ > +static void sigbus_handler(int signo, siginfo_t *info, void *context) > +{ > + if (!expecting_sigbus) > + ksft_exit_fail_msg("unexpected sigbus with addr=3D%p", > + info->si_addr); > + > + got_sigbus =3D true; > + was_mceerr =3D (info->si_code =3D=3D BUS_MCEERR_AO || > + info->si_code =3D=3D BUS_MCEERR_AR); > + sigbus_addr =3D info->si_addr; > + sigbus_addr_lsb =3D info->si_addr_lsb; > +} > + > +static void *do_hwpoison(void *hwpoison_addr) > +{ > + int hwpoison_size =3D getpagesize(); > + > + ksft_print_msg("MADV_HWPOISON hwpoison_addr=3D%p, len=3D%d\n", > + hwpoison_addr, hwpoison_size); > + if (madvise(hwpoison_addr, hwpoison_size, MADV_HWPOISON) < 0) > + ksft_exit_fail_perror("Failed to MADV_HWPOISON"); > + > + pthread_exit(NULL); > +} > + > +static void test_hwpoison_multiple_pages(unsigned char *start_addr) > +{ > + pthread_t pthread; > + int ret; > + unsigned char *hwpoison_addr; > + unsigned long offsets[] =3D {0x200000}; > + > + for (size_t i =3D 0; i < ARRAY_SIZE(offsets); ++i) { > + sigbus_addr =3D (void *)0xBADBADBAD; > + sigbus_addr_lsb =3D 0; > + was_mceerr =3D false; > + got_sigbus =3D false; > + expecting_sigbus =3D true; > + hwpoison_addr =3D start_addr + offsets[i]; > + > + ret =3D pthread_create(&pthread, NULL, &do_hwpoison, hwpo= ison_addr); > + if (ret) > + ksft_exit_fail_perror("Failed to create hwpoison = thread"); > + > + ksft_print_msg("Created thread to hwpoison and access hwp= oison_addr=3D%p\n", > + hwpoison_addr); > + > + pthread_join(pthread, NULL); > + > + if (!got_sigbus) > + ksft_test_result_fail("Didn't get a SIGBUS\n"); > + if (!was_mceerr) > + ksft_test_result_fail("Didn't get a BUS_MCEERR_A(= R|O)\n"); > + if (sigbus_addr !=3D hwpoison_addr) > + ksft_test_result_fail("Incorrect address: got=3D%= p, expected=3D%p\n", > + sigbus_addr, hwpoison_addr)= ; > + if (sigbus_addr_lsb !=3D 30) > + ksft_test_result_fail("Incorrect address LSB: got= =3D%d, expected=3D%d\n", > + sigbus_addr_lsb, pshift()); > + > + ksft_print_msg("Received expected and correct SIGBUS\n"); > + } > +} > + > +static int read_nr_hugepages(unsigned long hugepage_size, > + unsigned long *nr_hugepages) > +{ > + char buffer[256] =3D {0}; > + char cmd[256] =3D {0}; > + > + sprintf(cmd, "cat /sys/kernel/mm/hugepages/hugepages-%ldkB/nr_hug= epages", > + hugepage_size); You'll notice this is just reading a file through an external command > + FILE *cmdfile =3D popen(cmd, "r"); > + > + if (cmdfile =3D=3D NULL) { > + ksft_perror(EPREFIX "failed to popen nr_hugepages"); > + return -1; > + } > + > + if (!fgets(buffer, sizeof(buffer), cmdfile)) { > + ksft_perror(EPREFIX "failed to read nr_hugepages"); > + pclose(cmdfile); > + return -1; > + } and this is just reading a "file" (pipe) directly, soo.... static int read_nr_hugepages(...) { char path[256]; snprintf(path, 256, /sys/kernel/mm/hugepages/hugepages-%ldkB/nr_hugepages", hugepage_size); FILE *file =3D fopen(path, "r"); fscanf(file, "%lu", nr_hugepages); } (error handling omitted) --=20 Pedro