From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DF6E7D0B4 for ; Thu, 21 Sep 2023 23:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ADE66B027E; Thu, 21 Sep 2023 19:41:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55E226B027F; Thu, 21 Sep 2023 19:41:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44CA46B0280; Thu, 21 Sep 2023 19:41:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 317856B027E for ; Thu, 21 Sep 2023 19:41:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F074B8096B for ; Thu, 21 Sep 2023 23:41:50 +0000 (UTC) X-FDA: 81262229580.13.CC92B78 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by imf09.hostedemail.com (Postfix) with ESMTP id 4CEB2140008 for ; Thu, 21 Sep 2023 23:41:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c3tNUUX3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695339709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w48GztKGUIvMqqvPZVDMleDtLD/hcfB0PxWuC7Y1iOw=; b=z1DNia5AY5IqjNByNI8WcfJsm4KOQEbqEwVLtDoxe9dt2YhPTKaFT4GrHb856a9IS17qOr Uvik7nwkMZFEvYqkdL4osvcHDiJy58bHsE7Abwr9F0a6/HWvEx8/GP6/fMbQaYItKKlo42 BGINtBWz2DYSavg683BejMBGKirw4VI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c3tNUUX3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.178 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695339709; a=rsa-sha256; cv=none; b=oBCGdO2FWE4LeHO0Ic3BjIkgMVE/4CrTeWQnMx3+xhAQI1lW2FRHcSXHpNRvR8ceZrIC9C 0WxeSb39jyOjzGqpctqMASfMuVGbm+XrVTaMuM5EHCFHSQUOG8numBbfiZCT+IP3/Mow4d deGs2vSz7ZmrS44F7KQaIJg9sNuDr1g= Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-4935f2d6815so1112008e0c.1 for ; Thu, 21 Sep 2023 16:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695339708; x=1695944508; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w48GztKGUIvMqqvPZVDMleDtLD/hcfB0PxWuC7Y1iOw=; b=c3tNUUX3278ilyTQ7MesPjsU33ZQpbf4lrUmul4A4AYfyRdOz+d971J1uCOj+begUX 0O4By8ODl0UwZrPOVhgp5I+OM5aQLBOlaoLCNQ4AH7y/ukcErhlLF8PbOuZkgZQZx5EQ Kx+dre1LFpbDSiaop+EHHTEsQ68HB+0ILvQNyyZjvv/6yZoce88VK/dfyI+mCXY52wV3 xnLPVvJYlBrfDQlCcnNhIVi8jCBZ2dhy+pKenxaS/GLl4+SYHW99YxF8pOtoOiq2LJjr yoNuJf/5vCyyp4V4E07fQF3q3hL6C7A6OYDZeQk4d3F766fez6FM9877axNNQnEFir5v trVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695339708; x=1695944508; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w48GztKGUIvMqqvPZVDMleDtLD/hcfB0PxWuC7Y1iOw=; b=Dz4T6/tWGl1967bQIDYwRngdbL2WHI9FCu/w4qJLvM96FFd2ACHwBpnpbhmHDzUX/y NHZ1mT7GV2MElLFPDetzmfmBsfXmEdtyK6AsO4XmxIqRDF0oplEnyr1aX7/CMV2JB/CN fp3Q0aVTdhgUatID7bWbkPeSi/y2webTXF8IAt3OiBYU0pEwVobCZrcxQiKg1ejCnogl SWaYGeos/3NhTS7ObLXoKx7q/7TPtkPcqp+gqkareUevZHezPpaW96IO3KHTjXrMHwpH k/ulgTJ3uhC61f4ChVrJRofD/rb0WlLQDnHia+UUyyzIENNjVU1ccRu3vHIlRNIsfsqQ PM4Q== X-Gm-Message-State: AOJu0YyIE3+e0+FiDJVZSZtR2ac8916NuHOvh1a18P8Aq65zURpiIIEl DmjnlMgIztNPiY4X3ftyCYPtgOMYp4uvuAt9KlE= X-Google-Smtp-Source: AGHT+IHowdOAInWy8qSJ+bGjp+ELswpQrYyP6Vw2ghvlTdU0OH1bR6+Ua/20leLuBdh2b2O6fPWb//YZdRjluLHi5Uw= X-Received: by 2002:ac5:c978:0:b0:493:a661:c5f5 with SMTP id t24-20020ac5c978000000b00493a661c5f5mr690990vkm.2.1695339708341; Thu, 21 Sep 2023 16:41:48 -0700 (PDT) MIME-Version: 1.0 References: <20230921181236.509072-1-Liam.Howlett@oracle.com> <20230921112521.fc07c658804f4e188179da77@linux-foundation.org> <20230921185330.j5jw3oms4tc6crkf@revolver> <20230921162748.a85eb5af766e0662e4f22a5e@linux-foundation.org> <20230921233422.kv46hm4lddhp6rgb@revolver> In-Reply-To: <20230921233422.kv46hm4lddhp6rgb@revolver> From: Pedro Falcato Date: Fri, 22 Sep 2023 00:41:37 +0100 Message-ID: Subject: Re: [PATCH 0/2] maple_tree: Fix mas_prev() state regression. To: "Liam R. Howlett" , Andrew Morton , Matthew Wilcox , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4CEB2140008 X-Stat-Signature: o5h171x4b8zgyz814xsbhuy583b1cd87 X-HE-Tag: 1695339709-90133 X-HE-Meta: U2FsdGVkX1/m4sXfe4pRb4N+xK24aHQ+QWja2EiRqnlRZF2isNYI2D/3S8JMVjuwt1HKa+i+q1gLvxbmD2MPJsvso2PFKuAXry6Ro+f2rUf2d0btovnqKc4drCePeelGmnpE3Jk/8zK5O9PPA37CBwG19/beHQH5scPyKl2UWw8OZEidJUpnF+WBzwG62yf3JIhBaZhj+8s5uKgbrzq3SR7HlLGBmcdcyuP+ACQRybTrLTPKCi4F0hYrznhzBaSgyNnLFop0R7/5s+0DCsdwswqdgcA4fyyvQ607x34Er1ITFpyL8F56mvzU2a9AljhUfYaLPqp1hrbKz7qOipJ/4s7/QaEPsXiP0uqExO4O0Q0rd3cwLVRtL8f9K3ynlU0XOHEpgUsTEz+nK3gZn4Whl+6dDcBdoZ0LdHvl3FgKrUpLG6Zd5Tl3oFChnkzxWwBDL0yDjZFsva677FvNtHu1TncGuAD7nH6IfLza0SMTJGZM0PtAnzhA+tO+BwxrJiE9ZaSJvucH/9jRq33w7hCbHLOfPB6J/O3jwdb3qewARHg3Y5Cw5DFvvf/txqnRzIAgZyF+DnYvb1vIkB9pTY0zFzHay5ZF06Ro4SRZQebSPZW/wOTfG5XaERz21F3N6av4uwtFuKd+X/KsY7e1lQLmPiebeBuGdgs0eAiP/AGk19UToJHSctFEparqL8As9MjYehg1NCGyXplnKi59oDA6nJMauOWVgfznFWFn+fdcL5cAPVUNKtQcdornKlLIWUTsiGTk2T0xy9DGnFDQnNJY+iNRjiyw6eqauTfAGRjzN+g069eQihI5thLt/U6oNw+fiA0Gs8WFnbTt+srRQRfsOUHLuKzcKpQFhPyqYllwpU0ZJlNYly6e1kFBLLqJS2LBK/UyVYUvkD+n5fb160ZVVtbA9B2IvfPW1/HyAaQUVYTFdS5Quk+/t7XI7HskgGsl2sUPTvMsvpP03PjUc/J PAhlKmir KpmzqZzZN9OV5BK2T6rN/fxMf/vaIJ++XiEuT87jw+oLii93qMuIH8/fH93vr+6Q8dXHWYe83cAE/zhpfyR2ux6S29NLISqjiUyFSq1lVsSwaNw2gZp3+2dKTOQwd1TFKOxV4dbwaIcDuQIMpHksQw50J4XT8Cc49QfWc1LCCZ/ozquwS00gOSQRjlGKPRI84ZYS+X1DChoY3oa37qtgNpgVUCqJVBxtgf9XuIqrA6tseSDPWYStEB+S+KUUDAAyQApR+iNtRCtSfKBao/3vx9NCHkXl1gRXRGruOHg7KPHVqdPYtgl1fcmy7U8QWR4HN51b2LZWUwyg7FchbsGPuNiVB5x0rbPJv4xYdW+HpgIg3qN/WQCMtagoWvF4Kqsq75yw+bRknHnp4axonKiwf68iz1918y3iLB+tua0cEz4qMf9J8RjF7l+Mzrre1Njz/wMJ3y3aiC6GsZVq6VjlLaMdwVMFpgBR9yCfJIErEVQX2Mw0dPcVsAJPBI608kCAhialDs0SdJuxOl0rJs99+zaBPGARIdtXytCp1WrLnCPCqQS2/Vw7CTdi6IIl6ijHPdp0BlLXmjxZ/1pPLAzIzx7q5CpZVSznrTRc+a8fCylopKkgkGu6BpBkUL3H7z7R6Mv2n4ydnNSbPm6Uj78jrUf2pOJ9KZVoKqjL9omkO0x6w07gNEkTq/MkS+wwToDqh5rmVM8cm0FqnNCSiWD8JsY9B4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 22, 2023 at 12:34=E2=80=AFAM Liam R. Howlett wrote: > > * Andrew Morton [230921 19:27]: > > On Thu, 21 Sep 2023 20:23:11 +0100 Matthew Wilcox = wrote: > > > > > > > It isn't clear what are the user-visible effects of this flaw? P= lease > > > > > send this along and I'll paste it in. > > > > > > > > > > > > User may notice that mas_prev() or mas_next() calls that result in = going > > > > outside of the limit passed to the call will cause incorrect return= s on > > > > subsequent calls using that maple state, such as mas_find() skippin= g an > > > > entry. > > > > > > When Andrew says "User visible" he means "userspace visible". Not > > > "in kernel user visible". What are the _consequences_. > > > > Thanks ;) > > > > We have a Link: > > (https://gist.github.com/heatd/85d2971fae1501b55b6ea401fbbe485b) but it > > takes us to the reproducer code. If it took us to Pedro's initial bug > > report then the sun would shine and birds would sing. > > > > I don't think the irc channel is logged so I'll respin with a cleaner > changelog for both patches and the subject of patch 1. FYI: The original distro bug report: https://bugs.archlinux.org/task/79656 The original userspace program bug report: https://github.com/cebix/macemu/issues/271 (and yes, this is my fault, I should've raised this on the ML with the regression tracker and all, but I tried to write my own fix then realized it was trickier than it looked and pinged Liam) --=20 Pedro