From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB79EC47DD9 for ; Thu, 22 Feb 2024 23:16:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07BC36B0075; Thu, 22 Feb 2024 18:16:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BB86B0078; Thu, 22 Feb 2024 18:16:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E35066B007B; Thu, 22 Feb 2024 18:16:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D15C66B0075 for ; Thu, 22 Feb 2024 18:16:13 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 745FA12104C for ; Thu, 22 Feb 2024 23:16:13 +0000 (UTC) X-FDA: 81821000226.16.92CC78A Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf19.hostedemail.com (Postfix) with ESMTP id DB1081A0006 for ; Thu, 22 Feb 2024 23:16:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nImaP/NE"; spf=pass (imf19.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708643771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4JtTdXxCGCTnvQvSWv3Y1gG67yDkcySzLqqUm/qFAtw=; b=DsCnuPZHjDMVipnZNvmgllAZ2GjsWEMNooW/XBAyARmDWjLpWVJk9t1albK+RA+L7a29pK cPLU08/14zBv/8bHCOfNZGBR36KLbaUJN8VLKW7jAdj2RAna868FDWIZtUa2kGVGWAkzPY OlzpEKCuLRw5uLSpuvRP831dXp6JKII= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nImaP/NE"; spf=pass (imf19.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708643771; a=rsa-sha256; cv=none; b=C4yo+HL/jBeq4vL0BnawEDtWSSu7n+hOx+bhng2YReSzJ910THqkKDrbM5ZzRov02A8rj5 TzSNRpEa0HA7jhn20VxhzmUQhgIpyZ57PQ0yIHNwprJJwG63vCZbbW+SKJGtbjmN0gK2Bj at3amwyCZvizBIHckEmR+rWNsqeUHS4= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7d2e15193bbso131233241.0 for ; Thu, 22 Feb 2024 15:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708643771; x=1709248571; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4JtTdXxCGCTnvQvSWv3Y1gG67yDkcySzLqqUm/qFAtw=; b=nImaP/NEE5J13XdAh27Syj2HoPDW4Ah9E1ekYXA6ZCXPIwCh85C1Y8fIdISqAOgAFq wUKj0rcvHC3pFuy+/xjdmN3MUTzpMYzAfj9xnHbOgtSCs1Lef2LZxnXc1MJdw+7JaEfO FqoQlTxapYHU9ycqryxBVxzMEfFyy8LgbcxWuL0LwCALXynYqfSbRY8NSQXxIIgfLZn3 IeTDvBIrCWbI2W1Se0cC3C/esztmYJVzY3lP4u30mATwo4oMneWPwfeIQCuILqqSX/Dd U+mFcE+SZyWhgmZd3Hev8ljUuy8mDG/KBcL2AQZ8Q4YSbpPMG0wNT3/zE4zyHZbH0uWo zhJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708643771; x=1709248571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4JtTdXxCGCTnvQvSWv3Y1gG67yDkcySzLqqUm/qFAtw=; b=F1f0B8UZZuWNlmx144m3B5oZNThRxI4ZXS4vaifGfA35ShFjj9sqo3ZPq44RImJsLh 4iJSs/gfqONW2IAIrfWYknLVYAjlrPV0rAG/hfVa+nSxWOAhgBYEnxe14hVor1IkyqNt JDS/l+oWehNXdJ1BGSBdauJxFtXxTUWgsQTDMC68sAjGjnt3cHeRo1fFfHMiAaTsixDu pat8jG+0JL0uZqkKh5oJlsr4AOdkrAXv/N2wUhOUWKP8ikfUdPoApvStw7O26aGp3snc WTT/BbRYcIx9syOSl9cug6VcxFgCMKdx+FZR1YFZCVDkX+FQxO1v8pwUV3+cn42EM5f7 QJVg== X-Forwarded-Encrypted: i=1; AJvYcCVBOosJwh/zdXBVTpXIrNoe2AcPg+HRy6AsptQvMXGK1Twv3kCVIMe9c4+RUokzQdxgpXZSJ8qQ4761xUtP6WWa54k= X-Gm-Message-State: AOJu0YzkOqnQdcuWPjT6DUmgLFP/RWRjOZjLdyJUNMrZJtUSXGxbnynz 7/Xb67ZnpRLpt2E9G+gCs82ZPyC3aeR/H5htTWuGR4NPwWstmzCLarJNUoNTZKgUhLX0krI2PGK 66Fh6FY36chvJxyDrTGGsYJtZcVA= X-Google-Smtp-Source: AGHT+IET7SLCpXUutFO5wTAkeaY0stX0a7qnERj2kTvzSDmplXe26G+bcAoizsf7zicRW4KaVVWyD+L2cHQaJkIgIeU= X-Received: by 2002:a67:c992:0:b0:470:472a:89a1 with SMTP id y18-20020a67c992000000b00470472a89a1mr384850vsk.30.1708643770735; Thu, 22 Feb 2024 15:16:10 -0800 (PST) MIME-Version: 1.0 References: <20240102184633.748113-1-urezki@gmail.com> In-Reply-To: From: Pedro Falcato Date: Thu, 22 Feb 2024 23:15:59 +0000 Message-ID: Subject: Re: [PATCH v3 00/11] Mitigate a vmap lock contention v3 To: Uladzislau Rezki Cc: Matthew Wilcox , Mel Gorman , kirill.shutemov@linux.intel.com, Vishal Moola , Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DB1081A0006 X-Rspam-User: X-Stat-Signature: orf3sfiewitby1uxuo5rga5qeuaabpxs X-Rspamd-Server: rspam01 X-HE-Tag: 1708643771-520472 X-HE-Meta: U2FsdGVkX1/fTTj8BmDjkQFuU2jOAY91D409WmcmJKmKWOahptjAFVns16Lchd+QEjtntND3JGAcSM9mGy+v6KweFUm+tW9c4kgDASjSF2SLPh9JzviUY7vAofec+vygwmY1JRRNrs5/bIDvxM5Lw6Q4Qv+thQ3I6OQSG/t1W0apIVWYHvjEWOqY0hx/tEiPIk+maJ6M+/tvdWvc45tQSVsjyGVmF5kz0mIfQyWVgauAp4Z6ReyP/mTqJ1k9508SHHlvEHcN6UGDY31TV9nTHJDBFq7jJKSKoTF+4psdbmK1zR6qlX6QaRpt4Tc0IbZXtmhVKyXWaFOh9UUPiE7/s3MitPpLmGgWw0R+a5VYX1alBSiFVSLGv+LywrzXsEjPYtRvPT+/+sK+do/96Mwc55LqRHwrAds3uR/h4MQcJ5m+erigyHC9Fqq8ZsfeS4vWMD11E+S7giKBfPap8r7jki8jBXpE6fhA/zj/mZtN2JlCIWdIav7lrTkONJUuTqzrVXjPusNt4/kmZRMc1BfmnKXVhWh6DnzD6PJyXXcvSYN2ifj115n+4je1lVQxJdi0dKg02G0WdsUUJwz1R/gC+FYtcBj+9L6+oor4ANGvZ1HqTvQG8ta5UubLW5EdkE/fvgspWm57sTq50HdOHhirSzB7hCmslZKF/7gtk0ShMiByPyF1SDGQ224h7WVUOv6YvI/bntXVdQQHjxslYZB3UgF2Byh3dBfGBPMzjK5vD0/598e9lg+OC1KSQNiAs1KDaYvB7Mh4L1ykYwzHlc+qcFUvyQarW1d2xP8PtMwr5VK0p2B84Pqh3LwwnDcfQ2wo/ykWkypgBzq6DlPeFIQpC8EtLzNLEjII/PFQg4JaxvyW6ecrYWD8ku+Cso6lKrCsOInOPNqiuJIvz6ZckAsibRzZFKZ5nhaozwg5UTMWoCKa0AzwNdCYYD8/dKNc5VEQOxCWhvNUAUVnREPm6w6 jhnTf+Cx D9s7bdPfsBxjoh5rXrQQ4/cqeZ3Y50Vx/sPFz0wJA2poTqy/MF1WBVou5KJZh5PCyP4FUqhvOwzIrdfxJFkinTCO6OZe+w5vHb9kc6SX4IBDIDmQT6ijlvpYdgEEXO4TPOKHui5uRTosN5VQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Feb 22, 2024 at 8:35=E2=80=AFAM Uladzislau Rezki = wrote: > > Hello, Folk! > >[...] > pagetable_alloc - gets increased as soon as a higher pressure is applied = by > increasing number of workers. Running same number of jobs on a next run > does not increase it and stays on same level as on previous. > > /** > * pagetable_alloc - Allocate pagetables > * @gfp: GFP flags > * @order: desired pagetable order > * > * pagetable_alloc allocates memory for page tables as well as a page tab= le > * descriptor to describe that memory. > * > * Return: The ptdesc describing the allocated page tables. > */ > static inline struct ptdesc *pagetable_alloc(gfp_t gfp, unsigned int orde= r) > { > struct page *page =3D alloc_pages(gfp | __GFP_COMP, order); > > return page_ptdesc(page); > } > > Could you please comment on it? Or do you have any thought? Is it expecte= d? > Is a page-table ever shrink? It's my understanding that the vunmap_range helpers don't actively free page tables, they just clear PTEs. munmap does free them in mmap.c:free_pgtables, maybe something could be worked up for vmalloc too. I would not be surprised if the memory increase you're seeing is more or less correlated to the maximum vmalloc footprint throughout the whole test. --=20 Pedro