From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8F4C46467 for ; Sat, 14 Jan 2023 08:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C92F38E0003; Sat, 14 Jan 2023 03:08:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C6A288E0001; Sat, 14 Jan 2023 03:08:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B58B28E0003; Sat, 14 Jan 2023 03:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A65898E0001 for ; Sat, 14 Jan 2023 03:08:38 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 65EA31C5CE0 for ; Sat, 14 Jan 2023 08:08:38 +0000 (UTC) X-FDA: 80352677916.07.C78F9EC Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf08.hostedemail.com (Postfix) with ESMTP id CE3A016000E for ; Sat, 14 Jan 2023 08:08:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YDkbWirr; spf=pass (imf08.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673683716; a=rsa-sha256; cv=none; b=YeVb5WLSsn2YNAjgStpldLM8o735QVBBGBW+zZNMCAqmDDwrYwutoLqLp4S4cVGu9TBDz3 jzVevYS6cPSe2PKF29YPjWug3LHPQ3ky/hnkZYAtc/Tw/MFbkq9XLRjBBPBYpr/90Vq5D/ 4Hai7HAJs5cbHbDC/i5akjsZTtM5F8k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YDkbWirr; spf=pass (imf08.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673683716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lZpVju+c3esZJi64lpN19QBiN5Ioh9BTNl6Imk6TaQ8=; b=Ygyx4iKjxs7FpvEKTKBI1W4xMzNNyyefMUZsAMlO2Gb1G9plDkYI1y5i8v0R0NTMzSmA7k o7xlXxFFHpm3Q6jmhBYrDKzcyoGSS1vgVZnqNJan23psetHfaI8DTHZX0Tycl+izIvvB4Q SVXwyI6mHOoCBuSPVnUzgH/lnqphycI= Received: by mail-pf1-f182.google.com with SMTP id g205so624121pfb.6 for ; Sat, 14 Jan 2023 00:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lZpVju+c3esZJi64lpN19QBiN5Ioh9BTNl6Imk6TaQ8=; b=YDkbWirrjszTbCxF/w/+kgQBI26iQK/PpN2Pj1Xd/qpJUr7uC2C4Umt1nkDmVNgYL5 +9EUfTmXyOCKO0w5Vcz+epHNUSG0dYzldYoPrNt3zofsDpl8OqfyLXstSE83vcrQrp/R fcm99IgQuqOctaqqAvPUkEpTaPp5ihSVcF/ltgxGCuOLMAeOpc9JFZP7zTl3f/iDX3ok EEdVj7+U+7o3c1Q/R59Vmm8ZK2QLM0qTgw68UfqgcYzLsF/pUDLgnctlcFqNdgVAXeih B5+mRish2KwjD7u7UO7r3lOyM9OmYRPjZefar17SYM27x2c0wZSnkvLu9kM7i5fUKwvs lRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lZpVju+c3esZJi64lpN19QBiN5Ioh9BTNl6Imk6TaQ8=; b=r6thZTfDRDWQELtlZw/5c5Fjy5Z8KZA/RLXElZCd6Km367x7eWWBWfND+woAJF5LPN FDeHeJyWPFHdoyyoDCtCRONG37C0Y/0F/V7/8Nm/GBoegEPY/goSzhQDkpUFc03k6tGF KrbY5Lh3z7VEVGRv+Ydsbs30qVQVKIy3At0Kj9eWfEwIX5lETfN5YGNEHrXQSd5J0tu4 pGYt9ZIhY8EK3D32JgbkS1TLzgE6edQajjTdTq8zon65qaVGvxofDQVs7B/1w9U0SAt9 WAimBFjQgUMDFe9TTVAavHrpu9O34C3o1wdFFqRsda1VyTBk3gGctDMCnubiFro1Zi4h X/uw== X-Gm-Message-State: AFqh2koNnkiN6JgDg3Fh5d+tuqXjQDJoiEABArBQXw5O+UPv+I/XLIMe aHuMQaNyLq4Rt/biWCW5C2mQHuDCDFef471xV6g= X-Google-Smtp-Source: AMrXdXsQsL3B/zYKPN9dUrbznfzAi6Xw7QwAsjh0FukLj4SuwnfW4cuGgva6gqrtIhvo+T9gnxMqe+jDFz37FYZX5gc= X-Received: by 2002:a63:ee0f:0:b0:4a5:c88:55c2 with SMTP id e15-20020a63ee0f000000b004a50c8855c2mr2584926pgi.530.1673683715615; Sat, 14 Jan 2023 00:08:35 -0800 (PST) MIME-Version: 1.0 References: <20230113173345.9692-1-vbabka@suse.cz> <3e419e8e-cdd7-eaf5-0572-ae5c44d7b68e@suse.cz> In-Reply-To: <3e419e8e-cdd7-eaf5-0572-ae5c44d7b68e@suse.cz> From: Pedro Falcato Date: Sat, 14 Jan 2023 08:08:24 +0000 Message-ID: Subject: Re: [PATCH for 6.1 regression] Revert "mm/compaction: fix set skip in fast_find_migrateblock" To: Vlastimil Babka Cc: Andrew Morton , patches@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, regressions@leemhuis.info, Jiri Slaby , Maxim Levitsky , Mel Gorman , Michal Hocko , Paolo Bonzini , Chuyi Zhou , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: CE3A016000E X-Rspamd-Server: rspam01 X-Stat-Signature: rp5t4skjdt1c1h9rqdyxm4n8ako4bt5e X-HE-Tag: 1673683716-882045 X-HE-Meta: U2FsdGVkX1+pzAGTcc2zeE8/CSQTELRQ0UNpuZtQPwbipUVYiVX1EBawDPRXXHnsvGhslSnkSXek1aJcB8P2z8uLW+OaNtGCKU7eQAAbeS9JTDfYXAEJ6wBWCuq1ynwDEWkASNtXQ7IbAPJgDmJiDDF4I/4UIxn9WyOLjmn0szRSSS9lXDT9SNm/fKSGM/42KszVz1xF1H1zlMYfPtaWCI0K6oWaXQBMKelLyhCHHrL3sAb1D6pkfE8b649969Z7LPuwhKC4/e2p9/Z2RjvbOokyKflpQiS32dBSjLLBD+FrHqDnAyucrRRU1H67dF1A26TMmf9BRFlkx8y5MwdNipnINL31OvGbZwCnDQnnz3lMGfvgmpVSp0H9jnjOFaq+M/wc/qh8ngnwwUgrukBD8lk4NJSY6CKrVvPEEsBnSf1jKJ+mX7Lsd6r6BOrmD1pN911gavvK++iuRMS2OMPZah77udkIbnXYuyoPALx0E+1wa0trSIxulvzjKUNWHGsmePinX+sYjysXY5wtL8OYn6sPiC/Daom8IOKnAInQyjkFTdWRpjLvAoHaP0zBb05d5EcKwOXUa7ILdr4eZjT6kHW+AvZNEsVFfd7IRjYVz7pT8tRFBw5DB08xeASrVYTtM92odu6hX8jKu4iZKJw4PzG301eZscMg94VZBM0V3wNeUNhd7SMLegJaGCKi0DotVuzybtYg+c6JWpCWy1PaVCOhjh52UWiEdgx9sQQ4FeEIrRrWj4Wj+EX1K+1DYQQsVePIjKxu8ywaFz6oyFEinhVjzt8JFKX3PF4LwWFAcJmznUyu0kDGHnD7zGMtKfzkiw9BROJWTX4eXM6RXO+IP5ig0s5IC2WdBiAYl5biJgdksb8E8793JXO15N96zPpOEjegpkFZmcHFuL9fpAyYsKCv+ycZ0IFTcn5WWmh/caYxfEh7bB0P/44yX6+NlmKdeh6lRv79kxRcyzOe63P 7SKx2dcd hITwWSj/wWTrKP9lhf7IXFGsVNdKc9qCmLgz7YaXv4LjChOzOyAIcgZTdZk0LzdB/rSk9W9tl4+3/czctn21RceEssjrw4BX7J1Q9/wk1SolDWsIsOyCHaO5BMb1LAyKu0Sn3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 14, 2023 at 6:51 AM Vlastimil Babka wrote: > > On 1/13/23 18:33, Vlastimil Babka wrote: > > This reverts commit 7efc3b7261030da79001c00d92bc3392fd6c664c. > > > > We have got openSUSE reports (Link 1) for 6.1 kernel with khugepaged > > stalling CPU for long periods of time. Investigation of tracepoint data > > shows that compaction is stuck in repeating fast_find_migrateblock() > > based migrate page isolation, and then fails to migrate all isolated > > pages. Commit 7efc3b726103 ("mm/compaction: fix set skip in > > fast_find_migrateblock") was suspected as it was merged in 6.1 and in > > theory can indeed remove a termination condition for > > fast_find_migrateblock() under certain conditions, as it removes a place > > that always marks a scanned pageblock from being re-scanned. There are > > other such places, but those can be skipped under certain conditions, > > which seems to match the tracepoint data. > > > > Testing of revert also appears to have resolved the issue, thus revert > > the commit until a more robust solution for the original problem is > > developed. > > > > It's also likely this will fix qemu stalls with 6.1 kernel reported in > > Link 2, but that is not yet confirmed. > > > > Link: https://bugzilla.suse.com/show_bug.cgi?id=1206848 > > Link: https://lore.kernel.org/kvm/b8017e09-f336-3035-8344-c549086c2340@kernel.org/ > > Fixes: 7efc3b726103 ("mm/compaction: fix set skip in fast_find_migrateblock") > > Cc: > > Oops, forgot: > > Signed-off-by: Vlastimil Babka > > > --- > > mm/compaction.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mm/compaction.c b/mm/compaction.c > > index ca1603524bbe..8238e83385a7 100644 > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -1839,6 +1839,7 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) > > pfn = cc->zone->zone_start_pfn; > > cc->fast_search_fail = 0; > > found_block = true; > > + set_pageblock_skip(freepage); > > break; > > } > > } > Vlastimil, Thank you so much for looking into this. I've been daily driving it for the past half day and it seems to have fixed my QEMU issues. Of course, I don't have exactly a test suite for this but I've tried everything and I can't get any of the original problems to show up. That being said, Tested-by: Pedro Falcato I'll report back if QEMU freezes the system again. -- Pedro