From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F01E7F154 for ; Fri, 29 Sep 2023 12:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2C78D00EF; Fri, 29 Sep 2023 08:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7930D8D0023; Fri, 29 Sep 2023 08:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681E18D00EF; Fri, 29 Sep 2023 08:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 577438D0023 for ; Fri, 29 Sep 2023 08:12:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 94C6DB49A7 for ; Fri, 29 Sep 2023 12:12:26 +0000 (UTC) X-FDA: 81289522692.19.D83B827 Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by imf01.hostedemail.com (Postfix) with ESMTP id D16F740011 for ; Fri, 29 Sep 2023 12:12:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pu+h03Iy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695989544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O6AGwXiXnrUMPXklIL5nmsijRotoMkC208+2TMbjvG0=; b=dOZSf/qf8dOrzjuK3YKdJ+i/KxQh08QwJYGGAr97i8FXf+z6x8WfLIJTDkberjdpyn8u27 6nflpsUEDifYGOwedB+uLvro4DmgAHfxM+9cEygE/81pBgx0Xj16udLsMr8koV1kiNCd9q 3mkhFN3j6C8NUewyL1KnRrzlsuvqs0w= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Pu+h03Iy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.44 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695989544; a=rsa-sha256; cv=none; b=mq+2FbepVEDcM3X6qnSL1eZXLn7r4me8wX9Jw/BUzLUFX5q+Da91cB6fYhsHKyC55Lw7hG s1BVrLBmlSglaDb8H5SLzAhHmfQjCyBlT8ZONa1RZiaoFQR21yxIiCRLj0jRdnBrUvzwMy 9mqSNn7l/r+s4f1ttW0ILlr9rnmjkvw= Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-452951b27d0so6687513137.2 for ; Fri, 29 Sep 2023 05:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695989544; x=1696594344; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O6AGwXiXnrUMPXklIL5nmsijRotoMkC208+2TMbjvG0=; b=Pu+h03Iy3f7Y2GdqFkWAHP4eokKpSM6EBjBKRgzZhiywZcMivJK0DxJcnUw+JUsP/H /MqNTBVD72wcDHWfXPnJ9VKxX35o6foCYDXTUZD3v9JK3lsDaNtmqw/qDNae19Xy8DuC 1F+rAXaej2FR0Q9NEypKkTCNr+mKDOrHHfcuj2z5T6z3323/deePk718sMsuGaphiS44 qFpjVUEMqFuYZY8FRDJJnaw33109EOHhLbIJPMt0943TtTimgmwjPJE1aszlstFop4wc LGQ0Zhcvm7XFjLoRmqVNr5RjhoEaNwMb9x7xxQgwsTs9NhBA8WSdRk7FS1D0S0YWrkAv h0cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695989544; x=1696594344; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O6AGwXiXnrUMPXklIL5nmsijRotoMkC208+2TMbjvG0=; b=IcM5EcxpDXK6RgftR8gGZ27Lvm+neHOxsvXNFm5ORTG56ksW/rkylwa+zbU0nxVs1C NL4gYKAPJSj8NqlpAnYhNiFdfaBCdsp6RZXEb3VtKPGBJEbNFv/9wJO0jtmqGasig5uD b1MBRbIi/WaYvOTRAH8sPrR2chmvYpcXTU01+N41roXcMreeTA/aDbR7GvICb6uVJTUu AtuSitiJsuJs7PMhrDa33Al1RtYBhF1U7vtnq/O+/38D7h3c2ia6QlY+02s0EcWgoW1H +b3jBVbLWs0c9aN3GMvLccIsWoR29V6xcdTjzEDkMT734bc08U4n9vKBiNmTU2j56b6i YWOA== X-Gm-Message-State: AOJu0Ywk2SVZst+Oey/JIquECV0GUBgRj9XyycoRIq3P7/0AfUnbwfmW dZBeC4LZpSr+XIu1uaypqr7XnjI8j4laBnk1HZVxjwUglNJ4iQ== X-Google-Smtp-Source: AGHT+IFL72KqbSIw/G7vE5rVtmiJ3L3ZrqYM/4H/e5qUq9cV909l+/PBvNa7N1kRqgXb9QMyFQV3Xm6Xw7VpBFtehK4= X-Received: by 2002:a67:ffc7:0:b0:44d:3bc0:f1bc with SMTP id w7-20020a67ffc7000000b0044d3bc0f1bcmr3884563vsq.18.1695989543918; Fri, 29 Sep 2023 05:12:23 -0700 (PDT) MIME-Version: 1.0 References: <20230929031716.it.155-kees@kernel.org> <20230929032435.2391507-4-keescook@chromium.org> In-Reply-To: <20230929032435.2391507-4-keescook@chromium.org> From: Pedro Falcato Date: Fri, 29 Sep 2023 13:12:13 +0100 Message-ID: Subject: Re: [PATCH v4 4/6] binfmt_elf: Use elf_load() for library To: Kees Cook Cc: Eric Biederman , Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Sebastian Ott , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andrew Morton , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D16F740011 X-Stat-Signature: ob4f9c6otzzk4jh43xsehdkfjpy6rrtx X-Rspam-User: X-HE-Tag: 1695989544-250269 X-HE-Meta: U2FsdGVkX1/gP4HP3A90dvsUMu9qzu74AjgWrmUUUysU3Pamh1MUeW8mNha6BnWmeK2v5H0kXHRJ3LbPfu6SrlZ0hiqU83Kjgtk4lrrhNVStRjVc1E5AToQAEqzPpBnnmRAryNG/fXkUHWGdrRFQ1QS34KDH5iE5Y67aptiV1eUR4upU7wy/m1r57PxQ1WmFxrSN3tN8nHpBakeAdjscHi6TusCPLkO3EdaTmQlc0J665rZ4whxB6XOZznV/iL/R/Ms3KZAcOlv7As6pG6BZ6ZTsI4XFetR0Sj4MtWs8Va5/atqVNXPaU9nix4veFp2iZW4Dt7v+LCG/ZQVb6FEpWdOlvn2rz9xkLO8iq5or+Rh9M4osNpcU6LC6k5fRCXUmILsCagwNJRXY5Xiu0iy8ImWf8HTMCfA7iWznyATwdLl8FyyCjfS6CAD10kYuIOOF+pbHHNHcPHsZMOpTdLT2/pf0A48mzSrf4RM4DIntBIyTAWiLf0IcYoy0hiICvBHUbTgTDy/2fHQnf3nY22Pfs+/MY9hfpNr1FzMWdAXi/XDZItX8RXpWF0OH9UKa+GEVFXIb4KQbE0hXhF98qB5SUoRiCrD/99VYzBXFef+Sj6xiU2nSYiy0+b4GLleTlfCkXu/4yW2YJzvFWw9rUFTxonZYoJ8eqMvNawqm47X3NxEfe/DXQu96/mvKCcU9/pNL4hjR0CggmLqiwu0y2NGCUiRaVIhWymGgX5j54rKg18qEwmEb2o0ABqzf+G3CfMhAqwIT1gSaGNzyB7vQcPXp/iW4NEga4AzsezyVcVL5VRpqL2+OktWMdqNaERjD82Oq2jSJeE3xjTbEqhSndgHhZ5RISBdPzqPY9BmOzSIVLU+B946YJ4VRMtphrOtRY6qQN6lbHLwuWjRmSJKyhYKu3jIHMLJS+cWRw+BQ84BjXV5dSb/e+2cavDcjOoi8zZ6M3Q5BMeWVZ+vJU5LAq0u V2365GbX bF5Sk/AS0ZeGADhTmWQJavRythwU8BG+4qSBK1lrgGBML/p+1PtEhipuzN96KOZT1oP8WYDCDWmcM51KQ8Z0jlSMAN6TJ2vvrXoeuZ3UXIsre5fDm6JXBA8St4nX1WZ/GhWHS1Cc4lTgnWDZkKf40ARGNMjX6cDKlp3as/FrhdnqGRVlIb2u/MkoIYlE/UXyVOoSbYuglCcfLepjAGOud6qQFAFei5yfh5QbS543fuHyigknhat8i80tAp5yd2RHhrzcjGzHfDV3l/t1YX4iegYSfPlFrkARPgPe8dJHtbcQw8MHpgQKqSVoQwRNdmInyMN5tCgIL82jHHw7E3obIRzcZVsLTWdkFTB5XKdSo64jVcCWi9nCHdVpZg9Oz6hr8LMYQdyFnI/a6eIwqA0/hlDbmwH/zTaexjWCMiX+YYyHuGpvp/KLNAPLqGBoH5Uqqgr1wbUNTVQOimhwV9vPI4FOs14iEi2EE4XAbpmGlsHt6Riw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000276, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 4:24=E2=80=AFAM Kees Cook w= rote: > > While load_elf_library() is a libc5-ism, we can still replace most of > its contents with elf_load() as well, further simplifying the code. While I understand you want to break as little as possible (as the ELF loader maintainer), I'm wondering if we could axe CONFIG_USELIB altogether? Since CONFIG_BINFMT_AOUT also got axed. Does this have users anywhere? --=20 Pedro