From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC72D5C0C5 for ; Fri, 8 Nov 2024 13:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C28396B007B; Fri, 8 Nov 2024 08:48:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD8166B0092; Fri, 8 Nov 2024 08:48:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9FF06B0098; Fri, 8 Nov 2024 08:48:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 89E1C6B0092 for ; Fri, 8 Nov 2024 08:48:07 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A64AC140C96 for ; Fri, 8 Nov 2024 13:48:06 +0000 (UTC) X-FDA: 82763056236.14.F8983BA Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf19.hostedemail.com (Postfix) with ESMTP id BE5071A0003 for ; Fri, 8 Nov 2024 13:47:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d9cQMqqL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731073514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V7LsUM1cFA3UgXJwuW2E2Qmgqb4a7XdzHCxiALyKrCo=; b=gMK258drmBDC4SdDZYaSTrWOgW3D+m6iCtev0BKexH4HWnHD6Nfj6AxdDivbTDmIleTrtS lpPox34BD7FV9CYULbyicxXEVKt7WlJVrX23O5u2E1rP/Q0M8bMyVcd961SihjY7tatGro IBVWpVslODZxpUyscD3GdtTyzjDPdcc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=d9cQMqqL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731073514; a=rsa-sha256; cv=none; b=nInhXcSvzPoMYEqzfAuSA9PbCJGMd77GbnBWwGlET9PfL4IQnIhh4d3xYmubuRyB/uG2b+ 7IA837FcTibjK8U96ofv4iwSrTltpDHOjYFn/fXbBJzRwH9qzdS1dog9M4COxZ4ToS1mBc cM/PtFz4pJ3DiVZi8kmgTDA8vxmDX6E= Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-851d2a36e6dso2493222241.0 for ; Fri, 08 Nov 2024 05:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731073684; x=1731678484; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V7LsUM1cFA3UgXJwuW2E2Qmgqb4a7XdzHCxiALyKrCo=; b=d9cQMqqLOUYsZxR41VSHzNXqxVsLo4IuhC2gPyd7/H+3WFq4myGx9H7PBYOYAwZBtS tFQiGhdenmE1Wv/ZrNpF+EB7Ly15/AMUx/Oru4sEQ21wCYAsRIL5AetsL2Qv4p0YLqJa 6qprft9zGkouRaXlw3bwvBFCZijLAC9g5IBJIVaBkpy0SKWBsergKGyfFUMTU9rBak7u v341gJPCLRiaCFRAMzPuFxDNCUJGyPS4JBF6Yw5XcMHDfBV+XfSyIuvToWEGz13INsj1 1xqt+DWCxugkug0tqWzqSQUPKo2JtHZpNCx6uS4enXOIqo4a/ED0UY5Hixb7eGcIyGv4 wwIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731073684; x=1731678484; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V7LsUM1cFA3UgXJwuW2E2Qmgqb4a7XdzHCxiALyKrCo=; b=UbFMLF+Nlnm4y4ZgfnFHihTVdNdkGutxwkz8xkprqDO2wu9qrValWCcomLdlbPAVFg C4eHoroEyVOBnrB2jPqaPka2vEAdWTq4Vl95t2a2fqGqQUTCX9EhVTXg+eIf0fSfSg87 hVk6CgR5mCDKhMgzazZCbCPxEghVlSthDKPGdH0jLNKa2In+D2ddzpBQvNNlTRPHRF7D czcUoDuO8UX+DOc4SYp7+iw3znbC54Dfq41BuNp3DALEsA9LeVGvwe9nvUnf9F/qPTG8 a3ysQWGqO8g7SJbQI52BPQE8uiulPzZYmo+3W1YBveDWuHCcKyxmS2OrCrf90442kbFm 6rQA== X-Forwarded-Encrypted: i=1; AJvYcCUxb3AV4lHNragm9wDzfsyXXoYgpBYIDZrdU9dLOXowY2iro5+VYD9PeehyZ+JKD6ls9j+B42KdDg==@kvack.org X-Gm-Message-State: AOJu0Yx6yyp0kp1+pXEGqMNPYfLHzuKdteToQxAZKrU0ZlsM8W2VN4Ue 5eoXRwPtST0iIxc8K3bgUnU/6y41jGC+hGhT7kvbZ3Kvg0+EvFkuZ0BERotqRWYfTlaNLiYachj o3RpQdHFOKJhIUIxNyFUnzSXsgoE= X-Google-Smtp-Source: AGHT+IEA/CW0P5hh9LF9e1YZRQzI8NjKvj640GmwEtr8RoqNJ6UBeqcHoxckXFlAuasI3lBR40mkAH+KHGWqn5rXlmk= X-Received: by 2002:a67:f997:0:b0:4a4:7148:85d9 with SMTP id ada2fe7eead31-4aadfc18b03mr3094337137.0.1731073683980; Fri, 08 Nov 2024 05:48:03 -0800 (PST) MIME-Version: 1.0 References: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> <5a1e67c3-481e-4c6e-8507-5a8ea0bd9f28@suse.cz> <27ba7473-9255-2407-8e4e-e5c3cafc25c4@redhat.com> <58fce0d4-9074-3d98-5a1b-970371f0c23c@redhat.com> In-Reply-To: From: Pedro Falcato Date: Fri, 8 Nov 2024 13:47:52 +0000 Message-ID: Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists To: Vlastimil Babka Cc: Mikulas Patocka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , zkabelac@redhat.com, Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BE5071A0003 X-Stat-Signature: kwrjw1km7geg8mzsfqppanehxtdpsz4y X-Rspam-User: X-HE-Tag: 1731073638-498689 X-HE-Meta: U2FsdGVkX18dUVbSmTxHhovAE5hQhivZyZ8/aAGdikieunIyzVppvN2BmcHn8aPjkCMn5pi/s+vPcvzceydK06fHw5tlEX210yxKnGd0IISZL3ZKnNSSPPFz0STVYYouLUA1Fws5W1IOlCml/y0EF8YVNkUh5BBiEXX8/Z1vI3MbZCwvZBFC5Gb7QOSEzXVWhqWPt9ml5cjWPycLc+NtHVgnwo1HhjQ5ifBlx1qjly9haWbkCGQ+slW8757mNTXCN9khYK5Dv1cnQVki2n+ZIMH73mj0XOnbt7VFybM7NPMgGiiIYDJT5mraKYjcvVYq0EMc1IwTuwU8UkBgH6LM2melB4j4vLeFQfwwV+gm1DL08nU28ArUg6ltFiUQTsJh9RJNcu/4vDa2LYhhczI5u9C9FW2ADsyLPGH0yY+3NnDIm5PQx909+pAxlCUwe0TAntQOPS0/52qqNU8svc/yUaunveMGuf7mx3deLu1Z7dhTRaF06TtIOE7jh/39qatgXhDHYhIktQupAoLRN1RnsB9fTyXBNp/uS+dc40Xqe4iO0BXnLk7gM04Sn8KO9PL5Phl1A4gmegqhUp3PCh0y0Oypn/zUIZxFpQqHNNXUsNVfrxj/M0bLbgGZtMUQCbfdt0e1toV8WUj0HAsG4rn67QyqP5QzlCHG/6ffF5jEJuLQ2vrmGE2kkGIfP/YJ3K592kwWxZbV4p0YNvsQsw9daUVGe/sNrUKSdocb5NLLlsAxTVpom3uNUykSuNY3PMD8KdOybPaHZip+SX1fMLHpbHX1RKaj5Ek+AWHGryX+JiwaHWVYixl5h2QYGn87i5C7x6PdfZn84w766r9O8QZLd8iB1Ge266kBpDzEyPrFg2dT86ZrXK1b90AQXdDKXVDRuoq0qDhpPlreBW8Gsrac2bYyEyKIIftOe+jUdWlwnU2eJ3hWsz6NrXB4E0haf1kXJUCU3vxSdBMSTI/vTFq a9APWYVy PIk0tnX6mDkqqHAxuPaU86b77p78uZ4JeZ4ElljABTo7S4abKFYoWpGHE8Y5V8+Wv+vE4eBnG+IAKvp+Tt232osfq5Jxq/ZgyPY4kmzudf6IH7pvdX9RMztNpTbkvRbscRgnVK/4Y+SVKF1WCDNSSkDAyHhbs8GPKS7faLPMq8zPlPczUSxzccBGwI2liqMCVJJr1BEhliV2jAFa2Yh9M0s0Y6v8+tdrzFUnYeeI8P/vsFceoeJ8tMBg7HLla19ehHvGI6GHGAQY+jLnGL/eVypQR0RnJU9Rr32gc6Hv5RgDQF2xCJJ0zR6pfjMg6BE7/q+kaBoWD9e+9wRAUKwHEH8nOStnfqaLcR1BJUOvHTCx9H6XvMQbZAMhRF+29+1hVb/cmMjO14os2Z6BQpxbISuhi3WhuoKpTEYzQ8SVrC1iGJ2dgsRGB8zBYEvJUXUnd64AxUEkec3H1dEpMIxQ1dj8kHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 8, 2024 at 9:56=E2=80=AFAM Vlastimil Babka wro= te: > > On 11/6/24 22:22, Mikulas Patocka wrote: > > > > > > On Wed, 6 Nov 2024, Vlastimil Babka wrote: > > > >> On 11/6/24 13:05, Mikulas Patocka wrote: > >> > > >> > > >> > On Wed, 6 Nov 2024, Vlastimil Babka wrote: > >> > > >> >> On 11/6/24 12:19, Mikulas Patocka wrote: > >> >> > Hi > >> >> > >> >> Hi, > >> >> > >> >> > The commit 4c39529663b93165953ecf9b1a9ea817358dcd06 ("slab: Warn = on > >> >> > duplicate cache names when DEBUG_VM=3Dy") is causing large number= of > >> >> > warnings about "dm_bufio_buffer", "dm_bufio_buffer-%u" (and other= ) device > >> >> > mapper caches. > >> >> > >> >> Hmm wonder why nobody run into this before. We thought the code tha= t would > >> >> cause the warning would be all fixed before introducing it, but we = missed > >> >> some, sorry. > >> >> > >> >> > I'd like to ask - how to properly fix it? > >> >> > > >> >> > We create a "dm_bufio_buffer" or "dm_bufio_buffer-%u" cache with = every dm > >> >> > bufio client. It used to work (and the duplicate caches are merge= d), but > >> >> > >> >> Note the merging can be disabled so then it's really several caches= with > >> >> exactly same name in /proc/slabinfo and inability to create their > >> >> sysfs/debugfs directories. > >> > > >> > Would it be sensible to allow merging caches with the same name and = same > >> > attributes and only warn if there are caches with the same name and > >> > different attributes? > >> > >> We might consider that. > > > > That would be good - so that users don't have to write their own slab > > cache merge logic. > > So Pedro, wanna do that? Or Hyeonggon maybe? :) > I'll take a look this weekend, now that our polish friend passed me the smoking gun ;) --=20 Pedro