From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD789C3DA7F for ; Mon, 5 Aug 2024 10:24:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 565526B0098; Mon, 5 Aug 2024 06:24:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 514CB6B009B; Mon, 5 Aug 2024 06:24:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DCA16B009C; Mon, 5 Aug 2024 06:24:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CC226B0098 for ; Mon, 5 Aug 2024 06:24:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BFC73161C80 for ; Mon, 5 Aug 2024 10:24:55 +0000 (UTC) X-FDA: 82417808550.26.7020B1F Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf16.hostedemail.com (Postfix) with ESMTP id 03924180005 for ; Mon, 5 Aug 2024 10:24:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="OEG/QtMS"; spf=pass (imf16.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722853412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tMkeG4izRg3Cy2r8N32ZDttVGuy8Xq+hXqAv8E7cHFU=; b=R/caWnieHNd3Ak6+1qypBbop0X5cP6WduMuE+NxknjB6V2apDCXrmvSLeDKRUWKgxOvuKJ rVmO6qjseRx4r66rvJdsDNc3kOb65vF/3MiEPzORRMtUrnkFdaF9fnBdUK3MocGmaSTW6N 4mjCIOzw31Z6BeWLLWV76YEpN7K1+Fg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="OEG/QtMS"; spf=pass (imf16.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722853412; a=rsa-sha256; cv=none; b=b3/QItg81g9s3WLPLLjQoCOE+kxJRV+Z+7OKWrj0cejz3/rK6QkDuCro7Tf3kkiKiiOGhG QxiOPsmA4t3PTaOw/0KVM6YpQ1dw+8wT2Dhm58nPXhWhbhkMsrsw9/Q8PNh8fUx9DzyPIg XbtLod+ufArskquOFGFbIv7QWeZI24w= Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-4f52bd5b555so3121362e0c.1 for ; Mon, 05 Aug 2024 03:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722853493; x=1723458293; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tMkeG4izRg3Cy2r8N32ZDttVGuy8Xq+hXqAv8E7cHFU=; b=OEG/QtMSMe4N7ONzS0vzqWqzsRgV/ggu4PFIbSzaPqUXoZTDExyOFNHHCJ1i7EG9Oz kxD5dhM0v7NjCV0bsf20rzcLGH9Jkc6XoIxHc2SXmI1UeAbrcjgBztJ4vNL2jIViyXLO sLu4xAEDC8GgjBpDQQJvvMF6IGk78I3h514qR2C4TjdR2xB/FT721YTAzvdR9AoXmXCh 7oew7B9nA+RECaeylSyfijwytTqrtw/Z3kNwC6i7NIYxJicf2IUmQ7xFiCRbONX9Gj9p vsamnVfXm+QNeSvqMyCmNI7qbG1aGEYnbx88wSJpbTMUmSU/hZM3CVobyxwHCxMBRvbZ /vVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722853493; x=1723458293; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tMkeG4izRg3Cy2r8N32ZDttVGuy8Xq+hXqAv8E7cHFU=; b=OUogAmmB79x8DzGWwBe+CYTdY5d9eUnD92PO7U7Az6DRZIDIFIfpwVDaUX+WKfBE54 EududdfgXOwUBc3jQX78v5iFVWluNMcq/ggHnkmoJF4cvU/BokPA80KqvpLldhPvtQXK X01a44HwXeI13UYWxWvKcN3Dk8g7EVyHE3q1msdChCD5fPdIrYoP24DcfB/AHLKASKeG d2DeT5W0+AcLgW+Bn5Tcl5okBXIHaWj/8oOpRY5kijP1KkyzSN6FHOoEnMKZo7fl/euy 4dYIMochCC651J3T4FbKY3h0k1x5rY5hiEWHqdHBGzz6YdQq9FOhcxUxcrYw+CkkIioG JxlQ== X-Forwarded-Encrypted: i=1; AJvYcCV1sSGMe/HBwqRkgpIkuAdqbFB4NBfyp2rC/7bgygc4f19qPR1y8Ou9Gr7ndOhk5jgvvTTippBE3qFE/aIAGj0t5rY= X-Gm-Message-State: AOJu0YyNbMrjFV8fLUQMfzcxanVGxNsrGtwSdysFwO58kZz4WCyBpfGV ApOqsu2Sqh0Fyo27gq1IHrogcd6RIeoShN52sfD7yzfa+L6qI4zM/Q7asDNi4EVoNMTx0svc94R +yQWoQ3MqffVhovSrO/RadiOy2Wo= X-Google-Smtp-Source: AGHT+IFs5C6I/kpXxdQc0J8NsfQIiE+eZWbHqvAeaOrKb5oPCoEwogoGU56iYNVe57kTq4dPEHvevqYcnT0+GFxqbMI= X-Received: by 2002:a05:6122:da0:b0:4f5:d98:5ec3 with SMTP id 71dfb90a1353d-4f8a0ebf1damr6875199e0c.6.1722853492977; Mon, 05 Aug 2024 03:24:52 -0700 (PDT) MIME-Version: 1.0 References: <20240804212839.685795-1-pedro.falcato@gmail.com> In-Reply-To: <20240804212839.685795-1-pedro.falcato@gmail.com> From: Pedro Falcato Date: Mon, 5 Aug 2024 11:24:40 +0100 Message-ID: Subject: Re: [PATCH] slab: Error out on duplicate cache names when DEBUG_VM=y To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka Cc: Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 03924180005 X-Stat-Signature: 5biku6h56ra9sqxyhwfko557n8t3zkwd X-Rspam-User: X-HE-Tag: 1722853493-634541 X-HE-Meta: U2FsdGVkX1+ZCYUAbCzzDvGqRjo52kd6sy0S7VLGb1JNxsqT58tBlhf9MCtlxfN265oJdd22GUJyvK13QIFK1z29I6liaL+RPM31wse8IY0Qxy9z9zePfSwLOVN7FgrEIAJ/lYsT83Bn7CZ2Og9U57lh1Y3CTFF2uCEB8xRwPelX0KDsiWKjJoRq++RccTUHwFc+BOG0Q6+G8OBetrIVVCAcFsw3eJFKc7R4qTmvCQEmU9D/9BnUJwE6f3JK15peGJtLFSuNUtHBiXTXwyjZfAHwDPrAuFq5RZeYSPcBjfvkOYn5ZRjCz11q+4J//ipCm6tkzP8YyNm0RoG/sPRlCIFqd0vb4udMbGczovz2qyOHHDOFOC8Y4aD+fTAFbI46+zQ411gExz8vOPV7e7gGoC7n/4YH8ZNqIq3lUjxZX1Ww9nKqCxcS/7SxWQHDy95BsLI8LraLTCJ6/M53+hcoF3r3Zl9v15uNGd/egGh5r+4TD7+D4GSBLAqnogM5d9aIZbxVS5UwLOM4YGZAojHFx118rdVzU4vea/GJ6OhIFLlVKJjKIOmq8zrah6BxzxEFywsYmnisKtLvXQX2xZX/HOSW1evIRoJhCmQ1fzt+LyiMUIhGmauNV1xuOyB2jvBGZzX6N9L+73aof81uBwpo4jBeBe7EmzOmJ/VIzJhZPdOTEcQjdHE7SOKJfknxcNc6oK0oK4qsBqG/bWLVcWc2NrH5+3pWviykAVsIPeeApNVXG0MaILTy5xHilFhZY6lxUHkWVwXlzfxPTrwevxNagikqScV7zvvhD8vOQ3a/+J1V1rxnH/cy6ZAy/CbMaB7nV5axI5mWlzOrV3tBZ40CjapNf7Xl9rgx3WJwqdF11xCL+TMBVzoPV9yZstEqzpyU3EL/gS+EyCOHOoxBzxT8v633hInnXHgNPqOt3e42lg4H/mHOui+51I8w84JIRLotxaINqvTtJMHm1Hs0wwd 2Gwef0L8 8OzNfaZ8p7PQO7s3BAZP+yBO+abYkz59jE6/2YCaRERM1NOHMuYlRHCJVK/DfWWqGvxiW0KJ4f3spL4C05vQS5F2RnYniV2JFvTeolcGCQ+X0AfeFcIveC1/c3rahRRK+LB5QPx+tvZklBxDwQqLRHN2b/+r4INI4C8eF94GXyam4rVr8uRQtvgindk4XLjW43XIfvcY8mGfNLrjh0jU7+R71Q9l9+wsoZesqF20O2czgRYhGEDj5mfQRGqTywUAkt2BRkD3u34akazstei9CXOIJDllhivAHyEI0r5sbg9McEiljmXUsY/6CftSZsefAJ1L4R7cK8yeZlXfnrDlDKw8TGhz/vq47VHZhGHYGoZwQ//nc0YYtOcZ9/Ke+Z3MTZMeQ3k/FVUADouNCjutNSYBw2yNkCPDyfxhGnvhPXfVGng/NNDPk1BuvTvQDIPfMQ8miSgOF5X/7aD93gYs0q+epoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Aug 4, 2024 at 10:28=E2=80=AFPM Pedro Falcato wrote: > > Duplicate slab cache names can create havoc for userspace tooling that > expects slab cache names to be unique. This is a reasonable expectation. For completeness, I just had a look at duplicate cache names around the kernel using git grep -Eoh "kmem_cache_create.*\"," | grep -Eo \".*\" | uniq -d (which seems to be correct) which results in the following patch (on top of torvalds/linux.git master, so file_lock_cache hasn't been fixed yet) This patch being so small is what leads me to believe that erroring out here is safe. Of course, no one knows what the out-of-tree modules do. diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c index cc824dcfe7d..abc78320c66 100644 --- a/drivers/scsi/snic/snic_main.c +++ b/drivers/scsi/snic/snic_main.c @@ -873,7 +873,7 @@ snic_global_data_init(void) snic_glob->req_cache[SNIC_REQ_CACHE_MAX_SGL] =3D cachep; len =3D sizeof(struct snic_host_req); - cachep =3D kmem_cache_create("snic_req_maxsgl", len, SNIC_SG_DESC_A= LIGN, + cachep =3D kmem_cache_create("snic_req_tm", len, SNIC_SG_DESC_ALIGN= , SLAB_HWCACHE_ALIGN, NULL); if (!cachep) { SNIC_ERR("Failed to create snic tm req slab\n"); diff --git a/fs/locks.c b/fs/locks.c index 9afb16e0683..e45cad40f8b 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -2984,7 +2984,7 @@ static int __init filelock_init(void) filelock_cache =3D kmem_cache_create("file_lock_cache", sizeof(struct file_lock), 0, SLAB_PANIC, NULL); - filelease_cache =3D kmem_cache_create("file_lock_cache", + filelease_cache =3D kmem_cache_create("file_lease_cache", sizeof(struct file_lease), 0, SLAB_PANIC, NULL); for_each_possible_cpu(i) {