From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E401C4332F for ; Fri, 11 Nov 2022 17:15:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D58866B0081; Fri, 11 Nov 2022 12:15:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1358E0003; Fri, 11 Nov 2022 12:15:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81016B0083; Fri, 11 Nov 2022 12:15:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A42B06B0081 for ; Fri, 11 Nov 2022 12:15:00 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 693AF407E5 for ; Fri, 11 Nov 2022 17:15:00 +0000 (UTC) X-FDA: 80121811560.28.8D34E9D Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 1C4F1A000F for ; Fri, 11 Nov 2022 17:14:59 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id j12so4711046plj.5 for ; Fri, 11 Nov 2022 09:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VaPoeYE4uEi9Lmo7p9yRpFWEg7l1U2uEZTo6yD3TkRM=; b=lghTviNWaq+AkqOQRd5UDvTAxXSEy7IeXOvFlezCg3KZ4VkOUh3Wn9AWjzmSqeMVPI 9tWkEXiZLMR/IpUAKuosI6h+Ykg6p/T0hfs0PxodRkgccD5nWAaZvyo86cvt7/d0Gqf/ tIMkuvVR+AnDBd4cGDrAGKwgGqHZMSSabod95GAhwceSSImLnx0AmzMJadnWp/a05+gd waUrejkaon/AJK/xfGprBQm2ML5Wr+cj/vSiP2zlcUjjCKLUc0imwHpPy+7VKWxOPLOp x+9cTL2iXG4G8PCQsgxeZsXYBkQNyPmgO4SpOvK604wJLBKbv7aiscKSOL8FNzai3zzO 4E/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VaPoeYE4uEi9Lmo7p9yRpFWEg7l1U2uEZTo6yD3TkRM=; b=j4y0OCxYO5LofWpK2+7AtlXtXv0VYd+nneoNGfXzdbqPZbs1YBLZ0exlMG6P0vQT4R Ds6hWJUd+jFdhqklciouNSkS8oRjnDevR/V7wr/ZQarug3BFdadSPQSY9Db8F1Z4Pk+l qOkSQy/xnuC7NvQeMKngWlJX9w0ZvWZpF1Bm6c7EQDDy6+14t/lUGywDI0IyjI8wDY5S H3mEYfw+Xcb2SDXYMbb705pgo6Vj8RQWpl6lqu1SPYqe3ZgkEWu96kVZ0OBgP4kEpoeO HHNBQDp0fintWKIJ5SyYYeA9gFqKwrGdZL6xO92l2HFSWAydOHIiS+4nft1gg4b5z5ld vUuQ== X-Gm-Message-State: ANoB5plXBgysaOJ+gz+FBYHhKCwJwrvcNy7ANCzWIkxfAICDOEtj/eO+ nQfcHHivPkXy24QrTOT5eJMIYeClfqllKB4I3eU= X-Google-Smtp-Source: AA0mqf4ZJx4qqRa/BdK8gQWNZKMu3MCDEQvRH3e3ZoU4lsON/NGPkpKfE2JGmKB2rzeH5Pv45K1pMygdBG+Iw2g4SqY= X-Received: by 2002:a17:902:6ac6:b0:186:a8c1:884f with SMTP id i6-20020a1709026ac600b00186a8c1884fmr3630644plt.25.1668186899027; Fri, 11 Nov 2022 09:14:59 -0800 (PST) MIME-Version: 1.0 References: <20221108110715.227062-1-pedro.falcato@gmail.com> <202211101934.22CACD615@keescook> <202211102214.D764FAE21@keescook> In-Reply-To: <202211102214.D764FAE21@keescook> From: Pedro Falcato Date: Fri, 11 Nov 2022 17:14:47 +0000 Message-ID: Subject: Re: [PATCH v3] fs/binfmt_elf: Fix memsz > filesz handling To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, dalias@libc.org, ebiederm@xmission.com, sam@gentoo.org, viro@zeniv.linux.org.uk Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668186900; a=rsa-sha256; cv=none; b=We/x3AGwKo/6BwAlMRwYuMUfpj1zVdMqfm0M2xVWrPL38HFGYSDyHN84wAdr7iJawX4P0C 8u0RTieElYbJLG4fZ/9gSa9Qe5SeLub0fjHI3TwX6z6+ws1xgFakD1Z+uUFBF4hK5MHCP5 9tcuzbj/E/A0HvNlD8jRrv9yNgA+U3E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lghTviNW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668186900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VaPoeYE4uEi9Lmo7p9yRpFWEg7l1U2uEZTo6yD3TkRM=; b=Rtas83FqHo6vFJz+3SbO0nvzJp9R6SJE0SgKhoOdKWqK0GZMXYSZpsTN8fQGOvY15cZIW4 o0c4Kc3vGahGibZ24RhRoDvRNvZuRuw4uPUIFuj0jlZblIWt1BCD94tAYlER0/3FaPhjEa 9GmtpIY8r2ymjguZkiqDfdK5BHYiIvw= X-Rspamd-Queue-Id: 1C4F1A000F Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lghTviNW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Stat-Signature: rgih7jzw5irqk85ydkmggnmtfwbdaek1 X-HE-Tag: 1668186899-724847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 11, 2022 at 6:15 AM Kees Cook wrote: > > On Fri, Nov 11, 2022 at 03:59:08AM +0000, Pedro Falcato wrote: > > We could of course also just sort the program headers at load time, > > but I assume that's unwanted overhead for most well behaved ELF > > program headers :) > > Large refactoring of the ELF loader needs proper unit testing, and we're > still a bit away from that existing. In the meantime, we'll need to make > very very small changes to fix bugs. I've sent a minimal change which I > think should fix the problem (now at v2 since right after sending it I > realized I was trading one accidentally correct state for another in the > v1): > https://lore.kernel.org/linux-hardening/20221111061315.gonna.703-kees@kernel.org/ Got it. I understand you may be a bit nervous deploying this patch ATM. What are we missing for ELF loader kunit testing? How can one help? Note that my -v1 is still relatively safe and was already tested, you could just apply that. Thanks, Pedro