From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4370EC52D7C for ; Mon, 19 Aug 2024 21:00:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A00706B0082; Mon, 19 Aug 2024 17:00:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0706B0083; Mon, 19 Aug 2024 17:00:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 878586B0085; Mon, 19 Aug 2024 17:00:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 64C0B6B0082 for ; Mon, 19 Aug 2024 17:00:23 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C8351C517D for ; Mon, 19 Aug 2024 21:00:23 +0000 (UTC) X-FDA: 82470213126.05.0BA4D5F Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf03.hostedemail.com (Postfix) with ESMTP id 413BB20029 for ; Mon, 19 Aug 2024 21:00:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hs1fyKam; spf=pass (imf03.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724101143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5tXNZjwr+hBs8nEysGgHixtJhZqND0ZaCAsJOcANha8=; b=2wXMMp8bPYlF2+oufzxwYvUHmI7Eibsk82IYjlAO+Ti6H+R9Uuh1L9+eGCv3fV4oIHvfBn V5duI+LoGXOtI//sBVjFnC5JK6qMvCl9LymYXbqAZAR6TuIgZyEyKiqjf0TBoVN1zsCxNL 6n+Rl/638FvumoftumjLy8n+d0AEe28= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724101143; a=rsa-sha256; cv=none; b=zHFK3ti6hWwJp8Jm/RfLgg/3aVXIlcolLBM72MCfzFT2lLbZrS67NKX+srwzNiKabnZ0nW tdcnSjbVRrlVVtMU69DWxoDSGHx+BdgRnoQm+XEG9O1eGARLmBKREbgYAnRM3pFRT/mlum 1+CVttyoBoI+LJ0sDvkTNWVnXKzAZfI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Hs1fyKam; spf=pass (imf03.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.217.54 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-4929992a5e2so1636382137.2 for ; Mon, 19 Aug 2024 14:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724101220; x=1724706020; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5tXNZjwr+hBs8nEysGgHixtJhZqND0ZaCAsJOcANha8=; b=Hs1fyKame8xrqQe1NXq0DUjnxcr3mGIMzwTEqYzB4UeR63NUgDguw8mqRby+UBAldS H+nfWfMOafiE7wqM639oOxdYhKd4tY0KCsxHEfIIuxr0V6SPmrYHb6qHAnVhcKIyVw+4 +gVc4P00tFBnn8IJppYDfxJXpWRYlxordaXMIiEsVwI0yNu3z/+XOZ9ueKLRJ21aNONX V4J0pcH0XzxMR0WQ9AbnAsiWvoKMxF8FEzeN9c/mQzZ7z4EJpnHFSHR01+cQRoiAX1Uh GKrjxCv6NlJi0LkS+ErwiopZOgZ1C2oFl5eoGbWoc59cqeTVU3n3BHfDQR2yhZCj6p8a diyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724101220; x=1724706020; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5tXNZjwr+hBs8nEysGgHixtJhZqND0ZaCAsJOcANha8=; b=A2Y/1moN8mu3vYeuz13+FemzkDoI4xb14iPy1Wrxc4Y7uixJ8fLTKK+uMR+wurvaMO PAvntnFPnCtEWR/70lxQ/Ru+m9S9mT3E/Azakwu4vTQhq5NjJljUtJqb4Y74uPCEarBf WkdDylKyYd9bHmTIitA8YFXEDcDLfF1WLoxfarf0k5MKD/QSfk2t4+mOgN2saqFjHFdk ZmgbsmrNMkQp+6t4F8tkz7N1DGJFAET3YPSdfYJJ2zjekXAUaEBNvOoKl9PMAoeKiHQ0 rbmBHVbk0aEgzGe5SUXd99s+dHhMnnaD55AAN9hpMEsoXQ2G3+qovadMgVpmVAVSFExr u8Wg== X-Forwarded-Encrypted: i=1; AJvYcCXf0v0VvdewdFcPAvl9+5c1fPS2JcNSLwtE2WW7QkzMNA6WIUpYb7y6EAfQ/wBGSyiPeXG//TpDu762fRKHVTLjMuU= X-Gm-Message-State: AOJu0YxzL9IugHqHz2za0fgM4/vZ+a8DENasCP4vnAGSDMKpC3nWT/Ay MbOZC0Jv34Gckjni+IlfJxO6RppsoIoccYPE4UnhASoUbbjhtMJNvZQJj+ROtEYJH+IjhN28K1v rd6nUxUb5pLyf6Xm4S9ECV/JSJT4= X-Google-Smtp-Source: AGHT+IFgyf09STPsI38BphKGnEeIk0IuhIpUZe4M/rkhpaHXmXXbr2kT7JrKiDhpU0K8kRu+41V9eeAGKiVaFg50c8c= X-Received: by 2002:a05:6102:370a:b0:493:df26:f9c5 with SMTP id ada2fe7eead31-497798d15d7mr9743758137.11.1724101219912; Mon, 19 Aug 2024 14:00:19 -0700 (PDT) MIME-Version: 1.0 References: <20240817-mseal-depessimize-v3-0-d8d2e037df30@gmail.com> <20240817-mseal-depessimize-v3-1-d8d2e037df30@gmail.com> In-Reply-To: From: Pedro Falcato Date: Mon, 19 Aug 2024 22:00:08 +0100 Message-ID: Subject: Re: [PATCH v3 1/7] mm: Move can_modify_vma to mm/vma.h To: "Liam R. Howlett" , Pedro Falcato , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, jeffxu@chromium.org, oliver.sang@intel.com, torvalds@linux-foundation.org, Michael Ellerman , Kees Cook Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: qd91xyfiyiyx1iw1z5w3exixoifdpeyq X-Rspamd-Queue-Id: 413BB20029 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724101221-94922 X-HE-Meta: U2FsdGVkX18bHMPUS4bzgsrbuZ4gSvHoOZ1qUljNF8sWCnHFQfkjV8Tlu61VJtEpQMS79KWQ/SxH6U1k5Q4KJ88GwtTSDHLiBMAlH5gOySL9y6M2sRJ7i90fU9fimJrzvjUpWuwBpWfmO4Q98kvCzUF9QPeVYKghpOF737FeWNdyQJZkAgeRe0xE5/+hqjHniCoWPLfqOo2nt7dPOMbJjTKtarnzKfU9MzKtfg4yKLN2Rbj+A03G5xvhOSCmFVKdhjsZVxngn5q7SmGAObdlC4/IZPzbh8wPSnsXBDAc7idOjOuNNsaw9eN35Df2ZxNOYd6XiGxeMxsdZ+sf1aGkLYSxHfr+Odnczo+KtsENdnopRAN6lpcRzipFsx4pMv6be2SM7Y2vwGEuLcEavse2ycak/7ougvi3ZoUyjvzkoGgU4trdvxVv73dBuZCBiUcyZMdLUWeMSrLOosw7J8dcUcojsTCpKGHJva8n8ekI6vYoUinb1l01NrRkFLrORGUSYbiR4Pz0F4duejoXf+HXCVW5DJAbFcwsrS5Tx6cZbmHfWSc7bYKWjwkruO7sYqiVx7l7OrbFIj+BOmGbtqwzaC54jQxQPgm4wF1Fty51x83o9l1PW2EpCKd46oybtZWYEbR0iDI1a3209BIGecAMS7axoSGr7IKPGoVyFoCvB4f8B43p3NKurMHEeTIPUJsgl9ceBXqTk8JgQdmRrqo3xzav49nXGUVkARsJsC5VVXRFBJ0RxM0jHSN9zuVYBCUbSgQCaGQLm3as/CdHwAgBxcDPyJZ4Ta1xQEqqMqs/IcZUtrd+G+Zriuo03HxIzM4Wwg5S4WmHNoykj/rdQluF16xmdyQwbdfgqBl228N6+vum2mtkZEBhVyqOLeU4vnvaYEBBlkj0V7rCLmU6yzmhR0rtzwZW/GwV244M4n/QPq9VIh+2ubA0VMoxFVadcJIimOZ7tnh5k4Xhc+GEeoI BJbYQSZb DwZG2cido2KGf33gqt7qY4CbBnq2QrdFGC9fIFsXMItszYOzPfU1VtPuJHk/Kffi/xDsVzCuISaC+Y7TjtUz2iGG528Pc2kjyvQuP+L0//KPRoP1e3Z1ecJMi4WSRt0g3hD7UnLkgb10/0g2E7MnD2VSNNfacO7A10CRtzMzHE2lb9ioPHnNBd4suBZSWUsaM98pHS/l3ICPIg9iLPZcWbTks1TR6A6rtzYCMnU/ibqXhIHHSmtVEeKRqk2mc9+xbne4o/4Qk2E6k32Lgnd7XtGMVNQ079MEi0ice6LWeOlayK2zn3d3h5uxgljj0HENwhZ4pzp1r2YlaKArSsc9YgxQgqJQa+ZZFr4odbzT+61jsioqxUnSRX98nu+lzx9cHimbucuvsS4W/HwxKJ1bJLad1NkEcgRfV9ZJE+iPG7tNJou9Z4wwcJliKJiPuaejFHzVVwkgGTep8Z27bQGBKD4A7ndjENgM8m/6HESOrMVVQJsg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 9:15=E2=80=AFPM Liam R. Howlett wrote: > > * Pedro Falcato [240816 20:18]: > > Move can_modify_vma to vma.h so it can be inlined properly (with > > the intent to remove can_modify_mm callsites). > > > > Signed-off-by: Pedro Falcato > > --- > > mm/mseal.c | 17 ----------------- > > mm/vma.h | 28 ++++++++++++++++++++++++++++ > > 2 files changed, 28 insertions(+), 17 deletions(-) > > > > diff --git a/mm/mseal.c b/mm/mseal.c > > index 15bba28acc00..2170e2139ca0 100644 > > --- a/mm/mseal.c > > +++ b/mm/mseal.c > > @@ -16,28 +16,11 @@ > > #include > > #include "internal.h" > > > > -static inline bool vma_is_sealed(struct vm_area_struct *vma) > > -{ > > - return (vma->vm_flags & VM_SEALED); > > -} > > - > > static inline void set_vma_sealed(struct vm_area_struct *vma) > > { > > vm_flags_set(vma, VM_SEALED); > > } > > > > -/* > > - * check if a vma is sealed for modification. > > - * return true, if modification is allowed. > > - */ > > -static bool can_modify_vma(struct vm_area_struct *vma) > > -{ > > - if (unlikely(vma_is_sealed(vma))) > > - return false; > > - > > - return true; > > -} > > - > > static bool is_madv_discard(int behavior) > > { > > switch (behavior) { > > diff --git a/mm/vma.h b/mm/vma.h > > index 6efdf1768a0a..e979015cc7fc 100644 > > --- a/mm/vma.h > > +++ b/mm/vma.h > > @@ -361,4 +361,32 @@ struct vm_area_struct *vma_iter_prev_range(struct = vma_iterator *vmi) > > return mas_prev_range(&vmi->mas, 0); > > } > > > > +#ifdef CONFIG_64BIT > > + > > +static inline bool vma_is_sealed(struct vm_area_struct *vma) > > +{ > > + return (vma->vm_flags & VM_SEALED); > > +} > > If you respin, I'd support dropping this entirely as it seems > unnecessary. ACK, I'll fold this into the next patch if the need for v4 arises. > Either way, > Reviewed-by: Liam R. Howlett Thank you for the speedy review(s)! --=20 Pedro