From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDA2C77B7C for ; Fri, 5 May 2023 06:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A573D6B0075; Fri, 5 May 2023 02:17:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A07E36B0078; Fri, 5 May 2023 02:17:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91D946B007B; Fri, 5 May 2023 02:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by kanga.kvack.org (Postfix) with ESMTP id 7F5CF6B0075 for ; Fri, 5 May 2023 02:17:57 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C5A863B49 for ; Fri, 5 May 2023 06:17:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9198EC433D2 for ; Fri, 5 May 2023 06:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683267476; bh=s0Q8w+nZ3D0tRHQQ0NfVXIwOgzbtcIUS0LMXlLCVPlE=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=o1qf7cQdVwokJTmvHOUCzh1Ufx8A7z0mfp+Syr2QumpBf+BULm85uYhxTrHFDWbUw VHQp29hxAkwn8iiQW296pvqPyqZbuNcBhcpfPaAxZb7yDHKs+ndks4eB8+cP4gCaAM MFShDD/D/Xj9dPRMCmJjGvxSDq6K13LipD8RWK6/cXu0pb568dq+wMNmKChbW9yX3r vyIlzRvG3drFvnfcqMPFXawsh9RprNsAXAd2E7i9RPfuiEl15oWMA/QEMk3LUqwgrx Wymj7LusMUXonXZaeJowV759+ZK2g9f9r1QO9iTi/oLalolYF5XP0NFYppPRbx/5hk 6cejNlJw0FSbQ== Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-192b1a4dd2eso648258fac.1 for ; Thu, 04 May 2023 23:17:56 -0700 (PDT) X-Gm-Message-State: AC+VfDzjUoz4N5EW1+LoBqbkrNvxx2fXYyWg0xQg1JY4ISc6O8qUVFCE 04SGhso+oqaahAO6K96FkCWAIRPRcZu8k40PdOI= X-Google-Smtp-Source: ACHHUZ59xiLH2jDPQ4tx28+0BYl225DfqBgHqfgxYWhngZ+AuyTuVMNt1mq8TJ8mpHQ1QQBrGJ2S0bdPvmhDKfVC170= X-Received: by 2002:a05:6870:5141:b0:176:4c90:a172 with SMTP id z1-20020a056870514100b001764c90a172mr295547oak.56.1683267475770; Thu, 04 May 2023 23:17:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7858:0:b0:4d3:d9bf:b562 with HTTP; Thu, 4 May 2023 23:17:55 -0700 (PDT) In-Reply-To: <20230503140609.e65bdc2b0e55ba6f49bbb620@linux-foundation.org> References: <20230407194433.25659-1-listdansp@mail.ru> <20230503140609.e65bdc2b0e55ba6f49bbb620@linux-foundation.org> From: Namjae Jeon Date: Fri, 5 May 2023 15:17:55 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ntfs orphan? (was Re: [PATCH] ntfs: do not dereference a null ctx on error) To: Andrew Morton Cc: Bagas Sanjaya , Danila Chernetsov , Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, Linux Memory Management , Konstantin Komarov , Christian Brauner Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2023-05-04 6:06 GMT+09:00, Andrew Morton : > On Wed, 3 May 2023 11:16:02 +0700 Bagas Sanjaya > wrote: > >> On Fri, Apr 07, 2023 at 07:44:33PM +0000, Danila Chernetsov wrote: >> > In ntfs_mft_data_extend_allocation_nolock(), if an error condition >> > occurs >> > prior to 'ctx' being set to a non-NULL value, avoid dereferencing the >> > NULL >> > 'ctx' pointer in error handling. >> > >> > Found by Linux Verification Center (linuxtesting.org) with SVACE. >> >> Duplicate of 10-years-old outstanding patch at [1]. > > Well, the patches are actually quite different. Is Danila's longer one > better? Danila's patch is better than old one. old patch doesn't free allocated cluster in error handling. And Christian will apply this to his queue if you drop this patch. > >> I'm not speaking of the patch itself but rather on unfortunate state >> of ntfs subsystem. It seems like the maintainer is MIA (has not >> responding to patch submissions for a long time). Some trivial >> patches, however, are merged through mm tree. >> >> Konstantin (from newer ntfs3 subsystem), Andrew, would you like to take a >> look on this orphaned subsystem (and help reviewing)? I'd like to send >> MAINTAINERS update if it turns out to be the case. >> > > Sure, I can join linux-ntfs-dev@lists.sourceforge.net and hendle things > which come along. > > Or Christian may want to do that? > >> >> [1]: >> https://lore.kernel.org/all/1358389709-20561-1-git-send-email-nickolai@csail.mit.edu/ > > >