From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90BEC4332B for ; Fri, 20 Mar 2020 23:24:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8806C2070A for ; Fri, 20 Mar 2020 23:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vN1/Ute8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8806C2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5A6B6B0005; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE3E56B0006; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAB836B0007; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id AF75B6B0005 for ; Fri, 20 Mar 2020 19:24:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6942A5825 for ; Fri, 20 Mar 2020 23:24:20 +0000 (UTC) X-FDA: 76617321480.01.pen60_600ffb7510910 X-HE-Tag: pen60_600ffb7510910 X-Filterd-Recvd-Size: 4496 Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 23:24:19 +0000 (UTC) Received: by mail-ot1-f68.google.com with SMTP id j16so7750656otl.1 for ; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=vN1/Ute8SimVqT3y3hab78UyOf4VVJ7VRiHOmD/0YEw4RVsLYf+I9I+znQgoZJ4gdB ictTZbD1FHachCP/sbEN+nf5NkPQ3zRL8Ac1BelFOIse/g9g6UpeoAfXXPC7J0vE8auY ePcveIYKTMSHJgWhosQIxl0CCrkGF9pmyNFPTwd0v+oVmX5riIDdzQ03F5K6zEp+Yorg xUhrv1K+sA6wqpG3J43WbuJGu1I6tO2+B7xlqRuhBhDVQUlM25cT94sYTuO+2rNTPHR+ wUJD/jin1TicQd15MZDDptDmvyxFQ3GYs+b1BI3MQaatUfXjIV8IMG9GTl9ZI1NYxiQ/ JVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=r1RjSBup4MWDnxcSCK94McxMdoDpG8eO0JDhY4wpKR0=; b=OCDrpld6Y8srMbpQ+6MBDQTxaDPwx8g71FMcm0/1ZgiwMdiuJpT0BSd9/lRSR3SUk4 f6Jr7fLVWkAiPbhcipc53tMkqK1dx/tEIiRP02BXzLv+Cx86z6dbYw3N/SgXCXpU6qfE oOMUDuJ4bBm2gcPlQOKR4Eya7aQzcZaGsvVlQVpzFL/Y+7B1urGNHjyK8Z+lDd4j+TmS ckz7mi4IXgFOo1xiSvZnrP20pPNGSHjbo2TRiEt2DEGAqy2QAdetS3VGQ4TtQmXA7C2I kiZ8K7Uv0rpqMNHlWAUNdGHRM9ICSzPVAwxOn6yXrgZqSQYzZvHRIrUOU8XVt4iUNTZp +2fQ== X-Gm-Message-State: ANhLgQ1u8XtSnSjZ293GUcItol3Xm6+ai5cj6Ghzz2NfUYw3Wddfwo9E VpHkNQ6NW9twB6c63YL3/r1EleDDafs8R8CHUVs= X-Google-Smtp-Source: ADFU+vvk42JpEDDDlDUp6QEGUIHSuidkoO4gJ/JVIxwHCPUSqqRu1OBVOgg9ZhRrthX3kgHdC2yuDHRY3AYH9iDgANA= X-Received: by 2002:a05:6830:1608:: with SMTP id g8mr9414965otr.282.1584746659261; Fri, 20 Mar 2020 16:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:8e:0:0:0:0:0 with HTTP; Fri, 20 Mar 2020 16:24:18 -0700 (PDT) In-Reply-To: <20200320142231.2402-17-willy@infradead.org> References: <20200320142231.2402-1-willy@infradead.org> <20200320142231.2402-17-willy@infradead.org> From: Namjae Jeon Date: Sat, 21 Mar 2020 08:24:18 +0900 Message-ID: Subject: Re: [PATCH v9 16/25] fs: Convert mpage_readpages to mpage_readahead To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Junxiao Bi , Joseph Qi , Dave Chinner , John Hubbard , Christoph Hellwig , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/drivers/staging/exfat/exfat_super.c > b/drivers/staging/exfat/exfat_super.c > index b81d2a87b82e..96aad9b16d31 100644 > --- a/drivers/staging/exfat/exfat_super.c > +++ b/drivers/staging/exfat/exfat_super.c Maybe, You should change fs/exfat instead of staging/exfat that is gone from -next ? > @@ -3002,10 +3002,9 @@ static int exfat_readpage(struct file *file, struct > page *page) > return mpage_readpage(page, exfat_get_block); > } > > -static int exfat_readpages(struct file *file, struct address_space > *mapping, > - struct list_head *pages, unsigned int nr_pages) > +static void exfat_readahead(struct readahead_control *rac) > { > - return mpage_readpages(mapping, pages, nr_pages, exfat_get_block); > + mpage_readahead(rac, exfat_get_block); > } > > static int exfat_writepage(struct page *page, struct writeback_control > *wbc) > @@ -3104,7 +3103,7 @@ static sector_t _exfat_bmap(struct address_space > *mapping, sector_t block) > > static const struct address_space_operations exfat_aops = { > .readpage = exfat_readpage, > - .readpages = exfat_readpages, > + .readahead = exfat_readahead, > .writepage = exfat_writepage, > .writepages = exfat_writepages, > .write_begin = exfat_write_begin,