From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE7BC48BDF for ; Fri, 18 Jun 2021 12:03:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 396F1613E9 for ; Fri, 18 Jun 2021 12:03:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 396F1613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B97776B0071; Fri, 18 Jun 2021 08:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1FC06B0072; Fri, 18 Jun 2021 08:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9718C6B0073; Fri, 18 Jun 2021 08:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 5BE3A6B0071 for ; Fri, 18 Jun 2021 08:03:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D18A48249980 for ; Fri, 18 Jun 2021 12:03:12 +0000 (UTC) X-FDA: 78266709024.20.4DCFBA1 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf12.hostedemail.com (Postfix) with ESMTP id 6ED22567 for ; Fri, 18 Jun 2021 12:03:11 +0000 (UTC) Received: by mail-qk1-f176.google.com with SMTP id q16so10254184qkm.9 for ; Fri, 18 Jun 2021 05:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BS3omeOppyoShd1+LwrhmXqufv0Lv657lMEmOyaYMYw=; b=Gb36UT4iH8mrlI9grJsKcZc/6dVSCOhopbItrzJzkGDG4s2ViSK6ACPCaNiqfdqkr5 HC5mPohZzo+oDK0ll4HXl/ANn4FMqgbGZRDTtzDK7E9nS01pkQh0mPiGuW9YRXGw6xvc yfuQheWzKELjxip6d2MHYymQOp0pD1K8UJEcmGHd6Ttk2jeaRscoDYk7/mSbFQQDZ7v1 uVhgAkjx/Qe5xVT0A1jsn34L8DOFMtIapGd3TLcDlxSPFForVq1BkRYm9NjNnQ1PcACn PpNj6AlCXFm/o2vfe4DqLu6mNzIiMKUS2KvUnRzTSCCX0di7tZfd3QjkgeWhazjKHqeu 9HLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BS3omeOppyoShd1+LwrhmXqufv0Lv657lMEmOyaYMYw=; b=FGo/pK9QpTrpVF8WHN78FdoY95CZV+MO3rWE2ieW0qKJzEQS8cntWX3SRKxKehUZVR vFTmsokON1DE5gi4RYLLdnKAU31h4ESis/RG4G04PKbgIwJwhMzcEZ84Co74rCijOHVk nlLn60zzGKCpcbd+sq3zNr/nIxMpZKsY3CjD9tHowYqfp3J4oNWN6MtpsrBajsQtLyhW 4NQGoG/1DqHkxauGEZCgsmfWjqW/AwcAh6MlJrySy+UlcyDD0QBOJqr1YBE1v1hB7rbR fTDlvm/5lSEASjbnX1Glkg3eMt/Zt4blOw6DKAAw2Bt+b3Ohh9OF0mbqMD0guTuTaJrb 9DAg== X-Gm-Message-State: AOAM532k1LjzkaB3jJxUDPtkh7taxHx6wRDV0TcC0Mg9UpcK1Mbn/FI8 wIVLUBTSsGIFnkRKiktPevN6+xtzOUHOk6xVgmI= X-Google-Smtp-Source: ABdhPJyaW3LQ7JA4frN3NrxC7GNRRn2U+0+ejV4K1ngurOjopIl45bLG8ZC+1e2MRhAhle/GNmEL74X2oQVMrsafgNo= X-Received: by 2002:a25:8b86:: with SMTP id j6mr12009074ybl.470.1624017791766; Fri, 18 Jun 2021 05:03:11 -0700 (PDT) MIME-Version: 1.0 References: <1624013943-13935-1-git-send-email-gumingtao@xiaomi.com> In-Reply-To: <1624013943-13935-1-git-send-email-gumingtao@xiaomi.com> From: Lukas Bulwahn Date: Fri, 18 Jun 2021 14:03:04 +0200 Message-ID: Subject: Re: [PATCH] slab: Use %s instead of function name To: gumingtao Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , Vlastimil Babka , Nathan Chancellor , Nick Desaulniers , Linux-MM , Linux Kernel Mailing List , clang-built-linux , gumingtao Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Gb36UT4i; spf=pass (imf12.hostedemail.com: domain of lukasbulwahn@gmail.com designates 209.85.222.176 as permitted sender) smtp.mailfrom=lukasbulwahn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: w48dcrwaj4am3aptwcnegkusyh816ir9 X-Rspamd-Queue-Id: 6ED22567 X-Rspamd-Server: rspam06 X-HE-Tag: 1624017791-169423 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 18, 2021 at 12:59 PM gumingtao wrote: > > It is better to replace the function name with %s. > > Signed-off-by: gumingtao > --- > mm/slab_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index a4a5714..36127dc 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -381,8 +381,8 @@ kmem_cache_create_usercopy(const char *name, > panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n", I am just wondering: Can you also make that refactoring change for the panic() call as well? How about checking the whole file for such patterns and doing that change for all occurrences? > name, err); > else { > - pr_warn("kmem_cache_create(%s) failed with error %d\n", > - name, err); > + pr_warn("%s(%s) failed with error %d\n", > + __func__, name, err); > dump_stack(); > } > return NULL; > -- > 2.7.4 >