From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by kanga.kvack.org (Postfix) with ESMTP id 11D396B0035 for ; Mon, 28 Apr 2014 01:03:48 -0400 (EDT) Received: by mail-we0-f174.google.com with SMTP id w62so4515801wes.5 for ; Sun, 27 Apr 2014 22:03:48 -0700 (PDT) Received: from mail-wg0-x22c.google.com (mail-wg0-x22c.google.com [2a00:1450:400c:c00::22c]) by mx.google.com with ESMTPS id gi5si3019667wib.15.2014.04.27.22.03.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 27 Apr 2014 22:03:47 -0700 (PDT) Received: by mail-wg0-f44.google.com with SMTP id m15so5886401wgh.27 for ; Sun, 27 Apr 2014 22:03:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140427114600.GA21935@gmail.com> References: <535C854C.1070105@gmail.com> <20140427114600.GA21935@gmail.com> Date: Mon, 28 Apr 2014 13:03:46 +0800 Message-ID: Subject: Re: [PATCH] mm: update the comment for high_memory From: Wang Sheng-Hui Content-Type: multipart/alternative; boundary=e89a8f5034f884a57e04f8133daa Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Andrew Morton , kirill.shutemov@linux.intel.com, peterz@infradead.org, riel@redhat.com, Mel Gorman , Johannes Weiner , Hugh Dickins , linux-mm@kvack.org --e89a8f5034f884a57e04f8133daa Content-Type: text/plain; charset=UTF-8 Got it, Ingo. Will figure out more fine comment. 2014-04-27 19:46 GMT+08:00 Ingo Molnar : > > * Wang Sheng-Hui wrote: > > > > > The system variable is not used for x86 only now. Remove the > > "x86" strings. > > > > Signed-off-by: Wang Sheng-Hui > > --- > > mm/memory.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 93e332d..1615a64 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map); > > #endif > > > > /* > > - * A number of key systems in x86 including ioremap() rely on the > assumption > > - * that high_memory defines the upper bound on direct map memory, then > end > > - * of ZONE_NORMAL. Under CONFIG_DISCONTIG this means that max_low_pfn > and > > + * A number of key systems including ioremap() rely on the assumption > that > > + * high_memory defines the upper bound on direct map memory, then end of > > + * ZONE_NORMAL. Under CONFIG_DISCONTIG this means that max_low_pfn and > > * highstart_pfn must be the same; there must be no gap between > ZONE_NORMAL > > * and ZONE_HIGHMEM. > > ioremap() is not a 'key system', so if we are touching it then the > comment should be fixed in other ways as well. > > Thanks, > > Ingo > --e89a8f5034f884a57e04f8133daa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Got it, Ingo.

Will figure out more fine = comment.


2014-04-27 19:46 GMT+08:00 Ingo Molnar <mingo@kernel.org>:

* Wang Sheng-Hui <shhuiw@gmail.com> wrote:

>
> The system variable is not used for x86 only now. Remove the
> "x86" strings.
>
> Signed-off-by: Wang Sheng-Hui <= shhuiw@gmail.com>
> ---
> =C2=A0mm/memory.c | 7 +++----
> =C2=A01 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 93e332d..1615a64 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -85,14 +85,13 @@ EXPORT_SYMBOL(mem_map);
> =C2=A0#endif
>
> =C2=A0/*
> - * A number of key systems in x86 including ioremap() rely on the ass= umption
> - * that high_memory defines the upper bound on direct map memory, the= n end
> - * of ZONE_NORMAL. =C2=A0Under CONFIG_DISCONTIG this means that max_l= ow_pfn and
> + * A number of key systems including ioremap() rely on the assumption= that
> + * high_memory defines the upper bound on direct map memory, then end= of
> + * ZONE_NORMAL. =C2=A0Under CONFIG_DISCONTIG this means that max_low_= pfn and
> =C2=A0 * highstart_pfn must be the same; there must be no gap between = ZONE_NORMAL
> =C2=A0 * and ZONE_HIGHMEM.

ioremap() is not a 'key system', so if we are touching = it then the
comment should be fixed in other ways as well.

Thanks,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Ingo

--e89a8f5034f884a57e04f8133daa-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org