From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FBAC36005 for ; Mon, 28 Apr 2025 08:27:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D15F6B0007; Mon, 28 Apr 2025 04:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 780FD6B000A; Mon, 28 Apr 2025 04:27:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 649386B000C; Mon, 28 Apr 2025 04:27:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 407DA6B0007 for ; Mon, 28 Apr 2025 04:27:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 70D735CB5F for ; Mon, 28 Apr 2025 08:27:50 +0000 (UTC) X-FDA: 83382774300.03.0DC19C6 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf26.hostedemail.com (Postfix) with ESMTP id AA710140003 for ; Mon, 28 Apr 2025 08:27:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QTtjXQX8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745828868; a=rsa-sha256; cv=none; b=Qiz9DnyYjBxmy/4GbRRU79gh1/Y+ZupN0Ur6KnUGNiWNz9q1zcIezMayki/GnfELPvphX1 qZZRg3U0goh0LVqWAKQMWqqglrIlbgHiN178wdY7MgNGuWofdTzl2XOQNgx8KbyoMC2WR2 B6EgraJ01WEpqrd7h6kaqem1m6yAdrA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QTtjXQX8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of siddarthsgml@gmail.com designates 209.85.208.68 as permitted sender) smtp.mailfrom=siddarthsgml@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745828868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CwUUkCJR2OrrnJKN4pgTHYLZI/b3TeatY/zmmJw1QFg=; b=oAdNaQIrQnZvQ6nqXjW2tC0/bK3Ilw7og1Z9wmlqPJVYn6oowUkl3c6g/ypiLu9UbWxHpO AihwDBc9nHzJSdsGbB8YWOCry6510rFmhIAVgCaQDBd+HK2MZYr3W5inMRKcNhpivCOaku AMkRvFQx0rVQ40+noaKy4D3tYJUaXso= Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-5e61d91a087so6902450a12.0 for ; Mon, 28 Apr 2025 01:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745828867; x=1746433667; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CwUUkCJR2OrrnJKN4pgTHYLZI/b3TeatY/zmmJw1QFg=; b=QTtjXQX8Qr14gnHOSIfRIgOjl+62EA073Sj7Vs2IfNstOjhL+ED3DzIHtDh1wNIsQN BmxafAOonl+wEoICr723tC7sI6kUu1CSQoaQE1DGu4q/O/qGS+aG5kYfb0AfbHW2Bs43 lpSLIk2Ab3gnDVwGX5flAGFcf/Od2jws4zAh/1lx02XXwISd5mPIdVFuJmy/pr6xVkoA Jud8LG5j0okZHPeH5DKlgvBbtSdZKvw1IT8QfPxYuBgp5oFwjHb7Foj/oBTgQ0o8EpTd JITkVHFMwOMccHeNZIgV+t0bizrhl80FzpZn9EnVWTm6I3HnJrjGDyDdA+CKjfTnRVJ4 r7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745828867; x=1746433667; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CwUUkCJR2OrrnJKN4pgTHYLZI/b3TeatY/zmmJw1QFg=; b=Ou7khGBsar87W5iYHnzP5UMLvfBCDPcUbmDkzBO/agUEiqMeiXhQft9sdylBXRSoH9 +Z8i6rKe7PoEO1/aqZ8jlcJBMNAwsZ2JGyxqIy7KtpTnt22SzUaXGLKY9XROW1hvXfDj ZxZXdSwEZta5E40e+gdSirkJWDBaHz4m0BfuV5jBR16PA+qOgnwxYfyzUYOaFx/ZmnpH nynTF9CWogEtipsIhVL+oKdU+Nwrg5HsaQiA8BIV7p1l8S8M1SaJC6DQ22Cp4pRj98pq QrbswBRywOBcstJTD+eZ3Ue4fSwWnZTbgzaBrivW23zz9TRMkc/adC164xpykcu/tYBm /XJw== X-Forwarded-Encrypted: i=1; AJvYcCUMxm5HbJTIo6qJxqLEbqJWuuCqmkM7B0wGuxeenp5dF8suBBjCfiw+3NBF+5j0G7sXSutblwXvAw==@kvack.org X-Gm-Message-State: AOJu0Yxfken20YXM6C9KiQH3aFeenMSqCBuG+xk20sUf+NPM1k7EVJwS UDzi68RuoAwFApnMMbNU4lsTLZ+w5cd6NHXT7f2xR6w3XU8RhDR+WKLHMpXtvjFUKtyBbPMau6N ivbQ+toA1gbWfRzuKMOI0D4avOmU= X-Gm-Gg: ASbGncu1h3KZPL/fouYK8psEWo2VdHas5phDLRdsznzTU14wYfd4MJcfL42I5T3BKli 2LAfwXCt2TNnboA84cll6kI7eEtQ13rmOR6kR5B3gNlSxG2P5yWCUKpKHD2vA4UPCHykqrLVfTx emDrfD8bdJjZSPO4WrxeJunZki0nZomNVeb3I= X-Google-Smtp-Source: AGHT+IGSAGsZ7aIS9O7ZBPI6QhzFnzGR3AA2xOVbO2kl/FyyEoxxvEMa2cF0G5A+ICmN484+iEbYEB4Rz1UAPWE7FuA= X-Received: by 2002:a05:6402:5193:b0:5f6:48b1:f416 with SMTP id 4fb4d7f45d1cf-5f73960b8b7mr7199166a12.19.1745828866814; Mon, 28 Apr 2025 01:27:46 -0700 (PDT) MIME-Version: 1.0 References: <20250427102639.39978-1-siddarthsgml@gmail.com> <20250427171307.876badf3d5606cf502b7f46f@linux-foundation.org> In-Reply-To: <20250427171307.876badf3d5606cf502b7f46f@linux-foundation.org> From: siddarth Date: Mon, 28 Apr 2025 13:57:35 +0530 X-Gm-Features: ATxdqUGN6berUd6DsgaYG2w3UD7JXGErVYQtCtdA4QjGCpyyozjuOz4WJKcsSJs Message-ID: Subject: Re: [PATCH] selftests/mm: use long for dwRegionSize To: Andrew Morton Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Content-Type: multipart/alternative; boundary="00000000000071f8cc0633d27508" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AA710140003 X-Stat-Signature: uqrinawf8bo8ni9fhtdg1hgmau47nqdh X-HE-Tag: 1745828868-404805 X-HE-Meta: U2FsdGVkX1+Qpt1NvHr2OWmDWmpolM/r818fC1qKGUcHHE9As7eikhEG7Z8wR79fkBM179b45MPlenrdXUJHGJ2Dls7jM3Ofda9eu+b1VDGiBIn1KSZfEFLjImE98/02p5YM4JGBYmDrflMbRmtTHIexxbmuo+wPvwF+zUiLZvEy/nizjPkcZC7JVui0I/oDjSiweUXLUGi8R9273KJOsw+cHN4wvIe6GBPrMXsLAMiOa1HbjwfKRE3nIctG0OAwrhbeeHzaBqViRNfRbvevhcxKELDSLNMq7dtRyWlo5rMwUeJXUE2w1ylnevhwSaF+OuYURwdZh+4nj02mAMPeOjTD/Ppnznw4B9RQ4JFSd4UZ7XcxnJkpOFGHkSz2MsRrwphsb9S3+GB8tRmkzTxar8qdja8S0HlUj2FJBqB8CnNN9SpVWhEHl3yxZ0s2cyM2K3eHQy4gmXhp+e2XTQQJyhQcjECuVZytxBAH7A7Ae09VFzDEHPRPgptatJyg0Bu7u9DjRfNTCzefQF+NUSLIv9sDo3FpfAUSEZ7JUepm7gmQA6Hee881EhpE2IlRK2pc3MlF6uH72su891sV6yiE+QG1vobOLVWR4rDX6Ng3hl8zR86F0FtekFO4cf0pauyx3qUYo9YkX7QA6DjVgNxaxswKJv9O+q0X5uu+DHHXjF7bE4HkvD6LEZD6BzX57TgTCuHsaN//cU/cGCYY+kF/EOgcbbPeEAXg5Qf99NEfXvRX3fSZzeNNxwi5uhW+smDZaSknBR+PnCni7e94D8g/yyb1E+dsFsggRVaKDO8HSY8pAboUf9OBguCTfKINtpdfZVYBwkGX1g0R53Kpr8Zaym4/IEjNnlbThuxGle7MJ4gEd2BEIqcIi3EWQvTnnxzYWZLKR5jTp+5ssCG4WlosAxjara2Sm07E4qAdnpSchCLhmg7f9YR+6gnDCnGwXR+HrVrLv+p0QKAWjbHBA8y Ib8pD0Iq Ls1iMX0x7+z3WQC3YLn5wi1aBkXxzpF/GLLFN4IfoUC8hpNx6m6fdWpILLxihQ73vqREi3sCSbbh8eNF2FOkRpvGEkECwASyesD67 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --00000000000071f8cc0633d27508 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 28, 2025 at 5:43=E2=80=AFAM Andrew Morton wrote: > On Sun, 27 Apr 2025 15:56:39 +0530 Siddarth G > wrote: > > > Change the type of 'dwRegionSize' in wp_init() and wp_free() > > from int to long to match callers that pass long or > > unsigned long long values. > > > > wp_addr_range function is left unchanged because it passes > > 'dwRegionSize' parameter directly to pagemap_ioctl, which expects > > an int. > > Thanks. Does this fix any known compile-time or runtime issues? > On Mon, Apr 28, 2025 at 5:43=E2=80=AFAM Andrew Morton wrote: On Sun, 27 Apr 2025 15:56:39 +0530 Siddarth G wrote: > Change the type of 'dwRegionSize' in wp_init() and wp_free() > from int to long to match callers that pass long or > unsigned long long values. > > wp_addr_range function is left unchanged because it passes > 'dwRegionSize' parameter directly to pagemap_ioctl, which expects > an int. Thanks. Does this fix any known compile-time or runtime issues? Hi, thanks for the review. This patch does not fix any actual known issues. It aligns parameter types with their actual usage and avoids any potential future issues. With gratitude Siddarth G --00000000000071f8cc0633d27508 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Apr 28,= 2025 at 5:43=E2=80=AFAM Andrew Morton <akpm@linux-foundation.org> wrote:
On Sun, 27 Apr 2025 15:56:39 +0530 Si= ddarth G <si= ddarthsgml@gmail.com> wrote:

> Change the type of 'dwRegionSize' in wp_init() and wp_free() > from int to long to match callers that pass long or
> unsigned long long values.
>
> wp_addr_range function is left unchanged because it passes
> 'dwRegionSize' parameter directly to pagemap_ioctl, which expe= cts
> an int.

Thanks.=C2=A0 Does this fix any known compile-time or runtime issues?

On Mon, Apr 28, 2025 at 5:43=E2=80=AFAM Andrew Morton &= lt;akpm@linux-foundation.org> wrote:
On Sun, 27 Apr 2025 15:56:39 +0530 Siddarth G <siddarthsgml@gmail.com> wrote:
> Change the type of 'dwRegionSize' in wp_init() and wp_fre= e()
> from int to long to match callers that pass long or
> uns= igned long long values.
>
> wp_addr_range function is left unch= anged because it passes
> 'dwRegionSize' parameter directly t= o pagemap_ioctl, which expects
> an int.

Thanks.=C2=A0 Does th= is fix any known compile-time or runtime issues?
Hi, thanks for the revi= ew. This patch does not fix any actual known issues. It aligns parameter ty= pes with their actual usage and avoids any potential future issues.

= With gratitude
Siddarth G

=C2=A0
--00000000000071f8cc0633d27508--